Re: Review Request 46524: Sanitized src/Makefile.am.

/r/46524/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46519: Copied libprocess-specific configure options to top-level configure.ac.

ae91a07e2bafd97566ac6e6873990302acad14c9 Diff: https://reviews.apache.org/r/46519/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46522: Sanitized libprocess/3rdparty/Makefile.am.

f7aa579f133d19c3ef252773c5ed868c977785cd Diff: https://reviews.apache.org/r/46522/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46516: Sorted option checks for libprocess configure.ac.

d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46516/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46529: Moved stout from libprocess/3rdparty/ to 3rdparty/.

ae91a07e2bafd97566ac6e6873990302acad14c9 src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46529/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46528: Updated stout/Makefile.am to reflect bundled dependencies.

f7aa579f133d19c3ef252773c5ed868c977785cd 3rdparty/libprocess/3rdparty/stout/Makefile.am 10be36652034ea5860f122ffb45ee50cc72ffdb3 Diff: https://reviews.apache.org/r/46528/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46525: Moved 3rdparty packages from libprocess/3rdparty/ to 3rdparty/.

922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46525/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46535: Updated stout path for doxygen main page.

://reviews.apache.org/r/46535/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46536: Updated stout path in newbie-guide.

://reviews.apache.org/r/46536/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46514: Libprocess: Sorted configure.ac AC_ARG_{ENABLE, WITH} entries.

d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46514/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46532: Updated LDADD flags for libprocess tests.

Diff: https://reviews.apache.org/r/46532/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46520: Added --with-stout flag to libprocess configure.

c51c31eb91dd7be4cff8a188942ea77b3b361d45 3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46520/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46530: Libprocess: Replaced $(top_srcdir) with $(srcdir) in Makefile.am.

-specific configure script. Diffs - 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 Diff: https://reviews.apache.org/r/46530/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46517: Sorted top-level configure.ac AC_ARG_{ENABLE, WITH} entries.

Diff: https://reviews.apache.org/r/46517/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46518: Sorted option checks for top-level configure.ac.

://reviews.apache.org/r/46518/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46523: Sanitized libprocess/Makefile.am.

: https://reviews.apache.org/r/46523/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46527: Updated stout/configure.ac to include several '--with-XXX' options.

/stout/m4/ax_cxx_compile_stdcxx.m4 PRE-CREATION 3rdparty/libprocess/3rdparty/stout/m4/ax_pthread.m4 PRE-CREATION Diff: https://reviews.apache.org/r/46527/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46521: Added --with-{libproces, stout} flags to top-level configure.ac.

src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46521/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46534: Updated stout path for mesos_split.py.

://reviews.apache.org/r/46534/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46539: Removed libprocess/3rdparty references from misc files.

: https://reviews.apache.org/r/46539/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46526: Updated 3rdparty paths in Python build scripts.

/r/46526/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46533: Stopped using libprocess/stout configure scripts.

re.ac ae91a07e2bafd97566ac6e6873990302acad14c9 Diff: https://reviews.apache.org/r/46533/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46515: Libprocess: Renamed --without-zlib to --disable-zlib.

d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46515/diff/ Testing --- Thanks, Kapil Arya

Review Request 46540: Updated pkg-config file to include module dependency info.

a0cc66a77058bf4beaa21d7dd4208654c6185640 Diff: https://reviews.apache.org/r/46540/diff/ Testing --- Thanks, Kapil Arya

Review Request 46535: Updated stout path for doxygen main page.

/ Testing --- Thanks, Kapil Arya

Review Request 46514: Libprocess: Sorted configure.ac AC_ARG_{ENABLE, WITH} entries.

: https://reviews.apache.org/r/46514/diff/ Testing --- Thanks, Kapil Arya

Review Request 46532: Updated LDADD flags for libprocess tests.

://reviews.apache.org/r/46532/diff/ Testing --- Thanks, Kapil Arya

Review Request 46530: Libprocess: Replaced $(top_srcdir) with $(srcdir) in Makefile.am.

. Diffs - 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 Diff: https://reviews.apache.org/r/46530/diff/ Testing --- Thanks, Kapil Arya

Review Request 46516: Sorted option checks for libprocess configure.ac.

://reviews.apache.org/r/46516/diff/ Testing --- Thanks, Kapil Arya

Review Request 46518: Sorted option checks for top-level configure.ac.

/diff/ Testing --- Thanks, Kapil Arya

Review Request 46527: Updated stout/configure.ac to include several '--with-XXX' options.

/ax_cxx_compile_stdcxx.m4 PRE-CREATION 3rdparty/libprocess/3rdparty/stout/m4/ax_pthread.m4 PRE-CREATION Diff: https://reviews.apache.org/r/46527/diff/ Testing --- Thanks, Kapil Arya

Review Request 46520: Added --with-stout flag to libprocess configure.

/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46520/diff/ Testing --- Thanks, Kapil Arya

Review Request 46522: Sanitized libprocess/3rdparty/Makefile.am.

://reviews.apache.org/r/46522/diff/ Testing --- Thanks, Kapil Arya

Review Request 46533: Stopped using libprocess/stout configure scripts.

https://reviews.apache.org/r/46533/diff/ Testing --- Thanks, Kapil Arya

Review Request 46524: Sanitized src/Makefile.am.

--- Thanks, Kapil Arya

Review Request 46529: Moved stout from libprocess/3rdparty/ to 3rdparty/.

src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46529/diff/ Testing --- Thanks, Kapil Arya

Review Request 46531: Added explicit ldflags '-static -fpic' to libprocess.la.

3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46531/diff/ Testing --- Thanks, Kapil Arya

Review Request 46521: Added --with-{libproces, stout} flags to top-level configure.ac.

922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46521/diff/ Testing --- Thanks, Kapil Arya

Review Request 46534: Updated stout path for mesos_split.py.

/diff/ Testing --- Thanks, Kapil Arya

Review Request 46536: Updated stout path in newbie-guide.

/ Testing --- Thanks, Kapil Arya

Review Request 46525: Moved 3rdparty packages from libprocess/3rdparty/ to 3rdparty/.

Diff: https://reviews.apache.org/r/46525/diff/ Testing --- Thanks, Kapil Arya

Review Request 46537: Added --enable-install-module-dependencies.

ae91a07e2bafd97566ac6e6873990302acad14c9 Diff: https://reviews.apache.org/r/46537/diff/ Testing --- Thanks, Kapil Arya

Review Request 46539: Removed libprocess/3rdparty references from misc files.

/46539/diff/ Testing --- Thanks, Kapil Arya

Review Request 46523: Sanitized libprocess/Makefile.am.

/46523/diff/ Testing --- Thanks, Kapil Arya

Review Request 46519: Copied libprocess-specific configure options to top-level configure.ac.

://reviews.apache.org/r/46519/diff/ Testing --- Thanks, Kapil Arya

Review Request 46538: Install module dependencies in build/3rdparty as well.

0523151d924a1398334767bd401ae84e41bdceb7 Diff: https://reviews.apache.org/r/46538/diff/ Testing --- Thanks, Kapil Arya

Review Request 46526: Updated 3rdparty paths in Python build scripts.

--- Thanks, Kapil Arya

Review Request 46528: Updated stout/Makefile.am to reflect bundled dependencies.

3rdparty/libprocess/3rdparty/stout/Makefile.am 10be36652034ea5860f122ffb45ee50cc72ffdb3 Diff: https://reviews.apache.org/r/46528/diff/ Testing --- Thanks, Kapil Arya

Review Request 46517: Sorted top-level configure.ac AC_ARG_{ENABLE, WITH} entries.

://reviews.apache.org/r/46517/diff/ Testing --- Thanks, Kapil Arya

Review Request 46515: Libprocess: Renamed --without-zlib to --disable-zlib.

://reviews.apache.org/r/46515/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

> On April 16, 2016, 9:41 p.m., Jie Yu wrote: > > src/log/log.cpp, lines 742-744 > > <https://reviews.apache.org/r/46295/diff/2/?file=1347521#file1347521line742> > > > > Can you move this to the top of the file? > > Kapil Arya wrote: > That won&

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

--- Thanks, Kapil Arya

Review Request 46308: Moved LogProcess declaration to log/log.h.

/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 Diff: https://reviews.apache.org/r/46308/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

To reply, visit: https://reviews.apache.org/r/46295/#review129255 --- On April 15, 2016, 9:27 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 46162: Moved mesos::internal::log::Log to mesos::log namespace.

ews.apache.org/r/46295/ - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46162/#review129227 --- On April 15,

Re: Review Request 46163: Exposed state/{state,storage}.hpp files.

s displaying it incorrectly. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46163/#review129228 --- On April

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

e5d8d5bb9ead6 src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec Diff: https://reviews.apache.org/r/46295/diff/ Testing --- Thanks, Kapil Arya

Review Request 46295: Replaced 'using namespace' with 'using'.

src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec Diff: https://reviews.apache.org/r/46295/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46288: Update CMake file to include the new state.proto file.

/r/46288/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 46163: Exposed state/{state,storage}.hpp files.

f18e8030f69d8ebf8de81ff03632106e08823df1 src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec Diff: https://reviews.apache.org/r/46163/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

, Kapil Arya

Review Request 46288: Update CMake file to include the new state.proto file.

, Kapil Arya

Re: Review Request 46161: Exposed log/log.hpp.

> On April 13, 2016, 8:54 p.m., Jie Yu wrote: > > Please make sure the cmake works. Also, put mesos header after > > libprocess/stout headers. Please all occurances. > > Kapil Arya wrote: > The CMakelists.txt files don't contain headers so w

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

---- On April 15, 2016, 7 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46164/ > --

Re: Review Request 46161: Exposed log/log.hpp.

good here. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46161/#review128816 --- On April 15, 2016, 6:12 p.

Re: Review Request 46160: Exposed zookeeper headers.

ready inconsistent with codebase. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46160/#review128817 --- On

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

, Kapil Arya

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

f18e8030f69d8ebf8de81ff03632106e08823df1 src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec Diff: https://reviews.apache.org/r/46164/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 46163: Exposed state/{state,storage}.hpp files.

/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec Diff: https://reviews.apache.org/r/46163/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 46163: Exposed state/{state,storage}.hpp files.

/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec Diff: https://reviews.apache.org/r/46163/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 46161: Exposed log/log.hpp.

/46161/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec Diff: https://reviews.apache.org/r/46164/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 45901: Removed unsed headers from master contender/detector files.

. Thanks, Kapil Arya

Re: Review Request 45900: Removed stale contender/detector files.

/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 src/master/contender/contender.hpp ba05551340f9ca1763f2f460121dc008f0262686 src/master/detector/detector.hpp 840026577d81d1b8cd3b079ff1e5b6809d139250 Diff: https://reviews.apache.org/r/45900/diff/ Testing --- make check. Thanks, Kapil

Re: Review Request 46162: Moved mesos::internal::log::Log to mesos::log namespace.

f18e8030f69d8ebf8de81ff03632106e08823df1 src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec Diff: https://reviews.apache.org/r/46162/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 46160: Exposed zookeeper headers.

eeper/zookeeper.hpp src/zookeeper/zookeeper.cpp 02fa158a37ddaf045bdf6403c134d03a02c74833 Diff: https://reviews.apache.org/r/46160/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 46160: Exposed zookeeper/authentication.hpp.

g/r/46160/#review128814 --- On April 13, 2016, 7:50 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec Diff: https://reviews.apache.org/r/46164/diff/ Testing --- make check Thanks, Kapil Arya

Review Request 46160: Exposed zookeeper/authentication.hpp.

Diff: https://reviews.apache.org/r/46160/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 45900: Removed stale contender/detector files.

/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 src/master/contender/contender.hpp ba05551340f9ca1763f2f460121dc008f0262686 src/master/detector/detector.hpp 840026577d81d1b8cd3b079ff1e5b6809d139250 Diff: https://reviews.apache.org/r/45900/diff/ Testing --- make check. Thanks, Kapil

Review Request 46161: Exposed log/log.hpp.

85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec Diff: https://reviews.apache.org/r/46161/diff/ Testing --- make check Thanks, Kapil Arya

Review Request 46162: Moved mesos::internal::log::Log to mesos::log namespace.

://reviews.apache.org/r/46162/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 45901: Removed unsed headers from master contender/detector files.

. Thanks, Kapil Arya

Review Request 46163: Exposed state/{state,storage}.hpp files.

/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 45901: Removed unsed headers from master contender/detector files.

042505346636de8e1d258ca3f866e7c35acfca01 src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758 src/tests/master_contender_detector_tests.cpp 1426a173b1f458d67b748016aee311ac008b054a Diff: https://reviews.apache.org/r/45901/diff/ Testing --- make check. Thanks, Kapil Arya

Re: Review Request 45900: Removed stale contender/detector files.

/contender.hpp ba05551340f9ca1763f2f460121dc008f0262686 src/master/detector/detector.hpp 840026577d81d1b8cd3b079ff1e5b6809d139250 Diff: https://reviews.apache.org/r/45900/diff/ Testing --- make check. Thanks, Kapil Arya

Review Request 45900: Removed stale contender/detector files.

/detector.hpp 840026577d81d1b8cd3b079ff1e5b6809d139250 Diff: https://reviews.apache.org/r/45900/diff/ Testing --- make check. Thanks, Kapil Arya

Review Request 45901: Removed unsed headers from master contender/detector files.

. Thanks, Kapil Arya

Review Request 45876: Fixed library lookup for Master detector/contender modules.

Description --- See summary. Diffs - src/tests/module.cpp 4b2404871386319393fc09e1dce872cf6bd43279 Diff: https://reviews.apache.org/r/45876/diff/ Testing --- make check. Thanks, Kapil Arya

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review127498 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:02 p.m

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review127499 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:02 p.m

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/#review127496 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/#review127497 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44546: Moved functions in promises to a common header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/#review127491 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44670: Added master_detector and master_contender flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/#review127487 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44289: Added support for contender and detector modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/#review127489 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44547: Added functions in promises to the future header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/#review127490 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44669: Implemented create methods in MasterContender and MasterDetector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/#review127488 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44545: Separated standalone and zookeeper classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/#review127492 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03 p.m

Re: Review Request 44545: Separated standalone and zookeeper classes.

lerance_tests.cpp (line 52) <https://reviews.apache.org/r/44545/#comment189336> newline? src/tests/master_contender_detector_tests.cpp (line 47) <https://reviews.apache.org/r/44545/#comment189339> newline. src/tests/master_tests.cpp (line 58) <https://

<    1   2   3   4   5   6   7   8   9   >