----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/#review126336 -----------------------------------------------------------
src/Makefile.am <https://reviews.apache.org/r/44545/#comment189306> I think this should have been part of the previous RR (https://reviews.apache.org/r/44544). src/Makefile.am (line 640) <https://reviews.apache.org/r/44545/#comment189307> Same as above. src/Makefile.am (line 643) <https://reviews.apache.org/r/44545/#comment189308> ditto. src/Makefile.am <https://reviews.apache.org/r/44545/#comment189309> ditto src/master/contender.cpp (line 35) <https://reviews.apache.org/r/44545/#comment189311> Alphabetize please. src/master/contenders/contender.hpp (line 22) <https://reviews.apache.org/r/44545/#comment189314> We don't need messages.hpp. However, we do need headers for Future, Nothing and also mesos/mesos.hpp. src/master/contenders/contender.cpp <https://reviews.apache.org/r/44545/#comment189319> This is needed below. src/master/contenders/standalone.cpp (line 19) <https://reviews.apache.org/r/44545/#comment189321> It's not being used, I think. src/master/contenders/standalone.cpp (line 24) <https://reviews.apache.org/r/44545/#comment189320> this is probably not used. src/master/detector.hpp (line 22) <https://reviews.apache.org/r/44545/#comment189312> We still need headers for option, future, and mesos/mesos.hpp. src/master/detectors/detector.cpp (lines 45 - 46) <https://reviews.apache.org/r/44545/#comment189326> we can get rid of these. src/master/detectors/standalone.cpp (lines 44 - 46) <https://reviews.apache.org/r/44545/#comment189329> remove? src/master/detectors/standalone.cpp (line 49) <https://reviews.apache.org/r/44545/#comment189330> remove this? src/tests/authentication_tests.cpp (line 34) <https://reviews.apache.org/r/44545/#comment189332> alphabetize? src/tests/cluster.cpp (line 56) <https://reviews.apache.org/r/44545/#comment189334> newline? src/tests/cluster.cpp (line 58) <https://reviews.apache.org/r/44545/#comment189335> newline? src/tests/fault_tolerance_tests.cpp (line 52) <https://reviews.apache.org/r/44545/#comment189336> newline? src/tests/master_contender_detector_tests.cpp (line 47) <https://reviews.apache.org/r/44545/#comment189339> newline. src/tests/master_tests.cpp (line 58) <https://reviews.apache.org/r/44545/#comment189340> newline - Kapil Arya On March 23, 2016, 7:05 p.m., Anurag Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44545/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 7:05 p.m.) > > > Review request for mesos, Benjamin Hindman and Kapil Arya. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > ------- > > Instead of keeping standalone and zookeper contender/detector class > definitions and implementations in the same file, separated them. Also > made the necessary changes in users of class headers to point to the > new locations. > > > Diffs > ----- > > src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf > src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 > src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 > src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 > src/master/contenders/contender.hpp PRE-CREATION > src/master/contenders/contender.cpp PRE-CREATION > src/master/contenders/standalone.cpp PRE-CREATION > src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 > src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e > src/master/detectors/detector.hpp PRE-CREATION > src/master/detectors/detector.cpp PRE-CREATION > src/master/detectors/standalone.cpp PRE-CREATION > src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 > src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 > src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 > src/tests/authentication_tests.cpp 8143cd7a22bbdbcd0fc613cb44eae8b55fd458e7 > src/tests/cluster.cpp 22167da70a855a39fd9c3ca980304372c70bd8d3 > src/tests/containerizer/external_containerizer_test.cpp > 5e2116355418f5a0716cfd1573bab48ba75df596 > src/tests/containerizer/isolator_tests.cpp > 6a2e25b967742c034364d19372f06aa9f9cdf828 > src/tests/fault_tolerance_tests.cpp > f99413f56e96a796d3d45decad1f049e6a238789 > src/tests/gc_tests.cpp 42059b2d6544f360cdc9230fe6ed33a11a15bc50 > src/tests/master_allocator_tests.cpp > b41ba2bda4d680f6fc42f525719973d56c11fe31 > src/tests/master_authorization_tests.cpp > 8b9b8991fbb8c5a5beb69416a9c4a4ef3525942d > src/tests/master_contender_detector_tests.cpp > bbce379e5a0a0ca608579d0ab2b10970e9cd5ef1 > src/tests/master_slave_reconciliation_tests.cpp > 988f1d46580ab5a707fe801824e24f94d4f50da7 > src/tests/master_tests.cpp d34ba0bdd71efd261850d8c205c16cecb701ac7c > src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 > src/tests/oversubscription_tests.cpp > ba036810758d99a6fb0034c5e2bc7829e2343a44 > src/tests/partition_tests.cpp 349adbf67686e6044a2e6a4b673043ad74fce44e > src/tests/persistent_volume_tests.cpp > 26fff19daa8b175fdcc06fd9467224d5920a1967 > src/tests/reconciliation_tests.cpp 5f541f5fe004ede943a1b022daab92f01d1f4853 > src/tests/reservation_tests.cpp a9261bdf48c0af933e7fc303b7af356a60b49506 > src/tests/scheduler_event_call_tests.cpp > 00e99777ba0294c9c12ac86594987afbd9388b51 > src/tests/scheduler_http_api_tests.cpp > b65790a9aad0ca68c6a93dd1d872442b906598fd > src/tests/scheduler_tests.cpp 917058f4dcf32ddaaeda8a3ff21898571f4829dd > src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e > src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 > > Diff: https://reviews.apache.org/r/44545/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/44670/. > > > Thanks, > > Anurag Singh > >
