Re: Review Request 50707: Added test for race between health checks and agent disconnect.

/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51374: Change registry update order on removal, mark-unreachable.

--- make check Thanks, Neil Conway

Re: Review Request 51021: Added GC of unreachable agent metadata from the registry.

f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 src/tests/registrar_tests.cpp b04fc92c66449f1094212a534899e16d5f6f01bd Diff: https://reviews.apache.org/r/51021/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51653: Handled agents failing health checks multiple times.

ice/0" --gtest_repeat=1000 --gtest_break_on_failure` Thanks, Neil Conway

Re: Review Request 51707: Fixed races between "unreachable" and "unregister" slave transitions.

701fab20091f9f7df020290b9f0a9db1dec92647 Diff: https://reviews.apache.org/r/51707/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 50845: Added `unreachable_time` to TaskStatus.

://reviews.apache.org/r/50845/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 50845: Added `unreachable_time` to TaskStatus.

if that's not the case. - Neil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50845/#review148077 --- On Sept. 6, 2

Review Request 51706: Tweaked logging for UnregisterSlaveMessage handler.

agent, and do some minor code cleanup. Diffs - src/master/master.cpp b2a19a645528e8fc1fd48f5ac9929d38c9a76b49 Diff: https://reviews.apache.org/r/51706/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51653: Handled agents failing health checks multiple times.

ice/0" --gtest_repeat=1000 --gtest_break_on_failure` Thanks, Neil Conway

Re: Review Request 50707: Added test for race between health checks and agent disconnect.

/ Testing --- make check Thanks, Neil Conway

Review Request 51707: Fixed races between "unreachable" and "unregister" slave transitions.

--- make check Thanks, Neil Conway

Re: Review Request 51374: Change registry update order on removal, mark-unreachable.

--- make check Thanks, Neil Conway

Re: Review Request 50845: Added `unreachable_time` to TaskStatus.

/50845/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

sts/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86 src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 Diff: https://reviews.apache.org/r/50705/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51021: Added GC of unreachable agent metadata from the registry.

b04fc92c66449f1094212a534899e16d5f6f01bd Diff: https://reviews.apache.org/r/51021/diff/ Testing --- make check Thanks, Neil Conway

Review Request 51805: Updated master to send TASK_UNREACHABLE task state.

_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 src/tests/reconciliation_tests.cpp 8e438bfbce508a074f0d54513cd752344238e3f2 Diff: https://reviews.apache.org/r/51805/diff/ Testing --- make check on OSX and Linux. Thanks, Neil Conway

Review Request 51891: Added test case for registry GC race condition.

/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 Diff: https://reviews.apache.org/r/51891/diff/ Testing --- `make check` Thanks, Neil Conway

Re: Review Request 51375: Introduced MockRegistrar.

EATION src/tests/mock_registrar.cpp PRE-CREATION Diff: https://reviews.apache.org/r/51375/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51375: Introduced MockRegistrar.

of the `reset`s should be the reverse of the order in which the fields are initialized in the ctor. That is also fragile, however. - Neil Conway On Sept. 14, 2016, 10:35 a.m., Neil Conway wrote: > > --- > This is an automatically generat

Re: Review Request 51805: Updated master to send TASK_UNREACHABLE task state.

master.cpp 1dcce6cd66804990af238176c61aca03bb5c9471 src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 src/tests/reconciliation_tests.cpp 8e438bfbce508a074f0d54513cd752344238e3f2 Diff: https://reviews.apache.org/r/51805/diff/ Testing --- make check on OSX and Linux. Tha

Re: Review Request 51808: Moved OfferEqMatcher to the single test file where it is used.

92d7d94733d461eb0c565830cc1c8e709e7a2ef7 Diff: https://reviews.apache.org/r/51808/diff/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway

Re: Review Request 51151: Moved MockContainerLogger to the single test where it is used.

92d7d94733d461eb0c565830cc1c8e709e7a2ef7 src/tests/mesos.cpp 539634eef8575a4e0091842343c29439f6d4d94c Diff: https://reviews.apache.org/r/51151/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51149: Cleaned up 'using' statements.

://reviews.apache.org/r/51149/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51150: Cleaned up usage of namespace-qualified identifiers.

dbb2772f8ba30db00 src/tests/resources_tests.cpp f627862870279e5a778aa83e1ddcaa88c27ba1cb src/tests/slave_recovery_tests.cpp 3c69e569d2adeab6058dde2b86d41edaa342e7b7 Diff: https://reviews.apache.org/r/51150/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51152: Moved MockDocker and related declarations to separate files.

://reviews.apache.org/r/51152/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51148: Moved MockSlave into a separate header/implementation file.

d07ff1fd2f14c73c924a07ce3850bf0d9de2135a src/tests/reservation_tests.cpp 000957826011bf28f7550a83db3e60a796162fb3 src/tests/slave_tests.cpp 2f3fa5fae634b6250f3c00bbef3077493f79af95 Diff: https://reviews.apache.org/r/51148/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51149: Cleaned up 'using' statements.

Thanks, Neil Conway

Re: Review Request 51021: Added GC of unreachable agent metadata from the registry.

https://reviews.apache.org/r/51021/#review148615 --- On Sept. 12, 2016, 1:48 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 51021: Added GC of unreachable agent metadata from the registry.

/registrar_tests.cpp b04fc92c66449f1094212a534899e16d5f6f01bd Diff: https://reviews.apache.org/r/51021/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 50707: Added test for race between health checks and agent disconnect.

ain). I also improved the comments. - Neil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50707/#review148592 ------- O

Re: Review Request 50707: Added test for race between health checks and agent unregistration.

) - src/tests/slave_tests.cpp 2f3fa5fae634b6250f3c00bbef3077493f79af95 Diff: https://reviews.apache.org/r/50707/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51653: Handled agents failing health checks multiple times.

rtant for admins to pay attention to. - Neil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51653/#review148619 --- On Sept. 12, 2

Re: Review Request 50707: Added test for race between health checks and agent unregistration.

s > > correctly here? What would happen if master behaves incorrectly? Maybe add > > some comments? > > Neil Conway wrote: > Well, we're checking the master does not segfault or hit a `CHECK` > failure, which it was doing before I fixed that bug and added this test :

Review Request 51845: Improved SlaveTest.HealthCheckUnregisterRace.

Thanks, Neil Conway

Re: Review Request 51374: Change registry update order on removal, mark-unreachable.

/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51707: Fixed races between "unreachable" and "unregister" slave transitions.

2f3fa5fae634b6250f3c00bbef3077493f79af95 Diff: https://reviews.apache.org/r/51707/diff/ Testing --- make check Thanks, Neil Conway

Review Request 51913: Ignored agent registrations with duplicate agent IDs.

4992ab0a0bb5babbf6a4fa3e6eff3577590fc879 src/master/master.cpp b88472f6350d3f71e057bab34822423da5427151 Diff: https://reviews.apache.org/r/51913/diff/ Testing --- `make check` Thanks, Neil Conway

Re: Review Request 51913: Ignored agent registrations with duplicate agent IDs.

whose ID we collided with. Diffs (updated) - src/master/master.hpp 4992ab0a0bb5babbf6a4fa3e6eff3577590fc879 src/master/master.cpp b88472f6350d3f71e057bab34822423da5427151 Diff: https://reviews.apache.org/r/51913/diff/ Testing --- `make check` Thanks, Neil Conway

Re: Review Request 51148: Moved MockSlave into a separate header/implementation file.

/51148/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51149: Cleaned up 'using' statements.

://reviews.apache.org/r/51149/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51150: Cleaned up usage of namespace-qualified identifiers.

42ad8d50daafcdb70ad9dbb2772f8ba30db00 src/tests/resources_tests.cpp f627862870279e5a778aa83e1ddcaa88c27ba1cb src/tests/slave_recovery_tests.cpp 3c69e569d2adeab6058dde2b86d41edaa342e7b7 Diff: https://reviews.apache.org/r/51150/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51151: Moved MockContainerLogger to the single test where it is used.

9bcdaf19833d08ccfbfe4781179f8626e141a7e1 src/tests/mesos.cpp f5034f9f8de7040182e10f51be125a87b29fdd24 Diff: https://reviews.apache.org/r/51151/diff/ Testing --- make check Thanks, Neil Conway

Review Request 51808: Moved OfferEqMatcher to the single test file where it is used.

--- `make check` on OSX and Linux. Thanks, Neil Conway

Re: Review Request 51152: Moved MockDocker and related declarations to separate files.

/mock_docker.cpp PRE-CREATION Diff: https://reviews.apache.org/r/51152/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51375: Introduced MockRegistrar.

/tests/mock_registrar.hpp PRE-CREATION src/tests/mock_registrar.cpp PRE-CREATION Diff: https://reviews.apache.org/r/51375/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51707: Fixed races between "unreachable" and "unregister" slave transitions.

701fab20091f9f7df020290b9f0a9db1dec92647 Diff: https://reviews.apache.org/r/51707/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51653: Handled agents failing health checks multiple times.

est_repeat=1000 --gtest_break_on_failure` Thanks, Neil Conway

Re: Review Request 52222: Changed the name of a constant in the tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review150236 --- Ship it! Ship It! - Neil Conway On Sept. 23, 2016, 7:31 p.m

Re: Review Request 52645: Harden Mesos

ons of?) gcc/clang. (2) You should split this review into three separate reviews: a single review should make changes to at most one of Mesos, libprocess, and stout. (3) What _specific_ attack vectors are these changes intended to prevent? - Neil Conway On Oct. 7, 2016, 7:22 p.m.

Review Request 52633: Fixed typo in comment.

--- Fixed typo in comment. Diffs - src/java/jni/org_apache_mesos_state_AbstractState.cpp 8addd2d71c0e830e4bf9c0c1ff0c7e4af776060a Diff: https://reviews.apache.org/r/52633/diff/ Testing --- Thanks, Neil Conway

Review Request 52634: Synchronized unversioned and v1 mesos.proto.

--- Synchronized unversioned and v1 mesos.proto. Diffs - include/mesos/v1/mesos.proto 57846a5cc0d8af53771346ad4b441ce7b337c6c5 Diff: https://reviews.apache.org/r/52634/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 52647: Fix new errors/warnings produced by hardened flags

, we previously didn't enable basic stuff like `-Wall` for stout and libprocess?!). As noted in the other review, stout/libprocess/mesos changes should be split into separate reviews. - Neil Conway On Oct. 7, 2016, 7:22 p.m., Aaron Wood wrote

Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

--- `make check` Thanks, Neil Conway

Review Request 52658: Changed scheduler driver to send TASK_DROPPED.

--- `make check` Thanks, Neil Conway

Review Request 52657: Clarified a comment that occurs in several tests.

--- `make check` Thanks, Neil Conway

Review Request 52656: Cleaned up a test case.

--- Cleaned up a test case. Diffs - src/tests/fault_tolerance_tests.cpp 5a9944cf459ab688907d95bbda09f464b37efd1e Diff: https://reviews.apache.org/r/52656/diff/ Testing --- `make check` Thanks, Neil Conway

Review Request 52616: Fixed whitespace infelicities.

--- Fixed whitespace infelicities. Diffs - src/tests/utils.cpp cc5259a720bb6451714a100b0451b473395e3650 Diff: https://reviews.apache.org/r/52616/diff/ Testing --- `make check` Thanks, Neil Conway

Review Request 52618: Added comment describing a common gotcha.

://issues.apache.org/jira/browse/MESOS-6231 Repository: mesos Description --- Added comment describing a common gotcha. Diffs - src/tests/utils.cpp cc5259a720bb6451714a100b0451b473395e3650 Diff: https://reviews.apache.org/r/52618/diff/ Testing --- `make check` Thanks, Neil Conway

Review Request 52617: Improved symmetry of code in related utility functions.

--- Improved symmetry of code in related utility functions. Diffs - src/tests/utils.cpp cc5259a720bb6451714a100b0451b473395e3650 Diff: https://reviews.apache.org/r/52617/diff/ Testing --- `make check` Thanks, Neil Conway

Review Request 52113: Fixed an uninitialized variable warning.

Description --- Observed with clang-tidy. Diffs - src/linux/fs.cpp 369a302e0f97daaa987df8d625cfe3c4808cdfc9 Diff: https://reviews.apache.org/r/52113/diff/ Testing --- `make check` on Linux. Thanks, Neil Conway

Re: Review Request 52113: Fixed an uninitialized variable warning.

Klues. Changes --- Tweak. Repository: mesos Description --- Observed with clang-tidy. Diffs (updated) - src/linux/fs.cpp 369a302e0f97daaa987df8d625cfe3c4808cdfc9 Diff: https://reviews.apache.org/r/52113/diff/ Testing --- `make check` on Linux. Thanks, Neil

Re: Review Request 51375: Introduced MockRegistrar.

eviews.apache.org/r/51375/#review148960 --- On Sept. 15, 2016, 7:36 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51375/ >

Re: Review Request 51375: Introduced MockRegistrar.

Diff: https://reviews.apache.org/r/51375/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51376: Adjusted existing tests to use MockRegistrar.

4992ab0a0bb5babbf6a4fa3e6eff3577590fc879 src/tests/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86 src/tests/reconciliation_tests.cpp 8e438bfbce508a074f0d54513cd752344238e3f2 Diff: https://reviews.apache.org/r/51376/diff/ Testing --- make check Thanks, Neil Conway

Review Request 51909: Added benchmarks for new registry operations.

` is quadratic time and `MarkSlaveReachable` and `MarkSlaveUnreachable` are both linear time. For the time being, optimizing these operations doesn't seem like it is needed urgently. Thanks, Neil Conway

Re: Review Request 51909: Added benchmarks for new registry operations.

(32296 ms) [ RUN ] SlaveCount/Registrar_BENCHMARK_Test.MarkUnreachableThenReachable/3 Marked 5 agents unreachable in 39.277686secs Marked 5 agents reachable in 18.483256secs [ OK ] SlaveCount/Registrar_BENCHMARK_Test.MarkUnreachableThenReachable/3 (73369 ms) ``` Thanks, Neil

Review Request 51967: Changed return type of `os::pagesize` in stout.

/include/stout/os/windows/pagesize.hpp 6112e9781a9d42f7ec1ae0832c0c877d1915b09b Diff: https://reviews.apache.org/r/51967/diff/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway

Review Request 51968: Simplified usage of `os::pagesize` in Mesos.

/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway

Re: Review Request 51953: Changed registrar operations to no longer depend on "strict" flag.

rc/master/master.hpp 4992ab0a0bb5babbf6a4fa3e6eff3577590fc879 src/master/master.cpp b88472f6350d3f71e057bab34822423da5427151 src/tests/registrar_tests.cpp b04fc92c66449f1094212a534899e16d5f6f01bd Diff: https://reviews.apache.org/r/51953/diff/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway

Re: Review Request 51954: Removed the "strict" flag from the registry operation interface.

4942ac88b8e27741ef9b4e1fe0d82ab788bae883 Diff: https://reviews.apache.org/r/51954/diff/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway

Review Request 52039: Avoided using SIGUSR1 in two test cases.

_tests.cpp 696e0f71190238133f29b6380bc58b994a556e69 Diff: https://reviews.apache.org/r/52039/diff/ Testing --- `make check` on OSX. Thanks, Neil Conway

Review Request 52080: Replaced `Latch*` with `Latch` in executor, scheduler drivers.

/52080/diff/ Testing --- `make check` on OSX. Thanks, Neil Conway

Re: Review Request 52174: Fixed bug with unreachable tasks and disconnected frameworks.

7c38f0efa414447e6292b2d6b334fb9879c92eb5 Diff: https://reviews.apache.org/r/52174/diff/ Testing --- `make check` on OSX. Thanks, Neil Conway

Review Request 52214: Cleaned up some code for managing recovered frameworks.

and Linux. Thanks, Neil Conway

Re: Review Request 52175: Tweaked test comments.

. Changes --- Rebase. Repository: mesos Description --- Tweaked test comments. Diffs (updated) - src/tests/partition_tests.cpp 7c38f0efa414447e6292b2d6b334fb9879c92eb5 Diff: https://reviews.apache.org/r/52175/diff/ Testing --- `make check` on OSX. Thanks, Neil

Re: Review Request 52174: Fixed bug with unreachable tasks and disconnected frameworks.

----- On Sept. 22, 2016, 9:12 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52174/ >

Review Request 52175: Tweaked test comments.

--- Tweaked test comments. Diffs - src/tests/partition_tests.cpp 7c38f0efa414447e6292b2d6b334fb9879c92eb5 Diff: https://reviews.apache.org/r/52175/diff/ Testing --- `make check` on OSX. Thanks, Neil Conway

Review Request 52174: Fixed bug with unreachable tasks and disconnected frameworks.

66a672f6d16233e96b29e330a9e6c474546fa851 src/tests/partition_tests.cpp 7c38f0efa414447e6292b2d6b334fb9879c92eb5 Diff: https://reviews.apache.org/r/52174/diff/ Testing --- `make check` on OSX. Thanks, Neil Conway

Review Request 52086: Cleaned up header includes in stout.

3ac62169be22eebaa56ec1a3b7cf1d0007b17870 Diff: https://reviews.apache.org/r/52086/diff/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway

Review Request 52085: Replaced usage of `strcpy` in stout.

/52085/diff/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway

Re: Review Request 43138: Updated a comment for oversubscribed resources for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43138/#review149971 --- Ship it! Ship It! - Neil Conway On Sept. 21, 2016, 2:39 p.m

Review Request 52082: Tweaked initialization order in executor driver.

initialize libprocess before calling into any libprocess facilities (in this case, `process::Latch`). Diffs - src/exec/exec.cpp c1cda5aca81dd8c73c50dd01ce49ef69805bbf09 Diff: https://reviews.apache.org/r/52082/diff/ Testing --- `make check` on OSX. Thanks, Neil Conway

Re: Review Request 52080: Ensured that `Latch*` in exec, sched drivers is initialized.

. Thanks, Neil Conway

Review Request 51958: Removed "registry_strict" master command-line flag.

r/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740 src/tests/cluster.cpp b04653af97d17aaa9d0d3ee872169b66cd67126b src/tests/mesos.cpp 07a64f0ff49a753ec26260cdf859d0584c3f935a Diff: https://reviews.apache.org/r/51958/diff/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway

Review Request 51957: Removed "strictness" parameter from RegistrarTest and PartitionTest.

b04fc92c66449f1094212a534899e16d5f6f01bd Diff: https://reviews.apache.org/r/51957/diff/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway

Review Request 51955: Removed dependency on "registry_strict" in master failover.

rc/master/master.cpp b88472f6350d3f71e057bab34822423da5427151 src/tests/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86 Diff: https://reviews.apache.org/r/51955/diff/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway

Review Request 51956: Squelched GMock warning in MasterTest.RecoveredSlaveCanReregister.

/51956/diff/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway

Review Request 51953: Changed registrar operations to no longer depend on "strict" flag.

rc/master/master.cpp b88472f6350d3f71e057bab34822423da5427151 src/tests/registrar_tests.cpp b04fc92c66449f1094212a534899e16d5f6f01bd Diff: https://reviews.apache.org/r/51953/diff/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway

Review Request 51954: Removed the "strict" flag from the registry operation interface.

. Thanks, Neil Conway

Re: Review Request 51953: Changed registrar operations to no longer depend on "strict" flag.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51953/#review149241 ------- On Sept. 16, 2016, 7:15 p.m., Neil Conway wrote: > >

Review Request 51983: Avoided passing large object by value.

--- Avoided passing large object by value. Diffs - src/slave/containerizer/mesos/isolators/network/cni/cni.hpp eea80355d9a12f7b9571c55194ef3ab4931e6aed Diff: https://reviews.apache.org/r/51983/diff/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway

Re: Review Request 51958: Removed use of "--registry_strict" master flag.

43af218 src/tests/cluster.cpp b04653af97d17aaa9d0d3ee872169b66cd67126b src/tests/mesos.cpp 07a64f0ff49a753ec26260cdf859d0584c3f935a Diff: https://reviews.apache.org/r/51958/diff/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway

Review Request 51984: Cleaned up initialization of atomic fields in ProcessManager.

to a well-defined value in the first place. Diffs - 3rdparty/libprocess/src/process.cpp 1e48fd5269d1a94c2217e8826af54b9b42ec4b23 Diff: https://reviews.apache.org/r/51984/diff/ Testing --- `make check` on OSX. Thanks, Neil Conway

Re: Review Request 52086: Cleaned up header includes in stout.

hpp 31acbd406c7d447d6f141201c0cfa153d948ef9f 3rdparty/stout/include/stout/os/raw/argv.hpp 3ac62169be22eebaa56ec1a3b7cf1d0007b17870 Diff: https://reviews.apache.org/r/52086/diff/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50705/#review146438 --- On Aug. 25, 2016, 8:23 a.m., Neil Conway wrote: > > ---

Re: Review Request 50846: Added more assertions to the master.

2b4aff80385d02c71dc3eeff4ddda326c9824ede Diff: https://reviews.apache.org/r/50846/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 50845: Added `unreachable_time` to TaskStatus.

://reviews.apache.org/r/50845/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

sts/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86 src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 Diff: https://reviews.apache.org/r/50705/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 50706: Added test cases for PARTITION_AWARE behavior.

Diff: https://reviews.apache.org/r/50706/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 51374: Change registry update order on removal, mark-unreachable.

--- make check Thanks, Neil Conway

<    8   9   10   11   12   13   14   15   16   17   >