/
Testing
---
sudo make check
Thanks,
Qian Zhang
---
On June 19, 2019, 10:49 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70887/
> ---
>
> (Updated June 19, 201
s an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70889/
> ---
>
> (Updated June 19, 2019, 10:49 p.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-9841
> https://issues.apache.org/jira
tps://reviews.apache.org/r/70889/#comment303849>
Kill this newline.
- Qian Zhang
On June 19, 2019, 10:49 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
--
>
> (Updated June 19, 2019, 10:49 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gilbert Song, James Peach, Meng
> Zhu, and Qian Zhang.
>
>
> Bugs: MESOS-9837
> https://issues.apache.org/jir
> On July 15, 2019, 4:35 p.m., Qian Zhang wrote:
> > src/common/future_track.hpp
> > Lines 90 (patched)
> > <https://reviews.apache.org/r/70887/diff/3/?file=2154659#file2154659line90>
> >
> > I'd suggest to use `Owned` instead of raw pointer.
>
t;
Suggest to merge these two lines into a single line.
src/common/future_track.hpp
Lines 90 (patched)
<https://reviews.apache.org/r/70887/#comment303810>
I'd suggest to use `Owned` instead of raw pointer.
- Qian Zhang
On June 19, 2019, 1
/slave/flags.cpp b4e3eb99221a09404dbbf813da33607867a78691
src/tests/containerizer/isolator_tests.cpp
a493a309464f8c7b3cb6f0fc45a2762d12071c67
Diff: https://reviews.apache.org/r/71072/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
namespaces and /dev/shm.
Diffs (updated)
-
src/tests/containerizer/isolator_tests.cpp
bb2cda47ad1fdd7ad16c419eb04f2e0b9293d2b6
Diff: https://reviews.apache.org/r/70859/diff/2/
Changes: https://reviews.apache.org/r/70859/diff/1-2/
Testing
---
Thanks,
Qian Zhang
/containerizer/isolator_tests.cpp
bb2cda47ad1fdd7ad16c419eb04f2e0b9293d2b6
Diff: https://reviews.apache.org/r/70860/diff/2/
Changes: https://reviews.apache.org/r/70860/diff/1-2/
Testing
---
sudo make check
Thanks,
Qian Zhang
bb2cda47ad1fdd7ad16c419eb04f2e0b9293d2b6
Diff: https://reviews.apache.org/r/70857/diff/2/
Changes: https://reviews.apache.org/r/70857/diff/1-2/
Testing
---
Thanks,
Qian Zhang
/containerizer/isolator_tests.cpp
bb2cda47ad1fdd7ad16c419eb04f2e0b9293d2b6
Diff: https://reviews.apache.org/r/70852/diff/2/
Changes: https://reviews.apache.org/r/70852/diff/1-2/
Testing
---
Thanks,
Qian Zhang
bb2cda47ad1fdd7ad16c419eb04f2e0b9293d2b6
Diff: https://reviews.apache.org/r/70849/diff/2/
Changes: https://reviews.apache.org/r/70849/diff/1-2/
Testing
---
sudo make check
Thanks,
Qian Zhang
/containerizer/isolator_tests.cpp
bb2cda47ad1fdd7ad16c419eb04f2e0b9293d2b6
Diff: https://reviews.apache.org/r/70845/diff/3/
Changes: https://reviews.apache.org/r/70845/diff/2-3/
Testing
---
sudo make check
Thanks,
Qian Zhang
/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
/
Testing
---
sudo make check
Thanks,
Qian Zhang
/
Testing
---
sudo make check
Thanks,
Qian Zhang
src/launcher/executor.cpp 38d82614ed82e8a6644334f0401cecdee6a025bf
Diff: https://reviews.apache.org/r/70989/diff/1/
Testing
---
Thanks,
Qian Zhang
t;
Do we plan to return pending operations for other components rather than
just containerizer in future? If yes, then I think we'd better give it a
generic name (like `/debug`) and return component name (currently it is just
`containerizer`) along with operation name and args in the respons
(patched)
<https://reviews.apache.org/r/70891/#comment303392>
Can we merge these into a single line?
- Qian Zhang
On June 19, 2019, 10:49 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail.
(patched)
<https://reviews.apache.org/r/70890/#comment303391>
This method should be tracked as well.
- Qian Zhang
On June 19, 2019, 10:49 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail.
(patched)
<https://reviews.apache.org/r/70889/#comment303390>
Why do we need a dedicated for loop to do this? Can we just do it when each
isolator is created (line 549 and line 563)?
- Qian Zhang
On June 19, 2019, 10:49 p.m., Andrei Budnik
ending for
a long time somehow.
src/slave/containerizer/mesos/isolator_tracker.cpp
Lines 111 (patched)
<https://reviews.apache.org/r/70888/#comment303387>
Better to add `stringify(resources)`.
- Qian Zhang
On June 19, 2019, 10:49 p.m., Andrei
we use `std::vector` instead?
- Qian Zhang
On June 19, 2019, 10:49 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/paths.cpp
4281abc522c942c87fcfd811af26f95cbd6f734f
src/tests/containerizer/isolator_tests.cpp
9c14f3acbc19631b2f5cac4dc7cd9caba8527712
Diff: https://reviews.apache.org/r/70798/diff/5/
Changes: https://reviews.apache.org/r/70798/diff/4-5/
Testing
---
Thanks,
Qian Zhang
4281abc522c942c87fcfd811af26f95cbd6f734f
src/tests/containerizer/isolator_tests.cpp
9c14f3acbc19631b2f5cac4dc7cd9caba8527712
Diff: https://reviews.apache.org/r/70798/diff/4/
Changes: https://reviews.apache.org/r/70798/diff/3-4/
Testing
---
Thanks,
Qian Zhang
on cycle.
- Qian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70820/#review216030
---
On June 12, 2019, 10:32 p.m.
eviews.apache.org/r/70844/#review216029
---
On June 12, 2019, 10:36 p.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To re
t; > how about `CONTAINER_SHM_DIRECTORY` or just `CONTAINER_SHM`?
Agree! Let's go with `CONTAINER_SHM_DIRECTORY`.
- Qian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70798/#review216026
-
2b4f350815935220c2d2b0dd0e52346bc74c91d9
include/mesos/v1/mesos.proto bafc27499f810791700c4a30dcb1da33b6f31d2e
Diff: https://reviews.apache.org/r/70775/diff/2/
Changes: https://reviews.apache.org/r/70775/diff/1-2/
Testing
---
Thanks,
Qian Zhang
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70775/#review215974
---
On June 7, 2019, 7:23 a.m., Qian Zhang wrote:
>
> ---
9684a09071be930f25a7d10821ee65b5a965fa83
src/slave/flags.cpp e23061ad929c8e3c24806f52c95f82766e3d1911
Diff: https://reviews.apache.org/r/70773/diff/3/
Testing
---
Thanks,
Qian Zhang
/r/70774/diff/3/
Changes: https://reviews.apache.org/r/70774/diff/2-3/
Testing
---
Thanks,
Qian Zhang
://reviews.apache.org/r/70773/diff/2-3/
Testing
---
Thanks,
Qian Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70863/#review215932
---
Ship it!
Ship It!
- Qian Zhang
On June 17, 2019, 10:47 a.m
/diff/1/
Testing
---
Thanks,
Qian Zhang
/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
9c14f3acbc19631b2f5cac4dc7cd9caba8527712
Diff: https://reviews.apache.org/r/70859/diff/1/
Testing
---
Thanks,
Qian Zhang
9c14f3acbc19631b2f5cac4dc7cd9caba8527712
Diff: https://reviews.apache.org/r/70852/diff/1/
Testing
---
Thanks,
Qian Zhang
/
Testing
---
Thanks,
Qian Zhang
the test `NamespacesIsolatorTest.ROOT_ShareAgentIPCNamespace`.
Diffs
-
src/tests/containerizer/isolator_tests.cpp
9c14f3acbc19631b2f5cac4dc7cd9caba8527712
Diff: https://reviews.apache.org/r/70852/diff/1/
Testing
---
Thanks,
Qian Zhang
/70849/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
9c14f3acbc19631b2f5cac4dc7cd9caba8527712
Diff: https://reviews.apache.org/r/70845/diff/2/
Changes: https://reviews.apache.org/r/70845/diff/1-2/
Testing
---
sudo make check
Thanks,
Qian Zhang
/70845/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
32c888309ca536d944e4d73641aed214805ccce2
src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp
6c8e8eed69ed355094f7d9b54bde25a8a9bc63f7
Diff: https://reviews.apache.org/r/70844/diff/1/
Testing
---
Thanks,
Qian Zhang
/mesos/isolators/namespaces/ipc.cpp
6c8e8eed69ed355094f7d9b54bde25a8a9bc63f7
Diff: https://reviews.apache.org/r/70844/diff/1/
Testing
---
Thanks,
Qian Zhang
and IPC namespace
will be handled by `namespaces/ipc` isolator.
Diffs
-
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
3cfb6e97a565420c8be2a0e31b481b39cd09d9da
Diff: https://reviews.apache.org/r/70820/diff/1/
Testing
---
Thanks,
Qian Zhang
/
Changes: https://reviews.apache.org/r/70798/diff/2-3/
Testing
---
Thanks,
Qian Zhang
Diffs
-
src/tests/containerizer/cgroups_isolator_tests.cpp
957f72d78f9ab0bf2775687915099c0109dac6e1
Diff: https://reviews.apache.org/r/70827/diff/1/
Testing (updated)
---
sudo make check
The tests updated in this patch would fail without the previous patch.
Thanks,
Qian Zhang
/cgroups_isolator_tests.cpp
957f72d78f9ab0bf2775687915099c0109dac6e1
Diff: https://reviews.apache.org/r/70827/diff/1/
Testing
---
Thanks,
Qian Zhang
---
Thanks,
Qian Zhang
/paths.cpp
4281abc522c942c87fcfd811af26f95cbd6f734f
src/tests/containerizer/isolator_tests.cpp
9c14f3acbc19631b2f5cac4dc7cd9caba8527712
Diff: https://reviews.apache.org/r/70798/diff/2/
Changes: https://reviews.apache.org/r/70798/diff/1-2/
Testing
---
Thanks,
Qian Zhang
by `namespaces/ipc` isolator.
Diffs
-
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
3cfb6e97a565420c8be2a0e31b481b39cd09d9da
Diff: https://reviews.apache.org/r/70820/diff/1/
Testing
---
Thanks,
Qian Zhang
/diff/1/
Testing
---
Thanks,
Qian Zhang
/mesos.proto e8086e0f70cac73876a8ae31db3365b5059b5c44
Diff: https://reviews.apache.org/r/70775/diff/1/
Testing
---
Thanks,
Qian Zhang
9684a09071be930f25a7d10821ee65b5a965fa83
src/slave/flags.cpp e23061ad929c8e3c24806f52c95f82766e3d1911
Diff: https://reviews.apache.org/r/70774/diff/2/
Testing
---
Thanks,
Qian Zhang
/slave/flags.hpp 9684a09071be930f25a7d10821ee65b5a965fa83
src/slave/flags.cpp e23061ad929c8e3c24806f52c95f82766e3d1911
Diff: https://reviews.apache.org/r/70774/diff/2/
Changes: https://reviews.apache.org/r/70774/diff/1-2/
Testing
---
Thanks,
Qian Zhang
: https://reviews.apache.org/r/70773/diff/1-2/
Testing
---
Thanks,
Qian Zhang
/flags.cpp e23061ad929c8e3c24806f52c95f82766e3d1911
Diff: https://reviews.apache.org/r/70774/diff/1/
Testing
---
Thanks,
Qian Zhang
e8086e0f70cac73876a8ae31db3365b5059b5c44
Diff: https://reviews.apache.org/r/70775/diff/1/
Testing
---
Thanks,
Qian Zhang
src/slave/flags.cpp e23061ad929c8e3c24806f52c95f82766e3d1911
Diff: https://reviews.apache.org/r/70773/diff/1/
Testing
---
Thanks,
Qian Zhang
> On May 15, 2019, 2:16 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Lines 230-235 (patched)
> > <https://reviews.apache.org/r/70581/diff/4/?file=2145030#file2145030line230>
> >
> > s/ignore_docker
untime` isolator handle it (i.e., if it is true the isolator will just
do nothing)? Or maybe this should be a configuration per container? Like add a
field in `ContainerInfo`.
- Qian Zhang
On May 15, 2019, 2:51 a.m., Jacob Janco
/linux.cpp
725754f26855ea54ccf8cbcb288ee3b29e8ed4e7
Diff: https://reviews.apache.org/r/70514/diff/3/
Changes: https://reviews.apache.org/r/70514/diff/2-3/
Testing
---
Thanks,
Qian Zhang
/
Testing
---
sudo make check.
Thanks,
Qian Zhang
/filesystem/linux.cpp
725754f26855ea54ccf8cbcb288ee3b29e8ed4e7
Diff: https://reviews.apache.org/r/70514/diff/2/
Changes: https://reviews.apache.org/r/70514/diff/1-2/
Testing
---
Thanks,
Qian Zhang
eviews.apache.org/r/70514/#review214832
---
On April 22, 2019, 9:25 p.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70514/
> ---
a couple of isolators, like:
cgroups, Docker volume, CNI, etc.
- Qian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70514/#review214832
----
Diff: https://reviews.apache.org/r/70515/diff/1/
Testing
---
sudo make check
This test will fail without the previous patch
(https://reviews.apache.org/r/70514/ ).
Thanks,
Qian Zhang
/
Testing
---
Thanks,
Qian Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70484/#review214694
---
Ship it!
Ship It!
- Qian Zhang
On April 16, 2019, 2:08 p.m
/provisioner/store.hpp
Line 49 (original), 49 (patched)
<https://reviews.apache.org/r/70483/#comment300888>
This comment seems not accurate, this field should be either Docker v1
image manifest or Docker v2 s2 image configuration.
- Qian Zhang
On April 16, 2019, 2:07 p.m., Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70482/#review214691
---
Ship it!
Ship It!
- Qian Zhang
On April 16, 2019, 2:07 p.m
it:
https://reviews.apache.org/r/70446/#review214554
---
On April 10, 2019, 5:32 p.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70398/#review214564
---
Ship it!
Ship It!
- Qian Zhang
On April 6, 2019, 5:42 a.m
/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
/
Testing
---
Thanks,
Qian Zhang
://reviews.apache.org/r/70444/diff/1/
Testing
---
Thanks,
Qian Zhang
bb224d8b991d13aa7ea7185dd78a99def0c18c7f
src/uri/fetcher.cpp 3147e41f2d61712d50d8378c750a72790eeb27bb
Diff: https://reviews.apache.org/r/70443/diff/1/
Testing
---
Thanks,
Qian Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70288/#review214368
---
Ship it!
Ship It!
- Qian Zhang
On April 4, 2019, 4 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70291/#review214366
---
Ship it!
Ship It!
- Qian Zhang
On April 3, 2019, 3:18 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70290/#review214365
---
Ship it!
Ship It!
- Qian Zhang
On April 3, 2019, 3:18 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70289/#review214364
---
Ship it!
Ship It!
- Qian Zhang
On April 2, 2019, 4:11 p.m
than config
path.
- Qian Zhang
On April 3, 2019, 3:17 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
and we will not find anything
since what is saved in cache is `library/alpine`. This will cause our cache is
always missed.
- Qian Zhang
On April 3, 2019, 4:01 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e
329-331 (patched)
<https://reviews.apache.org/r/70288/#comment300532>
We should only do this if `image->has_config_digest()` is true.
- Qian Zhang
On April 3, 2019, 4:01 p.m., Gilbert Song wrote:
>
> ---
> This i
458-462 (patched)
<https://reviews.apache.org/r/70288/#comment300529>
Do we really need this check? I think even without this check, the
`os::rename` in the code below will also give us reasonable error message if
`configSource` does not exist.
- Qian Zhang
On April 3, 2019, 4:
> On April 2, 2019, 9:18 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
> > Lines 548 (patched)
> > <https://reviews.apache.org/r/70288/diff/3/?file=2136767#file2136767line548>
> >
> > Can we
> On April 2, 2019, 9:18 p.m., Qian Zhang wrote:
> > src/uri/fetchers/docker.cpp
> > Line 842 (original), 742 (patched)
> > <https://reviews.apache.org/r/70288/diff/3/?file=2136769#file2136769line843>
> >
> > Is it possible that there is no `Content-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70365/#review214321
---
Ship it!
Ship It!
- Qian Zhang
On April 3, 2019, 3:17 p.m
/provisioner_docker_tests.cpp
Lines 830-832 (patched)
<https://reviews.apache.org/r/70366/#comment300515>
The indent seems not correct.
- Qian Zhang
On April 2, 2019, 4:12 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically g
---
>
> (Updated April 3, 2019, 9:08 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
>
>
> Bugs: MESOS-6934
> https://issues.apache.org/jira/browse/MESOS-6934
>
>
> Repository: mesos
>
>
&g
404-405 (original), 411-412 (patched)
<https://reviews.apache.org/r/70288/#comment300514>
I think this comment should be moved up to line 406.
- Qian Zhang
On April 3, 2019, 9:08 a.m., Gilbert Song
> On March 25, 2019, 3:56 p.m., Qian Zhang wrote:
> > src/uri/fetchers/docker.cpp
> > Line 1028 (original), 956 (patched)
> > <https://reviews.apache.org/r/70288/diff/1/?file=2133764#file2133764line1087>
> >
> > I think this will make `urlF
ed)
<https://reviews.apache.org/r/70288/#comment300485>
I think it is five (including both s1 and s2) rather than three.
src/uri/fetchers/docker.cpp
Lines 832-835 (patched)
<https://reviews.apache.org/r/70288/#comment300489>
I think we also need to add c
s also consistent with the above `layer_ids` field.
- Qian Zhang
On April 2, 2019, 4:10 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
;
Ditto.
src/tests/containerizer/provisioner_docker_tests.cpp
Line 328 (original), 329 (patched)
<https://reviews.apache.org/r/70354/#comment300469>
Comment (`return list`) need to be updated?
- Qian Zhang
On April 2, 2019, 9:21 a.m.,
container, we will download
`manifest->config()` again even it is already in storeDir, that's a duplicated
download to me.
Basically I think we should treat fetching `manifest->config()` as part of
fetching blobs rather than part of fetching manifest.
- Qian Zhang
On March 2
tps://reviews.apache.org/r/70288/#comment300108>
Can we add a TODO somewhere for verifying the digest after the blob is
fetched?
- Qian Zhang
On March 24, 2019, 12:33 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically g
-638 (original), 634-639 (patched)
<https://reviews.apache.org/r/70291/#comment300098>
I think we should use `alpine` (e.g.,
gcr.io/google-containers/alpine-with-bash) since the prefix here is
`ImageAlpine`.
- Qian Zhang
On March 24, 2019, 12:34 p.m., Gilbert Song
501 - 600 of 2317 matches
Mail list logo
