---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73004/#review222166
---
Ship it!
Ship It!
- Vinod Kone
On Nov. 4, 2020, 7:56 p.m
/console
Thanks,
Vinod Kone
Description
---
This ensures extracted tarballs are owned by root when running the
build as root.
Diffs
-
3rdparty/Makefile.am 23f49ecffc5b44529ce69ccd841d942a30a98c2d
Diff: https://reviews.apache.org/r/72861/diff/1/
Testing
---
Thanks,
Vinod Kone
Description
---
This ensures extracted tarballs are owned by root when running the
build as root.
Diffs
-
3rdparty/libprocess/3rdparty/Makefile.am
e148f2dd2470ba973cc3f6d4067be64039299a48
Diff: https://reviews.apache.org/r/72860/diff/1/
Testing
---
Thanks,
Vinod Kone
Description
---
This ensures extracted tarballs are owned by root when running the
build as root.
Diffs
-
3rdparty/stout/3rdparty/Makefile.am 5a90a11c67131f21dc4487222ea1dde228dd
Diff: https://reviews.apache.org/r/72859/diff/1/
Testing
---
Thanks,
Vinod Kone
72fd72375e63f7e0dddb5472187edfdbe7a9d148
Diff: https://reviews.apache.org/r/72856/diff/3/
Changes: https://reviews.apache.org/r/72856/diff/2-3/
Testing
---
Tested via
https://ci-builds.apache.org/job/Mesos/job/Mesos-Websitebot-test/4/console
Thanks,
Vinod Kone
ps://reviews.apache.org/r/72858/#review221846
---
On Sept. 10, 2020, 12:14 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail.
-Websitebot-test/4/console
Thanks,
Vinod Kone
---
https://ci-builds.apache.org/job/Mesos/job/Mesos-Websitebot-test/4/console
Thanks,
Vinod Kone
/job/Mesos-Websitebot-test/4/console
Thanks,
Vinod Kone
(patched)
<https://reviews.apache.org/r/72413/#comment308812>
Is the location also sent to the executor via an environment variable? If
yes, we should specify the name of it. If not, I think that would make it hard
to write a domain socket communicating executor?
- Vinod Kone
On Ap
,
Vinod Kone
On Jan. 28, 2020, 2:13 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72055/
> ---
>
> (Updated Jan. 28, 2020, 2:13 p.m.)
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71652/#review218354
---
Ship it!
Ship It!
- Vinod Kone
On Oct. 23, 2019, 3:52 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71559/#review218009
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 30, 2019, 1:06 p.m
(patched)
<https://reviews.apache.org/r/71497/#comment305180>
can you use the `alias` argument in `add()` for these?
docs/ssl.md
Lines 100 (patched)
<https://reviews.apache.org/r/71497/#comment305179>
These deprecations need to be documented in CHANGELOG and upgrades.md.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71415/#review217513
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 30, 2019, 1:10 p.m
://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
Thanks,
Vinod Kone
/
Testing
---
https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
Thanks,
Vinod Kone
/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6
Diff: https://reviews.apache.org/r/71393/diff/1/
Testing
---
https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
Thanks,
Vinod Kone
://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
Thanks,
Vinod Kone
/Mesos-Snapshot-Jar-Test/16/console
Thanks,
Vinod Kone
---
https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71389/#review217480
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 28, 2019, 2:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71375/#review217454
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 27, 2019, 4:56 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71309/#review217294
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 19, 2019, 5:03 p.m
(patched)
<https://reviews.apache.org/r/71244/#comment304392>
s/taskResources/tasksResources/
- Vinod Kone
On Aug. 7, 2019, 11:17 p.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71229/#review217041
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 1, 2019, 7:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71138/#review216793
---
Ship it!
Ship It!
- Vinod Kone
On July 22, 2019, 10:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70528/#review216485
---
Ship it!
- Vinod Kone
On July 10, 2019, 2:58 p.m., Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70528/#review216486
---
Ship it!
Ship It!
- Vinod Kone
On July 10, 2019, 2:58 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70527/#review216484
---
Ship it!
Ship It!
- Vinod Kone
On April 23, 2019, 2:32 p.m
atched)
<https://reviews.apache.org/r/70959/#comment303284>
can this be replaced with `return framework->idle()`?
- Vinod Kone
On June 27, 2019, 3:24 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically ge
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70898/#review215977
---
Ship it!
Ship It!
- Vinod Kone
On June 19, 2019, 6:37 p.m
k to master,
> but we do report it to users with https://reviews.apache.org/r/70835/.
>
> Greg Mann wrote:
> Are you proposing having a separate message for inclusion in the agent
> API outputs?
>
> Vinod Kone wrote:
> IIUC, Benjamin is questioning why we are st
; ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70822/
> ---
>
> (Updated June 18, 2019, 11:17 p.m.)
>
>
> Review request for mesos,
/isolators/linux/seccomp.cpp
Lines 35 (patched)
<https://reviews.apache.org/r/70567/#comment301226>
s/the/The/
- Vinod Kone
On April 29, 2019, 6:39 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70546/#review214896
---
Ship it!
Ship It!
- Vinod Kone
On April 25, 2019, 8:07 p.m
lid protos.
- Vinod Kone
On April 24, 2019, 3:28 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70538/
>
tps://reviews.apache.org/r/70449/#comment300762>
s/updated/update/
- Vinod Kone
On April 11, 2019, 1:30 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
or.cpp`.
- Vinod Kone
On April 11, 2019, 12:02 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
review :)
src/slave/slave.cpp
Lines 5033 (patched)
<https://reviews.apache.org/r/70449/#comment300733>
s/We don't need to updated/It is safe to not update/
- Vinod Kone
On April 10, 2019, 11:55 p.m., Chun-Hung Hsiao
tps://reviews.apache.org/r/70450/#comment300731>
Can you add a TODO to actually send the correct framework and executor id
in HEARTBEAT calls. It seems weird/wrong that we send dummy values.
- Vinod Kone
On April 10, 2019, 11:55 p.m., Joseph Wu
member this being safe because of lifecycle of resources vs
publish/unpublish.
- Vinod Kone
On April 10, 2019, 11:36 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
.
Diffs
-
NOTICE aa2fc8b2124bac35eb6e22c7188a8e38ef4d37a2
Diff: https://reviews.apache.org/r/70158/diff/1/
Testing
---
Testing RB webhook trigger.
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70103/#review213534
---
Ship it!
Ship It!
- Vinod Kone
On March 3, 2019, 12:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70129/#review213444
---
Ship it!
Ship It!
- Vinod Kone
On March 5, 2019, 6:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70105/#review213430
---
Ship it!
Ship It!
- Vinod Kone
On March 3, 2019, 6:03 p.m
: https://reviews.apache.org/api/review-requests/65820/
...
...
Thanks,
Vinod Kone
/65820/
...
...
Thanks,
Vinod Kone
70049
70053
66746
70044
67044
1df088d3e18b39b328291b1adc13f5e7c45b9e84
Thanks,
Vinod Kone
This just made sure I didn't make any syntax errors.
Thanks,
Vinod Kone
eded because verify-reviews.py sets the ENVIRONMENT
and other variables explicitly before verifying the review.
The comment at #33 should probably moved to #27.
- Vinod Kone
On Feb. 23, 2019, 8:18 p.m., Benjamin B
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70037/#review213039
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 21, 2019, 7 p.m
70018
70022
70011
70023
70025
67762
8effbf42ce2e7305973c7da5cf96760eed9da3d1
Thanks,
Vinod Kone
68785
69551
69559
69411
69614
69701
69582
69694
69755
69735
69775
69588
69869
69931
69955
69971
66644
69978
69615
70002
70001
70014
70018
70022
70011
70023
70025
67762
8effbf42ce2e7305973c7da5cf96760eed9da3d1
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70012/#review212928
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 19, 2019, 8:45 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7/#review212920
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 19, 2019, 5:23 p.m
)
<https://reviews.apache.org/r/7/#comment298793>
hmm. i don't think this is the right place to catch this exception. what if
we don't get into this for loop at all if it's a single review chain?
i think it should be in #197.
- Vinod Kone
On Feb. 19, 2019, 4:44 p.m., Be
)
-
src/tests/partition_tests.cpp 15af47b7d4328861a7523e669c2afc6a6574166b
Diff: https://reviews.apache.org/r/69909/diff/2/
Changes: https://reviews.apache.org/r/69909/diff/1-2/
Testing
---
make check
Thanks,
Vinod Kone
Diff: https://reviews.apache.org/r/69907/diff/2/
Changes: https://reviews.apache.org/r/69907/diff/1-2/
Testing
---
make check
Thanks,
Vinod Kone
://reviews.apache.org/r/69909/diff/1/
Testing
---
make check
Thanks,
Vinod Kone
that the latter is also cleaned up.
Diffs
-
src/master/master.cpp 4c9ef2528d0ab74b565dcb03d05c5189d0aa0c0f
Diff: https://reviews.apache.org/r/69908/diff/1/
Testing
---
make check (Updated test in next patch)
Thanks,
Vinod Kone
Description
---
Substituted `slave` with `slaveId` to be consistent with the code base.
No functional changes.
Diffs
-
src/master/master.cpp 4c9ef2528d0ab74b565dcb03d05c5189d0aa0c0f
Diff: https://reviews.apache.org/r/69907/diff/1/
Testing
---
make check
Thanks,
Vinod Kone
mework reconciles the operation after this code gets
executed. Will it always get OPERATION_UNREACHABLE? If not, then that would be
cnofusing.
Also, the operation status is not changed in-memory here. Is that
intentional?
- Vinod Kone
On Feb. 5, 2019, 4:24 p.m., Greg Mann
> On Jan. 25, 2019, 4:01 p.m., Vinod Kone wrote:
> > src/scheduler/scheduler.cpp
> > Line 234 (original), 234 (patched)
> > <https://reviews.apache.org/r/69839/diff/1/?file=2122187#file2122187line234>
> >
> > s/Augmenting/Authenticating/
>
)
<https://reviews.apache.org/r/69839/#comment298083>
s/Augmenting/Authenticating/
src/scheduler/scheduler.cpp
Line 587 (original), 573 (patched)
<https://reviews.apache.org/r/69839/#comment298087>
s/to augment request//
I didn't know "<< future" is th
?
- Vinod Kone
On Jan. 23, 2019, 11:47 a.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
)
<https://reviews.apache.org/r/69775/#comment297688>
This exited the process before, now we no longer do? Is that safe?
- Vinod Kone
On Jan. 16, 2019, 9:17 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically g
Do you know why?
Also `git checkout HEAD -- HEAD` is wrong. I don't think that works. Was
this tested?
- Vinod Kone
On Jan. 9, 2019, 9:30 a.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail.
?
- Vinod Kone
On Jan. 10, 2019, 2:52 p.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69705/
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69667/#review211733
---
Ship it!
Ship It!
- Vinod Kone
On Jan. 5, 2019, 1:25 a.m
S-9502).
// We do a SIGKILL here as a safeguard, so that switchboard server
forcefully exits and causes this
// cleanup feature to be completed, thus unblocking the container's cleanup.
- Vinod Kone
On Jan. 4, 2019, 8:03 a.m., Qian Zhang
pected to happen unless
there is a bug?
src/slave/containerizer/mesos/io/switchboard.cpp
Lines 825 (patched)
<https://reviews.apache.org/r/69667/#comment297130>
Is there anway to test this?
- Vinod Kone
On Jan. 4, 2019, 8:03
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69559/#review211340
---
Ship it!
Ship It!
- Vinod Kone
On Dec. 13, 2018, 3:59 p.m
'
Failed command: git reset --hard b'69296553d96ca78b3145b9dd400a3c2332b441c7\n'
Error: b'fatal: Cannot do hard reset with paths.\n'
This looks bad? Looks like we need to strip the trailing "\n"?
- Vinod Kone
On Dec. 13, 2018, 3:59 p.m., Armand Gri
review for cleanliness.
- Vinod Kone
On Dec. 12, 2018, 2:19 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
Manually copy test reports to host fs.
Diffs
-
support/mesos-build/entrypoint.sh ec98cc8b1fdcd0a32ed32cfeb69dfb976f82b81d
Diff: https://reviews.apache.org/r/69513/diff/1/
Testing
---
Have been testing this over week in a custom Jenkins job.
Thanks,
Vinod Kone
/
Changes: https://reviews.apache.org/r/61128/diff/2-3/
Testing
---
make check
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69293/#review210401
---
Ship it!
Ship It!
- Vinod Kone
On Nov. 7, 2018, 10:57 p.m
---
Simplified writing out test report xml files.
Diffs
-
support/mesos-build/entrypoint.sh 012f003b3cf22b49a442df293f1b6224c074e383
Diff: https://reviews.apache.org/r/69291/diff/1/
Testing
---
Thanks,
Vinod Kone
://reviews.apache.org/r/69291/diff/1-2/
Testing
---
Thanks,
Vinod Kone
manually with a custom jenkins job.
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69193/#review210099
---
Ship it!
Ship It!
- Vinod Kone
On Oct. 26, 2018, 5:42 p.m
)
<https://reviews.apache.org/r/69123/#comment294558>
Didn't quite follow why you had make this an Option?
- Vinod Kone
On Oct. 23, 2018, 3:08 a.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail.
-
On Oct. 8, 2018, 6:06 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68951/
> -----
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68951/#review209324
---
Ship it!
Ship It!
- Vinod Kone
On Oct. 8, 2018, 6:06 p.m
f3b-439c-a27a-847a8acd066c-S0
> > I1003 16:05:33.824251 17340 process.cpp:926] Stopped the socket accept loop
> > ```
@andy Is this a known issue with windows reviewbot?
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68912/#re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68866/#review209186
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 27, 2018, 5:41 p.m
> On Sept. 27, 2018, 6:23 p.m., Vinod Kone wrote:
> > src/java/jni/org_apache_mesos_v1_scheduler_V1Mesos.cpp
> > Lines 294 (patched)
> > <https://reviews.apache.org/r/68866/diff/1/?file=2092453#file2092453line294>
> >
> > Looks like you are doing `c
---
Added a log line to `MesosContainerizer::kill()`.
Diffs
-
src/slave/containerizer/mesos/containerizer.cpp
82d64e9928abd5e22493fa697d7b0910211533f3
Diff: https://reviews.apache.org/r/68912/diff/1/
Testing
---
make -j3 check
Ran it through internal CI.
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68899/#review209156
---
Ship it!
Ship It!
- Vinod Kone
On Oct. 2, 2018, 6:59 p.m
)
<https://reviews.apache.org/r/68865/#comment293336>
Can you add a comment on why you are doing this for posterity?
- Vinod Kone
On Sept. 27, 2018, 5:41 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatica
sleep in the client code instead of here for
now.
- Vinod Kone
On Sept. 27, 2018, 5:41 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
.org/r/68826/
> ---
>
> (Updated Sept. 24, 2018, 6:27 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Vinod Kone.
>
>
> Bugs: MESOS-9253
> https://issues.apache.org/jira/browse/MESOS-9253
>
>
> Repository: mesos
>
>
> Description
> ---
> On Aug. 7, 2018, 4:03 p.m., Vinod Kone wrote:
> > src/slave/containerizer/mesos/utils.cpp
> > Line 102 (original), 105 (patched)
> > <https://reviews.apache.org/r/68257/diff/1/?file=2069850#file2069850line108>
> >
> > Are we guaranteed that there a
(patched)
<https://reviews.apache.org/r/68257/#comment290125>
Are we guaranteed that there are no short-lived processes, other than the
task process, at the 2nd level? If not, we will have the same issue right?
Modulo the above question, the change LGTM.
- Vinod Kone
On
-2018-cfp-is-now-open.md
Lines 23 (patched)
<https://reviews.apache.org/r/68111/#comment289640>
s/2018/2017/
- Vinod Kone
On July 30, 2018, 8:12 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67965/#review206530
---
Ship it!
Ship It!
- Vinod Kone
On July 26, 2018, 7:14 p.m
s.apache.org/r/67965/#comment289371>
See below.
- Vinod Kone
On July 24, 2018, 5:29 a.m., Meng Zhu wrote:
>
> ---
> This is an automatically generated e-ma
1 - 100 of 3008 matches
Mail list logo
