Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

/symlink.hpp (line 65) <https://reviews.apache.org/r/39803/#comment173187> typo: sybolic->symbolic 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp (line 84) <https://reviews.apache.org/r/39803/#comment173189> We are not calling lstat here. - Yi

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review112701 --- Ship it! Ship It! - Yi Sun On Jan. 5, 2016, 12:12 a.m., Alex

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

ause we only hit here when it's not a directory. 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 96) <https://reviews.apache.org/r/39584/#comment173205> os::rmdir - Yi

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review112953 --- Ship it! Ship It! - Yi Sun On Jan. 5, 2016, 11:04 p.m., Alex

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

/stout/os/windows/ls.hpp (line 55) <https://reviews.apache.org/r/39802/#comment174322> So the entry is always pointing to the allocated memory when success. - Yi Sun On Jan. 4, 2016, 11:20 a.m., Alex Clemmer

Re: Review Request 42016: Windows: Apply patch.exe without elevation prompt

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/#review116126 --- Ship it! Ship It! - Yi Sun On Jan. 14, 2016, 12:43 a.m., M

Re: Review Request 43700: CMake: Fixed Find* scripts to not explode if invoked twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43700/#review119645 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:31 a.m

Re: Review Request 43418: Windows: Added slave/status_update_manager.cpp and other files.

g/r/43418/#comment180993> Is it intentional to drop slave/resource_estimator.cpp? - Yi Sun On Feb. 18, 2016, 1:01 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 43691: CMake:[2/2] Fixed http-parser library directory for Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43691/#review119650 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:24 a.m

Re: Review Request 43689: CMake: Begin to require 64-bit builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43689/#review119653 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:29 a.m

Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.

(line 105) <https://reviews.apache.org/r/43697/#comment180997> This seems like new. I suppose this is now needed. - Yi Sun On Feb. 18, 2016, 5:49 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e

Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43697/#review119657 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 5:49 a.m

Re: Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

) <https://reviews.apache.org/r/43698/#comment180999> Does STOUT_DEPENDENCIES already contain PICOJSON_TARGET? 3rdparty/libprocess/cmake/ProcessConfigure.cmake (line 70) <https://reviews.apache.org/r/43698/#comment181004> Already included in STOUT_INCLUDE_DIRS? - Yi Sun On Feb.

Re: Review Request 43699: CMake:[3/3] Used Stout config script in agent build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43699/#review119661 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 4:35 a.m

Re: Review Request 43692: CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43692/#review119665 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:26 a.m

Re: Review Request 43693: CMake:[2/4] Transitioned ZK build to be 64-bit and static.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43693/#review119666 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:27 a.m

Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43694/#review119673 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:28 a.m

Re: Review Request 43695: Windows:[4/4] Included Socket library for 64-bit builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43695/#review119674 --- Ship it! Ship It! - Yi Sun On Feb. 18, 2016, 2:28 a.m

Re: Review Request 43414: CMake:[2/2] Canonicalize location of third-party dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43414/#review119096 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 7:13 a.m

Re: Review Request 43413: CMake:[1/2] Allow downloading third-party dependencies from mirror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43413/#review119095 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 7:03 a.m

Re: Review Request 43409: Windows: Added `src/resource_estimator.cpp` to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43409/#review119093 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 6:44 a.m

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43407/#review119092 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 11:36 p.m

Re: Review Request 43410: Windows: Added support for dynamic library loading.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43410/#review119099 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 6:01 p.m

Re: Review Request 43415: CMake: Moved Windows build to version of glog that builds with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43415/#review119097 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 7:13 a.m

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43416/#review119098 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 7:13 a.m

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44141/#review121543 --- Ship it! Ship It! - Yi Sun On March 1, 2016, 8:58 p.m

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

> On March 1, 2016, 11:47 p.m., Yi Sun wrote: > > 3rdparty/libprocess/src/windows/subprocess.cpp, line 152 > > <https://reviews.apache.org/r/44141/diff/1/?file=1272989#file1272989line152> > > > > The second param for strcpy_s is the number of chars to be c

Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44078/#review123006 --- Ship it! Ship It! - Yi Sun On Feb. 26, 2016, 4:11 p.m

Re: Review Request 44045: Style fixes to `stout/include/Makefile.am`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44045/#review123008 --- Ship it! Ship It! - Yi Sun On Feb. 25, 2016, 10:28 p.m

Re: Review Request 44077: Windows:[3/3] Transitioned Windows `system` to use `os::execlp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44077/#review123005 --- Ship it! Ship It! - Yi Sun On Feb. 26, 2016, 4:11 p.m

Re: Review Request 44046: Windows: Used `evutil_socket_t` typedef for sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44046/#review123001 --- Ship it! Ship It! - Yi Sun On Feb. 26, 2016, 4:09 p.m

Re: Review Request 44042: Windows: Fixed `UUID::random` and added utime/touch to stout/os.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44042/#review123007 --- Ship it! Ship It! - Yi Sun On Feb. 25, 2016, 9:16 p.m

Re: Review Request 44076: Windows: [2/3] Used `os::execlp` in launch.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44076/#review123004 --- Ship it! Ship It! - Yi Sun On Feb. 26, 2016, 4:11 p.m

Re: Review Request 44075: Windows: [1/3] Add platform-dependent `os::execlp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44075/#review123003 --- Ship it! Ship It! - Yi Sun On Feb. 26, 2016, 4:11 p.m

Re: Review Request 44747: Stout: Added implementation of `write` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44747/#review123252 --- Ship it! Ship It! - Yi Sun On March 12, 2016, 1:28 a.m

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/#review123251 --- Ship it! Ship It! - Yi Sun On March 12, 2016, 1:28 a.m

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44081/#review123541 --- Ship it! Ship It! - Yi Sun On March 14, 2016, 9:10 p.m

Re: Review Request 44082: Stout: Un-commented out functions and marked them as deleted instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44082/#review123540 --- Ship it! Ship It! - Yi Sun On March 14, 2016, 9:12 p.m

Re: Review Request 44808: Fixup POSIX build by removing headers from load.*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44808/#review123536 --- Ship it! Ship It! - Yi Sun On March 14, 2016, 9:06 p.m

Re: Review Request 44808: Fixup POSIX build by removing headers from load.*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44808/#review123535 --- Ship it! Ship It! - Yi Sun On March 14, 2016, 9:06 p.m

Re: Review Request 44080: Windows:[1/2] Implemented `os::gmtime_r`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44080/#review123537 --- Ship it! Ship It! - Yi Sun On March 14, 2016, 8:48 p.m

Re: Review Request 45015: Windows: Fixed bug causing `os::exists` to report invalid paths exist.

/stout/tests/os/filesystem_tests.cpp (line 149) <https://reviews.apache.org/r/45015/#comment188232> Nit: expect. - Yi Sun On March 24, 2016, 7:58 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e

Re: Review Request 45009: Transition `filesystem_tests.cpp` to use `path::join`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45009/#review125448 --- Ship it! Ship It! - Yi Sun On March 18, 2016, 12:51 a.m

Re: Review Request 44084: Windows: Forked os::rename().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/#review125451 --- Ship it! Ship It! - Yi Sun On March 24, 2016, 2:59 p.m

Re: Review Request 45299: Stout:[1/2] transitioned codebase to use `os::pagesize`.

/stout/include/stout/os/linux.hpp (line 87) <https://reviews.apache.org/r/45299/#comment188235> nit: getpagesize() is irrelevant now. - Yi Sun On March 25, 2016, 6:12 p.m., Alex Clemmer wrote: > > --- > This is a

Re: Review Request 45300: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45300/#review125453 --- Ship it! Ship It! - Yi Sun On March 25, 2016, 6:12 p.m