Re: Review Request 53533: Extended `dockerFlags()` to pass `devices` to mesos-docker-executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53533/ --- (Updated Nov. 16, 2016, 3:29 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Summary (updated) - Extended `dockerFlags()` to pass `devices` to mesos-docker-executor. Repository: mesos Description (updated) --- This patch extended `dockerFlags()` to pass `devices` to mesos-docker-executor, and then the `devices` can be used by the docker container when mesos-docker-executor starts the docker container. Diffs (updated) - src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c Diff: https://reviews.apache.org/r/53533/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated Nov. 16, 2016, 3:30 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added a testing case for end-to-end GPU support for docker containerizer. Diffs (updated) - src/tests/containerizer/docker_containerizer_tests.cpp c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16 Diff: https://reviews.apache.org/r/50127/diff/ Testing --- GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check Thanks, Yubo Li
Re: Review Request 50125: Added `--devices` flag to mesos-docker-executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Nov. 16, 2016, 3:29 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Summary (updated) - Added `--devices` flag to mesos-docker-executor. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description (updated) --- Added a new flag `--devices` to mesos-docker-executor which is used to control the feature of devices exposition, isolation and access permission for docker container. Diffs (updated) - src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 Diff: https://reviews.apache.org/r/50125/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 53532: Added `parse` helper function for `Docker::Device`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53532/ --- (Updated Nov. 16, 2016, 3:28 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Summary (updated) - Added `parse` helper function for `Docker::Device`. Repository: mesos Description (updated) --- Added a new helper function to parse a string to `Docker::Device` structure. The string should be in the format of `PathInHost:PathInContainer:Permission`. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 Diff: https://reviews.apache.org/r/53532/diff/ Testing --- make -j4 check Thanks, Yubo Li
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated Nov. 16, 2016, 3:29 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Assigned Nvidia GPU devices to docker container based on GPUs allocated by Nvidia GPU allocator. Diffs (updated) - src/slave/containerizer/docker.hpp 006f929eca0e0a6b1de941821ac72869ba393d2d src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c Diff: https://reviews.apache.org/r/50599/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50947: Only check `gpu/nvidia` isolator for mesos containerizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated Nov. 16, 2016, 3:28 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Summary (updated) - Only check `gpu/nvidia` isolator for mesos containerizer. Bugs: MESOS-5975 https://issues.apache.org/jira/browse/MESOS-5975 Repository: mesos Description (updated) --- Mesos containerizer uses isolator `gpu/nvidia` for GPU isolation while docker containerizers do not need it. This patch is making the isolator `gpu/nvidia` check only available for mesos containerizer but not docker containerizer in GPU allocator. Diffs (updated) - src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 2e722691475c84afae14009014ea70cc0fdd0e65 Diff: https://reviews.apache.org/r/50947/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 52735: Updated comments for killing some garbage containers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- (Updated Nov. 16, 2016, 3:25 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Summary (updated) - Updated comments for killing some garbage containers. Repository: mesos Description (updated) --- We have already enabled `Garbage collector` for some garbage containers (failed to be killed when destroy), so the related comments should be updated to reflect this. Diffs (updated) - src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c Diff: https://reviews.apache.org/r/52735/diff/ Testing --- Thanks, Yubo Li
Re: Review Request 50128: Overloaded the << operator for `Docker::Device`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated Nov. 16, 2016, 3:25 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Summary (updated) - Overloaded the << operator for `Docker::Device`. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description (updated) --- This patch overloaded the `<<` operator for `Docker::Device`. With such overload, we can just run the global `stringify()` function to turn `Docker::Device` into a string. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/50128/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 52735: Updated comment message for docker killing.
> On 十一月 12, 2016, 11:39 a.m., Guangya Liu wrote: > > What about update the summary and description as following? > > > > Summary: > > ``` > > Updated comments for killing some garbage containers. > > ``` > > > > Description: > > ``` > > We have already enabled `Garbage collector` for some garbage > > containers (failed to be killed when destroy), so the related > > comments should be updated to reflect this. > > ``` fixed - Yubo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/#review155776 ------- On 十一月 10, 2016, 8:13 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52735/ > --- > > (Updated 十一月 10, 2016, 8:13 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Repository: mesos > > > Description > --- > > `Garbage collector` has already enabled so that the docker failed > in killing will be force removed by calling `Self::remove`. > > > Diffs > - > > src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c > > Diff: https://reviews.apache.org/r/52735/diff/ > > > Testing > --- > > > Thanks, > > Yubo Li > >
Re: Review Request 53533: Extended docker flags to pass devices to mesos-docker-executor.
> On 十一月 12, 2016, 2:20 p.m., Guangya Liu wrote: > > Summary > > ``` > > Extended `dockerFlags()` to pass `devices` to mesos-docker-executor. > > ``` > > > > Description > > ``` > > This patch extended `dockerFlags()` to pass `devices` to > > mesos-docker-executor, and then the `devices` can be used > > by the docker container when mesos-docker-executor start > > the docker container. > > ``` fixed - Yubo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53533/#review155781 ------- On 十一月 10, 2016, 8:15 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53533/ > --- > > (Updated 十一月 10, 2016, 8:15 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Repository: mesos > > > Description > --- > > Extended a new docker flag in docker containerizer to pass devices > to mesos-docker-executor. > > > Diffs > - > > src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c > > Diff: https://reviews.apache.org/r/53533/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yubo Li > >
Re: Review Request 50125: Added mesos-docker-executor support for devices control.
> On 十一月 12, 2016, 1:13 p.m., Guangya Liu wrote: > > Summary > > ``` > > Added '--devices' flag to mesos-docker-executor. > > ``` > > > > Description > > ``` > > Added a new flag '--devices' to mesos-docker-executor which is used to > > control the feature of devices exposition, isolation and access permission > > for docker container. > > ``` fixed - Yubo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review155780 ------- On 十一月 10, 2016, 8:15 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50125/ > --- > > (Updated 十一月 10, 2016, 8:15 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > --- > > Added a new flag '--devices' to mesos-docker-executor, and gave its > feature to control devices exposition, isolation, and access permission. > > > Diffs > - > > src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 > src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 > > Diff: https://reviews.apache.org/r/50125/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yubo Li > >
Re: Review Request 53532: Added parse helper function to 'Docker::Device'.
> On 十一月 12, 2016, 12:26 p.m., Guangya Liu wrote: > > Summary: > > ``` > > Added `parse` helper function for `Docker::Device`. > > ``` > > > > Description: > > ``` > > Added a new helper function to parse a string to 'Docker::Device' > > 'Docker::Device' structure. The string should be in the format of > > `PathInHost:PathInContainer:Permission`. > > ``` fixed - Yubo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53532/#review155778 ------- On 十一月 10, 2016, 8:14 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53532/ > --- > > (Updated 十一月 10, 2016, 8:14 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Repository: mesos > > > Description > --- > > Added helper function to parse string input to 'Docker::Device' > structure. > > > Diffs > - > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > > Diff: https://reviews.apache.org/r/53532/diff/ > > > Testing > --- > > make -j4 check > > > Thanks, > > Yubo Li > >
Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.
> On 十一月 12, 2016, 12:14 p.m., Guangya Liu wrote: > > We do not have `external containerizer` now, so you can remove it from the > > `Descripiton`. > > > > Summary > > ``` > > Only check `gpu/nvidia` isolator for mesos containerizer. > > ``` > > > > Description > > ``` > > Mesos containerizer uses isolator `gpu/nvidia` for GPU isolation while > > docker containerizers do not need it. This patch is making the isolator > > `gpu/nvidia` check only available for mesos containerizer but not docker > > containerizer in GPU allocator. > > ``` fixed. thanks - Yubo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/#review155777 ------- On 十一月 10, 2016, 8:13 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50947/ > --- > > (Updated 十一月 10, 2016, 8:13 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5975 > https://issues.apache.org/jira/browse/MESOS-5975 > > > Repository: mesos > > > Description > --- > > Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while > docker and external containerizers do not need it anymore. This removed > the 'gpu/nvidia' isolator check for docker and external containerizers. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/gpu/allocator.cpp > 2e722691475c84afae14009014ea70cc0fdd0e65 > > Diff: https://reviews.apache.org/r/50947/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yubo Li > >
Re: Review Request 53533: Extended docker flags to pass devices to mesos-docker-executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53533/ --- (Updated Nov. 10, 2016, 8:15 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Repository: mesos Description --- Extended a new docker flag in docker containerizer to pass devices to mesos-docker-executor. Diffs (updated) - src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c Diff: https://reviews.apache.org/r/53533/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated Nov. 10, 2016, 8:15 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added a testing case for end-to-end GPU support for docker containerizer. Diffs (updated) - src/tests/containerizer/docker_containerizer_tests.cpp c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16 Diff: https://reviews.apache.org/r/50127/diff/ Testing --- GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check Thanks, Yubo Li
Re: Review Request 50125: Added mesos-docker-executor support for devices control.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Nov. 10, 2016, 8:15 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added a new flag '--devices' to mesos-docker-executor, and gave its feature to control devices exposition, isolation, and access permission. Diffs (updated) - src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 Diff: https://reviews.apache.org/r/50125/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated Nov. 10, 2016, 8:14 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Assigned Nvidia GPU devices to docker container based on GPUs allocated by Nvidia GPU allocator. Diffs (updated) - src/slave/containerizer/docker.hpp 006f929eca0e0a6b1de941821ac72869ba393d2d src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c Diff: https://reviews.apache.org/r/50599/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 53532: Added parse helper function to 'Docker::Device'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53532/ --- (Updated Nov. 10, 2016, 8:14 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Repository: mesos Description --- Added helper function to parse string input to 'Docker::Device' structure. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 Diff: https://reviews.apache.org/r/53532/diff/ Testing --- make -j4 check Thanks, Yubo Li
Re: Review Request 50128: Overloaded the << operator for 'Docker::Device'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated Nov. 10, 2016, 8:13 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This patch overloaded the << operator for 'Docker::Device'. With such overload, we can just run the global `stringify()` function to turn 'Docker::Device' into a string. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/50128/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated Nov. 10, 2016, 8:13 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5975 https://issues.apache.org/jira/browse/MESOS-5975 Repository: mesos Description --- Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while docker and external containerizers do not need it anymore. This removed the 'gpu/nvidia' isolator check for docker and external containerizers. Diffs (updated) - src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 2e722691475c84afae14009014ea70cc0fdd0e65 Diff: https://reviews.apache.org/r/50947/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 52735: Updated comment message for docker killing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- (Updated Nov. 10, 2016, 8:13 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Summary (updated) - Updated comment message for docker killing. Repository: mesos Description (updated) --- `Garbage collector` has already enabled so that the docker failed in killing will be force removed by calling `Self::remove`. Diffs (updated) - src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c Diff: https://reviews.apache.org/r/52735/diff/ Testing --- Thanks, Yubo Li
Re: Review Request 52735: Removed TODO message for docker killing.
> On 十一月 8, 2016, 3:24 a.m., Guangya Liu wrote: > > I would suggest that you create a patch chain based on the following order: > > > > https://reviews.apache.org/r/52735/ > > https://reviews.apache.org/r/50128/ > > https://reviews.apache.org/r/50947/ > > https://reviews.apache.org/r/53532/ > > https://reviews.apache.org/r/50599/ > > https://reviews.apache.org/r/50125/ > > https://reviews.apache.org/r/53533/ > > https://reviews.apache.org/r/50127/ Sure, fixed - Yubo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/#review155254 ------- On 十一月 7, 2016, 1:53 p.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52735/ > --- > > (Updated 十一月 7, 2016, 1:53 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Repository: mesos > > > Description > --- > > Removed TODO message for docker killing. > > > Diffs > - > > src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c > > Diff: https://reviews.apache.org/r/52735/diff/ > > > Testing > --- > > > Thanks, > > Yubo Li > >
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated 十一月 7, 2016, 2:06 p.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added a testing case for end-to-end GPU support for docker containerizer. Diffs (updated) - src/tests/containerizer/docker_containerizer_tests.cpp c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16 Diff: https://reviews.apache.org/r/50127/diff/ Testing --- GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check Thanks, Yubo Li
Review Request 53533: Extended docker flags to pass devices to mesos-docker-executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53533/ --- Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Repository: mesos Description --- Extended a new docker flag in docker containerizer to pass devices to mesos-docker-executor. Diffs - src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c Diff: https://reviews.apache.org/r/53533/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50125: Added mesos-docker-executor support for devices control.
> On 十一月 4, 2016, 3:28 p.m., Guangya Liu wrote: > > Seems spliting this to two patches is more simple for review: One patch for > > adding a new flag '--devices' to mesos docker executor, and the other is > > passing 'devices' as parameter for `dockerFlags` when launching mesos > > docker executor. split to `/r/53533` - Yubo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review154917 --- On 十一月 2, 2016, 7:28 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50125/ > --- > > (Updated 十一月 2, 2016, 7:28 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > --- > > Added a new flag '--devices' to mesos-docker-executor, and gave its > feature to control devices exposition, isolation, and access permission. > Also, passed GPUs assignment to mesos-docker-executor. > > > Diffs > - > > src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 > src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 > src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 > > Diff: https://reviews.apache.org/r/50125/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yubo Li > >
Re: Review Request 50125: Added mesos-docker-executor support for devices control.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十一月 7, 2016, 2:04 p.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description (updated) --- Added a new flag '--devices' to mesos-docker-executor, and gave its feature to control devices exposition, isolation, and access permission. Diffs (updated) - src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 Diff: https://reviews.apache.org/r/50125/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50128: Overloaded the << operator for 'Docker::Device'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十一月 7, 2016, 2:03 p.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This patch overloaded the << operator for 'Docker::Device'. With such overload, we can just run the global `stringify()` function to turn 'Docker::Device' into a string. Diffs - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/50128/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated 十一月 7, 2016, 2:02 p.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Assigned Nvidia GPU devices to docker container based on GPUs allocated by Nvidia GPU allocator. Diffs (updated) - src/slave/containerizer/docker.hpp 006f929eca0e0a6b1de941821ac72869ba393d2d src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c Diff: https://reviews.apache.org/r/50599/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 53532: Added parse helper function to 'Docker::Device'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53532/ --- (Updated 十一月 7, 2016, 1:59 p.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Repository: mesos Description --- Added helper function to parse string input to 'Docker::Device' structure. Diffs - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 Diff: https://reviews.apache.org/r/53532/diff/ Testing (updated) --- make -j4 check Thanks, Yubo Li
Review Request 53532: Added parse helper function to 'Docker::Device'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53532/ --- Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Repository: mesos Description --- Added helper function to parse string input to 'Docker::Device' structure. Diffs - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 Diff: https://reviews.apache.org/r/53532/diff/ Testing --- Thanks, Yubo Li
Re: Review Request 52735: Removed TODO message for docker killing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- (Updated 十一月 7, 2016, 1:53 p.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Repository: mesos Description --- Removed TODO message for docker killing. Diffs (updated) - src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c Diff: https://reviews.apache.org/r/52735/diff/ Testing --- Thanks, Yubo Li
Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated 十一月 7, 2016, 1:51 p.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5975 https://issues.apache.org/jira/browse/MESOS-5975 Repository: mesos Description --- Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while docker and external containerizers do not need it anymore. This removed the 'gpu/nvidia' isolator check for docker and external containerizers. Diffs (updated) - src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 2e722691475c84afae14009014ea70cc0fdd0e65 Diff: https://reviews.apache.org/r/50947/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50128: Added helper function to 'Docker::Device'.
> On 十一月 4, 2016, 3:03 p.m., Guangya Liu wrote: > > What about update the summary and desription as this? > > > > Summary: > > ``` > > Overload the << operator for 'Docker::Device'. > > ``` > > > > Description: > > ``` > > This patch overload the << operator for 'Docker::Device', > > with such overload, we can just run the global `stringify()` > > function to turn 'Docker::Device' into a string. > > ``` commit comment changed - Yubo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review154911 --- On 十一月 2, 2016, 7:27 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50128/ > --- > > (Updated 十一月 2, 2016, 7:27 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > --- > > Wrapped helper function to stringify 'Docker::Device' structure. > > > Diffs > - > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e > > Diff: https://reviews.apache.org/r/50128/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yubo Li > >
Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated Nov. 2, 2016, 7:29 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5975 https://issues.apache.org/jira/browse/MESOS-5975 Repository: mesos Description --- Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while docker and external containerizers do not need it anymore. This removed the 'gpu/nvidia' isolator check for docker and external containerizers. Diffs (updated) - src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 2e722691475c84afae14009014ea70cc0fdd0e65 Diff: https://reviews.apache.org/r/50947/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated Nov. 2, 2016, 7:29 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added a testing case for end-to-end GPU support for docker containerizer. Diffs (updated) - src/tests/containerizer/docker_containerizer_tests.cpp 810488d1476cadbbd5a4a7dcecaeec55739ab71f Diff: https://reviews.apache.org/r/50127/diff/ Testing --- GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check Thanks, Yubo Li
Re: Review Request 52735: Removed TODO message for docker killing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- (Updated Nov. 2, 2016, 7:29 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Repository: mesos Description --- Removed TODO message for docker killing. Diffs (updated) - src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 Diff: https://reviews.apache.org/r/52735/diff/ Testing --- Thanks, Yubo Li
Re: Review Request 50125: Added mesos-docker-executor support for devices control.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Nov. 2, 2016, 7:28 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added a new flag '--devices' to mesos-docker-executor, and gave its feature to control devices exposition, isolation, and access permission. Also, passed GPUs assignment to mesos-docker-executor. Diffs (updated) - src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 Diff: https://reviews.apache.org/r/50125/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated Nov. 2, 2016, 7:28 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Assigned Nvidia GPU devices to docker container based on GPUs allocated by Nvidia GPU allocator. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 Diff: https://reviews.apache.org/r/50599/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50128: Added helper function to 'Docker::Device'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated Nov. 2, 2016, 7:27 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Wrapped helper function to stringify 'Docker::Device' structure. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/50128/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated Nov. 2, 2016, 7:26 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added control logic to allocate/deallocate GPUs to GPU-related task when the task is started/terminated. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 Diff: https://reviews.apache.org/r/50841/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50123: Added GPU scheduler for docker containerizer process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated Nov. 2, 2016, 7:26 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added 'NvidiaComponents' to docker containerizer process so that docker containerizer process is ready to use it to allocate GPUs to task with 'gpus' resource. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 src/tests/mock_docker.hpp 1bf09c8dba020b421526b650523c879fb87380f8 src/tests/mock_docker.cpp 6a0e613bde6889864a37ffd7ec0b454e5fe4df1c Diff: https://reviews.apache.org/r/50123/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.
> On 十一月 1, 2016, 3:04 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 701 > > <https://reviews.apache.org/r/50599/diff/18/?file=1550716#file1550716line701> > > > > You need to keep the comments from Kevin as open here > > https://reviews.apache.org/r/50599/#comment223322 OK, I re-opened Kevin's comment. - Yubo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review154407 ------- On 十一月 1, 2016, 9:11 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50599/ > --- > > (Updated 十一月 1, 2016, 9:11 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > --- > > Assigned Nvidia GPU devices to docker container based on > GPUs allocated by Nvidia GPU allocator. > > > Diffs > - > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d > src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 > > Diff: https://reviews.apache.org/r/50599/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yubo Li > >
Re: Review Request 50128: Added helper function to 'Docker::Device'.
> On 十月 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/docker/docker.cpp, line 388 > > <https://reviews.apache.org/r/50128/diff/17/?file=1543832#file1543832line388> > > > > Add an error here to verify correct set of permissions in the > > permissions field. > > > > Once we have done all of this validation, we know it is safe to set the > > fields as we do below without error. > > Guangya Liu wrote: > This is only called after `docker inspect`, so I think that there will be > no error field in the permission field? But adding a check here will not > impact much. I think we could put it to another patch. - Yubo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review153838 ------- On 十一月 1, 2016, 9:11 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50128/ > --- > > (Updated 十一月 1, 2016, 9:11 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > --- > > Wrapped helper function to stringify 'Docker::Device' structure. > > > Diffs > - > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e > > Diff: https://reviews.apache.org/r/50128/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yubo Li > >
Re: Review Request 50128: Added helper function to 'Docker::Device'.
> On 十一月 1, 2016, 3:19 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 756 > > <https://reviews.apache.org/r/50128/diff/20/?file=1550713#file1550713line756> > > > > I think that we actually need to check invalid permissions here, as it > > is possible that there are invalid permissions when create container. But > > agree that we can handle this in a separate patch. Sure - Yubo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review154409 --- On 十一月 1, 2016, 9:11 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50128/ > --- > > (Updated 十一月 1, 2016, 9:11 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > --- > > Wrapped helper function to stringify 'Docker::Device' structure. > > > Diffs > - > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e > > Diff: https://reviews.apache.org/r/50128/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yubo Li > >
Re: Review Request 52735: Removed TODO message for docker killing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- (Updated Nov. 1, 2016, 9:12 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Repository: mesos Description --- Removed TODO message for docker killing. Diffs (updated) - src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 Diff: https://reviews.apache.org/r/52735/diff/ Testing --- Thanks, Yubo Li
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated Nov. 1, 2016, 9:12 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added a testing case for end-to-end GPU support for docker containerizer. Diffs (updated) - src/tests/containerizer/docker_containerizer_tests.cpp 810488d1476cadbbd5a4a7dcecaeec55739ab71f Diff: https://reviews.apache.org/r/50127/diff/ Testing --- GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check Thanks, Yubo Li
Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated Nov. 1, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5975 https://issues.apache.org/jira/browse/MESOS-5975 Repository: mesos Description --- Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while docker and external containerizers do not need it anymore. This removed the 'gpu/nvidia' isolator check for docker and external containerizers. Diffs (updated) - src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 2e722691475c84afae14009014ea70cc0fdd0e65 Diff: https://reviews.apache.org/r/50947/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50125: Added mesos-docker-executor support for devices control.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Nov. 1, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added a new flag '--devices' to mesos-docker-executor, and gave its feature to control devices exposition, isolation, and access permission. Also, passed GPUs assignment to mesos-docker-executor. Diffs (updated) - src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 Diff: https://reviews.apache.org/r/50125/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated Nov. 1, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Assigned Nvidia GPU devices to docker container based on GPUs allocated by Nvidia GPU allocator. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 Diff: https://reviews.apache.org/r/50599/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50128: Added helper function to 'Docker::Device'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated Nov. 1, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Wrapped helper function to stringify 'Docker::Device' structure. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/50128/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 52735: Removed TODO message for docker killing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- (Updated Nov. 1, 2016, 6:13 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Repository: mesos Description --- Removed TODO message for docker killing. Diffs (updated) - src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 Diff: https://reviews.apache.org/r/52735/diff/ Testing --- Thanks, Yubo Li
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated Nov. 1, 2016, 6:12 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added a testing case for end-to-end GPU support for docker containerizer. Diffs (updated) - src/tests/containerizer/docker_containerizer_tests.cpp 810488d1476cadbbd5a4a7dcecaeec55739ab71f Diff: https://reviews.apache.org/r/50127/diff/ Testing --- GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check Thanks, Yubo Li
Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated Nov. 1, 2016, 6:12 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5975 https://issues.apache.org/jira/browse/MESOS-5975 Repository: mesos Description --- Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while docker and external containerizers do not need it anymore. This removed the 'gpu/nvidia' isolator check for docker and external containerizers. Diffs (updated) - src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 2e722691475c84afae14009014ea70cc0fdd0e65 Diff: https://reviews.apache.org/r/50947/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50125: Added mesos-docker-executor support for devices control.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Nov. 1, 2016, 6:11 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added a new flag '--devices' to mesos-docker-executor, and gave its feature to control devices exposition, isolation, and access permission. Also, passed GPUs assignment to mesos-docker-executor. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 Diff: https://reviews.apache.org/r/50125/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated Nov. 1, 2016, 6:10 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added control logic to allocate/deallocate GPUs to GPU-related task when the task is started/terminated. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 Diff: https://reviews.apache.org/r/50841/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated Nov. 1, 2016, 6:11 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Assigned Nvidia GPU devices to docker container based on GPUs allocated by Nvidia GPU allocator. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 Diff: https://reviews.apache.org/r/50599/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50128: Added helper function to 'Docker::Device'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated Nov. 1, 2016, 6:10 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Summary (updated) - Added helper function to 'Docker::Device'. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description (updated) --- Wrapped helper function to stringify 'Docker::Device' structure. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/50128/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50123: Added GPU scheduler for docker containerizer process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated Nov. 1, 2016, 6:10 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added 'NvidiaComponents' to docker containerizer process so that docker containerizer process is ready to use it to allocate GPUs to task with 'gpus' resource. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 src/tests/mock_docker.hpp 1bf09c8dba020b421526b650523c879fb87380f8 src/tests/mock_docker.cpp 6a0e613bde6889864a37ffd7ec0b454e5fe4df1c Diff: https://reviews.apache.org/r/50123/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated Oct. 31, 2016, 7:11 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5975 https://issues.apache.org/jira/browse/MESOS-5975 Repository: mesos Description --- Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while docker and external containerizers do not need it anymore. This removed the 'gpu/nvidia' isolator check for docker and external containerizers. Diffs (updated) - src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 2e722691475c84afae14009014ea70cc0fdd0e65 Diff: https://reviews.apache.org/r/50947/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 52735: Removed TODO message for docker killing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- (Updated Oct. 31, 2016, 7:11 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Repository: mesos Description --- Removed TODO message for docker killing. Diffs (updated) - src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 Diff: https://reviews.apache.org/r/52735/diff/ Testing --- Thanks, Yubo Li
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated Oct. 31, 2016, 7:11 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added a testing case for end-to-end GPU support for docker containerizer. Diffs (updated) - src/tests/containerizer/docker_containerizer_tests.cpp 810488d1476cadbbd5a4a7dcecaeec55739ab71f Diff: https://reviews.apache.org/r/50127/diff/ Testing --- GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check Thanks, Yubo Li
Re: Review Request 50125: Added mesos-docker-executor support for devices control.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Oct. 31, 2016, 7:10 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added a new flag '--devices' to mesos-docker-executor, and gave its feature to control devices exposition, isolation, and access permission. Also, passed GPUs assignment to mesos-docker-executor. Diffs (updated) - src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 Diff: https://reviews.apache.org/r/50125/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50123: Added GPU scheduler for docker containerizer process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated Oct. 31, 2016, 7:09 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Summary (updated) - Added GPU scheduler for docker containerizer process. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added 'NvidiaComponents' to docker containerizer process so that docker containerizer process is ready to use it to allocate GPUs to task with 'gpus' resource. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 src/tests/mock_docker.hpp 1bf09c8dba020b421526b650523c879fb87380f8 src/tests/mock_docker.cpp 6a0e613bde6889864a37ffd7ec0b454e5fe4df1c Diff: https://reviews.apache.org/r/50123/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated Oct. 31, 2016, 7:10 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Assigned Nvidia GPU devices to docker container based on GPUs allocated by Nvidia GPU allocator. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 Diff: https://reviews.apache.org/r/50599/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50128: Added helper functions to 'Docker::Device'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated Oct. 31, 2016, 7:10 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Wrapped helper functions to 'Docker::Device' to handle data parsing and serializing between 'Docker::Device' structure and string. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/50128/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated Oct. 31, 2016, 7:09 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added control logic to allocate/deallocate GPUs to GPU-related task when the task is started/terminated. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 Diff: https://reviews.apache.org/r/50841/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.
> On 十月 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 723 > > <https://reviews.apache.org/r/50599/diff/15/?file=1543834#file1543834line723> > > > > Can you just use `stringify()` here? Also, can you use `Path().join()` > > instead of just `+`. I changed the code to `path::join(nvidiaDataPrefix, stringify(gpu.minor));`, but the output path becomes `/dev/nvidia/0`, not `/dev/nvidia0` we are expected. So that I keeped `+` instead of `path::join()`. - Yubo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review153839 ------- On 十月 24, 2016, 5 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50599/ > --- > > (Updated 十月 24, 2016, 5 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > --- > > Assigned Nvidia GPU devices to docker container based on > GPUs allocated by Nvidia GPU allocator. > > > Diffs > - > > src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d > src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 > > Diff: https://reviews.apache.org/r/50599/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yubo Li > >
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.
> On 十月 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 700 > > <https://reviews.apache.org/r/50599/diff/15/?file=1543834#file1543834line700> > > > > I would reword this to explicitly mention that tasks launched with the > > docker containerizer require these permissions in order to operate. Added comments as follow: ``` // NOTE: GPU devices permissions are required to be `rmw` by default, that // is because GPU tasks launched in the container may need to read/write/mknod // to GPU devices in their lifecycle. ``` - Yubo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review153839 ------- On 十月 24, 2016, 5 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50599/ > --- > > (Updated 十月 24, 2016, 5 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > --- > > Assigned Nvidia GPU devices to docker container based on > GPUs allocated by Nvidia GPU allocator. > > > Diffs > - > > src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d > src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 > > Diff: https://reviews.apache.org/r/50599/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yubo Li > >
Re: Review Request 52735: Removed TODO message for docker killing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- (Updated Oct. 24, 2016, 5:08 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Repository: mesos Description --- Removed TODO message for docker killing. Diffs (updated) - src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/52735/diff/ Testing --- Thanks, Yubo Li
Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated Oct. 24, 2016, 5:07 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5975 https://issues.apache.org/jira/browse/MESOS-5975 Repository: mesos Description --- Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while docker and external containerizers do not need it anymore. This removed the 'gpu/nvidia' isolator check for docker and external containerizers. Diffs (updated) - src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 2e722691475c84afae14009014ea70cc0fdd0e65 Diff: https://reviews.apache.org/r/50947/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated Oct. 24, 2016, 5:08 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added a testing case for end-to-end GPU support for docker containerizer. Diffs (updated) - src/tests/containerizer/docker_containerizer_tests.cpp 73ae3906ff1efab1af11ba49bfe0c5a5d9d1d5a1 Diff: https://reviews.apache.org/r/50127/diff/ Testing --- GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check Thanks, Yubo Li
Re: Review Request 50125: Added mesos-docker-executor support for devices control.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Oct. 24, 2016, 5 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added a new flag '--devices' to mesos-docker-executor, and gave its feature to control devices exposition, isolation, and access permission. Also, passed GPUs assignment to mesos-docker-executor. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/50125/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated Oct. 24, 2016, 5 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Assigned Nvidia GPU devices to docker container based on GPUs allocated by Nvidia GPU allocator. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/50599/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50128: Added helper functions to 'Docker::Device'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated Oct. 24, 2016, 4:59 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Wrapped helper functions to 'Docker::Device' to handle data parsing and serializing between 'Docker::Device' structure and string. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/50128/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated Oct. 24, 2016, 4:59 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added control logic to allocate/deallocate GPUs to GPU-related task when the task is started/terminated. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/50841/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50123: Added GPU scheduler for docker containerizer process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated Oct. 24, 2016, 4:57 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added 'NvidiaComponents' to docker containerizer process so that docker containerizer process is ready to use it to allocate GPUs to task with 'gpus' resource. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 src/tests/mock_docker.hpp 1bf09c8dba020b421526b650523c879fb87380f8 src/tests/mock_docker.cpp 6a0e613bde6889864a37ffd7ec0b454e5fe4df1c Diff: https://reviews.apache.org/r/50123/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
> On 十月 22, 2016, 4:49 a.m., Guangya Liu wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, lines 3953-3956 > > <https://reviews.apache.org/r/50127/diff/15/?file=1542957#file1542957line3953> > > > > What is the use of this? No use of that, this is copied from other test so that I'll remove that. - Yubo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/#review153521 --- On 十月 21, 2016, 9:12 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50127/ > --- > > (Updated 十月 21, 2016, 9:12 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > --- > > This added a testing case for end-to-end GPU support for docker > containerizer. > > > Diffs > - > > src/tests/containerizer/docker_containerizer_tests.cpp > 6d26797abf6d2b5e42b9e7743789e1edc62c9c1a > > Diff: https://reviews.apache.org/r/50127/diff/ > > > Testing > --- > > GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j > check > > > Thanks, > > Yubo Li > >
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated 十月 21, 2016, 9:12 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added a testing case for end-to-end GPU support for docker containerizer. Diffs (updated) - src/tests/containerizer/docker_containerizer_tests.cpp 6d26797abf6d2b5e42b9e7743789e1edc62c9c1a Diff: https://reviews.apache.org/r/50127/diff/ Testing --- GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check Thanks, Yubo Li
Re: Review Request 52735: Removed TODO message for docker killing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- (Updated 十月 21, 2016, 9:12 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Repository: mesos Description --- Removed TODO message for docker killing. Diffs (updated) - src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/52735/diff/ Testing --- Thanks, Yubo Li
Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated 十月 21, 2016, 9:12 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5975 https://issues.apache.org/jira/browse/MESOS-5975 Repository: mesos Description --- Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while docker and external containerizers do not need it anymore. This removed the 'gpu/nvidia' isolator check for docker and external containerizers. Diffs (updated) - src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 2e722691475c84afae14009014ea70cc0fdd0e65 Diff: https://reviews.apache.org/r/50947/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50125: Added mesos-docker-executor support for devices control.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十月 21, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added a new flag '--devices' to mesos-docker-executor, and gave its feature to control devices exposition, isolation, and access permission. Also, passed GPUs assignment to mesos-docker-executor. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/50125/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50128: Added helper functions to 'Docker::Device'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十月 21, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Wrapped helper functions to 'Docker::Device' to handle data parsing and serializing between 'Docker::Device' structure and string. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/50128/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated 十月 21, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Assigned Nvidia GPU devices to docker container based on GPUs allocated by Nvidia GPU allocator. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/50599/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 十月 21, 2016, 9:10 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added control logic to allocate/deallocate GPUs to GPU-related task when the task is started/terminated. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/50841/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50123: Added GPU scheduler for docker containerizer process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 十月 21, 2016, 9:10 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added 'NvidiaComponents' to docker containerizer process so that docker containerizer process is ready to use it to allocate GPUs to task with 'gpus' resource. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 src/tests/mock_docker.hpp 1bf09c8dba020b421526b650523c879fb87380f8 src/tests/mock_docker.cpp 6a0e613bde6889864a37ffd7ec0b454e5fe4df1c Diff: https://reviews.apache.org/r/50123/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 52735: Removed TODO message for docker killing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- (Updated 十月 21, 2016, 6:30 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Repository: mesos Description --- Removed TODO message for docker killing. Diffs (updated) - src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/52735/diff/ Testing --- Thanks, Yubo Li
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated 十月 21, 2016, 6:30 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added a testing case for end-to-end GPU support for docker containerizer. Diffs (updated) - src/tests/containerizer/docker_containerizer_tests.cpp 6d26797abf6d2b5e42b9e7743789e1edc62c9c1a Diff: https://reviews.apache.org/r/50127/diff/ Testing --- GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check Thanks, Yubo Li
Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated 十月 21, 2016, 6:30 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5975 https://issues.apache.org/jira/browse/MESOS-5975 Repository: mesos Description --- Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while docker and external containerizers do not need it anymore. This removed the 'gpu/nvidia' isolator check for docker and external containerizers. Diffs (updated) - src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 2e722691475c84afae14009014ea70cc0fdd0e65 Diff: https://reviews.apache.org/r/50947/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50125: Added mesos-docker-executor support for devices control.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十月 21, 2016, 6:29 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added a new flag '--devices' to mesos-docker-executor, and gave its feature to control devices exposition, isolation, and access permission. Also, passed GPUs assignment to mesos-docker-executor. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/50125/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated 十月 21, 2016, 6:29 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Assigned Nvidia GPU devices to docker container based on GPUs allocated by Nvidia GPU allocator. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/50599/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50128: Added helper functions to 'Docker::Device'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十月 21, 2016, 6:28 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Wrapped helper functions to 'Docker::Device' to handle data parsing and serializing between 'Docker::Device' structure and string. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/50128/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 十月 21, 2016, 6:28 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added control logic to allocate/deallocate GPUs to GPU-related task when the task is started/terminated. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/50841/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50123: Added GPU scheduler for docker containerizer process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 十月 21, 2016, 6:27 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added 'NvidiaComponents' to docker containerizer process so that docker containerizer process is ready to use it to allocate GPUs to task with 'gpus' resource. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 src/tests/mock_docker.hpp 1bf09c8dba020b421526b650523c879fb87380f8 src/tests/mock_docker.cpp 6a0e613bde6889864a37ffd7ec0b454e5fe4df1c Diff: https://reviews.apache.org/r/50123/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 52735: Removed TODO message for docker killing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- (Updated 十月 21, 2016, 2:57 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Repository: mesos Description --- Removed TODO message for docker killing. Diffs - src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/52735/diff/ Testing --- Thanks, Yubo Li
Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.
> On 十月 20, 2016, 1:32 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 2154-2158 > > <https://reviews.apache.org/r/50841/diff/14/?file=1542167#file1542167line2154> > > > > Do you have a patch for removing this comment? Yes, removed it in `https://reviews.apache.org/r/52735/`, sorry for foggetting publish it... - Yubo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review153384 --- On 十月 20, 2016, 10 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50841/ > --- > > (Updated 十月 20, 2016, 10 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > --- > > Added control logic to allocate/deallocate GPUs to GPU-related task > when the task is started/terminated. > > > Diffs > - > > src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d > src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 > > Diff: https://reviews.apache.org/r/50841/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yubo Li > >
Review Request 52735: Removed TODO message for docker killing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- Review request for mesos. Repository: mesos Description --- Removed TODO message for docker killing. Diffs - src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/52735/diff/ Testing --- Thanks, Yubo Li
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated 十月 20, 2016, 10:01 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This added a testing case for end-to-end GPU support for docker containerizer. Diffs (updated) - src/tests/containerizer/docker_containerizer_tests.cpp 6d26797abf6d2b5e42b9e7743789e1edc62c9c1a Diff: https://reviews.apache.org/r/50127/diff/ Testing --- GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check Thanks, Yubo Li
Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated 十月 20, 2016, 10:01 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5975 https://issues.apache.org/jira/browse/MESOS-5975 Repository: mesos Description --- Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while docker and external containerizers do not need it anymore. This removed the 'gpu/nvidia' isolator check for docker and external containerizers. Diffs (updated) - src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 2e722691475c84afae14009014ea70cc0fdd0e65 Diff: https://reviews.apache.org/r/50947/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50125: Added mesos-docker-executor support for devices control.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十月 20, 2016, 10:01 a.m.) Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added a new flag '--devices' to mesos-docker-executor, and gave its feature to control devices exposition, isolation, and access permission. Also, passed GPUs assignment to mesos-docker-executor. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/50125/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 十月 20, 2016, 10 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- Added control logic to allocate/deallocate GPUs to GPU-related task when the task is started/terminated. Diffs (updated) - src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 Diff: https://reviews.apache.org/r/50841/diff/ Testing --- make check Thanks, Yubo Li
