fbd2887800ccfd64c8628c5d6fd77a511c8f91d5
Diff: https://reviews.apache.org/r/59687/diff/3/
Changes: https://reviews.apache.org/r/59687/diff/2-3/
Testing
---
Thanks,
Zhitao Li
ing
---
Thanks,
Zhitao Li
: https://reviews.apache.org/r/67822/diff/1-2/
Testing
---
```make```
Thanks,
Zhitao Li
directories. This patch makes sure we do not call unmount
anymore after a success.
Diffs
-
src/slave/gc.cpp 407f6b23f87cf2e2bdaf873c8adcda57f5d559b3
Diff: https://reviews.apache.org/r/67822/diff/1/
Testing
---
```make```
Thanks,
Zhitao Li
/64812/diff/1-2/
Testing
---
Thanks,
Zhitao Li
,
Zhitao Li
ps://reviews.apache.org/r/56722/#review194469
-------
On Dec. 24, 2017, 7:31 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56722/
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65167/#review195467
---
Ship it!
Ship It!
- Zhitao Li
On Jan. 15, 2018, 1:49 p.m
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65294/#review196286
-------
On Jan. 24, 2018, 9:51 p.m., Zhitao Li wrote:
>
> ---
&g
://reviews.apache.org/r/65414/diff/2/
Changes: https://reviews.apache.org/r/65414/diff/1-2/
Testing
---
Thanks,
Zhitao Li
With command `mesos-execute --master=localhost:5050 --revocable_resources
--task=file:///home/user/test_rev_task.json`
If the master/agent has revocable cpu, this allows the task to execute.
Thanks,
Zhitao Li
---
Thanks,
Zhitao Li
atever
reason (i.e, disk space calculation is not applicable), so I don't see it is a
real problem.
Keeping this field out seems a strange discrepancy between the operator API
and agent flag.
- Zhitao Li
On Dec. 24, 2017, 7:31 p.m., Zhitao Li
, visit:
https://reviews.apache.org/r/64812/#review194515
-------
On Dec. 24, 2017, 1:21 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically gener
9246f4222548f8d19a8f4f89fb3c22ecae5b58b0
Diff: https://reviews.apache.org/r/62853/diff/6/
Changes: https://reviews.apache.org/r/62853/diff/5-6/
Testing
---
Thanks,
Zhitao Li
---
Thanks,
Zhitao Li
;
- allowing no principal to prune images.
Thanks,
Zhitao Li
uation without side effect to
calling actor be defered?
- Zhitao Li
On Jan. 2, 2018, 10:38 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
apture explicitly if you don't do it this
patch.
Thanks for fixing this!
- Zhitao Li
On Jan. 2, 2018, 10:38 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64885/#review194632
---
Ship it!
Ship It!
- Zhitao Li
On Jan. 2, 2018, 10:38 a.m
pulled) are
not affected.
Thanks,
Zhitao Li
f81e5bcb38455e6595e54892604773665140933d
Diff: https://reviews.apache.org/r/64813/diff/1/
Testing (updated)
---
https://github.com/zhitaoli/mesos/blob/public/zhitao/image_gc_revision3/docs/container-image.md
Thanks,
Zhitao Li
4ae9013e6fb27bdce72b4aa9fc9cbd99f79bc548
src/slave/http.cpp 3e20c90fb94f0128a757745052534ef03612d849
Diff: https://reviews.apache.org/r/64812/diff/1/
Testing
---
Thanks,
Zhitao Li
Diff: https://reviews.apache.org/r/64813/diff/1/
Testing
---
Thanks,
Zhitao Li
eeb9708f9ec76d83b6719541f4a012544c7c0cbe
src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478
Diff: https://reviews.apache.org/r/68088/diff/2/
Changes: https://reviews.apache.org/r/68088/diff/1-2/
Testing
---
`make` and `./bin/mesos-slave.sh --help`
Thanks,
Zhitao Li
8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed
src/slave/containerizer/mesos/linux_launcher.cpp
3bddcece7028745cec6623ac33dbfcaced629629
Diff: https://reviews.apache.org/r/68088/diff/1/
Testing
---
`make` and `./bin/mesos-slave.sh --help`
Thanks,
Zhitao Li
://reviews.apache.org/r/68087/diff/1/
Testing
---
`make` and run `./bin/mesos-slave.sh --help`.
Thanks,
Zhitao Li
Description
---
Documented new `--cgroups_destroy_timeout` agent option.
Diffs
-
docs/configuration/agent.md 83b5fed5a8bf287700688507eaa584f37e8ba2b7
Diff: https://reviews.apache.org/r/68299/diff/1/
Testing
---
Thanks,
Zhitao Li
eeb9708f9ec76d83b6719541f4a012544c7c0cbe
src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478
Diff: https://reviews.apache.org/r/68088/diff/3/
Changes: https://reviews.apache.org/r/68088/diff/2-3/
Testing
---
`make` and `./bin/mesos-slave.sh --help`
Thanks,
Zhitao Li
://reviews.apache.org/r/68300/diff/1/
Testing
---
Thanks,
Zhitao Li
With command `mesos-execute --master=localhost:5050 --revocable_resources
--task=file:///home/user/test_rev_task.json`
If the master/agent has revocable cpu, this allows the task to execute.
Thanks,
Zhitao Li
://reviews.apache.org/r/65930/diff/2-3/
Testing
---
Thanks,
Zhitao Li
: https://reviews.apache.org/r/65930/diff/2/
Changes: https://reviews.apache.org/r/65930/diff/1-2/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/65959/diff/1/
Testing
---
Thanks,
Zhitao Li
src/slave/metrics.cpp 0eb2b59ed67e14e73b29d7592c239441df0008d5
src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70
Diff: https://reviews.apache.org/r/65954/diff/2/
Changes: https://reviews.apache.org/r/65954/diff/1-2/
Testing
---
Thanks,
Zhitao Li
tout/include/stout/path.hpp
Lines 100-101 (patched)
<https://reviews.apache.org/r/65811/#comment278474>
`components.insert(components.begin(), "");`
- Zhitao Li
On Feb. 27, 2018, 6:23 a.m., Jason Lai wrote:
>
> --
---
Added missing comment on a test case.
Diffs
-
src/tests/persistent_volume_tests.cpp
924d8458e54e34a49c99593482b5908c5f7c7a48
Diff: https://reviews.apache.org/r/66048/diff/1/
Testing
---
Thanks,
Zhitao Li
30d4d35e865db2af1ba85b12e2b5b0e499ef8de8
Diff: https://reviews.apache.org/r/66049/diff/1/
Testing
---
Thanks,
Zhitao Li
---
Thanks,
Zhitao Li
6034bd5af8ad764f625f9fe80be08b48707bbadb
Diff: https://reviews.apache.org/r/66052/diff/1/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/66050/diff/1/
Testing
---
Thanks,
Zhitao Li
584>
Can we move the `TODO` to the sentence about follow-up? The sentence `These
special filesystem mount points need to be bind-mounted prior to all other ...`
is a comment on requirement which your follow up work would not change.
- Zhitao Li
On March 15, 2018, 6:24 p.m., Jason Lai
To reply, visit:
> https://reviews.apache.org/r/66104/
> ---
>
> (Updated March 15, 2018, 3:31 p.m.)
>
>
> Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, and Zhitao Li.
>
>
> Bugs: MESOS-8651
> https://issues.apache.org/jira/browse/MESOS-865
> On March 6, 2018, 2:44 a.m., Zhitao Li wrote:
> > src/master/http.cpp
> > Lines 845-857 (original), 845-861 (patched)
> > <https://reviews.apache.org/r/61262/diff/8/?file=1800242#file1800242line845>
> >
> > I believe this is a behavior change.
> &
/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70
Diff: https://reviews.apache.org/r/65954/diff/1/
Testing
---
Thanks,
Zhitao Li
.
This patch fixed the issue by starting heartbeater only after
`SUBSCRIBED` event is sent.
Diffs
-
src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad
Diff: https://reviews.apache.org/r/65930/diff/1/
Testing
---
Thanks,
Zhitao Li
,
Zhitao Li
/65954/diff/2-3/
Testing
---
Thanks,
Zhitao Li
ly, visit:
https://reviews.apache.org/r/65954/#review198952
-----------
On March 14, 2018, 4:06 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail.
https://issues.apache.org/jira/browse/MESOS-8609
Repository: mesos
Description
---
Document new `slave/recovery_time_secs` gauge.
Diffs
-
docs/monitoring.md 0fba5cede553e2030260dcf8401d48e66e740270
Diff: https://reviews.apache.org/r/66070/diff/1/
Testing
---
Thanks,
Zhitao
To reply, visit:
https://reviews.apache.org/r/65954/#review198954
---
On March 7, 2018, 11:20 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To rep
c2c53789296
> src/slave/metrics.cpp 0eb2b59ed67e14e73b29d7592c239441df0008d5
> src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70
>
>
> Diff: https://reviews.apache.org/r/65954/diff/2/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Zhitao Li
>
>
-
src/launcher/executor.cpp 383655230fcdad30b652ea984cb9f5fc9c49dd38
Diff: https://reviews.apache.org/r/66481/diff/1/
Testing
---
`make` on Linux.
Thanks,
Zhitao Li
shadowing.
Diffs (updated)
-
src/launcher/executor.cpp 383655230fcdad30b652ea984cb9f5fc9c49dd38
Diff: https://reviews.apache.org/r/66481/diff/3/
Changes: https://reviews.apache.org/r/66481/diff/2-3/
Testing
---
`make` on Linux.
Thanks,
Zhitao Li
/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8
Diff: https://reviews.apache.org/r/66531/diff/1/
Testing
---
Manually created ACL and verified that untrusted principals will not allow to
grow/shrink volumes.
Also created unit test in next patch.
Thanks,
Zhitao Li
/
Testing
---
Thanks,
Zhitao Li
/persistent_volume_tests.cpp
4edf781711d9efdb994114aeb6289b6af750b87a
Diff: https://reviews.apache.org/r/66220/diff/4/
Changes: https://reviews.apache.org/r/66220/diff/3-4/
Testing
---
Thanks,
Zhitao Li
6f4e0c5567b99891f6d0eceb7e6917d25083db0e
Diff: https://reviews.apache.org/r/66219/diff/5/
Changes: https://reviews.apache.org/r/66219/diff/4-5/
Testing
---
Thanks,
Zhitao Li
/diff/1/
Testing
---
Thanks,
Zhitao Li
/tests/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347
Diff: https://reviews.apache.org/r/66227/diff/4/
Changes: https://reviews.apache.org/r/66227/diff/3-4/
Testing
---
Thanks,
Zhitao Li
`GROW_VOLUME` or `SHRINK_VOLUME` and no other operations.
Diffs
-
src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8
Diff: https://reviews.apache.org/r/66568/diff/1/
Testing
---
Thanks,
Zhitao Li
ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d
Diff: https://reviews.apache.org/r/66591/diff/1/
Testing
---
Thanks,
Zhitao Li
f switch statements in
> > the code so that this patch cannot be used in isolation (fatal compiler
> > warnings). It might be enough to enumerate the new cases explicitly and
> > mark them `UNIMPLEMENTED`.
> >
> > Similar for v1 enum below.
>
> Zhit
/diff/2/
Changes: https://reviews.apache.org/r/53267/diff/1-2/
Testing
---
Ran this on master with a client keeps subscribing and disconnecting. Observes
that gauge gets updated and new log line is printed.
Thanks,
Zhitao Li
/66049/diff/8/
Changes: https://reviews.apache.org/r/66049/diff/7-8/
Testing
---
Thanks,
Zhitao Li
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66049/#review201067
-------
On April 13, 2018, 10:20 a.m., Zhitao Li wrote:
>
> --
://reviews.apache.org/r/66049/diff/7/
Changes: https://reviews.apache.org/r/66049/diff/6-7/
Testing
---
Thanks,
Zhitao Li
4edf781711d9efdb994114aeb6289b6af750b87a
src/tests/reservation_tests.cpp 5570df2e0b208512d0a0a3079a180e1acfe08f3d
Diff: https://reviews.apache.org/r/66050/diff/8/
Changes: https://reviews.apache.org/r/66050/diff/7-8/
Testing
---
Thanks,
Zhitao Li
/diff/9/
Changes: https://reviews.apache.org/r/66051/diff/8-9/
Testing
---
Thanks,
Zhitao Li
)
-
src/tests/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347
Diff: https://reviews.apache.org/r/66227/diff/3/
Changes: https://reviews.apache.org/r/66227/diff/2-3/
Testing
---
Thanks,
Zhitao Li
/10/
Changes: https://reviews.apache.org/r/66051/diff/9-10/
Testing
---
Thanks,
Zhitao Li
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/66051/#review200051
-------
On April 9, 2018, 9:32 p.m., Zhitao Li wrote:
>
> ---
> This is an au
iod of time, but which are not currently allocated to
> > some framework/role. I wonder if we need some new tools in the allocator to
> > handle this?
>
> Chun-Hung Hsiao wrote:
> Yeah this sounds bad. Would it help if we remove the consumed resources
> from the allocator and
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66343/#review200623
---
On March 28, 2018, 11:23 a.m., Zhitao Li wrote:
>
> ---
> This is an autom
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66049/#review200185
-------
On March 28, 2018, 11:24 a.m., Zhitao Li wrote:
>
> ---
` to avoid
shadowing.
Diffs (updated)
-
src/launcher/executor.cpp 383655230fcdad30b652ea984cb9f5fc9c49dd38
Diff: https://reviews.apache.org/r/66481/diff/2/
Changes: https://reviews.apache.org/r/66481/diff/1-2/
Testing
---
`make` on Linux.
Thanks,
Zhitao Li
: https://reviews.apache.org/r/66258/diff/2/
Changes: https://reviews.apache.org/r/66258/diff/1-2/
Testing
---
Thanks,
Zhitao Li
383655230fcdad30b652ea984cb9f5fc9c49dd38
Diff: https://reviews.apache.org/r/66259/diff/2/
Changes: https://reviews.apache.org/r/66259/diff/1-2/
Testing
---
Thanks,
Zhitao Li
y, visit:
https://reviews.apache.org/r/66481/#review200605
---
On April 7, 2018, 5:50 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail.
/2/
Changes: https://reviews.apache.org/r/66291/diff/1-2/
Testing
---
Thanks,
Zhitao Li
,
Zhitao Li
/executor.cpp 1d672112bae889cc9d19343a59e0ff66569785c4
Diff: https://reviews.apache.org/r/66283/diff/2/
Changes: https://reviews.apache.org/r/66283/diff/1-2/
Testing
---
Thanks,
Zhitao Li
support of `max_completion_time`.
Diffs (updated)
-
src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b
Diff: https://reviews.apache.org/r/66293/diff/2/
Changes: https://reviews.apache.org/r/66293/diff/1-2/
Testing
---
Thanks,
Zhitao Li
` support in command executor.
Diffs (updated)
-
src/tests/command_executor_tests.cpp 3c5687f918deb8cdda8a97abb0fbd8d9b089926a
Diff: https://reviews.apache.org/r/66260/diff/2/
Changes: https://reviews.apache.org/r/66260/diff/1-2/
Testing
---
Thanks,
Zhitao Li
---
Thanks,
Zhitao Li
nt which has
> > the RESOURCE_PROVIDER capability, but does not support the operation?
>
> Zhitao Li wrote:
> Good catch.
>
> For a 1.5 agent, I think it will crash at this line:
> https://github.com/apache/mesos/blob/1.5.0/src/common/protobuf_utils.cp
,
Zhitao Li
/
Changes: https://reviews.apache.org/r/66049/diff/9-10/
Testing
---
Thanks,
Zhitao Li
51de71bc45ff4fb862690efd9428b25d92055391
src/tests/master_tests.cpp be7a3cc6126d2fe7c56c49b3da5f6f4bf29657f5
src/tests/slave_tests.cpp 04f7acad47aa980d507bbe29b29db5eb050c02f3
Diff: https://reviews.apache.org/r/66733/diff/1/
Testing
---
Thanks,
Zhitao Li
/
Testing
---
Thanks,
Zhitao Li
: https://reviews.apache.org/r/66051/diff/12-13/
Testing
---
Thanks,
Zhitao Li
/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a
Diff: https://reviews.apache.org/r/66568/diff/4/
Changes: https://reviews.apache.org/r/66568/diff/3-4/
Testing
---
Behavior tested in https://reviews.apache.org/r/66569/.
Thanks,
Zhitao Li
for authorization actions for `RESIZE_VOLUME`.
Diffs (updated)
-
src/tests/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c
Diff: https://reviews.apache.org/r/66532/diff/4/
Changes: https://reviews.apache.org/r/66532/diff/3-4/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/66531/diff/2-3/
Testing
---
Manually created ACL and verified that untrusted principals will not allow to
grow/shrink volumes.
Also created unit test in next patch.
Thanks,
Zhitao Li
,
Zhitao Li
.org/r/66220/#comment282378>
Resources::contains only matches a volume if their size perfectly matches,
so I think it is sufficient.
- Zhitao Li
On April 11, 2018, 2:19 p.m., Zhitao Li wrote:
>
> ---
> This is an a
---
Thanks,
Zhitao Li
rsion. Do you want to consider adding that?
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66050/#review201055
-------
On April 16, 2018, 9:42 a.m., Zhitao Li wrote:
>
> --
hat the `ACCEPT` call fails by checking that the next offer
> > contains the original resources.
Semantic already fixed in the other patch. I will fix the test to reflect your
suggested semantic.
- Zhitao
---
This is an automatically ge
To reply, visit:
https://reviews.apache.org/r/66531/#review201357
-------
On April 10, 2018, 12:24 p.m., Zhitao Li wrote:
>
> ---
> This is an automatical
701 - 800 of 907 matches
Mail list logo
