Re: Review Request 70879: Updated webui Roles tab to consistently display '-' for 0 entries.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70879/#review215962 --- Ship it! LGTM - Armand Grillet On June 18, 2019, 10:22 p.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70879/ > --- > > (Updated June 18, 2019, 10:22 p.m.) > > > Review request for mesos, Armand Grillet and Meng Zhu. > > > Repository: mesos > > > Description > --- > > The Roles tab currently uses an inconsistent mix of '0', '0 B' and '-' > for displaying the allocation, guarantee, and limit. Since it's easier > to scan the table for non-empty entries when '-' is used, this updates > the every empty case to use '-'. > > We may also want to consider using the empty string '' in the future, > as that may help make the table even easier to scan visually than '-'. > > > Diffs > - > > src/webui/app/roles/roles.html c8ac1ef6cdfbc6d6a3d5c2e619896e8656a9badf > > > Diff: https://reviews.apache.org/r/70879/diff/1/ > > > Testing > --- > > Ran manually, see screenshot. > > > File Attachments > > > post-changes > > https://reviews.apache.org/media/uploaded/files/2019/06/18/ab42cf05-9252-4eed-a765-4126c5ed23a4__Screen_Shot_2019-06-18_at_4.16.49_PM.png > pre-changes > > https://reviews.apache.org/media/uploaded/files/2019/06/18/29122c1d-dae3-4d4c-8a52-062971d603c0__Screen_Shot_2019-06-18_at_4.21.27_PM.png > > > Thanks, > > Benjamin Mahler > >
Re: Review Request 70090: Addressed issues flagged by pylint-2.3.1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70090/#review213376 --- Ship it! Ship It! - Armand Grillet On March 3, 2019, 12:39 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70090/ > --- > > (Updated March 3, 2019, 12:39 p.m.) > > > Review request for mesos and Armand Grillet. > > > Bugs: MESOS-9629 > https://issues.apache.org/jira/browse/MESOS-9629 > > > Repository: mesos > > > Description > --- > > Addressed issues flagged by pylint-2.3.1. > > > Diffs > - > > src/python/cli_new/lib/cli/exceptions.py > c78f4a97debdb89cc9972c89c5c1ea249836713b > src/python/lib/mesos/http.py 5a8016da50b2e1e5a81710f10a7ef65d6f4198bd > support/common.py 845a687b6f92c66e1ae367701e96335f1c86b5de > support/verify-reviews.py 377792dd6f958ea8b138ca4d62fcd15b1c0bc9be > > > Diff: https://reviews.apache.org/r/70090/diff/2/ > > > Testing > --- > > * `make check` > * `./support/mesos-style.py` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 70091: Added tox invocation to test stage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70091/#review213375 --- Ship it! Ship It! - Armand Grillet On March 3, 2019, 6:09 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70091/ > --- > > (Updated March 3, 2019, 6:09 p.m.) > > > Review request for mesos and Armand Grillet. > > > Bugs: MESOS-9628 > https://issues.apache.org/jira/browse/MESOS-9628 > > > Repository: mesos > > > Description > --- > > This patch also removes a redundant printout which was not properly > synchronized with the test execution's output and would have appeared at > the incorrect time. > > > Diffs > - > > src/python/cli_new/bin/mesos-cli-tests > 9157d4970e2d6954c65d490ce7c4cffd7541e2b9 > src/python/cli_new/pip-requirements.txt > 663f774786989d93d20e005e3c3eeeffc439068e > src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6 > > > Diff: https://reviews.apache.org/r/70091/diff/1/ > > > Testing > --- > > `ctest -R CLI --verbose` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 70092: Updated to pylint-2.3.1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70092/#review213374 --- Ship it! Ship It! - Armand Grillet On March 3, 2019, 12:39 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70092/ > --- > > (Updated March 3, 2019, 12:39 p.m.) > > > Review request for mesos and Armand Grillet. > > > Bugs: MESOS-9629 > https://issues.apache.org/jira/browse/MESOS-9629 > > > Repository: mesos > > > Description > --- > > Updated to pylint-2.3.1. > > > Diffs > - > > src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 > src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 > support/pip-requirements.txt c8839fd2471826e8ca6bc023b3a0f4a38af9f899 > > > Diff: https://reviews.apache.org/r/70092/diff/3/ > > > Testing > --- > > * `make check` > * `./support/mesos-style.py` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 70090: Addressed issues flagged by pylint-2.3.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70090/#review213363 --- Ship it! Ship It! - Armand Grillet On March 3, 2019, 2:01 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70090/ > --- > > (Updated March 3, 2019, 2:01 a.m.) > > > Review request for mesos and Armand Grillet. > > > Repository: mesos > > > Description > --- > > Addressed issues flagged by pylint-2.3.0. > > > Diffs > - > > src/python/cli_new/lib/cli/exceptions.py > c78f4a97debdb89cc9972c89c5c1ea249836713b > src/python/lib/mesos/http.py 5a8016da50b2e1e5a81710f10a7ef65d6f4198bd > support/common.py 845a687b6f92c66e1ae367701e96335f1c86b5de > support/pip-requirements.txt c8839fd2471826e8ca6bc023b3a0f4a38af9f899 > support/verify-reviews.py 377792dd6f958ea8b138ca4d62fcd15b1c0bc9be > > > Diff: https://reviews.apache.org/r/70090/diff/1/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 70092: Updated to pylint-2.3.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70092/#review213364 --- support/mesos-style.py Lines 251 (patched) <https://reviews.apache.org/r/70092/#comment299302> Why is this necessary? The directory `.tox` should mainly have `.py` and `.pyc` but no C++ source files. - Armand Grillet On March 3, 2019, 2:01 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70092/ > --- > > (Updated March 3, 2019, 2:01 a.m.) > > > Review request for mesos and Armand Grillet. > > > Repository: mesos > > > Description > --- > > Updated to pylint-2.3.0. > > > Diffs > - > > src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 > src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 > support/mesos-style.py 11d5f96d4ca534a7d51ed93d2d6b0c528d31fad4 > > > Diff: https://reviews.apache.org/r/70092/diff/1/ > > > Testing > --- > > `make check` > > This currently triggers MESOS-9629 if one invokes a linter. It does not fail > `make check` unless we implement MESOS-9628. > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 69817: Refactored 'support/verify-reviews.py' to be closer to commit 7412179.
> On Jan. 23, 2019, 8:55 p.m., Vinod Kone wrote: > > Looks ok to me. I'll let Till ship this. > > > > Has this been tested? I have tested the changes locally but this was also the case for previous review requests on this support script thus I am still not confident regarding the reliability of this script. - Armand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69817/#review212250 --- On Jan. 23, 2019, 12:47 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69817/ > --- > > (Updated Jan. 23, 2019, 12:47 p.m.) > > > Review request for mesos, Till Toenshoff and Vinod Kone. > > > Repository: mesos > > > Description > --- > > The goal of this commit is to make 'verify-reviews.py' as close as > possible to its last known working state (commit > 74121798f24fca372180b8c4bc00b4df07d46240). > > The diff between 'verify-reviews.py' at this commit and 7412179 is > available here: https://www.diffchecker.com/cmfaM83O All the new > features added since 7412179 have been added again and the code > has been made Python 3 compatible again. > > The goal is to have a diff as minimal as possible with improvements > regarding logs so that we do not face CI issues anymore. Changes > have been made regarding how we run commands from the script so > that they are run from the repository instead of where the > script is being called. > > > Diffs > - > > support/verify-reviews.py 71326d34bb649e27a3a2901867d31a2a1fffd4e9 > > > Diff: https://reviews.apache.org/r/69817/diff/1/ > > > Testing > --- > > > Thanks, > > Armand Grillet > >
Review Request 69817: Refactored 'support/verify-reviews.py' to be closer to commit 7412179.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69817/ --- Review request for mesos, Till Toenshoff and Vinod Kone. Repository: mesos Description --- The goal of this commit is to make 'verify-reviews.py' as close as possible to its last known working state (commit 74121798f24fca372180b8c4bc00b4df07d46240). The diff between 'verify-reviews.py' at this commit and 7412179 is available here: https://www.diffchecker.com/cmfaM83O All the new features added since 7412179 have been added again and the code has been made Python 3 compatible again. The goal is to have a diff as minimal as possible with improvements regarding logs so that we do not face CI issues anymore. Changes have been made regarding how we run commands from the script so that they are run from the repository instead of where the script is being called. Diffs - support/verify-reviews.py 71326d34bb649e27a3a2901867d31a2a1fffd4e9 Diff: https://reviews.apache.org/r/69817/diff/1/ Testing --- Thanks, Armand Grillet
Review Request 69701: Improved debuggability of `verify-reviews.py`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69701/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9514 https://issues.apache.org/jira/browse/MESOS-9514 Repository: mesos Description --- Improves error handling in `shell()` and decodes what is returned by `urllib.request.urlopen` when doing API calls. Diffs - support/verify-reviews.py 04ed7fe9022f0758389bd76c21e48d0cd998 Diff: https://reviews.apache.org/r/69701/diff/1/ Testing --- Thanks, Armand Grillet
Review Request 69698: Added try/except for `shell()` calls in `verify-reviews.py`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69698/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9514 https://issues.apache.org/jira/browse/MESOS-9514 Repository: mesos Description --- This improves the errors returned by reviewbot so that we can more easily see which issues are on the nodes running our CI. Diffs - support/verify-reviews.py 72f98b234d9a2a84decb0569998d74e4c730122d Diff: https://reviews.apache.org/r/69698/diff/1/ Testing --- Thanks, Armand Grillet
Review Request 69697: Reverted cleanup step of `verify-reviews.py`.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69697/
---
Review request for mesos and Till Toenshoff.
Bugs: MESOS-9514
https://issues.apache.org/jira/browse/MESOS-9514
Repository: mesos
Description
---
Reverts the improvements made on the support script `verify-reviews.py`
in 3badf7179992e61f30f5a79da9d481dd451c7c2f. Sadly, these changes have
broken our Azure based Mesos CI as seen in MESOS-9514.
After comparing the code before and after the commit, we can see that
the line failing in CI, `HEAD = shell("git rev-parse HEAD")`, is
misplaced. It was previously located in the exit process in the
`cleanup()` function and it is now back there, surrounded by a
try/catch for error handling.
Diffs
-
support/verify-reviews.py 72f98b234d9a2a84decb0569998d74e4c730122d
Diff: https://reviews.apache.org/r/69697/diff/1/
Testing
---
Thanks,
Armand Grillet
Re: Review Request 69662: Displayed resource provider information in the Mesos webui.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211637 --- Ship it! LGTM. The button logic is similar to what is in `agents.html` (that's a good thing). - Armand Grillet On Jan. 3, 2019, 4 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69662/ > --- > > (Updated Jan. 3, 2019, 4 p.m.) > > > Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung > Hsiao. > > > Bugs: MESOS-8380 > https://issues.apache.org/jira/browse/MESOS-8380 > > > Repository: mesos > > > Description > --- > > Displayed resource provider information in the Mesos webui. > > > Diffs > - > > src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84 > src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3 > > > Diff: https://reviews.apache.org/r/69662/diff/1/ > > > Testing > --- > > `make check` > > Ran a local test with a `./src/test-csi-plugin`. > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.
verbose --disable-libtool-wrappers + append_dockerfile 'ENV GLOG_v=1 MESOS_VERBOSE=1' + echo ENV GLOG_v=1 MESOS_VERBOSE=1 + '[' -n '' ']' + case $BUILDTOOL in + append_dockerfile 'CMD ./bootstrap && ./configure --verbose --disable-libtool-wrappers && make -j6 distcheck 2>&1' + echo CMD ./bootstrap '&&' ./configure --verbose --disable-libtool-wrappers '&&' make -j6 distcheck '2>&1' ++ date +%s + TAG=mesos-1544790714-31615 + docker build --no-cache=true -t mesos-1544790714-31615 . Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running? Full log: console git clean -fd git reset --hard 343cf1e8a8f976b461d4bc05960e8e7019ea3d9f Checking if review: 69557 needs verification Latest diff timestamp: 2018-12-12 11:16:24 Latest review timestamp: 2018-12-14 12:22:58 Checking if review: 69445 needs verification Latest diff timestamp: 2018-12-12 20:44:05 Latest review timestamp: 2018-12-14 12:23:02 Checking if review: 69436 needs verification Latest diff timestamp: 2018-11-22 19:40:46 Latest review timestamp: 2018-12-14 12:23:16 4 review requests need verification 69551 69559 69338 69563 git clean -fd git reset --hard 343cf1e8a8f976b461d4bc05960e8e7019ea3d9f ``` Thanks, Armand Grillet
Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.
> On Dec. 17, 2018, 1:52 p.m., Till Toenshoff wrote: > > support/verify-reviews.py > > Line 77 (original), 72 (patched) > > <https://reviews.apache.org/r/69559/diff/3/?file=2114076#file2114076line79> > > > > Does this display as JSON? It doesn't as we go back to the old codebase. > On Dec. 17, 2018, 1:52 p.m., Till Toenshoff wrote: > > support/verify-reviews.py > > Lines 118 (patched) > > <https://reviews.apache.org/r/69559/diff/3/?file=2114076#file2114076line127> > > > > Why not > > ``` > > if data: > > ``` > > > > Can we get called with non `str` instances? Yes it happens because `api()` is used in different contexts, without this check the script crashed as we sometimes got data as a `str` when we except `bytes` to use `urllib.request.urlopen`. > On Dec. 17, 2018, 1:52 p.m., Till Toenshoff wrote: > > support/verify-reviews.py > > Lines 298 (patched) > > <https://reviews.apache.org/r/69559/diff/3/?file=2114076#file2114076line317> > > > > Does this mean that if a RR changed in the chain that was not the last > > one, that we wont run validate the chain? > > Can you please explain the consequences in the comment? Yes. This limitation existed since a while and is reintroduced by going back to the old code: https://github.com/apache/mesos/commit/d6f8620fd76d24a6e8efe1f6784557189de04f00 - Armand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211355 --- On Dec. 13, 2018, 4:59 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69559/ > --- > > (Updated Dec. 13, 2018, 4:59 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Dragos Schebesch, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-9459 > https://issues.apache.org/jira/browse/MESOS-9459 > > > Repository: mesos > > > Description > --- > > We have switched the Python 2 support scripts to Python 3 a few months > ago. During this transition, 'verify-reviews.py' has been modified, > mainly to work better on Windows: https://reviews.apache.org/r/67505/. > > The Python 3 script has then replaced the Python 2 one and we now face > an issue with the script, MESOS-9459. Due to all the changes made > between the Python 2 and Python 3 scripts, it is hard for us to > know when the script started failing and why. > > To solve this issue, this commit takes the state of 'verify-reviews.py' > as it was in 74121798f24fca372180b8c4bc00b4df07d46240, applies 2to3, > adds the '--out-file' option, then adds the content of: > * ac766c8bd0fba348399d8eac52f75f62e64db64e > * 43eba285cb5c8622a6be8a5bdad637ed53431e85 > * 5b348b6070f0d0403cb69b6a7fa638fc46b7ff49 > * 568fcdfd29788d9df89a51ffae7969c2bf0ea173 > > This gives a clean diff between 74121798f24fca372180b8c4bc00b4df07d46240 > and this commit, fixes the issue raised in MESOS-9459, and does not > remove existing features. However, this uses less our common library > developed in the chain that landed while migrating from Python 2 to 3. > > This should be followed by a refactoring of 'verify-review.py' and > 'common.py' to use our library more while not breaking the script > when using Reviewbot. > > > Diffs > - > > support/verify-reviews.py 552dc366a588e6c5ad0efdcdca03d66f1d7044c3 > > > Diff: https://reviews.apache.org/r/69559/diff/3/ > > > Testing > --- > > Checked https://www.diffchecker.com/R5uYlefc a diff of 'verify-reviews.py' > between 74121798f24fca372180b8c4bc00b4df07d46240 and this commit. > > > ``` > ? apache-mesos (MESOS-9459) ? BUILD_URL=yolo python3 > support/verify-reviews.py -u user -p password > git rev-parse HEAD > Checking if review: 69544 needs verification > Skipping blocking review 69544 > Checking if review: 69342 needs verification > Skipping blocking review 69342 > Checking if review: 69478 needs verification > Skipping blocking review 69478 > Checking if review: 69479 needs verification > Skipping blocking review 69479 > Checking if review: 67997 needs verification > Skipping blocking review 67997 > Checking if review: 68162 needs verification > Skipping blocking review 68162 > Checking if review: 68163 needs verification > Skipping blocking review 68163 > Checking if review: 69071 needs verification > Skipping bloc
Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.
> On Dec. 14, 2018, 1:23 p.m., Armand Grillet wrote: > > Bad patch! > > > > Reviews applied: [69436] > > > > Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' > > BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose > > --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; > > ./support/docker-build.sh 2>&1 | tee build_69436"] > > > > Error: > > + : ubuntu:14.04 > > + : autotools > > + : gcc > > + : --verbose --disable-libtool-wrappers > > + : GLOG_v=1 MESOS_VERBOSE=1 > > + : 6 > > +++ dirname ./support/docker-build.sh > > ++ cd ./support/.. > > ++ pwd > > + MESOS_DIRECTORY=/Users/Armand/Code/apache-mesos > > + cd /Users/Armand/Code/apache-mesos > > + DOCKERFILE=Dockerfile > > + rm -f Dockerfile > > + case $OS in > > + append_dockerfile 'FROM ubuntu:14.04' > > + echo FROM ubuntu:14.04 > > + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*' > > + echo RUN rm -rf '/var/lib/apt/lists/*' > > ++ uname -m > > + '[' x86_64 = x86_64 ']' > > + CLANG_PKG=clang-3.5 > > + append_dockerfile 'RUN apt-get update' > > + echo RUN apt-get update > > + append_dockerfile 'RUN apt-get install -y build-essential clang-3.5 git > > maven autoconf libtool software-properties-common' > > + echo RUN apt-get install -y build-essential clang-3.5 git maven autoconf > > libtool software-properties-common > > + append_dockerfile 'RUN apt-get install -y python-dev python-six > > libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev' > > + echo RUN apt-get install -y python-dev python-six libcurl4-nss-dev > > libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev > > + append_dockerfile 'RUN apt-get install -y wget curl sed' > > + echo RUN apt-get install -y wget curl sed > > + case $OS in > > + append_dockerfile 'RUN apt-get install -y openjdk-7-jdk' > > + echo RUN apt-get install -y openjdk-7-jdk > > + append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos' > > + echo RUN adduser --disabled-password --gecos ''\'''\''' mesos > > + append_dockerfile 'RUN curl -sSL > > https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh -o > > /tmp/install-cmake.sh' > > + echo RUN curl -sSL > > https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh -o > > /tmp/install-cmake.sh > > + append_dockerfile 'RUN chmod u+x /tmp/install-cmake.sh && sync && > > /tmp/install-cmake.sh --skip-license --prefix=/usr/local' > > + echo RUN chmod u+x /tmp/install-cmake.sh '&&' sync '&&' > > /tmp/install-cmake.sh --skip-license --prefix=/usr/local > > + case $COMPILER in > > + append_dockerfile 'ENV CC gcc' > > + echo ENV CC gcc > > + append_dockerfile 'ENV CXX g++' > > + echo ENV CXX g++ > > + append_dockerfile 'WORKDIR mesos' > > + echo WORKDIR mesos > > + append_dockerfile 'COPY . /mesos/' > > + echo COPY . /mesos/ > > + append_dockerfile 'RUN chown -R mesos /mesos' > > + echo RUN chown -R mesos /mesos > > + append_dockerfile 'USER mesos' > > + echo USER mesos > > + append_dockerfile 'ENV GTEST_OUTPUT xml:report.xml' > > + echo ENV GTEST_OUTPUT xml:report.xml > > + append_dockerfile 'ENV DISTCHECK_CONFIGURE_FLAGS --verbose > > --disable-libtool-wrappers' > > + echo ENV DISTCHECK_CONFIGURE_FLAGS --verbose --disable-libtool-wrappers > > + append_dockerfile 'ENV GLOG_v=1 MESOS_VERBOSE=1' > > + echo ENV GLOG_v=1 MESOS_VERBOSE=1 > > + '[' -n '' ']' > > + case $BUILDTOOL in > > + append_dockerfile 'CMD ./bootstrap && ./configure --verbose > > --disable-libtool-wrappers && make -j6 distcheck 2>&1' > > + echo CMD ./bootstrap '&&' ./configure --verbose > > --disable-libtool-wrappers '&&' make -j6 distcheck '2>&1' > > ++ date +%s > > + TAG=mesos-1544790190-23301 > > + docker build --no-cache=true -t mesos-1544790190-23301 . > > Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the > > docker daemon running? > > > > Full log: console > > Joseph Wu wrote: > Armand, did you accidentally use your own reviewboard credentials in one > of these scripts? Yes, I have run https://reviews.apache.org/r/69559/ without commenting the POST request at first. Sorry about the created comment, as it hasn't created a "Fix It!" I haven't commented the few impacted review requests. - Armand --- This is an automatic
Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.
> On Dec. 13, 2018, 9:58 p.m., Vinod Kone wrote: > > git reset --hard b'69296553d96ca78b3145b9dd400a3c2332b441c7\n' > > Failed command: git reset --hard > > b'69296553d96ca78b3145b9dd400a3c2332b441c7\n' > > > > Error: b'fatal: Cannot do hard reset with paths.\n' > > > > > > This looks bad? Looks like we need to strip the trailing "\n"? Thanks for the review, this is fixed and I have updated the `Testing Done`. - Armand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211306 ----------- On Dec. 13, 2018, 4:59 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69559/ > --- > > (Updated Dec. 13, 2018, 4:59 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Dragos Schebesch, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-9459 > https://issues.apache.org/jira/browse/MESOS-9459 > > > Repository: mesos > > > Description > --- > > We have switched the Python 2 support scripts to Python 3 a few months > ago. During this transition, 'verify-reviews.py' has been modified, > mainly to work better on Windows: https://reviews.apache.org/r/67505/. > > The Python 3 script has then replaced the Python 2 one and we now face > an issue with the script, MESOS-9459. Due to all the changes made > between the Python 2 and Python 3 scripts, it is hard for us to > know when the script started failing and why. > > To solve this issue, this commit takes the state of 'verify-reviews.py' > as it was in 74121798f24fca372180b8c4bc00b4df07d46240, applies 2to3, > adds the '--out-file' option, then adds the content of: > * ac766c8bd0fba348399d8eac52f75f62e64db64e > * 43eba285cb5c8622a6be8a5bdad637ed53431e85 > * 5b348b6070f0d0403cb69b6a7fa638fc46b7ff49 > * 568fcdfd29788d9df89a51ffae7969c2bf0ea173 > > This gives a clean diff between 74121798f24fca372180b8c4bc00b4df07d46240 > and this commit, fixes the issue raised in MESOS-9459, and does not > remove existing features. However, this uses less our common library > developed in the chain that landed while migrating from Python 2 to 3. > > This should be followed by a refactoring of 'verify-review.py' and > 'common.py' to use our library more while not breaking the script > when using Reviewbot. > > > Diffs > - > > support/verify-reviews.py 552dc366a588e6c5ad0efdcdca03d66f1d7044c3 > > > Diff: https://reviews.apache.org/r/69559/diff/2/ > > > Testing > --- > > Checked https://www.diffchecker.com/R5uYlefc a diff of 'verify-reviews.py' > between 74121798f24fca372180b8c4bc00b4df07d46240 and this commit. > > > ``` > ? apache-mesos (MESOS-9459) ? BUILD_URL=yolo python3 > support/verify-reviews.py -u user -p password > git rev-parse HEAD > Checking if review: 69342 needs verification > Skipping blocking review 69342 > Checking if review: 69478 needs verification > Skipping blocking review 69478 > Checking if review: 69479 needs verification > Skipping blocking review 69479 > Checking if review: 67997 needs verification > Skipping blocking review 67997 > Checking if review: 68162 needs verification > Skipping blocking review 68162 > Checking if review: 68163 needs verification > Skipping blocking review 68163 > Checking if review: 69547 needs verification > Latest diff timestamp: 2018-12-11 12:15:07 > Verifying review 69547 > Posting review: Bad review! > > Reviews applied: [] > > Error: > No reviewers specified. Please find a reviewer by asking on JIRA or the > mailing list. > git clean -fd > git reset --hard b'69296553d96ca78b3145b9dd400a3c2332b441c7\n' > Failed command: git reset --hard b'69296553d96ca78b3145b9dd400a3c2332b441c7\n' > > Error: b'fatal: Cannot do hard reset with paths.\n' > Checking if review: 69557 needs verification > Latest diff timestamp: 2018-12-12 11:16:24 > Verifying review 69557 > Dependent review: https://reviews.apache.org/api/review-requests/69398/ > Dependent review: https://reviews.apache.org/api/review-requests/69397/ > Applying review 69397 > /usr/local/opt/python/bin/python3.7 support/apply-reviews.py -n -r 69397 > ``` > > > Thanks, > > Armand Grillet > >
Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69436/#review211329 --- Bad patch! Reviews applied: [69436] Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee build_69436"] Error: + : ubuntu:14.04 + : autotools + : gcc + : --verbose --disable-libtool-wrappers + : GLOG_v=1 MESOS_VERBOSE=1 + : 6 +++ dirname ./support/docker-build.sh ++ cd ./support/.. ++ pwd + MESOS_DIRECTORY=/Users/Armand/Code/apache-mesos + cd /Users/Armand/Code/apache-mesos + DOCKERFILE=Dockerfile + rm -f Dockerfile + case $OS in + append_dockerfile 'FROM ubuntu:14.04' + echo FROM ubuntu:14.04 + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*' + echo RUN rm -rf '/var/lib/apt/lists/*' ++ uname -m + '[' x86_64 = x86_64 ']' + CLANG_PKG=clang-3.5 + append_dockerfile 'RUN apt-get update' + echo RUN apt-get update + append_dockerfile 'RUN apt-get install -y build-essential clang-3.5 git maven autoconf libtool software-properties-common' + echo RUN apt-get install -y build-essential clang-3.5 git maven autoconf libtool software-properties-common + append_dockerfile 'RUN apt-get install -y python-dev python-six libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev' + echo RUN apt-get install -y python-dev python-six libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev + append_dockerfile 'RUN apt-get install -y wget curl sed' + echo RUN apt-get install -y wget curl sed + case $OS in + append_dockerfile 'RUN apt-get install -y openjdk-7-jdk' + echo RUN apt-get install -y openjdk-7-jdk + append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos' + echo RUN adduser --disabled-password --gecos ''\'''\''' mesos + append_dockerfile 'RUN curl -sSL https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh -o /tmp/install-cmake.sh' + echo RUN curl -sSL https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh -o /tmp/install-cmake.sh + append_dockerfile 'RUN chmod u+x /tmp/install-cmake.sh && sync && /tmp/install-cmake.sh --skip-license --prefix=/usr/local' + echo RUN chmod u+x /tmp/install-cmake.sh '&&' sync '&&' /tmp/install-cmake.sh --skip-license --prefix=/usr/local + case $COMPILER in + append_dockerfile 'ENV CC gcc' + echo ENV CC gcc + append_dockerfile 'ENV CXX g++' + echo ENV CXX g++ + append_dockerfile 'WORKDIR mesos' + echo WORKDIR mesos + append_dockerfile 'COPY . /mesos/' + echo COPY . /mesos/ + append_dockerfile 'RUN chown -R mesos /mesos' + echo RUN chown -R mesos /mesos + append_dockerfile 'USER mesos' + echo USER mesos + append_dockerfile 'ENV GTEST_OUTPUT xml:report.xml' + echo ENV GTEST_OUTPUT xml:report.xml + append_dockerfile 'ENV DISTCHECK_CONFIGURE_FLAGS --verbose --disable-libtool-wrappers' + echo ENV DISTCHECK_CONFIGURE_FLAGS --verbose --disable-libtool-wrappers + append_dockerfile 'ENV GLOG_v=1 MESOS_VERBOSE=1' + echo ENV GLOG_v=1 MESOS_VERBOSE=1 + '[' -n '' ']' + case $BUILDTOOL in + append_dockerfile 'CMD ./bootstrap && ./configure --verbose --disable-libtool-wrappers && make -j6 distcheck 2>&1' + echo CMD ./bootstrap '&&' ./configure --verbose --disable-libtool-wrappers '&&' make -j6 distcheck '2>&1' ++ date +%s + TAG=mesos-1544790190-23301 + docker build --no-cache=true -t mesos-1544790190-23301 . Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running? Full log: console - Armand Grillet On Nov. 22, 2018, 7:43 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69436/ > --- > > (Updated Nov. 22, 2018, 7:43 p.m.) > > > Review request for mesos, Andrei Budnik, Greg Mann, and Joseph Wu. > > > Bugs: MESOS-9272 > https://issues.apache.org/jira/browse/MESOS-9272 > > > Repository: mesos > > > Description > --- > > The destructor of `cluster::Slave` contained an assertion > that was not safe to assume in the presence of the > composing containerizer. This commit adds an additional > `Clock::settle()` to fix the issue. > > > Diffs > - > > src/tests/cluster.cpp 2b351ca70d8e80008e49722aa7d46918b5ecd9b0 > > > Diff: https://reviews.apache.org/r/69436/diff/1/ > > > Testing > --- > > Ran `./src/mesos-tests --gtest_filter="SlaveTest.DefaultExecutorCommandInfo" > --verbose --gtest_repeat=5 --gtest_throw_on_failure` while
Re: Review Request 69445: WIP: Moved `ReadOnlyHandler` into separate header.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69445/#review211328 --- Bad review! Reviews applied: [] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Armand Grillet On Dec. 12, 2018, 8:54 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69445/ > --- > > (Updated Dec. 12, 2018, 8:54 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > --- > > Exposed the former inner class `Master::ReadOnlyHandler` > in a separate header so it can be used from unit tests. > > > Diffs > - > > src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937 > src/master/master.hpp c7becfa615964674dcf1ebd9424aa5818a0fdb85 > src/master/readonly_handler.hpp PRE-CREATION > src/master/readonly_handler.cpp 8895374499dc6baa2c4d8a8dd86fddac4e39be29 > > > Diff: https://reviews.apache.org/r/69445/diff/2/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Re: Review Request 69557: Removed redundant handling of empty framework IDs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69557/#review211327 --- Bad patch! Reviews applied: [69557, 69398, 69397] Failed command: /usr/local/opt/python/bin/python3.7 support/apply-reviews.py -n -r 69397 Error: 2018-12-14 13:22:56 URL:https://reviews.apache.org/r/69397/diff/raw/ [3588/3588] -> "69397.patch" [1] error: patch failed: src/tests/master_validation_tests.cpp:4581 error: src/tests/master_validation_tests.cpp: patch does not apply Full log: console - Armand Grillet On Dec. 12, 2018, 11:29 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69557/ > --- > > (Updated Dec. 12, 2018, 11:29 a.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9469 > https://issues.apache.org/jira/browse/MESOS-9469 > > > Repository: mesos > > > Description > --- > > We were previously treating empty framework IDs like unset framework > IDs and were maintaining dedicated handling for this case. > > Since we now reject empty framework IDs this handling is not required > anymore and removed in this patch. > > > Diffs > - > > src/master/master.cpp 3de0fd35cc815f4b5787ee2cb5e81f5059d7a47c > src/sched/sched.cpp e77a02951831a7e0c5d9a9068f8d014cb1478382 > > > Diff: https://reviews.apache.org/r/69557/diff/1/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/ --- (Updated Dec. 13, 2018, 3:08 p.m.) Review request for mesos, Andrew Schwartzmeyer, Dragos Schebesch, and Vinod Kone. Changes --- Fixed issue and improved testing done. Bugs: MESOS-9459 https://issues.apache.org/jira/browse/MESOS-9459 Repository: mesos Description --- We have switched the Python 2 support scripts to Python 3 a few months ago. During this transition, 'verify-reviews.py' has been modified, mainly to work better on Windows: https://reviews.apache.org/r/67505/. The Python 3 script has then replaced the Python 2 one and we now face an issue with the script, MESOS-9459. Due to all the changes made between the Python 2 and Python 3 scripts, it is hard for us to know when the script started failing and why. To solve this issue, this commit takes the state of 'verify-reviews.py' as it was in 74121798f24fca372180b8c4bc00b4df07d46240, applies 2to3, adds the '--out-file' option, then adds the content of: * ac766c8bd0fba348399d8eac52f75f62e64db64e * 43eba285cb5c8622a6be8a5bdad637ed53431e85 * 5b348b6070f0d0403cb69b6a7fa638fc46b7ff49 * 568fcdfd29788d9df89a51ffae7969c2bf0ea173 This gives a clean diff between 74121798f24fca372180b8c4bc00b4df07d46240 and this commit, fixes the issue raised in MESOS-9459, and does not remove existing features. However, this uses less our common library developed in the chain that landed while migrating from Python 2 to 3. This should be followed by a refactoring of 'verify-review.py' and 'common.py' to use our library more while not breaking the script when using Reviewbot. Diffs (updated) - support/verify-reviews.py 552dc366a588e6c5ad0efdcdca03d66f1d7044c3 Diff: https://reviews.apache.org/r/69559/diff/2/ Changes: https://reviews.apache.org/r/69559/diff/1-2/ Testing (updated) --- Checked https://www.diffchecker.com/R5uYlefc a diff of 'verify-reviews.py' between 74121798f24fca372180b8c4bc00b4df07d46240 and this commit. ``` ? apache-mesos (MESOS-9459) ? BUILD_URL=yolo python3 support/verify-reviews.py -u user -p password git rev-parse HEAD Checking if review: 69342 needs verification Skipping blocking review 69342 Checking if review: 69478 needs verification Skipping blocking review 69478 Checking if review: 69479 needs verification Skipping blocking review 69479 Checking if review: 67997 needs verification Skipping blocking review 67997 Checking if review: 68162 needs verification Skipping blocking review 68162 Checking if review: 68163 needs verification Skipping blocking review 68163 Checking if review: 69547 needs verification Latest diff timestamp: 2018-12-11 12:15:07 Verifying review 69547 Posting review: Bad review! Reviews applied: [] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. git clean -fd git reset --hard b'69296553d96ca78b3145b9dd400a3c2332b441c7\n' Failed command: git reset --hard b'69296553d96ca78b3145b9dd400a3c2332b441c7\n' Error: b'fatal: Cannot do hard reset with paths.\n' Checking if review: 69557 needs verification Latest diff timestamp: 2018-12-12 11:16:24 Verifying review 69557 Dependent review: https://reviews.apache.org/api/review-requests/69398/ Dependent review: https://reviews.apache.org/api/review-requests/69397/ Applying review 69397 /usr/local/opt/python/bin/python3.7 support/apply-reviews.py -n -r 69397 ``` Thanks, Armand Grillet
Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/#review211287 --- Bad review! Reviews applied: [] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Armand Grillet On Dec. 11, 2018, 1:17 p.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69547/ > --- > > (Updated Dec. 11, 2018, 1:17 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-8813 > https://issues.apache.org/jira/browse/MESOS-8813 > > > Repository: mesos > > > Description > --- > > Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. > > > Diffs > - > > src/tests/default_executor_tests.cpp > 86c3a98ec9e3c5d9d8f2a88218dec1e56d0ebc4c > > > Diff: https://reviews.apache.org/r/69547/diff/2/ > > > Testing > --- > > sudo make check > > > Thanks, > > Qian Zhang > >
Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/ --- Review request for mesos, Andrew Schwartzmeyer, Dragos Schebesch, and Vinod Kone. Bugs: MESOS-9459 https://issues.apache.org/jira/browse/MESOS-9459 Repository: mesos Description --- We have switched the Python 2 support scripts to Python 3 a few months ago. During this transition, 'verify-reviews.py' has been modified, mainly to work better on Windows: https://reviews.apache.org/r/67505/. The Python 3 script has then replaced the Python 2 one and we now face an issue with the script, MESOS-9459. Due to all the changes made between the Python 2 and Python 3 scripts, it is hard for us to know when the script started failing and why. To solve this issue, this commit takes the state of 'verify-reviews.py' as it was in 74121798f24fca372180b8c4bc00b4df07d46240, applies 2to3, adds the '--out-file' option, then adds the content of: * ac766c8bd0fba348399d8eac52f75f62e64db64e * 43eba285cb5c8622a6be8a5bdad637ed53431e85 * 5b348b6070f0d0403cb69b6a7fa638fc46b7ff49 * 568fcdfd29788d9df89a51ffae7969c2bf0ea173 This gives a clean diff between 74121798f24fca372180b8c4bc00b4df07d46240 and this commit, fixes the issue raised in MESOS-9459, and does not remove existing features. However, this uses less our common library developed in the chain that landed while migrating from Python 2 to 3. This should be followed by a refactoring of 'verify-review.py' and 'common.py' to use our library more while not breaking the script when using Reviewbot. Diffs - support/verify-reviews.py 552dc366a588e6c5ad0efdcdca03d66f1d7044c3 Diff: https://reviews.apache.org/r/69559/diff/1/ Testing --- Checked https://www.diffchecker.com/R5uYlefc, a diff of 'verify-reviews.py' between 74121798f24fca372180b8c4bc00b4df07d46240 and this commit. Thanks, Armand Grillet
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/ --- (Updated Nov. 26, 2018, 2:54 p.m.) Review request for mesos and Kevin Klues. Changes --- Fixed issues. Bugs: MESOS-9399 https://issues.apache.org/jira/browse/MESOS-9399 Repository: mesos Description --- With this option, the command can show all the tasks that have ever been run. This makes the command's behavior closer to the one of 'docker ps'. Diffs (updated) - src/python/cli_new/lib/cli/plugins/task/main.py 0ce21b365d64c5c331ce7f1a5937258960e15b6f src/python/cli_new/lib/cli/tests/task.py eb01bf5cae095a067572f534a13f4ec542101ca5 Diff: https://reviews.apache.org/r/69395/diff/5/ Changes: https://reviews.apache.org/r/69395/diff/4-5/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok test_list_all (cli.tests.task.TestTaskPlugin) ... ok -- Ran 8 tests in 20.889s OK ``` Thanks, Armand Grillet
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/ --- (Updated Nov. 26, 2018, 2:51 p.m.) Review request for mesos and Kevin Klues. Changes --- Rebased. Bugs: MESOS-9399 https://issues.apache.org/jira/browse/MESOS-9399 Repository: mesos Description --- With this option, the command can show all the tasks that have ever been run. This makes the command's behavior closer to the one of 'docker ps'. Diffs (updated) - src/python/cli_new/lib/cli/plugins/task/main.py 0ce21b365d64c5c331ce7f1a5937258960e15b6f src/python/cli_new/lib/cli/tests/task.py eb01bf5cae095a067572f534a13f4ec542101ca5 Diff: https://reviews.apache.org/r/69395/diff/4/ Changes: https://reviews.apache.org/r/69395/diff/3-4/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok test_list_all (cli.tests.task.TestTaskPlugin) ... ok -- Ran 8 tests in 20.889s OK ``` Thanks, Armand Grillet
Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69426/ --- (Updated Nov. 26, 2018, 2:45 p.m.) Review request for mesos and Kevin Klues. Changes --- Fixed issues. Bugs: MESOS-9399 https://issues.apache.org/jira/browse/MESOS-9399 Repository: mesos Description --- Replaces 'running_tasks(master)', a function that was not generic nor explicit, by 'wait_for_task(master, name, state, delay)'. This helper function waits a 'delay' for a task with a given 'name' to be in a certain 'state'. All uses of 'running_tasks' have been replaced by the new function. Diffs (updated) - src/python/cli_new/lib/cli/tests/base.py 58c96d7ba45a57cb824d1f7f146e6dc5e41572cd src/python/cli_new/lib/cli/tests/task.py eb01bf5cae095a067572f534a13f4ec542101ca5 Diff: https://reviews.apache.org/r/69426/diff/3/ Changes: https://reviews.apache.org/r/69426/diff/2-3/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 19.319s OK ``` Thanks, Armand Grillet
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/ --- (Updated Nov. 25, 2018, 12:17 p.m.) Review request for mesos and Kevin Klues. Changes --- Fixed issues. Bugs: MESOS-9399 https://issues.apache.org/jira/browse/MESOS-9399 Repository: mesos Description --- With this option, the command can show all the tasks that have ever been run. This makes the command's behavior closer to the one of 'docker ps'. Diffs (updated) - src/python/cli_new/lib/cli/plugins/task/main.py 4abc70a2de7e63bb629d5ed82d0045b29fb237fa src/python/cli_new/lib/cli/tests/task.py 1b48c0a4729043c874330552074b05368e38b715 Diff: https://reviews.apache.org/r/69395/diff/3/ Changes: https://reviews.apache.org/r/69395/diff/2-3/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok test_list_all (cli.tests.task.TestTaskPlugin) ... ok -- Ran 8 tests in 20.889s OK ``` Thanks, Armand Grillet
Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69426/ --- (Updated Nov. 25, 2018, 12:08 p.m.) Review request for mesos and Kevin Klues. Changes --- Fixed issues. Bugs: MESOS-9399 https://issues.apache.org/jira/browse/MESOS-9399 Repository: mesos Description --- Replaces 'running_tasks(master)', a function that was not generic nor explicit, by 'wait_for_task(master, name, state, delay)'. This helper function waits a 'delay' for a task with a given 'name' to be in a certain 'state'. All uses of 'running_tasks' have been replaced by the new function. Diffs (updated) - src/python/cli_new/lib/cli/tests/base.py c28e2a65b5c1b881c2f4eb09baf9806338f26e40 src/python/cli_new/lib/cli/tests/task.py 1b48c0a4729043c874330552074b05368e38b715 Diff: https://reviews.apache.org/r/69426/diff/2/ Changes: https://reviews.apache.org/r/69426/diff/1-2/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 19.319s OK ``` Thanks, Armand Grillet
Re: Review Request 69394: Updated 'mesos task list' to only display running tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69394/ --- (Updated Nov. 25, 2018, 10:53 a.m.) Review request for mesos and Kevin Klues. Changes --- Fixed issue. Bugs: MESOS-9399 https://issues.apache.org/jira/browse/MESOS-9399 Repository: mesos Description --- Updated 'mesos task list' to only display running tasks. Diffs (updated) - src/python/cli_new/lib/cli/plugins/task/main.py 4abc70a2de7e63bb629d5ed82d0045b29fb237fa src/python/cli_new/lib/cli/tests/task.py 1b48c0a4729043c874330552074b05368e38b715 Diff: https://reviews.apache.org/r/69394/diff/2/ Changes: https://reviews.apache.org/r/69394/diff/1-2/ Testing --- (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 19.845s OK Thanks, Armand Grillet
Review Request 69442: Updated 'REPOSITORY_URL' in 'support/reviewboardrc' to use gitbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69442/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9398 https://issues.apache.org/jira/browse/MESOS-9398 Repository: mesos Description --- The Apache Mesos repository was moved from the "git-wip" git server to the new "gitbox" server earlier in 2018. This change is now also made in 'support/reviewboardrc', a file used to generate the file '.reviewboardrc' at the root of the project directory. This update could also resolve the issue reported in MESOS-9398 which might be due to Review Board being out of date with its connected repo. Diffs - support/reviewboardrc 68002aaafe219f5bd9c8fdd57d082b293357 Diff: https://reviews.apache.org/r/69442/diff/1/ Testing --- Posted this review request after updating '.reviewboardrc' to use `REPOSITORY_URL = "https://gitbox.apache.org/repos/asf/mesos.git`. Thanks, Armand Grillet
Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69426/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9399 https://issues.apache.org/jira/browse/MESOS-9399 Repository: mesos Description --- Replaces 'running_tasks(master)', a function that was not generic nor explicit, by 'wait_for_task(master, name, state, delay)'. This helper function waits a 'delay' for a task with a given 'name' to be in a certain 'state'. All uses of 'running_tasks' have been replaced by the new function. Diffs - src/python/cli_new/lib/cli/tests/base.py c28e2a65b5c1b881c2f4eb09baf9806338f26e40 src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107 Diff: https://reviews.apache.org/r/69426/diff/1/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 19.319s OK ``` Thanks, Armand Grillet
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/ --- (Updated Nov. 22, 2018, 12:36 p.m.) Review request for . Changes --- Rebased to fix issue. Bugs: MESOS-9399 https://issues.apache.org/jira/browse/MESOS-9399 Repository: mesos Description --- With this option, the command can show all the tasks that have ever been run. This makes the command's behavior closer to the one of 'docker ps'. Diffs (updated) - src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107 Diff: https://reviews.apache.org/r/69395/diff/2/ Changes: https://reviews.apache.org/r/69395/diff/1-2/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok test_list_all (cli.tests.task.TestTaskPlugin) ... ok -- Ran 8 tests in 20.889s OK ``` Thanks, Armand Grillet
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/ --- (Updated Nov. 22, 2018, 12:36 p.m.) Review request for . Changes --- Rebased to fix issue. Bugs: MESOS-9399 https://issues.apache.org/jira/browse/MESOS-9399 Repository: mesos Description --- With this option, the command can show all the tasks that have ever been run. This makes the command's behavior closer to the one of 'docker ps'. Diffs (updated) - src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107 Diff: https://reviews.apache.org/r/69395/diff/2/ Changes: https://reviews.apache.org/r/69395/diff/1-2/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok test_list_all (cli.tests.task.TestTaskPlugin) ... ok -- Ran 8 tests in 20.889s OK ``` Thanks, Armand Grillet
Review Request 69425: Fixed name of task created when running mesos-cli-tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69425/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9399 https://issues.apache.org/jira/browse/MESOS-9399 Repository: mesos Description --- Fixed name of task created when running mesos-cli-tests. Diffs - src/python/cli_new/lib/cli/tests/base.py c28e2a65b5c1b881c2f4eb09baf9806338f26e40 Diff: https://reviews.apache.org/r/69425/diff/1/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 19.732s OK ``` Thanks, Armand Grillet
Re: Review Request 69390: Added docs describing how to use the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69390/ --- (Updated Nov. 20, 2018, 12:12 p.m.) Review request for mesos and Kevin Klues. Changes --- Fixed issue. Bugs: MESOS-9333 https://issues.apache.org/jira/browse/MESOS-9333 Repository: mesos Description (updated) --- The documentation describes the main commands of the new CLI, how to activate it, how to build Mesos including this component, and how to write a configuration file for it. Diffs (updated) - docs/cli.md PRE-CREATION docs/home.md e05b65d55176a706c072f73904a8e0f4365a8cb2 Diff: https://reviews.apache.org/r/69390/diff/3/ Changes: https://reviews.apache.org/r/69390/diff/2-3/ Testing --- Checked the rendered Markdown code. Thanks, Armand Grillet
Re: Review Request 69390: Added docs describing how to use the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69390/ --- (Updated Nov. 20, 2018, 11:57 a.m.) Review request for mesos and Kevin Klues. Changes --- Fixed issues. Bugs: MESOS-9333 https://issues.apache.org/jira/browse/MESOS-9333 Repository: mesos Description --- The documentation describes the main commands of the CLI, how to enable it and how to build Mesos including this component. Diffs (updated) - docs/cli.md PRE-CREATION docs/home.md e05b65d55176a706c072f73904a8e0f4365a8cb2 Diff: https://reviews.apache.org/r/69390/diff/2/ Changes: https://reviews.apache.org/r/69390/diff/1-2/ Testing --- Checked the rendered Markdown code. Thanks, Armand Grillet
Re: Review Request 69393: Displayed 'State' field when using 'mesos task list'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69393/ --- (Updated Nov. 19, 2018, 5:14 p.m.) Review request for mesos and Kevin Klues. Changes --- Fixed issues. Bugs: MESOS-9399 https://issues.apache.org/jira/browse/MESOS-9399 Repository: mesos Description --- Displayed 'State' field when using 'mesos task list'. Diffs (updated) - src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107 Diff: https://reviews.apache.org/r/69393/diff/2/ Changes: https://reviews.apache.org/r/69393/diff/1-2/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 20.812s OK ``` Thanks, Armand Grillet
Review Request 69395: Added '--all' flag to 'mesos task list'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9399 https://issues.apache.org/jira/browse/MESOS-9399 Repository: mesos Description --- With this option, the command can show all the tasks that have ever been run. This makes the command's behavior closer to the one of 'docker ps'. Diffs - src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107 Diff: https://reviews.apache.org/r/69395/diff/1/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok test_list_all (cli.tests.task.TestTaskPlugin) ... ok -- Ran 8 tests in 20.889s OK ``` Thanks, Armand Grillet
Review Request 69394: Updated 'mesos task list' to only display running tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69394/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9399 https://issues.apache.org/jira/browse/MESOS-9399 Repository: mesos Description --- Updated 'mesos task list' to only display running tasks. Diffs - src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107 Diff: https://reviews.apache.org/r/69394/diff/1/ Testing --- (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 19.845s OK Thanks, Armand Grillet
Review Request 69393: Displayed 'State' field when using 'mesos task list'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69393/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9399 https://issues.apache.org/jira/browse/MESOS-9399 Repository: mesos Description --- Displayed 'State' field when using 'mesos task list'. Diffs - src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107 Diff: https://reviews.apache.org/r/69393/diff/1/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 20.812s OK ``` Thanks, Armand Grillet
Review Request 69390: Added docs describing how to use the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69390/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9333 https://issues.apache.org/jira/browse/MESOS-9333 Repository: mesos Description --- The documentation describes the main commands of the CLI, how to enable it and how to build Mesos including this component. Diffs - docs/cli.md PRE-CREATION docs/home.md e05b65d55176a706c072f73904a8e0f4365a8cb2 Diff: https://reviews.apache.org/r/69390/diff/1/ Testing --- Checked the rendered Markdown code. Thanks, Armand Grillet
Review Request 69381: Updated configuration docs describing how to build the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69381/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9333 https://issues.apache.org/jira/browse/MESOS-9333 Repository: mesos Description --- Updated configuration docs describing how to build the new CLI. Diffs - docs/configuration/autotools.md 3c3c59a6343e00df16f4d0698fd61fb5ef792c1c docs/configuration/cmake.md 0cba405c53c5e2efdc7170abdafdd4a5db331804 Diff: https://reviews.apache.org/r/69381/diff/1/ Testing --- Checked the rendered Markdown code. Thanks, Armand Grillet
Review Request 69380: Added configuration docs describing how to use Python 3.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69380/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9333 https://issues.apache.org/jira/browse/MESOS-9333 Repository: mesos Description --- For Autotools, this means how to use 'PYTHON_3' and 'PYTHON_3_VERSION'. For CMake, this means how to use '-DPYTHON_3'. Diffs - docs/configuration/autotools.md 3c3c59a6343e00df16f4d0698fd61fb5ef792c1c docs/configuration/cmake.md 0cba405c53c5e2efdc7170abdafdd4a5db331804 Diff: https://reviews.apache.org/r/69380/diff/1/ Testing --- Checked the rendered Markdown code. Thanks, Armand Grillet
Review Request 69374: Updated new CLI test step to use binary created by PyInstaller.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69374/ --- Review request for mesos, Benjamin Bannier and Kevin Klues. Bugs: MESOS-9370 https://issues.apache.org/jira/browse/MESOS-9370 Repository: mesos Description --- The integration tests for the new CLI running while building Mesos now directly use the binary created during the build. That way we make sure that the binary created using PyInstaller is usable, which is the artifact that we want to distribute to users in the future. Previously, we were only activating the virtual environment to run the tests thus the binary created by PyInstaller was never properly tested. To use the binary created by PyInstaller, we simply update the PATH before running 'mesos-cli-tests'. Diffs - src/Makefile.am c17eae4ff1d019d515f67d81821e933ecb5dc190 src/python/cli_new/tests/CMakeLists.txt 19119d1d1d640c10ef4ec8e245773920359ccb75 Diff: https://reviews.apache.org/r/69374/diff/1/ Testing --- The main test for this change is to make sure that we do not rely on the `mesos` in `src/python/cli_new/bin/` anymore. To do so, I have followed these steps: For Autotools: ``` $ ./bootstrap $ mkdir build $ cd build $ ../configure --enable-new-cli $ make check $ mv /home/agrillet/mesos/src/python/cli_new/bin/mesos /home/agrillet/mesos/src/python/cli_new/bin/mesos2 $ make check ``` Then I put `/home/agrillet/mesos/src/python/cli_new/bin/mesos` back. For CMake: ``` $ ./bootstrap $ mkdir build $ cd build $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON_3=python3 $ cmake --build . --target tests $ ctest -R CLITests -V $ mv /home/agrillet/mesos/src/python/cli_new/bin/mesos /home/agrillet/mesos/src/python/cli_new/bin/mesos2 $ ctest -R CLITests -V ``` Thanks, Armand Grillet
Re: Review Request 69310: Always used absolute executable paths in parallel runner.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69310/#review210469 --- Ship it! Ship It! - Armand Grillet On Nov. 11, 2018, 1:01 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69310/ > --- > > (Updated Nov. 11, 2018, 1:01 a.m.) > > > Review request for mesos and Armand Grillet. > > > Repository: mesos > > > Description > --- > > This allows executing test which are just passed as file names, not as > relative or absolute paths. > > > Diffs > - > > support/mesos-gtest-runner.py 043f1361f92dd5f24b92c010615b76e6cf6a357a > > > Diff: https://reviews.apache.org/r/69310/diff/1/ > > > Testing > --- > > `../../../../support/mesos-gtest-runner.py stout-tests` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 69309: Explicitly constructed command line args in parallel runner.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69309/#review210467 --- Fix it, then Ship it! support/mesos-gtest-runner.py Line 72 (original), 72 (patched) <https://reviews.apache.org/r/69309/#comment295151> s/`command lint`/`command line` - Armand Grillet On Nov. 11, 2018, 1:01 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69309/ > --- > > (Updated Nov. 11, 2018, 1:01 a.m.) > > > Review request for mesos and Armand Grillet. > > > Repository: mesos > > > Description > --- > > This fixes issues with flag propagation into shards. > > > Diffs > - > > support/mesos-gtest-runner.py 043f1361f92dd5f24b92c010615b76e6cf6a357a > > > Diff: https://reviews.apache.org/r/69309/diff/1/ > > > Testing > --- > > `../support/mesos-gtest-runner.py 3rdparty/stout/tests/stout-tests` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 69275: Added environment sanity check to parallel test runner.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69275/#review210384 --- Ship it! Ship It! - Armand Grillet On Nov. 7, 2018, 10:41 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69275/ > --- > > (Updated Nov. 7, 2018, 10:41 p.m.) > > > Review request for mesos, Armand Grillet and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > This patch adds a check to the parallel test runner that catches > setups where the user is not allowed to launch many process (e.g., the > default value for `ulimit -u` on centos7). > > This can lead to test execution failures if many `mesos-tests` > instances are run in parallel on machines with many cores (by default > the parallel test runner would execute `nproc` shards which would fork > potentially multiple executable launching `nproc` libprocess worker > threads). > > > Diffs > - > > support/mesos-gtest-runner.py 9cf72af246a2fabf2cb57ed42136eeaaa1495f20 > > > Diff: https://reviews.apache.org/r/69275/diff/2/ > > > Testing > --- > > Executed `mesos-tests` in parallel with default settings. > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 69274: Reduced default oversubscription in parallel test runner.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69274/#review210376 --- Ship it! Ship It! - Armand Grillet On Nov. 7, 2018, 9:30 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69274/ > --- > > (Updated Nov. 7, 2018, 9:30 p.m.) > > > Review request for mesos, Armand Grillet and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Reduced default oversubscription in parallel test runner. > > > Diffs > - > > support/mesos-gtest-runner.py 9cf72af246a2fabf2cb57ed42136eeaaa1495f20 > > > Diff: https://reviews.apache.org/r/69274/diff/1/ > > > Testing > --- > > Executed `mesos-tests` in parallel with default settings. > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 69275: Added environment sanity check to parallel test runner.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69275/#review210375 --- Fix it, then Ship it! support/mesos-gtest-runner.py Lines 212 (patched) <https://reviews.apache.org/r/69275/#comment295044> Double space here. - Armand Grillet On Nov. 7, 2018, 9:30 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69275/ > --- > > (Updated Nov. 7, 2018, 9:30 p.m.) > > > Review request for mesos, Armand Grillet and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > This patch adds a check to the parallel test runner that catches > setups where the user is not allowed to launch many process (e.g., the > default value for `ulimit -u` on centos7). > > This can lead to test execution failures if many `mesos-tests` > instances are run in parallel on machines with many cores (by default > the parallel test runner would execute `nproc` shards which would fork > potentially multiple executable launching `nproc` libprocess worker > threads). > > > Diffs > - > > support/mesos-gtest-runner.py 9cf72af246a2fabf2cb57ed42136eeaaa1495f20 > > > Diff: https://reviews.apache.org/r/69275/diff/1/ > > > Testing > --- > > Executed `mesos-tests` in parallel with default settings. > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7.
> On Nov. 5, 2018, 9:48 p.m., Benjamin Bannier wrote: > > This issue could have been caught would there have been just rudimentary > > tests. Could you please add a test to this RR fix that? I'd imagine a test > > making sure that executing the produced binary with `--help` might already > > be sufficient. I disagree regarding the "would there have been just rudimentary tests". The issue concerns PyInstaller, not the new CLI, which depends on the operating system and Python version installed. We have integration tests but they do not require to build the CLI, this is why we have not caught the bug sooner. To do what you suggest, the best way would be to add some code to our `Makefile.am` and `src/python/cli_new/CMakeLists.txt` to check the exit status of the built binary with `--help`. I would suggest not only running this command with `make check` but also simply `make` as this guarantees the integrity of the binary. Also, we need to specify the versions of Python the CLI supports. PyInstaller tends to add compatibility after new Python releases and it is thus likely that the problem will happen again with Python 3.8. - Armand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69255/#review210335 --- On Nov. 5, 2018, 7:13 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69255/ > --- > > (Updated Nov. 5, 2018, 7:13 p.m.) > > > Review request for mesos, Benjamin Bannier and Kevin Klues. > > > Bugs: MESOS-9370 > https://issues.apache.org/jira/browse/MESOS-9370 > > > Repository: mesos > > > Description > --- > > Updated PyInstaller requirement for new CLI to support Python 3.7. > > > Diffs > - > > src/python/cli_new/pip-requirements.txt > 520dc6131cf05e8f4626a1c673be9b6a59766a8d > > > Diff: https://reviews.apache.org/r/69255/diff/1/ > > > Testing > --- > > ``` > $ ./bootstrap > $ mkdir build > $ cd build > $ PYTHON_3=python37 ../configure --enable-new-cli > $ make check > $ ./src/mesos > ``` > > > Thanks, > > Armand Grillet > >
Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69255/ --- Review request for mesos, Benjamin Bannier and Kevin Klues. Bugs: MESOS-9370 https://issues.apache.org/jira/browse/MESOS-9370 Repository: mesos Description --- Updated PyInstaller requirement for new CLI to support Python 3.7. Diffs - src/python/cli_new/pip-requirements.txt 520dc6131cf05e8f4626a1c673be9b6a59766a8d Diff: https://reviews.apache.org/r/69255/diff/1/ Testing --- ``` $ ./bootstrap $ mkdir build $ cd build $ PYTHON_3=python37 ../configure --enable-new-cli $ make check $ ./src/mesos ``` Thanks, Armand Grillet
Review Request 69237: Simplified 'test_exec' in new CLI to better manage newlines.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69237/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9341 https://issues.apache.org/jira/browse/MESOS-9341 Repository: mesos Description --- Simplified 'test_exec' in new CLI to better manage newlines. Diffs - src/python/cli_new/lib/cli/tests/task.py 4b03cf13185f1c718f24a990a75a4dd74e7e132a Diff: https://reviews.apache.org/r/69237/diff/1/ Testing --- ``` (mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... giok test_list (cli.tests.task.TestTaskPlugin) ... commiok -- Ran 7 tests in 17.531s OK ``` Thanks, Armand Grillet
Review Request 69208: Updated new CLI task attach/exec exit strategy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69208/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9363 https://issues.apache.org/jira/browse/MESOS-9363 Repository: mesos Description --- Updated new CLI task attach/exec exit strategy. Diffs - src/python/cli_new/lib/cli/mesos.py 4a5777bf712c3e5fd20a2bfd6da8fb9f3975d120 src/python/cli_new/lib/cli/plugins/task/main.py 5866a23aa0c0dfe141fd8fbe4c9ccd04a2c13a08 src/python/cli_new/lib/cli/tests/task.py 4b03cf13185f1c718f24a990a75a4dd74e7e132a Diff: https://reviews.apache.org/r/69208/diff/1/ Testing --- ``` (mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 7 tests in 17.146s OK ``` Thanks, Armand Grillet
Review Request 69207: Moved 'updated_tasks()' to new CLI tests base.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69207/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9363 https://issues.apache.org/jira/browse/MESOS-9363 Repository: mesos Description --- Moved 'updated_tasks()' to new CLI tests base. Diffs - src/python/cli_new/lib/cli/tests/base.py 7fd39af665164eeef8bb1359de340ef923dc2272 src/python/cli_new/lib/cli/tests/task.py 4b03cf13185f1c718f24a990a75a4dd74e7e132a Diff: https://reviews.apache.org/r/69207/diff/1/ Testing --- ``` (mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 6 tests in 12.429s OK ``` Thanks, Armand Grillet
Review Request 69206: Added return value to new Mesos CLI commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69206/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9363 https://issues.apache.org/jira/browse/MESOS-9363 Repository: mesos Description --- Added return value to new Mesos CLI commands. Diffs - src/python/cli_new/bin/main.py 27783caf4eab6ea18eee5a7b90b0dd368c8b4020 src/python/cli_new/lib/cli/plugins/base.py c85abd6755c4b046ab4ecbda825f3a1615fb4ce5 Diff: https://reviews.apache.org/r/69206/diff/1/ Testing --- ``` (mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 6 tests in 12.429s OK ``` Thanks, Armand Grillet
Review Request 69138: Updated 'CLI_FILES' in 'cli_new/CmakeLists.txt'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69138/ --- Review request for mesos, Benjamin Bannier and Kevin Klues. Bugs: MESOS-9350 https://issues.apache.org/jira/browse/MESOS-9350 Repository: mesos Description --- Updated 'CLI_FILES' in 'cli_new/CmakeLists.txt'. Diffs - src/python/cli_new/CMakeLists.txt 9eda91778fa174709812f9830a81c3e6d952eed2 Diff: https://reviews.apache.org/r/69138/diff/1/ Testing --- Thanks, Armand Grillet
Re: Review Request 69115: Added test for interactive 'task exec'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69115/ --- (Updated Oct. 22, 2018, 4:40 p.m.) Review request for mesos and Kevin Klues. Changes --- Fixed issues. Bugs: MESOS-9342 https://issues.apache.org/jira/browse/MESOS-9342 Repository: mesos Description --- Added test for interactive 'task exec'. Diffs (updated) - src/python/cli_new/lib/cli/tests/task.py 4b03cf13185f1c718f24a990a75a4dd74e7e132a Diff: https://reviews.apache.org/r/69115/diff/2/ Changes: https://reviews.apache.org/r/69115/diff/1-2/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-6551) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 6 tests in 12.602s OK ``` Thanks, Armand Grillet
Re: Review Request 69049: Added test for 'task exec'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69049/ --- (Updated Oct. 22, 2018, 4:13 p.m.) Review request for mesos and Kevin Klues. Changes --- Fixed issues. Bugs: MESOS-9341 https://issues.apache.org/jira/browse/MESOS-9341 Repository: mesos Description --- Added test for 'task exec'. Diffs (updated) - src/python/cli_new/lib/cli/tests/data/lorem-ipsum.txt PRE-CREATION src/python/cli_new/lib/cli/tests/task.py b54ade557f579a489e459f6022807146e0211fb0 Diff: https://reviews.apache.org/r/69049/diff/3/ Changes: https://reviews.apache.org/r/69049/diff/2-3/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-6551) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 5 tests in 8.754s OK ``` Thanks, Armand Grillet
Review Request 69119: Added new CLI constants 'TEST_DIRECTORY' and 'TEST_DATA_DIRECTORY'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69119/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9341 https://issues.apache.org/jira/browse/MESOS-9341 Repository: mesos Description --- Added new CLI constants 'TEST_DIRECTORY' and 'TEST_DATA_DIRECTORY'. Diffs - src/python/cli_new/lib/cli/tests/constants.py 1398701b167eae397730afc5b1fab6a21e723266 Diff: https://reviews.apache.org/r/69119/diff/1/ Testing --- Thanks, Armand Grillet
Re: Review Request 69049: Added test for 'task exec'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69049/ --- (Updated Oct. 22, 2018, 3:41 p.m.) Review request for mesos and Kevin Klues. Changes --- Moved test data. Bugs: MESOS-9341 https://issues.apache.org/jira/browse/MESOS-9341 Repository: mesos Description --- Added test for 'task exec'. Diffs (updated) - src/python/cli_new/lib/cli/tests/data/lorem-ipsum.txt PRE-CREATION src/python/cli_new/lib/cli/tests/task.py b54ade557f579a489e459f6022807146e0211fb0 Diff: https://reviews.apache.org/r/69049/diff/2/ Changes: https://reviews.apache.org/r/69049/diff/1-2/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-6551) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 5 tests in 8.754s OK ``` Thanks, Armand Grillet
Re: Review Request 69114: Added 'exec_command' to test util functions for the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69114/ --- (Updated Oct. 22, 2018, 3:26 p.m.) Review request for mesos and Kevin Klues. Changes --- Fixed issues. Bugs: MESOS-9341 https://issues.apache.org/jira/browse/MESOS-9341 Repository: mesos Description (updated) --- This code was mostly pulled directly from: https://github.com/dcos/dcos-core-cli/blob/ 7fd55421939a7782c237e2b8719c0fe2f543acd7/ python/lib/dcoscli/dcoscli/test/common.py This function will be used by tests that do not return a specific output but an error code, stdout, and stderr. This will be the case for tests concerning the 'task exec' and 'task attach' subcommands. Diffs (updated) - src/python/cli_new/lib/cli/tests/base.py 3fb471c1f49e930d908322055bb9a188f88ee602 Diff: https://reviews.apache.org/r/69114/diff/2/ Changes: https://reviews.apache.org/r/69114/diff/1-2/ Testing --- Tested later in the chain. Thanks, Armand Grillet
Review Request 69116: Added 'popen_tty' to test util functions for the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9343 https://issues.apache.org/jira/browse/MESOS-9343 Repository: mesos Description --- This code was pulled directly from: https://github.com/dcos/dcos-core-cli/blob/ 7fd55421939a7782c237e2b8719c0fe2f543acd7/ python/lib/dcoscli/dcoscli/test/common.py This function will be used by tests requiring a TTY. This will be the case for tests concerning the 'task attach' subcommand. Diffs - src/python/cli_new/lib/cli/tests/base.py 3fb471c1f49e930d908322055bb9a188f88ee602 Diff: https://reviews.apache.org/r/69116/diff/1/ Testing --- Thanks, Armand Grillet
Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/#review209845 --- Ship it! Ship It! - Armand Grillet On Oct. 22, 2018, 1:22 p.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69075/ > --- > > (Updated Oct. 22, 2018, 1:22 p.m.) > > > Review request for mesos, Alexander Rukletsov, Armand Grillet, Jie Yu, and > James Peach. > > > Bugs: MESOS-8907 > https://issues.apache.org/jira/browse/MESOS-8907 > > > Repository: mesos > > > Description > --- > > Modifies the 'curl' invocation that is returning an http::Response, > locking it into HTTP 1.x. Our current HTTP parser is unable to process > HTTP 2 responses. > > With the advent of curl 7.47, HTTPS connections are being enforced > towards HTTP 2 rather aggressively. As a result, our image fetcher > fails when recent curl versions are being used for pulling images from > a registry that supports HTTP 2. > > HTTP 1.1 is chosen as long as the underlying curl supports the > '--http1.1' flag. If curl does not support that flag, fall back to > using HTTP 1.0. > > For allowing all the benefits of HTTP 2 where possible, we do not > adapt any 'curl' invocations that do not attempt to parse headers. > > > Diffs > - > > src/uri/fetchers/docker.cpp 6b1277f822dcf80d44daa8133b3ecc8c9a34ef07 > > > Diff: https://reviews.apache.org/r/69075/diff/3/ > > > Testing > --- > > `make check` > `sudo ./bin/mesos-tests.sh > --gtest_filter="ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2"` > on a system with curl 7.59.0 installed. > > > Thanks, > > Till Toenshoff > >
Review Request 69115: Added test for interactive 'task exec'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69115/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9342 https://issues.apache.org/jira/browse/MESOS-9342 Repository: mesos Description --- Added test for interactive 'task exec'. Diffs - src/python/cli_new/lib/cli/tests/task.py b54ade557f579a489e459f6022807146e0211fb0 Diff: https://reviews.apache.org/r/69115/diff/1/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-6551) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 6 tests in 12.602s OK ``` Thanks, Armand Grillet
Review Request 69049: Added test for 'task exec'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69049/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9341 https://issues.apache.org/jira/browse/MESOS-9341 Repository: mesos Description --- Added test for 'task exec'. Diffs - src/python/cli_new/lib/cli/tests/data/task/lorem-ipsum.txt PRE-CREATION src/python/cli_new/lib/cli/tests/task.py b54ade557f579a489e459f6022807146e0211fb0 Diff: https://reviews.apache.org/r/69049/diff/1/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-6551) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_exec (cli.tests.task.TestTaskPlugin) ... ok test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 5 tests in 8.754s OK ``` Thanks, Armand Grillet
Review Request 69048: Added tenacity to 'pip-requirements' for new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69048/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9341 https://issues.apache.org/jira/browse/MESOS-9341 Repository: mesos Description --- This requirement will be used in upcoming new CLI integration tests. Diffs - src/python/cli_new/pip-requirements.txt dfbc28fb041b5cdf6bf9440fab0730eab0a4c162 Diff: https://reviews.apache.org/r/69048/diff/1/ Testing --- Tested later in the chain. Thanks, Armand Grillet
Review Request 69114: Added 'exec_command' to test util functions for the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69114/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9341 https://issues.apache.org/jira/browse/MESOS-9341 Repository: mesos Description --- This code was pulled directly from: https://github.com/dcos/dcos-core-cli/blob/ 7fd55421939a7782c237e2b8719c0fe2f543acd7/ python/lib/dcoscli/dcoscli/test/common.py This function will be used by tests that do not return a specific output but an error code, stdout, and stderr. This will be the case for tests concerning the 'task exec' and 'task attach' subcommands. Diffs - src/python/cli_new/lib/cli/tests/base.py 3fb471c1f49e930d908322055bb9a188f88ee602 Diff: https://reviews.apache.org/r/69114/diff/1/ Testing --- Tested later in the chain. Thanks, Armand Grillet
Review Request 69105: Added 'task atach' subcommand to new CLI.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69105/
---
Review request for mesos and Kevin Klues.
Bugs: MESOS-6551
https://issues.apache.org/jira/browse/MESOS-6551
Repository: mesos
Description
---
Added 'task atach' subcommand to new CLI.
Diffs
-
src/python/cli_new/lib/cli/plugins/task/main.py
546ad00ee88fa51c54520a94da19752d010004a8
Diff: https://reviews.apache.org/r/69105/diff/1/
Testing
---
```
$ sudo bin/mesos-master.sh \
--ip=127.0.0.1 \
--work_dir=/var/lib/mesos
$ sudo bin/mesos-agent.sh
--master=127.0.0.1:5050 \
--work_dir=/var/lib/mesos \
--image_providers=docker \
--executor_environment_variables="{}" \
--isolation="cgroups/all,filesystem/linux,docker/runtime,namespaces/pid"
$ sudo src/mesos-execute \
--master=127.0.0.1:5050 \
--name=tty-test \
--docker_image=library/alpine \
--no-shell \
--tty \
--command="sh -i"
$ cd src/python/cli_new
$ source activate
$ mesos task attach tty-test
sh-4.3$
```
Thanks,
Armand Grillet
Re: Review Request 69104: Fixed formatting in subcommand help in the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69104/#review209821 --- Ship it! Ship It! - Armand Grillet On oct. 20, 2018, 11:30 matin, Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69104/ > --- > > (Updated oct. 20, 2018, 11:30 matin) > > > Review request for mesos and Armand Grillet. > > > Repository: mesos > > > Description > --- > > Previously, there was some weird formatting with extra newlines when > providing multi-line 'long_help' strings or extra flags to the > subcommands. This commit fixes that. > > > Diffs > - > > src/python/cli_new/lib/cli/util.py 6a012369fa151ffd6b73a071342073a55ef9cc6b > > > Diff: https://reviews.apache.org/r/69104/diff/1/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >
Re: Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69103/#review209820 --- Ship it! Ship It! - Armand Grillet On Oct. 20, 2018, 10:57 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69103/ > --- > > (Updated Oct. 20, 2018, 10:57 a.m.) > > > Review request for mesos, Armand Grillet, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-8978 > https://issues.apache.org/jira/browse/MESOS-8978 > > > Repository: mesos > > > Description > --- > > Previously, we could only launch tasks using the '--tty' flag if they > had a backing docker image (or some other combination of other flags set > that would cause the task to have a 'containerInfo' created for it). > > This commit makes sure that if '--tty' is passed, that a containerInfo > gets created and its TTYInfo field gets populated. > > > Diffs > - > > src/cli/execute.cpp eb5c5646ed84533d39ad2588c78f1c0caa5fccfb > > > Diff: https://reviews.apache.org/r/69103/diff/1/ > > > Testing > --- > > sudo bin/mesos-master.sh \ > --ip=127.0.0.1 \ > --work_dir=/var/lib/mesos > > > sudo bin/mesos-agent.sh > --master=127.0.0.1:5050 \ > --work_dir=/var/lib/mesos > > > sudo src/mesos-execute \ > --master=127.0.0.1:5050 \ > --name=tty-test \ > --tty \ > --command="sh -i" > > > Thanks, > > Kevin Klues > >
Review Request 69084: Updated 'Makefile.am' to make new CLI build step more reliable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69084/ --- Review request for mesos, Benjamin Bannier and Kevin Klues. Repository: mesos Description --- We list the files in 'MESOS_CLI_SRCDIR' when building the new CLI. We were previously using 'find' and then removing the files in the virtual environment but this is not enough as we now also use tools like 'tox' which creates files we do not care about. To filter more while simplifying the build step, we now use 'git ls-files' to get a list of the files we need when building. Git is a dependency of Apache Mesos and the files we have in the repository are the only ones required to build the CLI, making this solution simpler yet more future-proof. Diffs - src/Makefile.am 5795c7097a9ed1f659e169ad81a9f2c09481aa81 Diff: https://reviews.apache.org/r/69084/diff/1/ Testing --- ``` $ ./bootstrap $ mkdir build $ cd build $ ../configure --enable-new-cli --disable-java --disable-python $ make check $ ./src/mesos Mesos CLI ... ``` Thanks, Armand Grillet
Re: Review Request 68977: Added Record-IO encoder and decoder to Python library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68977/ --- (Updated Okt. 16, 2018, 12:35 nachm.) Review request for mesos and Kevin Klues. Changes --- Updated test instructions Bugs: MESOS-6551 https://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description --- Added Record-IO encoder and decoder to Python library. This code was pulled directly from: https://github.com/dcos/dcos-core-cli/blob/7fd55421939a7782c237e2b8719c0fe2f543acd7/python/lib/dcos/dcos/recordio.py https://github.com/dcos/dcos-core-cli/blob/7fd55421939a7782c237e2b8719c0fe2f543acd7/python/lib/dcos/tests/test_recordio.py It will be used by the new CLI for commands such as `task exec`. Diffs - src/python/lib/mesos/__init__.py 40219c5e03915754b61fc5d7263a063f0d18cca1 src/python/lib/mesos/recordio.py PRE-CREATION src/python/lib/tests/test_recordio.py PRE-CREATION Diff: https://reviews.apache.org/r/68977/diff/4/ Testing (updated) --- ``` $ tox -e py3-test -- -vvv -k test_recordio py3-test installed: atomicwrites==1.2.1,attrs==18.2.0,certifi==2018.10.15,chardet==3.0.4,coverage==4.5.1,idna==2.7,mock==2.0.0,more-itertools==4.3.0,pbr==4.3.0,pluggy==0.8.0,py==1.7.0,pytest==3.7.3,pytest-cov==2.5.1,requests==2.19.1,six==1.11.0,tenacity==4.12.0,ujson==1.35,urllib3==1.23 py3-test runtests: PYTHONHASHSEED='3750347574' py3-test runtests: commands[0] | py.test -vvv -k test_recordio test session starts platform linux -- Python 3.6.2, pytest-3.7.3, py-1.7.0, pluggy-0.8.0 -- /home/mesosphere.com/klueska/mesos/src/python/lib/.tox/py3-test/bin/python3 cachedir: .pytest_cache rootdir: /home/mesosphere.com/klueska/mesos/src/python/lib, inifile: plugins: cov-2.5.1 collected 26 items / 24 deselected tests/test_recordio.py::test_encode PASSED [ 50%] tests/test_recordio.py::test_encode_decode PASSED [100%] == 2 passed, 24 deselected in 0.18 seconds == __ summary __ py3-test: commands succeeded congratulations :) ``` Thanks, Armand Grillet
Re: Review Request 68977: Added Record-IO encoder and decoder to Python library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68977/ --- (Updated Okt. 16, 2018, 12:16 nachm.) Review request for mesos and Kevin Klues. Changes --- Changed description Bugs: MESOS-6551 https://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description (updated) --- Added Record-IO encoder and decoder to Python library. This code was pulled directly from: https://github.com/dcos/dcos-core-cli/blob/7fd55421939a7782c237e2b8719c0fe2f543acd7/python/lib/dcos/dcos/recordio.py https://github.com/dcos/dcos-core-cli/blob/7fd55421939a7782c237e2b8719c0fe2f543acd7/python/lib/dcos/tests/test_recordio.py It will be used by the new CLI for commands such as `task exec`. Diffs - src/python/lib/mesos/__init__.py 40219c5e03915754b61fc5d7263a063f0d18cca1 src/python/lib/mesos/recordio.py PRE-CREATION src/python/lib/tests/test_recordio.py PRE-CREATION Diff: https://reviews.apache.org/r/68977/diff/4/ Testing --- ``` (mesos-cli) ? python (MESOS-6551) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestRecordIO test_encode (cli.tests.recordio.TestRecordIO) ... ok test_encode_decode (cli.tests.recordio.TestRecordIO) ... ok TestTaskPlugin test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 6 tests in 5.008s OK ``` Thanks, Armand Grillet
Re: Review Request 68971: Moved import of '../lib' from new CLI bootstrap to pip-requirements.txt.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68971/ --- (Updated Oct. 16, 2018, 1:33 p.m.) Review request for mesos and Kevin Klues. Changes --- Rebased. Bugs: MESOS-6551 https://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description (updated) --- This adds the Mesos Python package to the requirements needed by the new CLI. We were previously adding the path to the package when setting up the CLI virtual environment but this does not work with Pylint when it is run from the linters virtual environment. By setting things in `pip-requirements.txt`, Pylint does not report inexisting linting errors when doing imports such as `import mesos`. Diffs (updated) - src/python/cli_new/bootstrap a6183d4c28281bf6d29c8b7f825ae474056f027b src/python/cli_new/pip-requirements.txt d1822bf752ce76aa5da5999057fe1efb83747fd0 Diff: https://reviews.apache.org/r/68971/diff/3/ Changes: https://reviews.apache.org/r/68971/diff/2-3/ Testing --- Updated the agent plugin to do `from mesos.exceptions import MesosException` and use `MesosException`. Commited to see the git hook running and saw the error `E0401: Unable to import 'mesos.exceptions' (import-error).`. Updated `support/pylint.config`, run the git hook again and saw that the error was gone. Thanks, Armand Grillet
Review Request 69047: Updated Python library to be easier to handle as a Python module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69047/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-8795 https://issues.apache.org/jira/browse/MESOS-8795 Repository: mesos Description --- Updated Python library to be easier to handle as a Python module. Diffs - src/python/lib/mesos/__init__.py 40219c5e03915754b61fc5d7263a063f0d18cca1 src/python/lib/setup.py 08f854f43681d1f694bb48604773256be7ce927b Diff: https://reviews.apache.org/r/69047/diff/1/ Testing --- Thanks, Armand Grillet
Review Request 69026: Changed usage documentation for new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69026/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6551 https://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description --- Moved the `[options]` in the usage documentation to where they should be set when using the CLI. Diffs - src/python/cli_new/lib/cli/plugins/base.py 6cba828d886dcc2e1d0a00514f62d87634aafe9e Diff: https://reviews.apache.org/r/69026/diff/1/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-6551) ? mesos task Interacts with the tasks running in a Mesos cluster Usage: mesos task (-h | --help) mesos task --version mesos task (-h | --help) mesos task [options] [...] Options: -h --help Show this screen. --version Show version info. Commands: exec Execute commands in a task's container list List all active tasks in a Mesos cluster ``` And: ``` (mesos-cli) ? cli_new (MESOS-6551) ? mesos task exec Execute commands in a task's container Usage: mesos task exec (-h | --help) mesos task exec --version mesos task exec [options] [...] Options: -h --help Show this screen. -i --interactive interactive [default: False] -t --tty tty [default: False] Description: Execute commands in a task's container ``` Thanks, Armand Grillet
Re: Review Request 68978: Added TaskIO object to new CLI for `task exec` and `task attach`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68978/ --- (Updated Oct. 15, 2018, 1:06 p.m.) Review request for mesos and Kevin Klues. Changes --- Rebased. Bugs: MESOS-6551 https://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description --- Added TaskIO object to new CLI for `task exec` and `task attach`. Diffs (updated) - src/python/cli_new/lib/cli/mesos.py 7cf84bcf1d327bc9c63934e371692cef989ad3aa Diff: https://reviews.apache.org/r/68978/diff/5/ Changes: https://reviews.apache.org/r/68978/diff/4-5/ Testing --- Thanks, Armand Grillet
Review Request 69023: Added `retry` argument to `request()` method for Resource object.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69023/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6551 https://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description --- This allows us to do requests without using `tenacity.retry()` which is useful when streaming data. Diffs - src/python/lib/mesos/http.py cd1587797db7d75c6b839851f0f3e5671269307c Diff: https://reviews.apache.org/r/69023/diff/1/ Testing --- Used `task exec` successfully later in this chain. Tests suite of the lib still passing. Thanks, Armand Grillet
Re: Review Request 69003: Added `task exec` to new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69003/ --- (Updated Oct. 15, 2018, 8:53 a.m.) Review request for mesos and Kevin Klues. Changes --- Fixed issues. Bugs: MESOS-6551 https://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description --- Added `task exec` to new CLI. Diffs (updated) - src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251 Diff: https://reviews.apache.org/r/69003/diff/4/ Changes: https://reviews.apache.org/r/69003/diff/3-4/ Testing --- Only tested manually at the moment. ``` $ mesos task exec --interactive --tty vi $ mesos task exec -it bash $ mesos task exec cat stderr $ echo "hello" | mesos task exec --interactive cat ``` Thanks, Armand Grillet
Review Request 69007: Added `get_container_id` to util functions for the new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69007/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6551 https://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description --- This function will be used by the `TaskIO` object to know which container to use in order to run `task attach` and `task exec.`. Diffs - src/python/cli_new/lib/cli/mesos.py 7cf84bcf1d327bc9c63934e371692cef989ad3aa Diff: https://reviews.apache.org/r/69007/diff/1/ Testing --- Thanks, Armand Grillet
Re: Review Request 69003: Added `task exec` to new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69003/ --- (Updated oct. 12, 2018, 11:18 après-midi) Review request for mesos and Kevin Klues. Changes --- Added arguments. Summary (updated) - Added `task exec` to new CLI. Bugs: MESOS-6551 https://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description (updated) --- Added `task exec` to new CLI. Diffs (updated) - src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251 Diff: https://reviews.apache.org/r/69003/diff/2/ Changes: https://reviews.apache.org/r/69003/diff/1-2/ Testing (updated) --- Only tested manually at the moment. Thanks, Armand Grillet
Re: Review Request 68977: Added Record-IO encoder and decoder to new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68977/ --- (Updated oct. 12, 2018, 11:16 après-midi) Review request for mesos and Kevin Klues. Changes --- Added tests. Bugs: MESOS-6551 https://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description --- Added Record-IO encoder and decoder to new CLI. Diffs (updated) - src/python/cli_new/lib/cli/recordio.py PRE-CREATION src/python/cli_new/lib/cli/tests/__init__.py 144cb338e9453c7f68d74a58620ee9d2345e363d src/python/cli_new/lib/cli/tests/recordio.py PRE-CREATION src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6 Diff: https://reviews.apache.org/r/68977/diff/3/ Changes: https://reviews.apache.org/r/68977/diff/2-3/ Testing (updated) --- ``` (mesos-cli) ? python (MESOS-6551) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestRecordIO test_encode (cli.tests.recordio.TestRecordIO) ... ok test_encode_decode (cli.tests.recordio.TestRecordIO) ... ok TestTaskPlugin test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 6 tests in 5.008s OK ``` Thanks, Armand Grillet
Review Request 69003: WIP: Added `task exec` to new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69003/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6551 https://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description --- WIP: Added `task exec` to new CLI. Diffs - src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251 Diff: https://reviews.apache.org/r/69003/diff/1/ Testing --- Thanks, Armand Grillet
Review Request 68978: Added TaskIO object to new CLI for `task exec` and `task attach`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68978/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6551 https://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description --- Added TaskIO object to new CLI for `task exec` and `task attach`. Diffs - src/python/cli_new/lib/cli/mesos.py 7cf84bcf1d327bc9c63934e371692cef989ad3aa Diff: https://reviews.apache.org/r/68978/diff/1/ Testing --- Thanks, Armand Grillet
Review Request 68977: Added Record-IO encoder and decoder to new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68977/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6551 https://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description --- Added Record-IO encoder and decoder to new CLI. Diffs - src/python/cli_new/lib/cli/recordio.py PRE-CREATION Diff: https://reviews.apache.org/r/68977/diff/1/ Testing --- Thanks, Armand Grillet
Review Request 68976: Added `post()` function to new CLI for interacting with the HTTP API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68976/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6551 https://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description --- Added `post()` function to new CLI for interacting with the HTTP API. Diffs - src/python/lib/mesos/http.py cd1587797db7d75c6b839851f0f3e5671269307c Diff: https://reviews.apache.org/r/68976/diff/1/ Testing --- Thanks, Armand Grillet
Review Request 68971: Added pylint init-hook to add Mesos library to `PYTHONPATH`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68971/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6551 https://issues.apache.org/jira/browse/MESOS-6551 Repository: mesos Description --- Without this change, adding `from mesos.exceptions import MesosException` to a file in the new CLI returns `E0401: Unable to import 'mesos.exceptions' (import-error)`. This is because the Mesos library is a local module that we need to add to the `PYTHONPATH`. This is already done when using the virtual environment of the new CLI and we now also do it when linting. Diffs - support/pylint.config af25dd90cb2d467c688ea4b060dc4640040a068b Diff: https://reviews.apache.org/r/68971/diff/1/ Testing --- Updated the agent plugin to do `from mesos.exceptions import MesosException` and use `MesosException`. Commited to see the git hook running and saw the error `E0401: Unable to import 'mesos.exceptions' (import-error).`. Updated `support/pylint.config`, run the git hook again and saw that the error was gone. Thanks, Armand Grillet
Review Request 68970: Fixed JSON object type error when using `support/apply-reviews.py`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68970/ --- Review request for mesos, Till Toenshoff and Vinod Kone. Bugs: MESOS-9253 https://issues.apache.org/jira/browse/MESOS-9253 Repository: mesos Description --- The error `TypeError: the JSON object must be str, not 'bytes'` was visible when using `support/apply-reviews.py` in our CI. This issue seems to only happen in old versions of Python 3 that are not supported but the fix works with any version of Python 3 and allows us to not change the Python interpreter used by reviewbot. Diffs - support/apply-reviews.py 92ad85945fb97e6ae3e21b3b9ab53c885158417e Diff: https://reviews.apache.org/r/68970/diff/1/ Testing --- Added the line `print(type(json_str))` in `def url_to_json(url):` to verify that the type was now a `str` and not a `http.client.HTTPResponse`. Thanks, Armand Grillet
Re: Review Request 68965: Added try/catch statements when using Mesos util functions in new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68965/ --- (Updated Oct. 9, 2018, 4:18 p.m.) Review request for mesos and Kevin Klues. Changes --- Updated caller to print info about master. Bugs: MESOS-8795 https://issues.apache.org/jira/browse/MESOS-8795 Repository: mesos Description --- Added try/catch statements when using Mesos util functions in new CLI. Diffs (updated) - src/python/cli_new/lib/cli/mesos.py 7cf84bcf1d327bc9c63934e371692cef989ad3aa src/python/cli_new/lib/cli/plugins/agent/main.py 5e821b36162cea8183f233a86181144daeca0753 src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251 Diff: https://reviews.apache.org/r/68965/diff/2/ Changes: https://reviews.apache.org/r/68965/diff/1-2/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-8795) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 4 tests in 5.350s OK ``` Thanks, Armand Grillet
Review Request 68965: Added try/catch statements when using Mesos util functions in new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68965/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-8795 https://issues.apache.org/jira/browse/MESOS-8795 Repository: mesos Description --- Added try/catch statements when using Mesos util functions in new CLI. Diffs - src/python/cli_new/lib/cli/plugins/agent/main.py 5e821b36162cea8183f233a86181144daeca0753 src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251 Diff: https://reviews.apache.org/r/68965/diff/1/ Testing --- ``` (mesos-cli) ? cli_new (MESOS-8795) ? mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_list (cli.tests.task.TestTaskPlugin) ... ok -- Ran 4 tests in 5.350s OK ``` Thanks, Armand Grillet
Re: Review Request 66683: Updated address sanitization in new CLI to accept DNS names.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/ --- (Updated Oct. 9, 2018, 2:49 p.m.) Review request for mesos and Kevin Klues. Changes --- Removed `master_address` variable and moved function. Bugs: MESOS-8025 https://issues.apache.org/jira/browse/MESOS-8025 Repository: mesos Description --- Updated address sanitization in new CLI to accept DNS names. Diffs (updated) - src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a Diff: https://reviews.apache.org/r/66683/diff/7/ Changes: https://reviews.apache.org/r/66683/diff/6-7/ Testing --- Ran `mesos agent list` successfully with config: ``` [master] address = "http://.com:5061" ``` On the server providing `http://.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. Also ran `mesos-cli-tests` successfully. Thanks, Armand Grillet
Re: Review Request 66683: Updated address sanitization in new CLI to accept DNS names.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/ --- (Updated Oct. 9, 2018, 2:16 p.m.) Review request for mesos and Kevin Klues. Changes --- Published Kevin's review request. Bugs: MESOS-8025 https://issues.apache.org/jira/browse/MESOS-8025 Repository: mesos Description --- Updated address sanitization in new CLI to accept DNS names. Diffs (updated) - src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a Diff: https://reviews.apache.org/r/66683/diff/6/ Changes: https://reviews.apache.org/r/66683/diff/5-6/ Testing --- Ran `mesos agent list` successfully with config: ``` [master] address = "http://.com:5061" ``` On the server providing `http://.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. Also ran `mesos-cli-tests` successfully. Thanks, Armand Grillet
Re: Review Request 66683: Updated address sanitization in new CLI to accept DNS names.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/ --- (Updated Oct. 9, 2018, 11:37 a.m.) Review request for mesos and Kevin Klues. Summary (updated) - Updated address sanitization in new CLI to accept DNS names. Bugs: MESOS-8025 https://issues.apache.org/jira/browse/MESOS-8025 Repository: mesos Description (updated) --- Updated address sanitization in new CLI to accept DNS names. Diffs (updated) - src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a Diff: https://reviews.apache.org/r/66683/diff/5/ Changes: https://reviews.apache.org/r/66683/diff/4-5/ Testing --- Ran `mesos agent list` successfully with config: ``` [master] address = "http://.com:5061" ``` On the server providing `http://.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. Also ran `mesos-cli-tests` successfully. Thanks, Armand Grillet
Re: Review Request 68951: Updated verify-reviews.py to use current interpreter in subprocesses.
> On Oct. 8, 2018, 8:12 p.m., Till Toenshoff wrote:
> > support/verify-reviews.py
> > Line 97 (original), 97 (patched)
> > <https://reviews.apache.org/r/68951/diff/1/?file=2095334#file2095334line97>
> >
> > IIUC, then `sys.executable` may be `None`. Shall we guard against that?
As described in https://docs.python.org/3/library/sys.html#sys.executable: "If
Python is unable to retrieve the real path to its executable, sys.executable
will be an empty string or None.".
In the first case, "", the shebang in the first line of
`support/apply-reviews.py`
(https://github.com/apache/mesos/blob/8375e426d1c07f625ee18cd439e0dd4f1dc804c5/support/apply-reviews.py#L1)
will make us use Python 3 AFAIK.
The reason why I set the current interpreter instead of nothing is that a user
might specify an interpreter when running `support/apply-reviews.py`. This is
not the first time we do this in our support scripts:
https://github.com/apache/mesos/blob/8375e426d1c07f625ee18cd439e0dd4f1dc804c5/support/mesos-style.py#L291
- Armand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68951/#review209317
-----------
On Oct. 8, 2018, 8:06 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68951/
> ---
>
> (Updated Oct. 8, 2018, 8:06 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Bugs: MESOS-9253
> https://issues.apache.org/jira/browse/MESOS-9253
>
>
> Repository: mesos
>
>
> Description
> ---
>
> This changes the command used in `support/verify-reviews.py` when
> running `support/apply-reviews.py` as a subprocess. It was previously
> `"python"`, which is generally Python 2, and is now `sys.executable`.
>
> That way, if verify-reviews.py is run with Python 3 (as it should),
> apply-reviews.py will be run with the same Python 3 interpreter. This
> should fix the `ImportError` issues we have recently seen in our CI.
>
>
> Diffs
> -
>
> support/verify-reviews.py 56321ae65b38a1c62f5589b6a8aaa3993fa3dd5f
>
>
> Diff: https://reviews.apache.org/r/68951/diff/1/
>
>
> Testing
> ---
>
> I have created a simple `test.py` file to check that the interpreter was
> correctly found:
>
> ```
> import sys
>
>
> def apply_review(review_id):
> """Apply a review using the script apply-reviews.py."""
> print("Applying review %s" % review_id)
> print("%s support/apply-reviews.py -n -r %s" % (sys.executable,
> review_id))
>
> apply_review(1337)
> apply_review("1337")
> ```
>
> In both cases, `python3 test.py` prints `/usr/local/bin/python3
> support/apply-reviews.py -n -r 1337` which is what I expected.
>
>
> Thanks,
>
> Armand Grillet
>
>
Review Request 68951: Updated verify-reviews.py to use current interpreter in subprocesses.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68951/
---
Review request for mesos, Till Toenshoff and Vinod Kone.
Bugs: MESOS-9253
https://issues.apache.org/jira/browse/MESOS-9253
Repository: mesos
Description
---
This changes the command used in `support/verify-reviews.py` when
running `support/apply-reviews.py` as a subprocess. It was previously
`"python"`, which is generally Python 2, and is now `sys.executable`.
That way, if verify-reviews.py is run with Python 3 (as it should),
apply-reviews.py will be run with the same Python 3 interpreter. This
should fix the `ImportError` issues we have recently seen in our CI.
Diffs
-
support/verify-reviews.py 56321ae65b38a1c62f5589b6a8aaa3993fa3dd5f
Diff: https://reviews.apache.org/r/68951/diff/1/
Testing
---
I have created a simple `test.py` file to check that the interpreter was
correctly found:
```
import sys
def apply_review(review_id):
"""Apply a review using the script apply-reviews.py."""
print("Applying review %s" % review_id)
print("%s support/apply-reviews.py -n -r %s" % (sys.executable, review_id))
apply_review(1337)
apply_review("1337")
```
In both cases, `python3 test.py` prints `/usr/local/bin/python3
support/apply-reviews.py -n -r 1337` which is what I expected.
Thanks,
Armand Grillet
Re: Review Request 68711: Added `task ls` command to new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68711/ --- (Updated Oct. 8, 2018, 3:09 p.m.) Review request for mesos, Eric Chung and Kevin Klues. Changes --- Rebased. Bugs: MESOS-8795 https://issues.apache.org/jira/browse/MESOS-8795 Repository: mesos Description --- Added `task ls` command to new CLI. Diffs (updated) - src/python/cli_new/lib/cli/mesos.py 068d694fb6407565003c9b65a71c2b1f7fb70c77 src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251 src/python/cli_new/lib/cli/tests/task.py b54ade557f579a489e459f6022807146e0211fb0 Diff: https://reviews.apache.org/r/68711/diff/7/ Changes: https://reviews.apache.org/r/68711/diff/6-7/ Testing --- Tested manually and: ``` (mesos-cli) bash-3.2$ mesos-cli-tests Running the Mesos CLI unit tests TestAgentPlugin test_list (cli.tests.agent.TestAgentPlugin) ... ok TestInfrastructure test_capture_output (cli.tests.tests.TestInfrastructure) ... ok test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok TestTaskPlugin test_list (cli.tests.task.TestTaskPlugin) ... ok test_ls (cli.tests.task.TestTaskPlugin) ... ok -- Ran 5 tests in 9.656s OK ``` Thanks, Armand Grillet
Review Request 68950: Moved `get_agent_address` from `util.py` to `mesos.py` in new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68950/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-8795 https://issues.apache.org/jira/browse/MESOS-8795 Repository: mesos Description --- Moved `get_agent_address` from `util.py` to `mesos.py` in new CLI. Diffs - src/python/cli_new/lib/cli/mesos.py 068d694fb6407565003c9b65a71c2b1f7fb70c77 src/python/cli_new/lib/cli/util.py 7cec7e49ab3c0926067626f5bd5dbba8bf4f44d7 Diff: https://reviews.apache.org/r/68950/diff/1/ Testing --- ``` $ mesos-cli-tests ``` Thanks, Armand Grillet
Review Request 68949: Removed unused `lib/cli/tasks.py` for new CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68949/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-8795 https://issues.apache.org/jira/browse/MESOS-8795 Repository: mesos Description --- Removed unused `lib/cli/tasks.py` for new CLI. Diffs - src/python/cli_new/lib/cli/tasks.py 531e001552ff68e10b2ff81e0e40d857681eb2a9 Diff: https://reviews.apache.org/r/68949/diff/1/ Testing --- ``` $ mesos-cli-tests ``` Thanks, Armand Grillet
Review Request 68939: Updated cpplint.py to be less verbose when there is no linting issue.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68939/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9056 https://issues.apache.org/jira/browse/MESOS-9056 Repository: mesos Description --- Updated cpplint.py to be less verbose when there is no linting issue. Diffs - support/cpplint.patch 30778d9cfcf3c884b7f7d3d4c811631a1d8d182b support/cpplint.py c5a45f7608d7d41bd9fc1b03640c418ecf31e534 Diff: https://reviews.apache.org/r/68939/diff/1/ Testing --- ``` ? apache-mesos (MESOS-9056) ? python3 support/apply-reviews.py -r 68813 2018-10-05 17:25:01 URL:https://reviews.apache.org/r/68813/diff/raw/ [1604/1604] -> "68813.patch" [1] Checking 1 C++ file Done processing 3rdparty/stout/include/stout/option.hpp [MESOS-9056 6b57b1bcd] Added support for `Option` / `Option`. Author: Benjamin Mahler 1 file changed, 44 insertions(+) ``` The updated `cpplint.patch` has been created using `git diff`. Thanks, Armand Grillet
Review Request 68937: Removed output in mesos-style.py when linting goes well.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68937/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9056 https://issues.apache.org/jira/browse/MESOS-9056 Repository: mesos Description --- Removed output in mesos-style.py when linting goes well. Diffs - support/mesos-style.py 4fea6721e8e2cff37e41815c9e434b7c8740bcf8 Diff: https://reviews.apache.org/r/68937/diff/1/ Testing --- Posted this review request, which uses the script due to the Git hook: ``` ? apache-mesos (MESOS-9056) ? git commit -m "Removed output in mesos-style.py when linting goes well." Checking 1 Python file [MESOS-9056 a0c5c6568] Removed output in mesos-style.py when linting goes well. 1 file changed, 3 insertions(+), 3 deletions(-) ``` Thanks, Armand Grillet
Re: Review Request 66683: Updated address field of new CLI config to accept URLs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/ --- (Updated Oct. 5, 2018, 11:59 a.m.) Review request for mesos and Kevin Klues. Changes --- Rebased. Bugs: MESOS-8025 https://issues.apache.org/jira/browse/MESOS-8025 Repository: mesos Description --- Updated address field of new CLI config to accept URLs. Diffs (updated) - src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db src/python/cli_new/lib/cli/util.py 7cec7e49ab3c0926067626f5bd5dbba8bf4f44d7 Diff: https://reviews.apache.org/r/66683/diff/4/ Changes: https://reviews.apache.org/r/66683/diff/3-4/ Testing --- Ran `mesos agent list` successfully with config: ``` [master] address = "http://.com:5061" ``` On the server providing `http://.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. Also ran `mesos-cli-tests` successfully. Thanks, Armand Grillet
