Re: Review Request 72846: Corrected the example of the managed CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72846/#review221980 --- Ship it! Ship It! - Greg Mann On Sept. 9, 2020, 2:46 a.m

Re: Review Request 72845: Added doc for the `volume/csi` isolator.

say "a task with a container image". docs/isolators/csi-volume.md Lines 268-269 (patched) <https://reviews.apache.org/r/72845/#comment311056> s/and `container_path` is a relative path/and a relative `container_path`/ The same for the other similar occurrences in th

Re: Review Request 72888: Inferred CSI volume's `readonly` field from volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72888/#review221971 --- Ship it! Ship It! - Greg Mann On Sept. 19, 2020, 8:05 a.m

Re: Review Request 72830: Added a regression test for MESOS-9609.

ent to explain the need for the clock operations here and below? - Greg Mann On Sept. 8, 2020, 11:49 p.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 72832: Avoided unnecessary [] map operators in the master.

(patched) <https://reviews.apache.org/r/72832/#comment310907> Should we use `CHECK_NOTNULL` here instead? - Greg Mann On Sept. 8, 2020, 11:47 p.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 72831: Fixed a CHECK failure in master during agent removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72831/#review221819 --- Ship it! Ship It! - Greg Mann On Sept. 8, 2020, 11:48 p.m

Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.

since I wasn't able to synchronize it correctly. - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72806/#review221801 ----

Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.

Testing --- `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"` Thanks, Greg Mann

Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.

t for mesos and Qian Zhang. > > > Repository: mesos > > > Description > --- > > Added tests for 'volume/csi' isolator recovery. > > > Diffs > - > > src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/72806/diff/7/ > > > Testing > --- > > `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"` > > > Thanks, > > Greg Mann > >

Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.

Testing --- `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"` Thanks, Greg Mann

Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.

Testing --- `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"` Thanks, Greg Mann

Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.

Testing --- `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"` Thanks, Greg Mann

Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.

Testing --- `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"` Thanks, Greg Mann

Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

ts here, we need to pull Docker > > image `alpine` from Docker Hub, right? Then I think we need to include the > > prefix `INTERNET_CURL_` in the test name. > > Greg Mann wrote: > Thanks!! I ended up switching the tests to use a mixt

Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

`sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"` Thanks, Greg Mann

Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

https://reviews.apache.org/r/72728/#review221754 --- On Sept. 2, 2020, 5:57 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

CSIIsolatorTest*"` Thanks, Greg Mann

Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.

est_filter="*VolumeCSIIsolatorTest*"` Thanks, Greg Mann

Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.

ATION Diff: https://reviews.apache.org/r/72806/diff/3/ Changes: https://reviews.apache.org/r/72806/diff/2-3/ Testing --- `sudo bin/mesos-tests.sh --gtest_filter="*UnpublishAfterAgentFailover*"` Thanks, Greg Mann

Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

--- `sudo make check` Thanks, Greg Mann

Re: Review Request 72805: Added a test helper for CSI volumes.

details at the end of this chain. Thanks, Greg Mann

Re: Review Request 72829: Moved the `volume/csi` isolator's root dir under work dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72829/#review221769 --- Ship it! Ship It! - Greg Mann On Sept. 1, 2020, 1:30 p.m

Re: Review Request 72816: Fixed broken authorization in the CSI server.

apache.org/r/72816/#review221751 --- On Aug. 29, 2020, 12:44 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 72820: Relaxed unknown volume check when unpublishing volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72820/#review221756 --- Ship it! Ship It! - Greg Mann On Aug. 30, 2020, 2:33 a.m

Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator.

e/containerizer/mesos/isolators/volume/csi/isolator.cpp Lines 470-471 (patched) <https://reviews.apache.org/r/72804/#comment310809> Nit: indented too far. - Greg Mann On Aug. 30, 2020, 1:36 a.m., Qian Zhang wrote: > > --- >

Re: Review Request 72805: Added a test helper for CSI volumes.

il. To reply, visit: https://reviews.apache.org/r/72805/#review221713 --- On Aug. 26, 2020, 5:50 a.m., Greg Mann wrote: > > --- > This is an automatically generat

Re: Review Request 72806: Added a test for 'volume/csi' isolator recovery.

6/diff/1-2/ Testing --- `sudo bin/mesos-tests.sh --gtest_filter="*UnpublishAfterAgentFailover*"` Thanks, Greg Mann

Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

--- `sudo make check` Thanks, Greg Mann

Re: Review Request 72727: Updated the test CSI plugin for CSI server testing.

src/examples/test_csi_plugin.cpp 214a3ee4481512b025ff054db6ffe15d476b0264 Diff: https://reviews.apache.org/r/72727/diff/5/ Changes: https://reviews.apache.org/r/72727/diff/4-5/ Testing --- These new flags are used in a subsequent test in this chain. Thanks, Greg Mann

Review Request 72816: Fixed broken authorization in the CSI server.

https://reviews.apache.org/r/72816/diff/1/ Testing --- Testing details at the end of this chain. This patch is required for the upcoming tests to pass when Mesos is built with SSL enabled. Thanks, Greg Mann

Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator.

Lines 439 (patched) <https://reviews.apache.org/r/72804/#comment310779> Can we just make this the default behavior instead of adding the `csi_volume_chown` flag? - Greg Mann On Aug. 26, 2020, 2:38 a.m., Qian Zhang

Review Request 72806: Added a test for 'volume/csi' isolator recovery.

--- Added a test for 'volume/csi' isolator recovery. Diffs - src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/72806/diff/1/ Testing --- `sudo bin/mesos-tests.sh --gtest_filter="*UnpublishAfterAgentFailover*&qu

Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

--- `sudo make check` Thanks, Greg Mann

Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

com/apache/mesos/blob/62931a04f2cd2a1951d04bd348ff23700cc73d9b/src/tests/mesos.hpp#L258-L262 - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/#review221714 ------

Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

ver but not > > launch a task from end to end, maybe we do not need to start master and > > agent just like what we do in `ROOT_InvalidPluginConfig`? > > Greg Mann wrote: > In this case, we still need the agent so that the CSI plugin can actually > be initialized succ

Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

s.apache.org/r/72728/diff/10/ Changes: https://reviews.apache.org/r/72728/diff/9-10/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

e-mail. To reply, visit: https://reviews.apache.org/r/72728/#review221703 --- On Aug. 26, 2020, 5:57 a.m., Greg Mann wrote: > > --- > This is an automatically generated e

Review Request 72805: Added a test helper for CSI volumes.

--- Added a test helper for CSI volumes. Diffs - src/tests/mesos.hpp 8f89d7ca5642a475ecbc176d8bba277a6774a8a1 Diff: https://reviews.apache.org/r/72805/diff/1/ Testing --- Testing details at the end of this chain. Thanks, Greg Mann

Re: Review Request 72799: Fixed a bug in CSI server initialization.

initialization so that the service managers will be initialized with a valid auth token when necessary. Diffs - src/slave/csi_server.cpp 0ffe020412dd3170d34052ebbbdc7f320c4cb31a Diff: https://reviews.apache.org/r/72799/diff/2/ Testing --- `make check` Thanks, Greg Mann

Re: Review Request 72799: Fixed a bug in CSI server initialization.

: https://reviews.apache.org/r/72799/diff/2/ Changes: https://reviews.apache.org/r/72799/diff/1-2/ Testing --- `make check` Thanks, Greg Mann

Review Request 72799: Fixed a data race in the CSI server.

0ffe020412dd3170d34052ebbbdc7f320c4cb31a Diff: https://reviews.apache.org/r/72799/diff/1/ Testing --- `make check` Thanks, Greg Mann

Re: Review Request 72728: Added unit tests for the CSI server.

: https://reviews.apache.org/r/72728/diff/9/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way.

protobuf helper function in the description if you want maybe? - Greg Mann On Aug. 23, 2020, 2:33 p.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

2ba4f22b92370b019722d845d6113fb37f1b876a Diff: https://reviews.apache.org/r/72779/diff/4/ Testing --- `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"` Thanks, Greg Mann

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

/ Testing --- `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"` Thanks, Greg Mann

Re: Review Request 72788: Introduced the `CSIPluginInfo.target_path_exists` field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72788/#review221679 --- Ship it! Ship It! - Greg Mann On Aug. 21, 2020, 2:37 p.m

Re: Review Request 72789: Checkpointed CSI volume state in stringified JSON.

Line 201 (original), 201 (patched) <https://reviews.apache.org/r/72789/#comment310739> Can we do `state::read(volumesPath)` here so that we don't need to do any extra JSON/protobuf parsing? Then I think this change may not be necessary? - Greg Mann On Aug. 20, 2020, 9:16 a.m.,

Re: Review Request 72728: Added unit tests for the CSI server.

Diff: https://reviews.apache.org/r/72728/diff/9/ Changes: https://reviews.apache.org/r/72728/diff/8-9/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 72761: Added the CSI server to the Mesos agent.

://reviews.apache.org/r/72761/diff/6/ Changes: https://reviews.apache.org/r/72761/diff/5-6/ Testing --- Testing details at the end of this chain. Thanks, Greg Mann

Re: Review Request 72728: Added unit tests for the CSI server.

Diff: https://reviews.apache.org/r/72728/diff/8/ Changes: https://reviews.apache.org/r/72728/diff/7-8/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

- Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221655 --- On Aug. 20, 2020, 11:14 p.m., Greg Mann wrote: > >

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

reply, visit: https://reviews.apache.org/r/72779/#review221653 --- On Aug. 20, 2020, 11:14 p.m., Greg Mann wrote: > > --- > This is an automatically

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

/ Changes: https://reviews.apache.org/r/72779/diff/3-4/ Testing --- `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"` Thanks, Greg Mann

Re: Review Request 72728: Added unit tests for the CSI server.

6d68ed050f99889c142d49bbc72a9292ef64c836 src/tests/csi_server_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/72728/diff/7/ Changes: https://reviews.apache.org/r/72728/diff/6-7/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 72761: Added the CSI server to the Mesos agent.

://reviews.apache.org/r/72761/diff/5/ Changes: https://reviews.apache.org/r/72761/diff/4-5/ Testing --- Testing details at the end of this chain. Thanks, Greg Mann

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

reg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221636 --- On Aug. 19, 2020, 7:04 p.m., Greg Mann wrote: > > -

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

/72779/diff/3/ Changes: https://reviews.apache.org/r/72779/diff/2-3/ Testing --- `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"` Thanks, Greg Mann

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

we load the correct file on the first try? - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221636 ---

Re: Review Request 72761: Added the CSI server to the Mesos agent.

:start()` is called. WDYT? Good call, I updated `registered` and `reregistered`. - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221632 --- On Aug. 19, 2020, 6:16 a.m.

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221599 ------- On Aug. 19, 2020, 6:23 a.m., Greg Mann wrote: > > -

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

rocess/include/process/future.hpp#L1478-L1479 - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221596 ---

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

f5ec7663926731483589c5e30e7060751ed01e55 src/slave/csi_server.cpp 2ba4f22b92370b019722d845d6113fb37f1b876a Diff: https://reviews.apache.org/r/72779/diff/2/ Changes: https://reviews.apache.org/r/72779/diff/1-2/ Testing --- `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"` Thanks, Greg Mann

Re: Review Request 72728: Added a unit test for the CSI server.

s (updated) - src/Makefile.am 6d68ed050f99889c142d49bbc72a9292ef64c836 src/tests/csi_server_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/72728/diff/6/ Changes: https://reviews.apache.org/r/72728/diff/5-6/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 72761: Added the CSI server to the Mesos agent.

://reviews.apache.org/r/72761/diff/4/ Changes: https://reviews.apache.org/r/72761/diff/3-4/ Testing --- Testing details at the end of this chain. Thanks, Greg Mann

Re: Review Request 72761: Added the CSI server to the Mesos agent.

------- On Aug. 18, 2020, 5:13 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72761/ > --

Re: Review Request 72761: Added the CSI server to the Mesos agent.

l. To reply, visit: https://reviews.apache.org/r/72761/#review221616 ------- On Aug. 18, 2020, 5:13 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72

Re: Review Request 72759: Exposed Mesos agent ID to managed CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72759/#review221621 --- Ship it! Ship It! - Greg Mann On Aug. 18, 2020, 4:22 p.m

Re: Review Request 72759: Exposed Mesos agent ID to managed CSI plugins.

> On Aug. 13, 2020, 10:21 p.m., Greg Mann wrote: > > src/csi/service_manager.cpp > > Lines 740 (patched) > > <https://reviews.apache.org/r/72759/diff/1/?file=2237900#file2237900line740> > > > > Where does this env var name come from, 'MESOS_NODE_ID

Re: Review Request 72761: Added the CSI server to the Mesos agent.

://reviews.apache.org/r/72761/diff/3/ Changes: https://reviews.apache.org/r/72761/diff/2-3/ Testing --- Testing details at the end of this chain. Thanks, Greg Mann

Re: Review Request 72759: Improved CSI service manager to set node ID for managed CSI plugins.

> On Aug. 13, 2020, 10:21 p.m., Greg Mann wrote: > > src/csi/service_manager.cpp > > Lines 740 (patched) > > <https://reviews.apache.org/r/72759/diff/1/?file=2237900#file2237900line740> > > > > Where does this env var name come from, 'MESOS_NODE_ID

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72733/#review221613 --- Ship it! Ship It! - Greg Mann On Aug. 11, 2020, 8:32 a.m

Re: Review Request 72781: Updated volume manager to support user specified target path root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72781/#review221610 --- Ship it! Ship It! - Greg Mann On Aug. 17, 2020, 11:31 a.m

Re: Review Request 72761: Added the CSI server to the Mesos agent.

://reviews.apache.org/r/72761/diff/2/ Changes: https://reviews.apache.org/r/72761/diff/1-2/ Testing --- Testing details at the end of this chain. Thanks, Greg Mann

Re: Review Request 72761: Added the CSI server to the Mesos agent.

ude to hopefully avoid this. - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221563 --- On Aug. 18, 2020, 1:25 a.m., Greg Mann

Re: Review Request 72728: Added a unit test for the CSI server.

s (updated) - src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353 src/tests/csi_server_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/72728/diff/5/ Changes: https://reviews.apache.org/r/72728/diff/4-5/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 72727: Updated the test CSI plugin for CSI server testing.

mples/test_csi_plugin.cpp 214a3ee4481512b025ff054db6ffe15d476b0264 Diff: https://reviews.apache.org/r/72727/diff/4/ Changes: https://reviews.apache.org/r/72727/diff/3-4/ Testing --- These new flags are used in a subsequent test in this chain. Thanks, Greg Mann

Re: Review Request 72727: Updated the test CSI plugin for CSI server testing.

ps://reviews.apache.org/r/72727/#review221554 --- On Aug. 18, 2020, 1:23 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail.

Review Request 72779: Initialized plugins lazily in the CSI server.

://reviews.apache.org/r/72779/diff/1/ Testing --- `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"` Thanks, Greg Mann

Re: Review Request 72728: Added a unit test for the CSI server.

injected elsewhere? - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/#review221553 --- On Aug. 13, 2020, 6:38 a.m., Greg M

Re: Review Request 72754: Enabled the `volume/csi` isolator in `MesosContainerizer`.

- > > (Updated Aug. 13, 2020, 6:14 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10156 > https://issues.apache.org/jira/browse/MESOS-10156 > > > Repository: mesos > > > Descrip

Re: Review Request 72753: Implemented the `recover` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72753/#review221578 --- Ship it! - Greg Mann On Aug. 11, 2020, 8:31 a.m., Qian Zhang

Re: Review Request 72734: Implemented the `cleanup` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72734/#review221576 --- Ship it! Ship It! - Greg Mann On Aug. 8, 2020, 3:18 p.m

Re: Review Request 72734: Implemented the `cleanup` method of `volume/csi` isolator.

> On Aug. 6, 2020, 10:04 p.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > > Lines 389-391 (patched) > > <https://reviews.apache.org/r/72734/diff/1/?file=2237067#file2237067line389> > > > > I'm wonde

Re: Review Request 72759: Improved CSI service manager to set node ID for managed CSI plugins.

tps://reviews.apache.org/r/72759/#comment310644> Where does this env var name come from, 'MESOS_NODE_ID'? - Greg Mann On Aug. 12, 2020, 11:47 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 72770: Updated the help message of the agent flag `--csi_plugin_config_dir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72770/#review221573 --- Ship it! Ship It! - Greg Mann On Aug. 13, 2020, 8:46 a.m

Re: Review Request 72760: Passed the CSI server into the Mesos containerizer.

://reviews.apache.org/r/72760/diff/1/ Testing --- Thanks, Greg Mann

Re: Review Request 72728: Added a unit test for the CSI server.

--- src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353 src/tests/csi_server_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/72728/diff/4/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 72728: Added a unit test for the CSI server.

--- src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353 src/tests/csi_server_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/72728/diff/4/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 72760: Passed the CSI server into the Mesos containerizer.

://reviews.apache.org/r/72760/diff/1/ Testing --- Thanks, Greg Mann

Re: Review Request 72728: Added a unit test for the CSI server.

--- src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353 src/tests/csi_server_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/72728/diff/4/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 72728: Added a unit test for the CSI server.

--- src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353 src/tests/csi_server_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/72728/diff/4/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 72761: Added the CSI server to the Mesos agent.

://reviews.apache.org/r/72761/diff/1/ Testing --- Testing details at the end of this chain. Thanks, Greg Mann

Review Request 72761: Added the CSI server to the Mesos agent.

--- Testing details at the end of this chain. Thanks, Greg Mann

Review Request 72760: Passed the CSI server into the Mesos containerizer.

--- Thanks, Greg Mann

Re: Review Request 72728: Added a unit test for the CSI server.

s (updated) - src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353 src/tests/csi_server_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/72728/diff/4/ Changes: https://reviews.apache.org/r/72728/diff/3-4/ Testing --- `sudo make check` Thanks, Greg Mann

Re: Review Request 72726: Fixed a bug in CSI volume manager initialization.

in this chain to pass. Thanks, Greg Mann

Re: Review Request 72727: Updated the test CSI plugin for CSI server testing.

mples/test_csi_plugin.cpp 214a3ee4481512b025ff054db6ffe15d476b0264 Diff: https://reviews.apache.org/r/72727/diff/3/ Changes: https://reviews.apache.org/r/72727/diff/2-3/ Testing --- These new flags are used in a subsequent test in this chain. Thanks, Greg Mann

Re: Review Request 72753: Implemented the `recover` method of `volume/csi` isolator.

p Lines 155 (patched) <https://reviews.apache.org/r/72753/#comment310592> Nit: s/Cleanup/Cleaning up/ src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp Lines 185 (patched) <https://reviews.apache.org/r/72753/#comment310593> s/CSI volumes checkpointed/CSI volume state

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

> On Aug. 6, 2020, 1:27 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > > Lines 115-117 (patched) > > <https://reviews.apache.org/r/72733/diff/1/?file=2236985#file2236985line115> > > > > This seems prett

Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221535 --- Ship it! Ship It! - Greg Mann On Aug. 8, 2020, 3:58 p.m

  1   2   3   4   5   6   7   8   9   10   >