Re: Review Request 70757: Added a NNP isolator.

/linux_nnp_isolator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70757/diff/16/ Changes: https://reviews.apache.org/r/70757/diff/15-16/ Testing --- Thanks, Jacob Janco

Re: Review Request 71106: Moved kernelVersion check to common code.

761dde1d63e0f4f1ac4ab86f129f84f3746d3153 src/common/kernel_version.hpp PRE-CREATION src/common/kernel_version.cpp PRE-CREATION src/linux/ns.cpp 2440bb2232dfd9cf57a6cc36aeff874c96297c4b Diff: https://reviews.apache.org/r/71106/diff/3/ Changes: https://reviews.apache.org/r/71106/diff/2-3/ Testing --- Thanks, Jacob

Re: Review Request 71107: Added docs for the NNP isolator.

e79976111ec8e9cc8e8d44b5f1b8d6e2c7e072d6 docs/upgrades.md 0493e1846c166f4bb65b8f23f1d7698774179128 Diff: https://reviews.apache.org/r/71107/diff/3/ Changes: https://reviews.apache.org/r/71107/diff/2-3/ Testing --- Thanks, Jacob Janco

Re: Review Request 70757: Added a NNP isolator.

/linux_nnp_isolator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70757/diff/15/ Changes: https://reviews.apache.org/r/70757/diff/14-15/ Testing --- Thanks, Jacob Janco

Re: Review Request 71106: Moved kernelVersion check to common code.

2440bb2232dfd9cf57a6cc36aeff874c96297c4b Diff: https://reviews.apache.org/r/71106/diff/2/ Changes: https://reviews.apache.org/r/71106/diff/1-2/ Testing --- Thanks, Jacob Janco

Re: Review Request 71106: Moved kernelVersion check to common code.

t;https://reviews.apache.org/r/71106/diff/1/?file=2155817#file2155817line31> > > > > Can you please move this into `kernel_version.cpp`? Sure - Jacob --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71106

Review Request 71106: Moved kernelVersion check to common code.

kernelVersion check to common code. Diffs - src/common/kernel_version.hpp PRE-CREATION src/linux/ns.cpp 2440bb2232dfd9cf57a6cc36aeff874c96297c4b Diff: https://reviews.apache.org/r/71106/diff/1/ Testing --- Thanks, Jacob Janco

Re: Review Request 70757: Added a NNP isolator.

ch.cpp 0419e8e0fbf154396ab5fb5026d77b94cc9fca5b src/tests/CMakeLists.txt 5eb9c65f30d9d6ade289f9d47b18d73908b1f1db src/tests/containerizer/linux_nnp_isolator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70757/diff/14/ Changes: https://reviews.apache.org/r/70757/diff/13-14/ Testing --- Thanks, Jacob Janco

Review Request 71107: Added docs for the NNP isolator.

for the NNP isolator. Diffs - CHANGELOG 164465a71c660ab9f01fb18d43076afc4b892ad5 docs/isolators/linux-nnp.md PRE-CREATION docs/mesos-containerizer.md e79976111ec8e9cc8e8d44b5f1b8d6e2c7e072d6 Diff: https://reviews.apache.org/r/71107/diff/1/ Testing --- Thanks, Jacob Janco

Re: Review Request 70757: Added a NNP isolator.

/ Changes: https://reviews.apache.org/r/70757/diff/12-13/ Testing --- Thanks, Jacob Janco

Re: Review Request 70757: Added docs for the NNP isolator.

docs/isolators/linux-nnp.md PRE-CREATION docs/mesos-containerizer.md e79976111ec8e9cc8e8d44b5f1b8d6e2c7e072d6 Diff: https://reviews.apache.org/r/70757/diff/12/ Changes: https://reviews.apache.org/r/70757/diff/11-12/ Testing --- Thanks, Jacob Janco

Re: Review Request 70757: Added docs for the NNP isolator.

-CREATION docs/mesos-containerizer.md e79976111ec8e9cc8e8d44b5f1b8d6e2c7e072d6 Diff: https://reviews.apache.org/r/70757/diff/11/ Changes: https://reviews.apache.org/r/70757/diff/10-11/ Testing --- Thanks, Jacob Janco

Re: Review Request 70757: Added docs for the NNP isolator.

-CREATION docs/mesos-containerizer.md e79976111ec8e9cc8e8d44b5f1b8d6e2c7e072d6 Diff: https://reviews.apache.org/r/70757/diff/10/ Changes: https://reviews.apache.org/r/70757/diff/9-10/ Testing --- Thanks, Jacob Janco

Re: Review Request 70757: Added docs for the NNP isolator.

alse`, given the isolator assigns `true` > > in any case? > > > > What is the semantics of `ContainerLaunchInfo::no_new_privileges` flag? > > How does it work in pair with the new isolator? > > Jacob Janco wrote: > I don't have a default value set in the proto

Re: Review Request 70757: Added docs for the NNP isolator.

NNP flag. Taking this approach, we can add the configurable parts later. - Jacob --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70757/#review216562 --------

Re: Review Request 70757: Added docs for the NNP isolator.

://reviews.apache.org/r/70757/diff/8-9/ Testing --- Thanks, Jacob Janco

Re: Review Request 70757: Added a NNP isolator.

/linux_nnp_isolator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70757/diff/8/ Changes: https://reviews.apache.org/r/70757/diff/7-8/ Testing --- Thanks, Jacob Janco

Re: Review Request 70757: Added a NNP isolator.

/linux_nnp_isolator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70757/diff/7/ Changes: https://reviews.apache.org/r/70757/diff/6-7/ Testing --- Thanks, Jacob Janco

Re: Review Request 70757: Added a NNP isolator.

/linux_nnp_isolator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70757/diff/6/ Changes: https://reviews.apache.org/r/70757/diff/5-6/ Testing --- Thanks, Jacob Janco

Re: Review Request 70757: Added a NNP isolator.

/linux_nnp_isolator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70757/diff/5/ Changes: https://reviews.apache.org/r/70757/diff/4-5/ Testing --- Thanks, Jacob Janco

Re: Review Request 70757: Added a NNP isolator.

/linux_nnp_isolator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70757/diff/4/ Changes: https://reviews.apache.org/r/70757/diff/3-4/ Testing --- Thanks, Jacob Janco

Re: Review Request 70757: Added a NNP isolator.

/linux_nnp_isolator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70757/diff/3/ Changes: https://reviews.apache.org/r/70757/diff/2-3/ Testing --- Thanks, Jacob Janco

Re: Review Request 70757: Added a NNP isolator.

To make a kernel version check, you can hoist `kernelVersion` from ns.cpp > into common code. Cool, moved it up - Jacob --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 70757: Added a NNP isolator.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70757/#review215607 --- On July 3, 2019, 11:30 p.m., Jacob Janco wrote: > > --

Re: Review Request 70757: Added a NNP isolator.

ane. The user can set this to false/true explicitly. - Jacob --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70757/#review215611 -----

Re: Review Request 70757: Added a NNP isolator.

3ea8b4400ff3b00470aa147cb8f39f62802727e3 src/tests/containerizer/linux_nnp_isolator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70757/diff/2/ Changes: https://reviews.apache.org/r/70757/diff/1-2/ Testing --- Thanks, Jacob Janco

Review Request 70757: Added a privs isolator.

/isolators/linux/privs.cpp PRE-CREATION src/slave/containerizer/mesos/launch.cpp 0c482f46a97063133edfe29ae3c6a2721d29f6c6 Diff: https://reviews.apache.org/r/70757/diff/1/ Testing --- Thanks, Jacob Janco

Re: Review Request 70581: Add flag to decouple docker runtime.

1c5d72091d570001ad543e342ab0b9128ffc01ae Diff: https://reviews.apache.org/r/70581/diff/6/ Changes: https://reviews.apache.org/r/70581/diff/5-6/ Testing --- Thanks, Jacob Janco

Re: Review Request 70581: Add flag to decouple docker runtime.

1c5d72091d570001ad543e342ab0b9128ffc01ae Diff: https://reviews.apache.org/r/70581/diff/5/ Changes: https://reviews.apache.org/r/70581/diff/4-5/ Testing --- Thanks, Jacob Janco

Re: Review Request 70581: Add flag to decouple docker runtime.

ad since all the codes are in a single place (the isolator) rather > than in multiple places (like the containerizer and store). This seems reasonable - I'll move this into the isolator. - Jacob --- This is an auto

Re: Review Request 70581: Add flag to decouple docker runtime.

/diff/3-4/ Testing --- Thanks, Jacob Janco

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

e `--ignore_docker_runtime`flag. - Jacob --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/#review215239 --- On

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

: https://reviews.apache.org/r/70581/diff/2-3/ Testing --- Thanks, Jacob Janco

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

ion. Done. - Jacob --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/#review215004 --- On May 9, 2019, 7 p.

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

11fce0eb47e9e6dfce6289afe04a1d58a0c4461a src/slave/flags.hpp 09921cb6172202b5c1d2f8d03f9ccaeb3d0e8c94 src/slave/flags.cpp 49a350f9e13409493fa9612c53d9d58b62122371 Diff: https://reviews.apache.org/r/70581/diff/2/ Changes: https://reviews.apache.org/r/70581/diff/1-2/ Testing --- Thanks, Jacob Janco

Review Request 70581: Add flag ignoring docker manifest config metadata.

49a350f9e13409493fa9612c53d9d58b62122371 Diff: https://reviews.apache.org/r/70581/diff/1/ Testing --- Thanks, Jacob Janco

Re: Review Request 68957: Add documentation for per-framework metrics flag.

: https://reviews.apache.org/r/68957/diff/13/ Changes: https://reviews.apache.org/r/68957/diff/12-13/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

quot;master/mem_revocable_used": 0, "master/mem_total": 15360, "master/mem_used": 0, "master/messages_authenticate": 0, "master/messages_deactivate_framework": 1, "master/messages_decline_offers": 0, "master/messages_executor_to_framework": 0, "master/messages_exited_executor": 1, "master/messages_framework_to_executor": 0, "master/messages_kill_task": 0, "master/messages_launch_tasks": 1, "master/messages_operation_status_update_acknowledgement": 0, "master/messages_reconcile_operations": 0, "master/messages_reconcile_tasks": 0, "master/messages_register_framework": 1, "master/messages_register_slave": 0, "master/messages_reregister_framework": 0, "master/messages_reregister_slave": 1, "master/messages_resource_request": 0, "master/messages_revive_offers": 0, "master/messages_status_update": 5, "master/messages_status_update_acknowledgement": 0, "master/messages_suppress_offers": 0, "master/messages_unregister_framework": 0, "master/messages_unregister_slave": 0, "master/messages_update_slave": 1, "master/outstanding_offers": 0, "master/recovery_slave_removals": 0, "master/slave_registrations": 0, "master/slave_removals": 0, "master/slave_removals/reason_registered": 0, "master/slave_removals/reason_unhealthy": 0, "master/slave_removals/reason_unregistered": 0, "master/slave_reregistrations": 1, "master/slave_shutdowns_canceled": 0, "master/slave_shutdowns_completed": 0, "master/slave_shutdowns_scheduled": 0, "master/slave_unreachable_canceled": 0, "master/slave_unreachable_completed": 0, "master/slave_unreachable_scheduled": 0, "master/slaves_active": 1, "master/slaves_connected": 1, "master/slaves_disconnected": 0, "master/slaves_inactive": 0, "master/slaves_unreachable": 0, "master/task_failed/source_slave/reason_executor_terminated": 5, "master/tasks_dropped": 0, "master/tasks_error": 0, "master/tasks_failed": 5, "master/tasks_finished": 0, "master/tasks_gone": 0, "master/tasks_gone_by_operator": 0, "master/tasks_killed": 0, "master/tasks_killing": 0, "master/tasks_lost": 0, "master/tasks_running": 0, "master/tasks_staging": 0, "master/tasks_starting": 0, "master/tasks_unreachable": 0, "master/uptime_secs": 6.64713984, "master/valid_executor_to_framework_messages": 0, "master/valid_framework_to_executor_messages": 0, "master/valid_operation_status_update_acknowledgements": 0, "master/valid_status_update_acknowledgements": 0, "master/valid_status_updates": 5, "registrar/log/ensemble_size": 1, "registrar/log/recovered": 1, "registrar/queued_operations": 0, "registrar/registry_size_bytes": 286, "registrar/state_fetch_ms": 2.797824, "registrar/state_store_ms": 4.041728, "system/cpus_total": 8, "system/load_15min": 2.9658203125, "system/load_1min": 1.51708984375, "system/load_5min": 2.09326171875, "system/mem_free_bytes": 6589292544, "system/mem_total_bytes": 17179869184 } Thanks, Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

://reviews.apache.org/r/68953/diff/11/ Changes: https://reviews.apache.org/r/68953/diff/10-11/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

quot;master/mem_revocable_used": 0, "master/mem_total": 15360, "master/mem_used": 0, "master/messages_authenticate": 0, "master/messages_deactivate_framework": 1, "master/messages_decline_offers": 0, "master/messages_executor_to_framework": 0, "master/messages_exited_executor": 1, "master/messages_framework_to_executor": 0, "master/messages_kill_task": 0, "master/messages_launch_tasks": 1, "master/messages_operation_status_update_acknowledgement": 0, "master/messages_reconcile_operations": 0, "master/messages_reconcile_tasks": 0, "master/messages_register_framework": 1, "master/messages_register_slave": 0, "master/messages_reregister_framework": 0, "master/messages_reregister_slave": 1, "master/messages_resource_request": 0, "master/messages_revive_offers": 0, "master/messages_status_update": 5, "master/messages_status_update_acknowledgement": 0, "master/messages_suppress_offers": 0, "master/messages_unregister_framework": 0, "master/messages_unregister_slave": 0, "master/messages_update_slave": 1, "master/outstanding_offers": 0, "master/recovery_slave_removals": 0, "master/slave_registrations": 0, "master/slave_removals": 0, "master/slave_removals/reason_registered": 0, "master/slave_removals/reason_unhealthy": 0, "master/slave_removals/reason_unregistered": 0, "master/slave_reregistrations": 1, "master/slave_shutdowns_canceled": 0, "master/slave_shutdowns_completed": 0, "master/slave_shutdowns_scheduled": 0, "master/slave_unreachable_canceled": 0, "master/slave_unreachable_completed": 0, "master/slave_unreachable_scheduled": 0, "master/slaves_active": 1, "master/slaves_connected": 1, "master/slaves_disconnected": 0, "master/slaves_inactive": 0, "master/slaves_unreachable": 0, "master/task_failed/source_slave/reason_executor_terminated": 5, "master/tasks_dropped": 0, "master/tasks_error": 0, "master/tasks_failed": 5, "master/tasks_finished": 0, "master/tasks_gone": 0, "master/tasks_gone_by_operator": 0, "master/tasks_killed": 0, "master/tasks_killing": 0, "master/tasks_lost": 0, "master/tasks_running": 0, "master/tasks_staging": 0, "master/tasks_starting": 0, "master/tasks_unreachable": 0, "master/uptime_secs": 6.64713984, "master/valid_executor_to_framework_messages": 0, "master/valid_framework_to_executor_messages": 0, "master/valid_operation_status_update_acknowledgements": 0, "master/valid_status_update_acknowledgements": 0, "master/valid_status_updates": 5, "registrar/log/ensemble_size": 1, "registrar/log/recovered": 1, "registrar/queued_operations": 0, "registrar/registry_size_bytes": 286, "registrar/state_fetch_ms": 2.797824, "registrar/state_store_ms": 4.041728, "system/cpus_total": 8, "system/load_15min": 2.9658203125, "system/load_1min": 1.51708984375, "system/load_5min": 2.09326171875, "system/mem_free_bytes": 6589292544, "system/mem_total_bytes": 17179869184 } Thanks, Jacob Janco

Re: Review Request 68957: Add documentation for per-framework metrics flag.

: https://reviews.apache.org/r/68957/diff/12/ Changes: https://reviews.apache.org/r/68957/diff/11-12/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

://reviews.apache.org/r/68953/diff/10/ Changes: https://reviews.apache.org/r/68953/diff/9-10/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

://reviews.apache.org/r/68953/diff/9/ Changes: https://reviews.apache.org/r/68953/diff/8-9/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68957: Add documentation for per-framework metrics flag.

: https://reviews.apache.org/r/68957/diff/11/ Changes: https://reviews.apache.org/r/68957/diff/10-11/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

quot;master/mem_revocable_used": 0, "master/mem_total": 15360, "master/mem_used": 0, "master/messages_authenticate": 0, "master/messages_deactivate_framework": 1, "master/messages_decline_offers": 0, "master/messages_executor_to_framework": 0, "master/messages_exited_executor": 1, "master/messages_framework_to_executor": 0, "master/messages_kill_task": 0, "master/messages_launch_tasks": 1, "master/messages_operation_status_update_acknowledgement": 0, "master/messages_reconcile_operations": 0, "master/messages_reconcile_tasks": 0, "master/messages_register_framework": 1, "master/messages_register_slave": 0, "master/messages_reregister_framework": 0, "master/messages_reregister_slave": 1, "master/messages_resource_request": 0, "master/messages_revive_offers": 0, "master/messages_status_update": 5, "master/messages_status_update_acknowledgement": 0, "master/messages_suppress_offers": 0, "master/messages_unregister_framework": 0, "master/messages_unregister_slave": 0, "master/messages_update_slave": 1, "master/outstanding_offers": 0, "master/recovery_slave_removals": 0, "master/slave_registrations": 0, "master/slave_removals": 0, "master/slave_removals/reason_registered": 0, "master/slave_removals/reason_unhealthy": 0, "master/slave_removals/reason_unregistered": 0, "master/slave_reregistrations": 1, "master/slave_shutdowns_canceled": 0, "master/slave_shutdowns_completed": 0, "master/slave_shutdowns_scheduled": 0, "master/slave_unreachable_canceled": 0, "master/slave_unreachable_completed": 0, "master/slave_unreachable_scheduled": 0, "master/slaves_active": 1, "master/slaves_connected": 1, "master/slaves_disconnected": 0, "master/slaves_inactive": 0, "master/slaves_unreachable": 0, "master/task_failed/source_slave/reason_executor_terminated": 5, "master/tasks_dropped": 0, "master/tasks_error": 0, "master/tasks_failed": 5, "master/tasks_finished": 0, "master/tasks_gone": 0, "master/tasks_gone_by_operator": 0, "master/tasks_killed": 0, "master/tasks_killing": 0, "master/tasks_lost": 0, "master/tasks_running": 0, "master/tasks_staging": 0, "master/tasks_starting": 0, "master/tasks_unreachable": 0, "master/uptime_secs": 6.64713984, "master/valid_executor_to_framework_messages": 0, "master/valid_framework_to_executor_messages": 0, "master/valid_operation_status_update_acknowledgements": 0, "master/valid_status_update_acknowledgements": 0, "master/valid_status_updates": 5, "registrar/log/ensemble_size": 1, "registrar/log/recovered": 1, "registrar/queued_operations": 0, "registrar/registry_size_bytes": 286, "registrar/state_fetch_ms": 2.797824, "registrar/state_store_ms": 4.041728, "system/cpus_total": 8, "system/load_15min": 2.9658203125, "system/load_1min": 1.51708984375, "system/load_5min": 2.09326171875, "system/mem_free_bytes": 6589292544, "system/mem_total_bytes": 17179869184 } Thanks, Jacob Janco

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

plicit` here anymore. Fixed. - Jacob --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/#review209938 --- On Oct.

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

t: https://reviews.apache.org/r/68956/#review209945 --- On Oct. 24, 2018, 9:38 p.m., Jacob Janco wrote: > > --- > This is an automatically generated e

Re: Review Request 68953: Refactor allocator configuration into a struct.

://reviews.apache.org/r/68953/diff/8/ Changes: https://reviews.apache.org/r/68953/diff/7-8/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

Nit: indent two more spaces. Fixed. - Jacob --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/#review209943 --- On

Re: Review Request 68957: Add documentation for per-framework metrics flag.

: https://reviews.apache.org/r/68957/diff/10/ Changes: https://reviews.apache.org/r/68957/diff/9-10/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

_decline_offers": 0, "master/messages_executor_to_framework": 0, "master/messages_exited_executor": 1, "master/messages_framework_to_executor": 0, "master/messages_kill_task": 0, "master/messages_launch_tasks": 1, "master/messages_operation_status_update_acknowledgement": 0, "master/messages_reconcile_operations": 0, "master/messages_reconcile_tasks": 0, "master/messages_register_framework": 1, "master/messages_register_slave": 0, "master/messages_reregister_framework": 0, "master/messages_reregister_slave": 1, "master/messages_resource_request": 0, "master/messages_revive_offers": 0, "master/messages_status_update": 5, "master/messages_status_update_acknowledgement": 0, "master/messages_suppress_offers": 0, "master/messages_unregister_framework": 0, "master/messages_unregister_slave": 0, "master/messages_update_slave": 1, "master/outstanding_offers": 0, "master/recovery_slave_removals": 0, "master/slave_registrations": 0, "master/slave_removals": 0, "master/slave_removals/reason_registered": 0, "master/slave_removals/reason_unhealthy": 0, "master/slave_removals/reason_unregistered": 0, "master/slave_reregistrations": 1, "master/slave_shutdowns_canceled": 0, "master/slave_shutdowns_completed": 0, "master/slave_shutdowns_scheduled": 0, "master/slave_unreachable_canceled": 0, "master/slave_unreachable_completed": 0, "master/slave_unreachable_scheduled": 0, "master/slaves_active": 1, "master/slaves_connected": 1, "master/slaves_disconnected": 0, "master/slaves_inactive": 0, "master/slaves_unreachable": 0, "master/task_failed/source_slave/reason_executor_terminated": 5, "master/tasks_dropped": 0, "master/tasks_error": 0, "master/tasks_failed": 5, "master/tasks_finished": 0, "master/tasks_gone": 0, "master/tasks_gone_by_operator": 0, "master/tasks_killed": 0, "master/tasks_killing": 0, "master/tasks_lost": 0, "master/tasks_running": 0, "master/tasks_staging": 0, "master/tasks_starting": 0, "master/tasks_unreachable": 0, "master/uptime_secs": 6.64713984, "master/valid_executor_to_framework_messages": 0, "master/valid_framework_to_executor_messages": 0, "master/valid_operation_status_update_acknowledgements": 0, "master/valid_status_update_acknowledgements": 0, "master/valid_status_updates": 5, "registrar/log/ensemble_size": 1, "registrar/log/recovered": 1, "registrar/queued_operations": 0, "registrar/registry_size_bytes": 286, "registrar/state_fetch_ms": 2.797824, "registrar/state_store_ms": 4.041728, "system/cpus_total": 8, "system/load_15min": 2.9658203125, "system/load_1min": 1.51708984375, "system/load_5min": 2.09326171875, "system/mem_free_bytes": 6589292544, "system/mem_total_bytes": 17179869184 } Thanks, Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

gt; > > > Is the `Some()` here really necessary? Nope. - Jacob --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68953/#review209944 ------- On Oct. 24, 2018, 9:38 p.m., Jacob Janco wrote: > >

Re: Review Request 68957: Add documentation for per-framework metrics flag.

n alphabetical order. Fixed. - Jacob --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209939 --- On Oct.

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

quot;master/mem_revocable_used": 0, "master/mem_total": 15360, "master/mem_used": 0, "master/messages_authenticate": 0, "master/messages_deactivate_framework": 1, "master/messages_decline_offers": 0, "master/messages_executor_to_framework": 0, "master/messages_exited_executor": 1, "master/messages_framework_to_executor": 0, "master/messages_kill_task": 0, "master/messages_launch_tasks": 1, "master/messages_operation_status_update_acknowledgement": 0, "master/messages_reconcile_operations": 0, "master/messages_reconcile_tasks": 0, "master/messages_register_framework": 1, "master/messages_register_slave": 0, "master/messages_reregister_framework": 0, "master/messages_reregister_slave": 1, "master/messages_resource_request": 0, "master/messages_revive_offers": 0, "master/messages_status_update": 5, "master/messages_status_update_acknowledgement": 0, "master/messages_suppress_offers": 0, "master/messages_unregister_framework": 0, "master/messages_unregister_slave": 0, "master/messages_update_slave": 1, "master/outstanding_offers": 0, "master/recovery_slave_removals": 0, "master/slave_registrations": 0, "master/slave_removals": 0, "master/slave_removals/reason_registered": 0, "master/slave_removals/reason_unhealthy": 0, "master/slave_removals/reason_unregistered": 0, "master/slave_reregistrations": 1, "master/slave_shutdowns_canceled": 0, "master/slave_shutdowns_completed": 0, "master/slave_shutdowns_scheduled": 0, "master/slave_unreachable_canceled": 0, "master/slave_unreachable_completed": 0, "master/slave_unreachable_scheduled": 0, "master/slaves_active": 1, "master/slaves_connected": 1, "master/slaves_disconnected": 0, "master/slaves_inactive": 0, "master/slaves_unreachable": 0, "master/task_failed/source_slave/reason_executor_terminated": 5, "master/tasks_dropped": 0, "master/tasks_error": 0, "master/tasks_failed": 5, "master/tasks_finished": 0, "master/tasks_gone": 0, "master/tasks_gone_by_operator": 0, "master/tasks_killed": 0, "master/tasks_killing": 0, "master/tasks_lost": 0, "master/tasks_running": 0, "master/tasks_staging": 0, "master/tasks_starting": 0, "master/tasks_unreachable": 0, "master/uptime_secs": 6.64713984, "master/valid_executor_to_framework_messages": 0, "master/valid_framework_to_executor_messages": 0, "master/valid_operation_status_update_acknowledgements": 0, "master/valid_status_update_acknowledgements": 0, "master/valid_status_updates": 5, "registrar/log/ensemble_size": 1, "registrar/log/recovered": 1, "registrar/queued_operations": 0, "registrar/registry_size_bytes": 286, "registrar/state_fetch_ms": 2.797824, "registrar/state_store_ms": 4.041728, "system/cpus_total": 8, "system/load_15min": 2.9658203125, "system/load_1min": 1.51708984375, "system/load_5min": 2.09326171875, "system/mem_free_bytes": 6589292544, "system/mem_total_bytes": 17179869184 } Thanks, Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

Fits on one line. Fixed - Jacob --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68953/#review209838 --- On Oct. 22, 2018, 11:52 p.m., Jaco

Re: Review Request 68957: Add documentation for per-framework metrics flag.

: https://reviews.apache.org/r/68957/diff/9/ Changes: https://reviews.apache.org/r/68957/diff/8-9/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

://reviews.apache.org/r/68953/diff/7/ Changes: https://reviews.apache.org/r/68953/diff/6-7/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

> > Lines 770 (patched) > > <https://reviews.apache.org/r/68956/diff/6/?file=2100265#file2100265line771> > > > > 2 newlines here. Fixed. - Jacob --- This is an automatically gener

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

t;: 0, "master/mem_revocable_total": 0, "master/mem_revocable_used": 0, "master/mem_total": 15360, "master/mem_used": 0, "master/messages_authenticate": 0, "master/messages_deactivate_framework": 1, "master/messages_decline_offers": 0, "master/messages_executor_to_framework": 0, "master/messages_exited_executor": 1, "master/messages_framework_to_executor": 0, "master/messages_kill_task": 0, "master/messages_launch_tasks": 1, "master/messages_operation_status_update_acknowledgement": 0, "master/messages_reconcile_operations": 0, "master/messages_reconcile_tasks": 0, "master/messages_register_framework": 1, "master/messages_register_slave": 0, "master/messages_reregister_framework": 0, "master/messages_reregister_slave": 1, "master/messages_resource_request": 0, "master/messages_revive_offers": 0, "master/messages_status_update": 5, "master/messages_status_update_acknowledgement": 0, "master/messages_suppress_offers": 0, "master/messages_unregister_framework": 0, "master/messages_unregister_slave": 0, "master/messages_update_slave": 1, "master/outstanding_offers": 0, "master/recovery_slave_removals": 0, "master/slave_registrations": 0, "master/slave_removals": 0, "master/slave_removals/reason_registered": 0, "master/slave_removals/reason_unhealthy": 0, "master/slave_removals/reason_unregistered": 0, "master/slave_reregistrations": 1, "master/slave_shutdowns_canceled": 0, "master/slave_shutdowns_completed": 0, "master/slave_shutdowns_scheduled": 0, "master/slave_unreachable_canceled": 0, "master/slave_unreachable_completed": 0, "master/slave_unreachable_scheduled": 0, "master/slaves_active": 1, "master/slaves_connected": 1, "master/slaves_disconnected": 0, "master/slaves_inactive": 0, "master/slaves_unreachable": 0, "master/task_failed/source_slave/reason_executor_terminated": 5, "master/tasks_dropped": 0, "master/tasks_error": 0, "master/tasks_failed": 5, "master/tasks_finished": 0, "master/tasks_gone": 0, "master/tasks_gone_by_operator": 0, "master/tasks_killed": 0, "master/tasks_killing": 0, "master/tasks_lost": 0, "master/tasks_running": 0, "master/tasks_staging": 0, "master/tasks_starting": 0, "master/tasks_unreachable": 0, "master/uptime_secs": 6.64713984, "master/valid_executor_to_framework_messages": 0, "master/valid_framework_to_executor_messages": 0, "master/valid_operation_status_update_acknowledgements": 0, "master/valid_status_update_acknowledgements": 0, "master/valid_status_updates": 5, "registrar/log/ensemble_size": 1, "registrar/log/recovered": 1, "registrar/queued_operations": 0, "registrar/registry_size_bytes": 286, "registrar/state_fetch_ms": 2.797824, "registrar/state_store_ms": 4.041728, "system/cpus_total": 8, "system/load_15min": 2.9658203125, "system/load_1min": 1.51708984375, "system/load_5min": 2.09326171875, "system/mem_free_bytes": 6589292544, "system/mem_total_bytes": 17179869184 } Thanks, Jacob Janco

Re: Review Request 68957: Add documentation for per-framework metrics flag.

: https://reviews.apache.org/r/68957/diff/8/ Changes: https://reviews.apache.org/r/68957/diff/7-8/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68957: Add documentation for per-framework metrics flag.

------- On Oct. 22, 2018, 10:05 p.m., Jacob Janco wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68957/ > ---

Re: Review Request 68957: Add documentation for per-framework metrics flag.

f290e377be9d7424899c82e099be98fc88688de1 Diff: https://reviews.apache.org/r/68957/diff/7/ Changes: https://reviews.apache.org/r/68957/diff/6-7/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68957: Add documentation for per-framework metrics flag.

tory: mesos > > > Description > --- > > Add documentation for per-framework metrics flag. > > > Diffs > - > > docs/configuration/master.md f290e377be9d7424899c82e099be98fc88688de1 > > > Diff: https://reviews.apache.org/r/68957/diff/7/ > > > Testing > --- > > make check on OSX > > > Thanks, > > Jacob Janco > >

Re: Review Request 68957: Add documentation for per-framework metrics flag.

: https://reviews.apache.org/r/68957/diff/6/ Changes: https://reviews.apache.org/r/68957/diff/5-6/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

amework": 1, "master/messages_decline_offers": 0, "master/messages_executor_to_framework": 0, "master/messages_exited_executor": 1, "master/messages_framework_to_executor": 0, "master/messages_kill_task": 0, "master/messages_launch_tasks": 1, "master/messages_operation_status_update_acknowledgement": 0, "master/messages_reconcile_operations": 0, "master/messages_reconcile_tasks": 0, "master/messages_register_framework": 1, "master/messages_register_slave": 0, "master/messages_reregister_framework": 0, "master/messages_reregister_slave": 1, "master/messages_resource_request": 0, "master/messages_revive_offers": 0, "master/messages_status_update": 5, "master/messages_status_update_acknowledgement": 0, "master/messages_suppress_offers": 0, "master/messages_unregister_framework": 0, "master/messages_unregister_slave": 0, "master/messages_update_slave": 1, "master/outstanding_offers": 0, "master/recovery_slave_removals": 0, "master/slave_registrations": 0, "master/slave_removals": 0, "master/slave_removals/reason_registered": 0, "master/slave_removals/reason_unhealthy": 0, "master/slave_removals/reason_unregistered": 0, "master/slave_reregistrations": 1, "master/slave_shutdowns_canceled": 0, "master/slave_shutdowns_completed": 0, "master/slave_shutdowns_scheduled": 0, "master/slave_unreachable_canceled": 0, "master/slave_unreachable_completed": 0, "master/slave_unreachable_scheduled": 0, "master/slaves_active": 1, "master/slaves_connected": 1, "master/slaves_disconnected": 0, "master/slaves_inactive": 0, "master/slaves_unreachable": 0, "master/task_failed/source_slave/reason_executor_terminated": 5, "master/tasks_dropped": 0, "master/tasks_error": 0, "master/tasks_failed": 5, "master/tasks_finished": 0, "master/tasks_gone": 0, "master/tasks_gone_by_operator": 0, "master/tasks_killed": 0, "master/tasks_killing": 0, "master/tasks_lost": 0, "master/tasks_running": 0, "master/tasks_staging": 0, "master/tasks_starting": 0, "master/tasks_unreachable": 0, "master/uptime_secs": 6.64713984, "master/valid_executor_to_framework_messages": 0, "master/valid_framework_to_executor_messages": 0, "master/valid_operation_status_update_acknowledgements": 0, "master/valid_status_update_acknowledgements": 0, "master/valid_status_updates": 5, "registrar/log/ensemble_size": 1, "registrar/log/recovered": 1, "registrar/queued_operations": 0, "registrar/registry_size_bytes": 286, "registrar/state_fetch_ms": 2.797824, "registrar/state_store_ms": 4.041728, "system/cpus_total": 8, "system/load_15min": 2.9658203125, "system/load_1min": 1.51708984375, "system/load_5min": 2.09326171875, "system/mem_free_bytes": 6589292544, "system/mem_total_bytes": 17179869184 } Thanks, Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

://reviews.apache.org/r/68953/diff/6/ Changes: https://reviews.apache.org/r/68953/diff/5-6/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

e more sense to change this > > member to an `Option`, rather than letting the master > > hold an empty `FrameworkMetrics` struct when those metrics are disabled. > > Does the latter approach in the current patch offer some advantage? > > Jacob Janco wrote: > The i

Re: Review Request 68957: Add documentation for per-framework metrics flag.

: https://reviews.apache.org/r/68957/diff/5/ Changes: https://reviews.apache.org/r/68957/diff/4-5/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

://reviews.apache.org/r/68953/diff/5/ Changes: https://reviews.apache.org/r/68953/diff/4-5/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

amework": 1, "master/messages_decline_offers": 0, "master/messages_executor_to_framework": 0, "master/messages_exited_executor": 1, "master/messages_framework_to_executor": 0, "master/messages_kill_task": 0, "master/messages_launch_tasks": 1, "master/messages_operation_status_update_acknowledgement": 0, "master/messages_reconcile_operations": 0, "master/messages_reconcile_tasks": 0, "master/messages_register_framework": 1, "master/messages_register_slave": 0, "master/messages_reregister_framework": 0, "master/messages_reregister_slave": 1, "master/messages_resource_request": 0, "master/messages_revive_offers": 0, "master/messages_status_update": 5, "master/messages_status_update_acknowledgement": 0, "master/messages_suppress_offers": 0, "master/messages_unregister_framework": 0, "master/messages_unregister_slave": 0, "master/messages_update_slave": 1, "master/outstanding_offers": 0, "master/recovery_slave_removals": 0, "master/slave_registrations": 0, "master/slave_removals": 0, "master/slave_removals/reason_registered": 0, "master/slave_removals/reason_unhealthy": 0, "master/slave_removals/reason_unregistered": 0, "master/slave_reregistrations": 1, "master/slave_shutdowns_canceled": 0, "master/slave_shutdowns_completed": 0, "master/slave_shutdowns_scheduled": 0, "master/slave_unreachable_canceled": 0, "master/slave_unreachable_completed": 0, "master/slave_unreachable_scheduled": 0, "master/slaves_active": 1, "master/slaves_connected": 1, "master/slaves_disconnected": 0, "master/slaves_inactive": 0, "master/slaves_unreachable": 0, "master/task_failed/source_slave/reason_executor_terminated": 5, "master/tasks_dropped": 0, "master/tasks_error": 0, "master/tasks_failed": 5, "master/tasks_finished": 0, "master/tasks_gone": 0, "master/tasks_gone_by_operator": 0, "master/tasks_killed": 0, "master/tasks_killing": 0, "master/tasks_lost": 0, "master/tasks_running": 0, "master/tasks_staging": 0, "master/tasks_starting": 0, "master/tasks_unreachable": 0, "master/uptime_secs": 6.64713984, "master/valid_executor_to_framework_messages": 0, "master/valid_framework_to_executor_messages": 0, "master/valid_operation_status_update_acknowledgements": 0, "master/valid_status_update_acknowledgements": 0, "master/valid_status_updates": 5, "registrar/log/ensemble_size": 1, "registrar/log/recovered": 1, "registrar/queued_operations": 0, "registrar/registry_size_bytes": 286, "registrar/state_fetch_ms": 2.797824, "registrar/state_store_ms": 4.041728, "system/cpus_total": 8, "system/load_15min": 2.9658203125, "system/load_1min": 1.51708984375, "system/load_5min": 2.09326171875, "system/mem_free_bytes": 6589292544, "system/mem_total_bytes": 17179869184 } Thanks, Jacob Janco

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

8956/diff/4/?file=2096503#file2096503line555> > > > > Ditto on formatting here. Fixed. - Jacob ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/#review209562 -

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

l": 0, "master/mem_revocable_used": 0, "master/mem_total": 15360, "master/mem_used": 0, "master/messages_authenticate": 0, "master/messages_deactivate_framework": 1, "master/messages_decline_offers": 0, "master/messages_executor_to_framework": 0, "master/messages_exited_executor": 1, "master/messages_framework_to_executor": 0, "master/messages_kill_task": 0, "master/messages_launch_tasks": 1, "master/messages_operation_status_update_acknowledgement": 0, "master/messages_reconcile_operations": 0, "master/messages_reconcile_tasks": 0, "master/messages_register_framework": 1, "master/messages_register_slave": 0, "master/messages_reregister_framework": 0, "master/messages_reregister_slave": 1, "master/messages_resource_request": 0, "master/messages_revive_offers": 0, "master/messages_status_update": 5, "master/messages_status_update_acknowledgement": 0, "master/messages_suppress_offers": 0, "master/messages_unregister_framework": 0, "master/messages_unregister_slave": 0, "master/messages_update_slave": 1, "master/outstanding_offers": 0, "master/recovery_slave_removals": 0, "master/slave_registrations": 0, "master/slave_removals": 0, "master/slave_removals/reason_registered": 0, "master/slave_removals/reason_unhealthy": 0, "master/slave_removals/reason_unregistered": 0, "master/slave_reregistrations": 1, "master/slave_shutdowns_canceled": 0, "master/slave_shutdowns_completed": 0, "master/slave_shutdowns_scheduled": 0, "master/slave_unreachable_canceled": 0, "master/slave_unreachable_completed": 0, "master/slave_unreachable_scheduled": 0, "master/slaves_active": 1, "master/slaves_connected": 1, "master/slaves_disconnected": 0, "master/slaves_inactive": 0, "master/slaves_unreachable": 0, "master/task_failed/source_slave/reason_executor_terminated": 5, "master/tasks_dropped": 0, "master/tasks_error": 0, "master/tasks_failed": 5, "master/tasks_finished": 0, "master/tasks_gone": 0, "master/tasks_gone_by_operator": 0, "master/tasks_killed": 0, "master/tasks_killing": 0, "master/tasks_lost": 0, "master/tasks_running": 0, "master/tasks_staging": 0, "master/tasks_starting": 0, "master/tasks_unreachable": 0, "master/uptime_secs": 6.64713984, "master/valid_executor_to_framework_messages": 0, "master/valid_framework_to_executor_messages": 0, "master/valid_operation_status_update_acknowledgements": 0, "master/valid_status_update_acknowledgements": 0, "master/valid_status_updates": 5, "registrar/log/ensemble_size": 1, "registrar/log/recovered": 1, "registrar/queued_operations": 0, "registrar/registry_size_bytes": 286, "registrar/state_fetch_ms": 2.797824, "registrar/state_store_ms": 4.041728, "system/cpus_total": 8, "system/load_15min": 2.9658203125, "system/load_1min": 1.51708984375, "system/load_5min": 2.09326171875, "system/mem_free_bytes": 6589292544, "system/mem_total_bytes": 17179869184 } Thanks, Jacob Janco

Re: Review Request 68957: Add documentation for per-framework metrics flag.

: https://reviews.apache.org/r/68957/diff/4/ Changes: https://reviews.apache.org/r/68957/diff/3-4/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into a struct.

://reviews.apache.org/r/68953/diff/4/ Changes: https://reviews.apache.org/r/68953/diff/3-4/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68954: Fix tests broken by allocator options refactor.

check on OSX Thanks, Jacob Janco

Re: Review Request 68957: Add documentation for per-framework metrics flag.

f290e377be9d7424899c82e099be98fc88688de1 Diff: https://reviews.apache.org/r/68957/diff/3/ Changes: https://reviews.apache.org/r/68957/diff/2-3/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into class.

t; On Oct. 10, 2018, 11:10 p.m., James Peach wrote: > > src/master/master.cpp > > Lines 758 (patched) > > <https://reviews.apache.org/r/68953/diff/1/?file=2095461#file2095461line758> > > > > Add a newline here. Done. - Jacob -----

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/#review209464 ------- On Oct. 11, 2018, 11:12 p.m., Jacob Janco wrote: > > ---

Re: Review Request 68953: Refactor allocator configuration into a struct.

/r/68953/diff/3/ Changes: https://reviews.apache.org/r/68953/diff/2-3/ Testing --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

5360, "master/mem_used": 0, "master/messages_authenticate": 0, "master/messages_deactivate_framework": 1, "master/messages_decline_offers": 0, "master/messages_executor_to_framework": 0, "master/messages_exited_executor": 1, "master/messages_framework_to_executor": 0, "master/messages_kill_task": 0, "master/messages_launch_tasks": 1, "master/messages_operation_status_update_acknowledgement": 0, "master/messages_reconcile_operations": 0, "master/messages_reconcile_tasks": 0, "master/messages_register_framework": 1, "master/messages_register_slave": 0, "master/messages_reregister_framework": 0, "master/messages_reregister_slave": 1, "master/messages_resource_request": 0, "master/messages_revive_offers": 0, "master/messages_status_update": 5, "master/messages_status_update_acknowledgement": 0, "master/messages_suppress_offers": 0, "master/messages_unregister_framework": 0, "master/messages_unregister_slave": 0, "master/messages_update_slave": 1, "master/outstanding_offers": 0, "master/recovery_slave_removals": 0, "master/slave_registrations": 0, "master/slave_removals": 0, "master/slave_removals/reason_registered": 0, "master/slave_removals/reason_unhealthy": 0, "master/slave_removals/reason_unregistered": 0, "master/slave_reregistrations": 1, "master/slave_shutdowns_canceled": 0, "master/slave_shutdowns_completed": 0, "master/slave_shutdowns_scheduled": 0, "master/slave_unreachable_canceled": 0, "master/slave_unreachable_completed": 0, "master/slave_unreachable_scheduled": 0, "master/slaves_active": 1, "master/slaves_connected": 1, "master/slaves_disconnected": 0, "master/slaves_inactive": 0, "master/slaves_unreachable": 0, "master/task_failed/source_slave/reason_executor_terminated": 5, "master/tasks_dropped": 0, "master/tasks_error": 0, "master/tasks_failed": 5, "master/tasks_finished": 0, "master/tasks_gone": 0, "master/tasks_gone_by_operator": 0, "master/tasks_killed": 0, "master/tasks_killing": 0, "master/tasks_lost": 0, "master/tasks_running": 0, "master/tasks_staging": 0, "master/tasks_starting": 0, "master/tasks_unreachable": 0, "master/uptime_secs": 6.64713984, "master/valid_executor_to_framework_messages": 0, "master/valid_framework_to_executor_messages": 0, "master/valid_operation_status_update_acknowledgements": 0, "master/valid_status_update_acknowledgements": 0, "master/valid_status_updates": 5, "registrar/log/ensemble_size": 1, "registrar/log/recovered": 1, "registrar/queued_operations": 0, "registrar/registry_size_bytes": 286, "registrar/state_fetch_ms": 2.797824, "registrar/state_store_ms": 4.041728, "system/cpus_total": 8, "system/load_15min": 2.9658203125, "system/load_1min": 1.51708984375, "system/load_5min": 2.09326171875, "system/mem_free_bytes": 6589292544, "system/mem_total_bytes": 17179869184 } Thanks, Jacob Janco

Re: Review Request 68956: Add flag to toggle per framework metrics.

://reviews.apache.org/r/68956/diff/2/ Changes: https://reviews.apache.org/r/68956/diff/1-2/ Testing (updated) --- make check on OSX test-framework in local cluster with flag on/off Thanks, Jacob Janco

Re: Review Request 68954: Fix tests related to allocator options refactor.

5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c Diff: https://reviews.apache.org/r/68954/diff/2/ Changes: https://reviews.apache.org/r/68954/diff/1-2/ Testing (updated) --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68955: Add per framework metrics in member function.

e1da18e6ba2737f729e1e30653020538150ae898 src/master/metrics.cpp 56a7eef2d279ad3248092d37d19013d3ac110757 Diff: https://reviews.apache.org/r/68955/diff/2/ Changes: https://reviews.apache.org/r/68955/diff/1-2/ Testing (updated) --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68957: Add documentation for per-framework metrics flag.

: https://reviews.apache.org/r/68957/diff/2/ Changes: https://reviews.apache.org/r/68957/diff/1-2/ Testing (updated) --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into class.

06d769aeba16586a020729d454f4d00688b78c78 Diff: https://reviews.apache.org/r/68953/diff/2/ Changes: https://reviews.apache.org/r/68953/diff/1-2/ Testing (updated) --- make check on OSX Thanks, Jacob Janco

Re: Review Request 68954: Fix tests related to allocator options refactor.

5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c Diff: https://reviews.apache.org/r/68954/diff/1/ Testing --- Thanks, Jacob Janco

Re: Review Request 68956: Add flag to toggle per framework metrics.

://reviews.apache.org/r/68956/diff/1/ Testing --- Thanks, Jacob Janco

Re: Review Request 68955: Add per framework metrics in member function.

src/master/metrics.cpp 56a7eef2d279ad3248092d37d19013d3ac110757 Diff: https://reviews.apache.org/r/68955/diff/1/ Testing --- Thanks, Jacob Janco

Re: Review Request 68957: Add documentation for per-framework metrics flag.

://reviews.apache.org/r/68957/diff/1/ Testing --- Thanks, Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into class.

06d769aeba16586a020729d454f4d00688b78c78 Diff: https://reviews.apache.org/r/68953/diff/1/ Testing --- Thanks, Jacob Janco

Review Request 68956: Add flag to toggle per framework metrics.

/metrics.hpp e1da18e6ba2737f729e1e30653020538150ae898 src/master/metrics.cpp 56a7eef2d279ad3248092d37d19013d3ac110757 Diff: https://reviews.apache.org/r/68956/diff/1/ Testing --- Thanks, Jacob Janco

Review Request 68953: Refactor allocator configuration into class.

e09a615979014909e7b88d44e6617fd1476415c5 src/master/allocator/mesos/hierarchical.cpp 6f389ed46683f7c642e87b673dc15307cc2b5cd6 src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 Diff: https://reviews.apache.org/r/68953/diff/1/ Testing --- Thanks, Jacob Janco

Review Request 68954: Fix tests related to allocator options refactor.

d6931220139d91620c886591d7916079b8541982 src/tests/resource_offers_tests.cpp 24800c2aa291431e4865e4104da62054b14e5eca src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c Diff: https://reviews.apache.org/r/68954/diff/1/ Testing --- Thanks, Jacob Janco

Review Request 68955: Add per framework metrics in member function.

--- This is a preliminary step for control registering per framework metrics. Diffs - src/master/metrics.hpp e1da18e6ba2737f729e1e30653020538150ae898 src/master/metrics.cpp 56a7eef2d279ad3248092d37d19013d3ac110757 Diff: https://reviews.apache.org/r/68955/diff/1/ Testing --- Thanks, Jacob

Review Request 68957: Add documentation for per-framework metrics flag.

documentation for per-framework metrics flag. Diffs - docs/configuration/master.md f290e377be9d7424899c82e099be98fc88688de1 Diff: https://reviews.apache.org/r/68957/diff/1/ Testing --- Thanks, Jacob Janco

Re: Review Request 53479: Perform agent GC asynchronously.

iew180877 --- On July 18, 2017, 10:15 p.m., Jacob Janco wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 53479: Perform agent GC asynchronously.

/mesos-tests.sh --gtest_filter="GarbageCollector*" --gtest_repeat=100 --gtest_break_on_failure` Thanks, Jacob Janco

Re: Review Request 53479: Perform agent GC asynchronously.

re are no equal > values under the same key in a Multimap (or std::multimap). > > This case shouldn't happen with our GC so we should probably insert some > hard `CHECK`s for it (in a separate patch) but I don't think removing > `promise == that.promise` has anything to do w

Re: Review Request 53479: Perform agent GC asynchronously.

repeat=100 --gtest_break_on_failure` Thanks, Jacob Janco

Re: Review Request 53479: Perform agent GC asynchronously.

generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/#review180730 ------- On July 15, 2017, 1:23 a.m., Jacob Janco wrote: > > --- > Thi

  1   2   3   >