Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

://reviews.apache.org/r/53699/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

://reviews.apache.org/r/53699/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

: https://reviews.apache.org/r/53699/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

: https://reviews.apache.org/r/53699/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

> On Nov. 15, 2016, 2:42 p.m., Sivaram Kannan wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1388 > > <https://reviews.apache.org/r/53473/diff/6/?file=1563497#file1563497line1388> > > > > Passing None() has the agent crashing when we hav

Re: Review Request 53473: Add new param user to logrotate's prepare function.

> On Nov. 15, 2016, 2:42 p.m., Sivaram Kannan wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1388 > > <https://reviews.apache.org/r/53473/diff/6/?file=1563497#file1563497line1388> > > > > Passing None() has the agent crashing when we hav

Re: Review Request 53473: Add new param user to logrotate's prepare function.

> On Nov. 15, 2016, 2:42 p.m., Sivaram Kannan wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1388 > > <https://reviews.apache.org/r/53473/diff/6/?file=1563497#file1563497line1388> > > > > Passing None() has the agent crashing when we hav

Re: Review Request 53473: Add new param user to logrotate's prepare function.

> On Nov. 15, 2016, 2:42 p.m., Sivaram Kannan wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1388 > > <https://reviews.apache.org/r/53473/diff/6/?file=1563497#file1563497line1388> > > > > Passing None() has the agent crashi

Re: Review Request 53473: Add new param user to logrotate's prepare function.

tps://reviews.apache.org/r/53473/#comment226008> Does not make much sense to run docker containrizer with anyother user other than root right?? - Sivaram Kannan On Nov. 14, 2016, 9:52 p.m., Sivaram Kannan wrote: > > --- > This is a

Re: Review Request 53473: Add new param user to logrotate's prepare function.

) <https://reviews.apache.org/r/53473/#comment226007> Passing None() has the agent crashing when we have switch_user=false. - Sivaram Kannan On Nov. 14, 2016, 9:52 p.m., Sivaram Kannan wrote: > > --- > This is an automatica

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

tps://reviews.apache.org/r/53699/#comment226006> Should I remove the below function? - Sivaram Kannan On Nov. 14, 2016, 9:51 p.m., Sivaram Kannan wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

: https://reviews.apache.org/r/53699/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

whether the logs are getting rotated. Thanks, Sivaram Kannan

Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

://reviews.apache.org/r/53473/diff/ Testing --- Thanks, Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

://reviews.apache.org/r/53473/diff/ Testing --- Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Review Request 53473: Add new param user to logrotate's prepare function.

--- Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53306: Change unit test function for new user param in prepare func.

-tests.sh Thanks, Sivaram Kannan

Re: Review Request 53305: Add new param user to logrotate's prepare function.

-tests.sh Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53305: Add new param user to logrotate's prepare function.

tps://reviews.apache.org/r/53305/#comment224025> I think we can delete the rbr #23209 with this change in place right? Should I discard #23209 ? - Sivaram Kannan On Nov. 1, 2016, 2 p.m., Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53305: Add new param user to logrotate's prepare function.

Thanks, Sivaram Kannan

Re: Review Request 53305: Add new param user to logrotate's prepare function.

-tests.sh Thanks, Sivaram Kannan

Re: Review Request 53306: Change unit test function for new user param in prepare func.

and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.

, Sivaram Kannan

Re: Review Request 53305: Add new param user to logrotate's prepare function.

Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.

, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53305: Add new param user to logrotate's prepare function.

Thanks, Sivaram Kannan

Re: Review Request 53305: Add new param user to logrotate's prepare function.

Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53305: Add new param user to logrotate's prepare function.

-tests.sh Thanks, Sivaram Kannan

Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.

Thanks, Sivaram Kannan

Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.

Thanks, Sivaram Kannan

Re: Review Request 53305: Add new param user to logrotate's prepare function.

/mesos-tests.sh Thanks, Sivaram Kannan

Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.

Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Review Request 53305: Add new param user to logrotate's prepare function.

, Sivaram Kannan

Review Request 53306: Modify prepare function of logrotate to accept new param user.

, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

/52311/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

/52311/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

tring is directly used without std here, so, std namespace is imported somewhere right? - Sivaram --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/#review152088 --

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

://reviews.apache.org/r/52311/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Set the user to stderr-logger binary too.

://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Set the user to stderr-logger binary too.

://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Fix removed empty lines from slave.cpp.

rotated. Thanks, Sivaram Kannan

Review Request 52424: Fix removed empty lines from slave.cpp.

empty lines from slave.cpp. Diffs - Diff: https://reviews.apache.org/r/52424/diff/ Testing --- Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Set the user to stderr-logger binary too.

/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

  1   2   >