Review Request 71157: Update docker image before build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71157/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9906 https://issues.apache.org/jira/browse/MESOS-9906 Repository: mesos Description --- We need to run `docker pull` before `docker run` to endusre build is done against latest docker image. Diffs - support/mesos-build.sh ee8ef8b8cfa84067fd7067dd8bf7dbde1cc7e67e Diff: https://reviews.apache.org/r/71157/diff/1/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 71118: Update clang and cmake for arm docker build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71118/ --- (Updated Lip 18, 2019, 7:17 po południu) Review request for mesos and Benjamin Bannier. Repository: mesos Description --- Update clang and cmake for arm docker build. Diffs (updated) - support/mesos-build/ubuntu-16.04-arm.dockerfile d223202e38d1d78554af9c95de1ee78a70dc3818 Diff: https://reviews.apache.org/r/71118/diff/4/ Changes: https://reviews.apache.org/r/71118/diff/3-4/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 71118: Update clang and cmake for arm docker build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71118/ --- (Updated Lip 18, 2019, 7:12 po południu) Review request for mesos and Benjamin Bannier. Repository: mesos Description --- Update clang and cmake for arm docker build. Diffs (updated) - support/mesos-build/ubuntu-16.04-arm.dockerfile d223202e38d1d78554af9c95de1ee78a70dc3818 Diff: https://reviews.apache.org/r/71118/diff/3/ Changes: https://reviews.apache.org/r/71118/diff/2-3/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 71118: Update clang and cmake for arm docker build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71118/ --- (Updated Lip 18, 2019, 7:09 po południu) Review request for mesos and Benjamin Bannier. Repository: mesos Description --- Update clang and cmake for arm docker build. Diffs (updated) - support/mesos-build/ubuntu-16.04-arm.dockerfile d223202e38d1d78554af9c95de1ee78a70dc3818 Diff: https://reviews.apache.org/r/71118/diff/2/ Changes: https://reviews.apache.org/r/71118/diff/1-2/ Testing --- Thanks, Tomasz Janiszewski
Review Request 71118: Update clang and cmake for arm docker build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71118/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description --- Update clang and cmake for arm docker build. Diffs - support/mesos-build/ubuntu-16.04-arm.dockerfile d223202e38d1d78554af9c95de1ee78a70dc3818 Diff: https://reviews.apache.org/r/71118/diff/1/ Testing --- Thanks, Tomasz Janiszewski
Review Request 70727: Fix V1 TaskState invalid enum in test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70727/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description --- > error: comparison between: > `const enum mesos::TaskState` and > `const enum mesos::v1::TaskState` [-Werror=enum-compare] Diffs - src/tests/api_tests.cpp 204c327ad157496f0f47e37bde2d6939e759b6c8 Diff: https://reviews.apache.org/r/70727/diff/1/ Testing --- Thanks, Tomasz Janiszewski
Review Request 70386: Quote chmode arguments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70386/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description --- Quote `chmod` arguments Diffs - support/mesos-build.sh c2d121debdbf26053bc9b699b437933a0682733c Diff: https://reviews.apache.org/r/70386/diff/1/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70102/#review213390 --- Ship it! Ship It! - Tomasz Janiszewski On Mar 3, 2019, 1:02 rano, Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70102/ > --- > > (Updated Mar 3, 2019, 1:02 rano) > > > Review request for mesos, Benjamin Mahler and Tomasz Janiszewski. > > > Repository: mesos > > > Description > --- > > Moved NULL check from cpplint into clang-tidy. > > > Diffs > - > > support/CPPLINT.cfg PRE-CREATION > support/clang-tidy d448314b245a043ced0c4816628cd7c05ea8a68d > support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 > support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 > > > Diff: https://reviews.apache.org/r/70102/diff/1/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Review Request 66138: Add dockerfile for ARM.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66138/ --- Review request for mesos, James Peach, Michael Park, and Vinod Kone. Repository: mesos Description --- Add dockerfile for ARM. Diffs - support/mesos-build/ubuntu-16.04-arm.dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/66138/diff/1/ Testing --- Thanks, Tomasz Janiszewski
Review Request 65569: Install ping for docker build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65569/ --- Review request for mesos, Michael Park and Vinod Kone. Repository: mesos Description --- By default Ubuntu docker image does not contain `ping`. We need to manually install it with `iputils-ping`. Refs: https://stackoverflow.com/a/39901446/1387612 Diffs - support/docker-build.sh 126d4e781086636a318afc9199a3566bdb578051 Diff: https://reviews.apache.org/r/65569/diff/1/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 63400: Fix bad links.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/ --- (Updated Nov. 8, 2017, 5:06 p.m.) Review request for mesos, Andrew Schwartzmeyer, Joerg Schad, and Vinod Kone. Repository: mesos Description --- Fix bad links. Diffs (updated) - docs/app-framework-development-guide.md 6e73e4e1909c315d566fa29b56a54ac47c711e79 docs/cmake.md 84cc3198f4b33b4b259f6995355b6dc9213baa64 docs/cni.md 09159cd26162fe06f7be0519909720b16166ad1e docs/isolators/network-port-mapping.md 522f2edb8ba2c1db28617d22237e6c20a2bf2aa8 docs/upgrades.md b65a3505ae1030274c9307a790691aedda0e418f docs/working-groups.md 19645d1e393e4af7593b42bec0437cf6c5615b1a site/source/blog/2014-03-28-mesos-community-update-1.md 3b8114d6c2eb33200800999c410d1d6030fa5148 site/source/layouts/community_section.erb 07fd28853e119c1d9298a662cc6d73054b6e415f Diff: https://reviews.apache.org/r/63400/diff/3/ Changes: https://reviews.apache.org/r/63400/diff/2-3/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 63400: Fix bad links.
> On Oct. 30, 2017, 6:03 p.m., Andrew Schwartzmeyer wrote: > > site/source/blog/2014-03-28-mesos-community-update-1.md > > Line 31 (original), 31 (patched) > > <https://reviews.apache.org/r/63400/diff/1/?file=1872401#file1872401line31> > > > > The `[lacking a while]` link is missing the colon in `https://`. > > Tomasz Janiszewski wrote: > Good catch. Thanks! > > Vinod Kone wrote: > forgot to push the updated diff? I pushed but forgot to publish :) Fixed. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/#review189620 ------- On Nov. 6, 2017, 2:23 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63400/ > --- > > (Updated Nov. 6, 2017, 2:23 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Joerg Schad, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Fix bad links. > > > Diffs > - > > docs/app-framework-development-guide.md > 6e73e4e1909c315d566fa29b56a54ac47c711e79 > docs/cmake.md 1e1a27ef67d256eb892a5eb455928c2424bb3fed > docs/cni.md 09159cd26162fe06f7be0519909720b16166ad1e > docs/isolators/network-port-mapping.md > 522f2edb8ba2c1db28617d22237e6c20a2bf2aa8 > docs/upgrades.md 6370c06a497161317884f61f376308423b744fe1 > docs/working-groups.md f6af1e39375cab0d0ed61d8c1fa18e4e4c0c1d42 > site/source/blog/2014-03-28-mesos-community-update-1.md > 3b8114d6c2eb33200800999c410d1d6030fa5148 > site/source/layouts/community_section.erb > 07fd28853e119c1d9298a662cc6d73054b6e415f > > > Diff: https://reviews.apache.org/r/63400/diff/2/ > > > Testing > --- > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 63400: Fix bad links.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/ --- (Updated Nov. 6, 2017, 2:23 p.m.) Review request for mesos, Andrew Schwartzmeyer, Joerg Schad, and Vinod Kone. Changes --- Add missing `:` Repository: mesos Description --- Fix bad links. Diffs (updated) - docs/app-framework-development-guide.md 6e73e4e1909c315d566fa29b56a54ac47c711e79 docs/cmake.md 1e1a27ef67d256eb892a5eb455928c2424bb3fed docs/cni.md 09159cd26162fe06f7be0519909720b16166ad1e docs/isolators/network-port-mapping.md 522f2edb8ba2c1db28617d22237e6c20a2bf2aa8 docs/upgrades.md 6370c06a497161317884f61f376308423b744fe1 docs/working-groups.md f6af1e39375cab0d0ed61d8c1fa18e4e4c0c1d42 site/source/blog/2014-03-28-mesos-community-update-1.md 3b8114d6c2eb33200800999c410d1d6030fa5148 site/source/layouts/community_section.erb 07fd28853e119c1d9298a662cc6d73054b6e415f Diff: https://reviews.apache.org/r/63400/diff/2/ Changes: https://reviews.apache.org/r/63400/diff/1-2/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 63400: Fix bad links.
> On Oct. 30, 2017, 6:03 p.m., Andrew Schwartzmeyer wrote: > > site/source/blog/2014-03-28-mesos-community-update-1.md > > Line 31 (original), 31 (patched) > > <https://reviews.apache.org/r/63400/diff/1/?file=1872401#file1872401line31> > > > > The `[lacking a while]` link is missing the colon in `https://`. Good catch. Thanks! - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/#review189620 --- On Oct. 30, 2017, 2:48 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63400/ > --- > > (Updated Oct. 30, 2017, 2:48 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Joerg Schad, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Fix bad links. > > > Diffs > - > > docs/app-framework-development-guide.md > 6e73e4e1909c315d566fa29b56a54ac47c711e79 > docs/cmake.md 1e1a27ef67d256eb892a5eb455928c2424bb3fed > docs/cni.md 09159cd26162fe06f7be0519909720b16166ad1e > docs/isolators/network-port-mapping.md > 522f2edb8ba2c1db28617d22237e6c20a2bf2aa8 > docs/upgrades.md 6370c06a497161317884f61f376308423b744fe1 > docs/working-groups.md f6af1e39375cab0d0ed61d8c1fa18e4e4c0c1d42 > site/source/blog/2014-03-28-mesos-community-update-1.md > 3b8114d6c2eb33200800999c410d1d6030fa5148 > site/source/layouts/community_section.erb > 07fd28853e119c1d9298a662cc6d73054b6e415f > > > Diff: https://reviews.apache.org/r/63400/diff/1/ > > > Testing > --- > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 63400: Fix bad links.
> On Oct. 30, 2017, 6:03 p.m., Andrew Schwartzmeyer wrote: > > docs/cmake.md > > Lines 245-251 (original), 245-250 (patched) > > <https://reviews.apache.org/r/63400/diff/1/?file=1872396#file1872396line245> > > > > This should make no difference, it's part of the base Markdown syntax > > (as in the original spec from Daring Fireball). How is this broken? I thought the same but it generates a relative link that points to http://mesos.apache.org/documentation/latest/cmake/cmake-examples.md#building-debug-or-release-configurations instead of http://mesos.apache.org/documentation/latest/cmake-examples.md#building-debug-or-release-configurations - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/#review189620 ------- On Oct. 30, 2017, 2:48 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63400/ > --- > > (Updated Oct. 30, 2017, 2:48 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Joerg Schad, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Fix bad links. > > > Diffs > - > > docs/app-framework-development-guide.md > 6e73e4e1909c315d566fa29b56a54ac47c711e79 > docs/cmake.md 1e1a27ef67d256eb892a5eb455928c2424bb3fed > docs/cni.md 09159cd26162fe06f7be0519909720b16166ad1e > docs/isolators/network-port-mapping.md > 522f2edb8ba2c1db28617d22237e6c20a2bf2aa8 > docs/upgrades.md 6370c06a497161317884f61f376308423b744fe1 > docs/working-groups.md f6af1e39375cab0d0ed61d8c1fa18e4e4c0c1d42 > site/source/blog/2014-03-28-mesos-community-update-1.md > 3b8114d6c2eb33200800999c410d1d6030fa5148 > site/source/layouts/community_section.erb > 07fd28853e119c1d9298a662cc6d73054b6e415f > > > Diff: https://reviews.apache.org/r/63400/diff/1/ > > > Testing > --- > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 63400: Fix bad links.
> On Oct. 30, 2017, 2:42 p.m., Joerg Schad wrote: > > Would it make sense (in addition to this) to add redirect fromt the old > > pages? There might be external links being broken as well... > > Tomasz Janiszewski wrote: > +1 I've already pointed it here > https://reviews.apache.org/r/63095/#comment266642 I'm not sure if we can do proper 301 redirections in middleman (see: https://middlemanapp.com/basics/redirects/) instead we should identify links that has changed and generate Apache config with 301 redirects. Who operates official Mesos site? - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/#review189577 --- On Oct. 30, 2017, 2:48 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63400/ > --- > > (Updated Oct. 30, 2017, 2:48 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Joerg Schad, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Fix bad links. > > > Diffs > - > > docs/app-framework-development-guide.md > 6e73e4e1909c315d566fa29b56a54ac47c711e79 > docs/cmake.md 1e1a27ef67d256eb892a5eb455928c2424bb3fed > docs/cni.md 09159cd26162fe06f7be0519909720b16166ad1e > docs/isolators/network-port-mapping.md > 522f2edb8ba2c1db28617d22237e6c20a2bf2aa8 > docs/upgrades.md 6370c06a497161317884f61f376308423b744fe1 > docs/working-groups.md f6af1e39375cab0d0ed61d8c1fa18e4e4c0c1d42 > site/source/blog/2014-03-28-mesos-community-update-1.md > 3b8114d6c2eb33200800999c410d1d6030fa5148 > site/source/layouts/community_section.erb > 07fd28853e119c1d9298a662cc6d73054b6e415f > > > Diff: https://reviews.apache.org/r/63400/diff/1/ > > > Testing > --- > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 63400: Fix bad links.
> On Oct. 30, 2017, 2:42 p.m., Joerg Schad wrote: > > Would it make sense (in addition to this) to add redirect fromt the old > > pages? There might be external links being broken as well... +1 I've already pointed it here https://reviews.apache.org/r/63095/#comment266642 - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/#review189577 --- On Oct. 29, 2017, 9:43 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63400/ > --- > > (Updated Oct. 29, 2017, 9:43 p.m.) > > > Review request for mesos, Joerg Schad and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Fix bad links. > > > Diffs > - > > docs/app-framework-development-guide.md > 6e73e4e1909c315d566fa29b56a54ac47c711e79 > docs/cmake.md 1e1a27ef67d256eb892a5eb455928c2424bb3fed > docs/cni.md 09159cd26162fe06f7be0519909720b16166ad1e > docs/isolators/network-port-mapping.md > 522f2edb8ba2c1db28617d22237e6c20a2bf2aa8 > docs/upgrades.md 6370c06a497161317884f61f376308423b744fe1 > docs/working-groups.md f6af1e39375cab0d0ed61d8c1fa18e4e4c0c1d42 > site/source/blog/2014-03-28-mesos-community-update-1.md > 3b8114d6c2eb33200800999c410d1d6030fa5148 > site/source/layouts/community_section.erb > 07fd28853e119c1d9298a662cc6d73054b6e415f > > > Diff: https://reviews.apache.org/r/63400/diff/1/ > > > Testing > --- > > > Thanks, > > Tomasz Janiszewski > >
Review Request 63400: Fix bad links.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/ --- Review request for mesos, Joerg Schad and Vinod Kone. Repository: mesos Description --- Fix bad links. Diffs - docs/app-framework-development-guide.md 6e73e4e1909c315d566fa29b56a54ac47c711e79 docs/cmake.md 1e1a27ef67d256eb892a5eb455928c2424bb3fed docs/cni.md 09159cd26162fe06f7be0519909720b16166ad1e docs/isolators/network-port-mapping.md 522f2edb8ba2c1db28617d22237e6c20a2bf2aa8 docs/upgrades.md 6370c06a497161317884f61f376308423b744fe1 docs/working-groups.md f6af1e39375cab0d0ed61d8c1fa18e4e4c0c1d42 site/source/blog/2014-03-28-mesos-community-update-1.md 3b8114d6c2eb33200800999c410d1d6030fa5148 site/source/layouts/community_section.erb 07fd28853e119c1d9298a662cc6d73054b6e415f Diff: https://reviews.apache.org/r/63400/diff/1/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 63095: Added the Getting Started landing page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63095/#review189526 --- site/config.rb Line 46 (original) <https://reviews.apache.org/r/63095/#comment266642> Why this line was removed? We have an issue with breoken links on offical page https://issues.apache.org/jira/browse/MESOS-8145 and Google already idexed that link and it could be used on external sites such as StackOverflow. We should not break exisitng links – instead provide 301 - Tomasz Janiszewski On Oct. 18, 2017, 6:46 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63095/ > --- > > (Updated Oct. 18, 2017, 6:46 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-8117 > https://issues.apache.org/jira/browse/MESOS-8117 > > > Repository: mesos > > > Description > --- > > After moving the build documentation to its own page, we can now have a > real "Getting Started" page suitable for anyone to get started with > Mesos. It is purposefully short, and therefore not overwhelming. > > > Diffs > - > > site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 > site/source/downloads.html.erb 3e24100a76a99b23ebc6589ee4f7332f43ef0ac9 > site/source/getting-started.html.md PRE-CREATION > site/source/index.html.erb b4e847fadf6682503a4e09139491b539bc59e0fd > site/source/layouts/documentation.erb > a91f916a5fb7348b2702c272e7a2059bdf628c66 > site/source/layouts/getting_started_section.erb PRE-CREATION > site/source/layouts/layout.erb 9213c63e6fef3f57fc225a87a7d7e0abdcc11a88 > > > Diff: https://reviews.apache.org/r/63095/diff/2/ > > > Testing > --- > > Built the site and tested it out locally. > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 63314: Add support for Ubuntu 16.04 in docker build.
> On Oct. 26, 2017, 7:55 a.m., Vinod Kone wrote: > > support/docker-build.sh > > Lines 72 (patched) > > <https://reviews.apache.org/r/63314/diff/1/?file=1869001#file1869001line72> > > > > do we need to install `zlib1g-dev` explicitly in ubuntu 16.04 but not > > in other versions? > > Tomasz Janiszewski wrote: > I'm not sure if we need it in 14.04. I follow instructions from [getting > started](http://mesos.apache.org/documentation/latest/building/#ubuntu-14-04) > and it looks like this are the only difference between 14.04 and 16.04 > https://www.diffchecker.com/Aj4N9M8y @vindo Should I add this package to 14.04 scrip too even if it's not required? - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63314/#review189278 ----------- On Oct. 26, 2017, 8:08 a.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63314/ > --- > > (Updated Oct. 26, 2017, 8:08 a.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Add support for Ubuntu 16.04 in docker build. > > > Diffs > - > > support/docker-build.sh 50e693ca71d499f71f2935923f4691feef560b12 > > > Diff: https://reviews.apache.org/r/63314/diff/2/ > > > Testing > --- > > > Thanks, > > Tomasz Janiszewski > >
Review Request 63379: Set max-size for a book thumbnail on the site.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63379/ --- Review request for mesos and James Peach. Repository: mesos Description --- There is an issue with books thumbnails. Covers are loaded from external resources and we do not control images sizes and ratios. When one book has different ration than other there might be a situation when there is not enough space (vertically) to place items in a row, so they are located in next row leaving a blank space. Diffs - site/source/assets/css/main.css d6ecb18f8c9ce785deee18cb9d131f021b6611f7 Diff: https://reviews.apache.org/r/63379/diff/1/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 63293: Update google-glog to 0.3.5.
> On Oct. 26, 2017, 1:43 a.m., Andrew Schwartzmeyer wrote: > > Is there a pressing need to update this _right now_? As it is, we are > > waiting for 0.3.6 (MESOS-3394) so that we can converge on a single version > > of Glog for all platforms. Nope. We can wait for 0.3.6. We have merged config.guess that open a way to build on ARM. I'll discard this PR. I'm not sure if our all issues will be solved in 0.3.6. The glog patch contains fix for cmake build. I'm not sure if glog 0.3.6 fixes this issue. I'm going to close this PR. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63293/#review189264 ------- On Oct. 25, 2017, 12:28 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63293/ > --- > > (Updated Oct. 25, 2017, 12:28 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-3322 > https://issues.apache.org/jira/browse/MESOS-3322 > > > Repository: mesos > > > Description > --- > > Version 0.3.5 adds support for PowerPC so no patching is required. > > Fixes: MESOS-3322 > Refs: https://github.com/google/glog/releases/tag/v0.3.5 > > > Diffs > - > > 3rdparty/glog-0.3.5.patch ab15bea04d7b8af31a638b7c4ce3256ed2f0df4e > > > Diff: https://reviews.apache.org/r/63293/diff/1/ > > > Testing > --- > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 63314: Add support for Ubuntu 16.04 in docker build.
> On Oct. 26, 2017, 7:55 a.m., Vinod Kone wrote: > > support/docker-build.sh > > Lines 72 (patched) > > <https://reviews.apache.org/r/63314/diff/1/?file=1869001#file1869001line72> > > > > do we need to install `zlib1g-dev` explicitly in ubuntu 16.04 but not > > in other versions? I'm not sure if we need it in 14.04. I follow instructions from [getting started](http://mesos.apache.org/documentation/latest/building/#ubuntu-14-04) and it looks like this are the only difference between 14.04 and 16.04 https://www.diffchecker.com/Aj4N9M8y - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63314/#review189278 ------- On Oct. 26, 2017, 8:08 a.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63314/ > --- > > (Updated Oct. 26, 2017, 8:08 a.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Add support for Ubuntu 16.04 in docker build. > > > Diffs > - > > support/docker-build.sh 50e693ca71d499f71f2935923f4691feef560b12 > > > Diff: https://reviews.apache.org/r/63314/diff/2/ > > > Testing > --- > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 63314: Add support for Ubuntu 16.04 in docker build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63314/ --- (Updated Oct. 26, 2017, 8:08 a.m.) Review request for mesos, Jie Yu and Vinod Kone. Changes --- Make `apt-get install -y` consistent Repository: mesos Description --- Add support for Ubuntu 16.04 in docker build. Diffs (updated) - support/docker-build.sh 50e693ca71d499f71f2935923f4691feef560b12 Diff: https://reviews.apache.org/r/63314/diff/2/ Changes: https://reviews.apache.org/r/63314/diff/1-2/ Testing --- Thanks, Tomasz Janiszewski
Review Request 63315: Allowe override of parallel jobs in docker build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63315/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- Use JOBS env variable to control `make -j` parameter. By default `JOBS=6`. Diffs - support/docker-build.sh 50e693ca71d499f71f2935923f4691feef560b12 Diff: https://reviews.apache.org/r/63315/diff/1/ Testing --- Thanks, Tomasz Janiszewski
Review Request 63314: Add support for Ubuntu 16.04 in docker build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63314/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- Add support for Ubuntu 16.04 in docker build. Diffs - support/docker-build.sh 50e693ca71d499f71f2935923f4691feef560b12 Diff: https://reviews.apache.org/r/63314/diff/1/ Testing --- Thanks, Tomasz Janiszewski
Review Request 63295: Update glog-0.3.3.patch to build on ARM.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63295/ --- Review request for mesos. Repository: mesos Description --- glog has an old version of config.guess this change updates it to the recent version that properly detects ARM architecture. Diffs - 3rdparty/glog-0.3.3.patch f1ed584cf12181307552c3c9429d31759be5de65 Diff: https://reviews.apache.org/r/63295/diff/1/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 63293: Update google-glog to 0.3.5.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63293/ --- (Updated Oct. 25, 2017, 12:28 p.m.) Review request for mesos. Bugs: MESOS-3322 https://issues.apache.org/jira/browse/MESOS-3322 Repository: mesos Description --- Version 0.3.5 adds support for PowerPC so no patching is required. Fixes: MESOS-3322 Refs: https://github.com/google/glog/releases/tag/v0.3.5 Diffs - 3rdparty/glog-0.3.5.patch ab15bea04d7b8af31a638b7c4ce3256ed2f0df4e Diff: https://reviews.apache.org/r/63293/diff/1/ Testing --- Thanks, Tomasz Janiszewski
Review Request 63293: Update google-glog to 0.3.5.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63293/ --- Review request for mesos. Repository: mesos Description --- Version 0.3.5 adds support for PowerPC so no patching is required. Fixes: MESOS-3322 Refs: https://github.com/google/glog/releases/tag/v0.3.5 Diffs - 3rdparty/glog-0.3.5.patch ab15bea04d7b8af31a638b7c4ce3256ed2f0df4e Diff: https://reviews.apache.org/r/63293/diff/1/ Testing --- Thanks, Tomasz Janiszewski
Review Request 63294: Update glog patch (config.guess) to support ARM.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63294/ --- Review request for mesos. Repository: mesos Description --- `config.guess` in glog 0.3.5 do not recognize ARM processors properly. We need to update this script in order to build glog on ARM. The patch could be removed after upgrading to 0.3.6. Diffs - 3rdparty/glog-0.3.5.patch PRE-CREATION Diff: https://reviews.apache.org/r/63294/diff/1/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 63101: Upgrades jQuery used by Mesos WebUI to version 3.2.1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63101/#review188472 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 18, 2017, 10:16 a.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63101/ > --- > > (Updated Oct. 18, 2017, 10:16 a.m.) > > > Review request for mesos, Armand Grillet, Gaston Kleiman, and Tomasz > Janiszewski. > > > Bugs: MESOS-8057 > https://issues.apache.org/jira/browse/MESOS-8057 > > > Repository: mesos > > > Description > --- > > The version of jQuery distributed with Mesos (1.7.1) was found to have > security issues which have been addressed in latter versions. > > > Diffs > - > > src/webui/master/static/index.html 0b977f58fa1f348b582a0e0bcafcb7d170862cf4 > src/webui/master/static/js/jquery-1.7.1.js > 00c4e23a27b15f6158ea46a016beb0ae95c6596d > src/webui/master/static/js/jquery-1.7.1.min.js > 198b3ff07d801dffa2c42fcf3b67eb3295eef85f > src/webui/master/static/js/jquery-3.2.1.js PRE-CREATION > src/webui/master/static/js/jquery-3.2.1.min.js PRE-CREATION > src/webui/master/static/pailer.html > c8ada4b19b88c701b23926121dd6061573c615a4 > > > Diff: https://reviews.apache.org/r/63101/diff/1/ > > > Testing > --- > > manual testing, verified with jQuery Update. Launched a cluster with two > agents and two frameworks. Verified that the UI behaved as before. > > > Thanks, > > Alexander Rojas > >
Re: Review Request 63102: Upgrades AngularJS used by Mesos WebUI to version 1.2.32.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63102/#review188471 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 18, 2017, 10:21 a.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63102/ > --- > > (Updated Oct. 18, 2017, 10:21 a.m.) > > > Review request for mesos, Armand Grillet, Gaston Kleiman, and Tomasz > Janiszewski. > > > Bugs: MESOS-8057 > https://issues.apache.org/jira/browse/MESOS-8057 > > > Repository: mesos > > > Description > --- > > The version of AngularJS distributed with Mesos (1.2.3) was found to > have security issues which have been addressed in latter versions. > > > Diffs > - > > src/webui/master/static/index.html 0b977f58fa1f348b582a0e0bcafcb7d170862cf4 > src/webui/master/static/js/angular-1.2.3.js > 41afab54ba4403d4fc8c65f68fe0b2b5709800ca > src/webui/master/static/js/angular-1.2.3.min.js > 3f93ab77219374de24146f30e17bad4c02f1a93d > src/webui/master/static/js/angular-1.2.32.min.js PRE-CREATION > src/webui/master/static/js/angular-route-1.2.3.js > 532d1e7fe8610384f8548956a3d786f8407aaff2 > src/webui/master/static/js/angular-route-1.2.3.min.js > 5870a6a82472bce06388d16f88ffa11fd2be2e81 > src/webui/master/static/js/angular-route-1.2.32.min.js PRE-CREATION > > > Diff: https://reviews.apache.org/r/63102/diff/1/ > > > Testing > --- > > manual testing Launched a cluster with two agents and two frameworks. > Verified that the UI behaved as before. > > > Thanks, > > Alexander Rojas > >
Re: Review Request 58874: Stripped spaces between directory elements in WebUI.
> On Maj 11, 2017, 8:35 rano, Tomasz Janiszewski wrote:
> > src/webui/master/static/browse.html
> > Lines 17-20 (original), 17-20 (patched)
> > <https://reviews.apache.org/r/58874/diff/3/?file=1710161#file1710161line17>
> >
> > How about usign `` here instead of list? Then `/` will be just
> > visible text and then copyalbe whitouth hacks with zero sized text.
> >
> >
> > I haven't tested this but below code is what I think it could look like.
> > ```
> >
> >
> >
> > {{dir}}
> >
> > /
> >
> >
> > ```
>
> Tomasz Janiszewski wrote:
> I've tested following code. It looks similar
> ```diff
>
> diff --git a/src/webui/master/static/browse.html
> b/src/webui/master/static/browse.html
> index b984919..0594f81 100644
> --- a/src/webui/master/static/browse.html
> +++ b/src/webui/master/static/browse.html
> @@ -11,14 +11,15 @@
>
>
>
> -
> -
> -
> +
> + href="#/agents/{{agent_id}}/browse?path={{
> encodeURIComponent(path.split('/').slice(0, $index +
> 1).join('/'))}}">
> + /
>{{dir}}
>
> -
> -
> +
> +
>
>
>×
> diff --git a/src/webui/master/static/css/mesos.css
> b/src/webui/master/static/css/mesos.css
> index 9f3de54..21e3ef1 100644
> --- a/src/webui/master/static/css/mesos.css
> +++ b/src/webui/master/static/css/mesos.css
> @@ -41,6 +41,11 @@
>content: "/";
> }
>
> +.dir {
> + padding: 0 5px 0 0;
> + color: #ccc;
> +}
> +
> /*
> * /BOOTSTRAP OVERRIDES
> */
>
> ```
>
> haosdent huang wrote:
> Hi, @janisz very sorry for the delay. I try this patch, but the spcaces
> is still there. Seems didn't resolve our problem.
No problem. I think we can merge it as is.
- Tomasz
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58874/#review174615
---
On Cze 20, 2017, 7:58 rano, haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58874/
> ---
>
> (Updated Cze 20, 2017, 7:58 rano)
>
>
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
>
>
> Bugs: MESOS-7468
> https://issues.apache.org/jira/browse/MESOS-7468
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Stripped spaces between directory elements in WebUI.
>
>
> Diffs
> -
>
> src/webui/master/static/browse.html
> b9849197227b06df348789a49348e2b5d4cfd2ae
> src/webui/master/static/css/mesos.css
> 9f3de5427071fc61d3791c4bc2a660368c2cd3c2
>
>
> Diff: https://reviews.apache.org/r/58874/diff/4/
>
>
> Testing
> ---
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 59796: Show used resources in per-framework page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59796/#review176906 --- Ship it! Ship It! - Tomasz Janiszewski On Cze 5, 2017, 4:50 rano, haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59796/ > --- > > (Updated Cze 5, 2017, 4:50 rano) > > > Review request for mesos, Benjamin Mahler, Tomasz Janiszewski, Neil Fordyce, > and Vinod Kone. > > > Bugs: MESOS-7458 > https://issues.apache.org/jira/browse/MESOS-7458 > > > Repository: mesos > > > Description > --- > > Show used resources in per-framework page. > > > Diffs > - > > src/webui/master/static/framework.html > ee683bc22354b1726abe256ca991df2d7c67faeb > > > Diff: https://reviews.apache.org/r/59796/diff/1/ > > > Testing > --- > > see screenhost in attached file. > > > File Attachments > > > screenshot.png > > https://reviews.apache.org/media/uploaded/files/2017/06/05/240a56ea-dd0d-49c2-a683-6a0ffe08f7a6__screenshot.png > > > Thanks, > > haosdent huang > >
Re: Review Request 58874: Stripped spaces between directory elements in WebUI.
> On Maj 11, 2017, 8:35 rano, Tomasz Janiszewski wrote:
> > src/webui/master/static/browse.html
> > Lines 17-20 (original), 17-20 (patched)
> > <https://reviews.apache.org/r/58874/diff/3/?file=1710161#file1710161line17>
> >
> > How about usign `` here instead of list? Then `/` will be just
> > visible text and then copyalbe whitouth hacks with zero sized text.
> >
> >
> > I haven't tested this but below code is what I think it could look like.
> > ```
> >
> >
> >
> > {{dir}}
> >
> > /
> >
> >
> > ```
I've tested following code. It looks similar
```diff
diff --git a/src/webui/master/static/browse.html
b/src/webui/master/static/browse.html
index b984919..0594f81 100644
--- a/src/webui/master/static/browse.html
+++ b/src/webui/master/static/browse.html
@@ -11,14 +11,15 @@
-
-
-
+
+
+ /
{{dir}}
-
-
+
+
×
diff --git a/src/webui/master/static/css/mesos.css
b/src/webui/master/static/css/mesos.css
index 9f3de54..21e3ef1 100644
--- a/src/webui/master/static/css/mesos.css
+++ b/src/webui/master/static/css/mesos.css
@@ -41,6 +41,11 @@
content: "/";
}
+.dir {
+ padding: 0 5px 0 0;
+ color: #ccc;
+}
+
/*
* /BOOTSTRAP OVERRIDES
*/
```
- Tomasz
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58874/#review174615
---
On Maj 8, 2017, 8:01 rano, haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58874/
> -------
>
> (Updated Maj 8, 2017, 8:01 rano)
>
>
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
>
>
> Bugs: MESOS-7468
> https://issues.apache.org/jira/browse/MESOS-7468
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Stripped spaces between directory elements in WebUI.
>
>
> Diffs
> -
>
> src/webui/master/static/browse.html
> b9849197227b06df348789a49348e2b5d4cfd2ae
> src/webui/master/static/css/mesos.css
> 9f3de5427071fc61d3791c4bc2a660368c2cd3c2
>
>
> Diff: https://reviews.apache.org/r/58874/diff/3/
>
>
> Testing
> ---
>
>
> File Attachments
>
>
> strip_space.gif
>
> https://reviews.apache.org/media/uploaded/files/2017/05/03/79afd0b1-5fb1-437c-a91c-732009af8fe3__strip_space.gif
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 58874: Stripped spaces between directory elements in WebUI.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58874/#review174615
---
src/webui/master/static/browse.html
Lines 17-20 (original), 17-20 (patched)
<https://reviews.apache.org/r/58874/#comment247820>
How about usign `` here instead of list? Then `/` will be just
visible text and then copyalbe whitouth hacks with zero sized text.
I haven't tested this but below code is what I think it could look like.
```
{{dir}}
/
```
- Tomasz Janiszewski
On Maj 8, 2017, 8:01 rano, haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58874/
> ---
>
> (Updated Maj 8, 2017, 8:01 rano)
>
>
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
>
>
> Bugs: MESOS-7468
> https://issues.apache.org/jira/browse/MESOS-7468
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Stripped spaces between directory elements in WebUI.
>
>
> Diffs
> -
>
> src/webui/master/static/browse.html
> b9849197227b06df348789a49348e2b5d4cfd2ae
> src/webui/master/static/css/mesos.css
> 9f3de5427071fc61d3791c4bc2a660368c2cd3c2
>
>
> Diff: https://reviews.apache.org/r/58874/diff/3/
>
>
> Testing
> ---
>
>
> File Attachments
>
>
> strip_space.gif
>
> https://reviews.apache.org/media/uploaded/files/2017/05/03/79afd0b1-5fb1-437c-a91c-732009af8fe3__strip_space.gif
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 56193: Use Docker cpus instead of cpu_share if possible.
> On Mar 27, 2017, 8:38 po południu, Jie Yu wrote: > > src/docker/docker.cpp > > Lines 524 (patched) > > <https://reviews.apache.org/r/56193/diff/1/?file=1621829#file1621829line524> > > > > Can you test if docker support arbitratry double here like 1.01 > > (more than 3 digits after decimal point)? > > > > Also, looks like 0.000 means unlimited. I am wondering if we should set > > a MIN_CPUS here just to be consistent with the cpu share based semantics. Yep, 0.000 means unlimited. Docker internay represnets cpus as [`NanoCPUs`](https://github.com/moby/moby/blob/a258ef58d8a100467d5d948b026a884ebe58eaf4/opts/opts.go#L344-L383). After introducting DockerRunOptions this patch makes no sense until docker deprecate old CPUs respurces API. I'll close it. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56193/#review170223 ------- On Lut 1, 2017, 10:31 po południu, Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56193/ > --- > > (Updated Lut 1, 2017, 10:31 po południu) > > > Review request for mesos, Jie Yu and Kevin Klues. > > > Bugs: MESOS-7006 > https://issues.apache.org/jira/browse/MESOS-7006 > > > Repository: mesos > > > Description > --- > > Docker 1.13 introduces new flag `--cpus` for limiting cpu usage > of a container. We can use this flag to avoid cpu share calculation > and just pass cpus resources to Docker. > > > Diffs > - > > src/docker/docker.cpp b63b060ba1c1d39dc1702368cf667831edbd39bd > > > Diff: https://reviews.apache.org/r/56193/diff/1/ > > > Testing > --- > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.
> On Maj 1, 2017, 8:45 po południu, Tomasz Janiszewski wrote:
> > src/webui/master/static/js/controllers.js
> > Lines 1024 (patched)
> > <https://reviews.apache.org/r/58872/diff/1/?file=1703827#file1703827line1024>
> >
> > It's not obious why we remove update listener on route change start.
> > Can you add a comment with clarification?
>
> haosdent huang wrote:
> It is because we no need to call this again if route change, so we remove
> it here. We do it in almost places which depends on `$scope.state`.
>
> ```
> var removeListener = $scope.$on('state_updated', update);
> $scope.$on('$routeChangeStart', removeListener);
> ```
>
> Do you think we need to add comment about this here?
No that's fine. Just spoted it's a template.
- Tomasz
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58872/#review173504
---
On Maj 3, 2017, 4:15 rano, haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58872/
> -------
>
> (Updated Maj 3, 2017, 4:15 rano)
>
>
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
>
>
> Bugs: MESOS-4992
> https://issues.apache.org/jira/browse/MESOS-4992
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Open sandbox link in a new tab would fail since it depends on agents
> information loading finish. This patch fixes it by ensuring the agents
> information loaded first and then rerouting the sandbox request.
>
>
> Diffs
> -
>
> src/webui/master/static/js/controllers.js
> a021962573d452de1581e6a7717016eac7d0cd85
>
>
> Diff: https://reviews.apache.org/r/58872/diff/2/
>
>
> Testing
> ---
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 58874: Stripped spaces between directory elements in WebUI.
> On Maj 1, 2017, 8:14 po południu, Tomasz Janiszewski wrote:
> > src/webui/master/static/browse.html
> > Line 17 (original), 17 (patched)
> > <https://reviews.apache.org/r/58874/diff/1/?file=1703836#file1703836line17>
> >
> > Could you keep original formatting?
>
> haosdent huang wrote:
> Change to
>
> ```
> href="#/agents/{{agent_id}}/browse?path={{
> encodeURIComponent(path.split('/').slice(0, $index +
> 1).join('/'))
> }}">{{dir}}/
> ```
>
> Is it match you expection here?
That's OK. We must keep everything in one line to prevent newlines and spaces
to appear.
> On Maj 1, 2017, 8:14 po południu, Tomasz Janiszewski wrote:
> > src/webui/master/static/css/mesos.css
> > Lines 180 (patched)
> > <https://reviews.apache.org/r/58874/diff/1/?file=1703837#file1703837line180>
> >
> > I think this should be replaced with `visibility: hidden;`. With
> > `font-size: 0;` there is different (smaller) padding then before the change.
>
> haosdent huang wrote:
> Oh, I didn't use it because with `visibility: hidden`, the copy content
> would not include `` in my browser. Is it work in your side?
My mistake, I'm sorry.
- Tomasz
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58874/#review173499
---
On Maj 3, 2017, 4:29 rano, haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58874/
> ---
>
> (Updated Maj 3, 2017, 4:29 rano)
>
>
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Stripped spaces between directory elements in WebUI.
>
>
> Diffs
> -
>
> src/webui/master/static/browse.html
> b9849197227b06df348789a49348e2b5d4cfd2ae
> src/webui/master/static/css/mesos.css
> 9f3de5427071fc61d3791c4bc2a660368c2cd3c2
>
>
> Diff: https://reviews.apache.org/r/58874/diff/2/
>
>
> Testing
> ---
>
>
> File Attachments
>
>
> strip_space.gif
>
> https://reviews.apache.org/media/uploaded/files/2017/05/03/79afd0b1-5fb1-437c-a91c-732009af8fe3__strip_space.gif
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58872/#review173504 --- Fix it, then Ship it! I tested it and it fixes the issue. I think code need some comments, it's simple but not obvious. src/webui/master/static/js/controllers.js Lines 1019 (patched) <https://reviews.apache.org/r/58872/#comment246494> Please add a comment for this condition with information why it can happen. The comment could be the same as previously used: > When navigating directly to this page, e.g. pasting the URL into the browser src/webui/master/static/js/controllers.js Lines 1024 (patched) <https://reviews.apache.org/r/58872/#comment246496> It's not obious why we remove update listener on route change start. Can you add a comment with clarification? - Tomasz Janiszewski On Kwi 29, 2017, 6:22 po południu, haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58872/ > --- > > (Updated Kwi 29, 2017, 6:22 po południu) > > > Review request for mesos, Benjamin Mahler and Tomasz Janiszewski. > > > Bugs: MESOS-4992 > https://issues.apache.org/jira/browse/MESOS-4992 > > > Repository: mesos > > > Description > --- > > Ensured sandbox URI request reroute after fetched `$scope.state`. > > > Diffs > - > > src/webui/master/static/js/controllers.js > a021962573d452de1581e6a7717016eac7d0cd85 > > > Diff: https://reviews.apache.org/r/58872/diff/1/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 58874: Stripped spaces between directory elements in WebUI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review173499 --- Fix it, then Ship it! Nice usability improvement. src/webui/master/static/browse.html Line 17 (original), 17 (patched) <https://reviews.apache.org/r/58874/#comment246488> Could you keep original formatting? src/webui/master/static/css/mesos.css Lines 180 (patched) <https://reviews.apache.org/r/58874/#comment246487> I think this should be replaced with `visibility: hidden;`. With `font-size: 0;` there is different (smaller) padding then before the change. - Tomasz Janiszewski On Kwi 30, 2017, 4:29 rano, haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58874/ > --- > > (Updated Kwi 30, 2017, 4:29 rano) > > > Review request for mesos, Benjamin Mahler and Tomasz Janiszewski. > > > Repository: mesos > > > Description > --- > > Stripped spaces between directory elements in WebUI. > > > Diffs > - > > src/webui/master/static/browse.html > b9849197227b06df348789a49348e2b5d4cfd2ae > src/webui/master/static/css/mesos.css > 9f3de5427071fc61d3791c4bc2a660368c2cd3c2 > > > Diff: https://reviews.apache.org/r/58874/diff/1/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 48291: Use varint comparator in replica log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48291/ --- (Updated Mar 11, 2017, 10:17 rano) Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang. Changes --- Update jira issue Bugs: MESOS-7233 https://issues.apache.org/jira/browse/MESOS-7233 Repository: mesos Description --- Since bug discussed at https://groups.google.com/forum/#!topic/leveldb/F-rDkWiQm6c was fixed. After upgrading leveldb to 1.18 we could replace default byte-wise comparator with varint comparator. Diffs - src/log/leveldb.cpp 5310a123b0fb25f240429722b676fe46174cb2ce Diff: https://reviews.apache.org/r/48291/diff/3/ Testing --- `make check dist` on Ubuntu x64 Thanks, Tomasz Janiszewski
Re: Review Request 48291: Use varint comparator in replica log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48291/ --- (Updated Lut 26, 2017, 5:12 rano) Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang. Changes --- rebase Bugs: MESOS-970 https://issues.apache.org/jira/browse/MESOS-970 Repository: mesos Description --- Since bug discussed at https://groups.google.com/forum/#!topic/leveldb/F-rDkWiQm6c was fixed. After upgrading leveldb to 1.18 we could replace default byte-wise comparator with varint comparator. Diffs (updated) - src/log/leveldb.cpp 5310a123b0fb25f240429722b676fe46174cb2ce Diff: https://reviews.apache.org/r/48291/diff/ Testing --- `make check dist` on Ubuntu x64 Thanks, Tomasz Janiszewski
Re: Review Request 56847: Removed unnecessary leveldb build rules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/ --- (Updated Feb. 20, 2017, 4:45 p.m.) Review request for mesos and haosdent huang. Bugs: MESOS-7146 https://issues.apache.org/jira/browse/MESOS-7146 Repository: mesos Description (updated) --- After upgraded to leveldb 1.19, the default CXXFLAGS of Mesos conflict with the require flags when building `db/c_test.c` with clang in macOS. This patch disables unnecessary rules in leveldb and bypass build failures in macOS. Diffs (updated) - 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9 Diff: https://reviews.apache.org/r/56847/diff/ Testing (updated) --- `make -j8` in macOS. `make -j24 GTEST_FILTER="*"` in CentOS 7. Thanks, Tomasz Janiszewski
Re: Review Request 56847: Removed unnecessary leveldb build rules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/ --- (Updated Feb. 20, 2017, 4:35 p.m.) Review request for mesos and haosdent huang. Bugs: MESOS-7146 https://issues.apache.org/jira/browse/MESOS-7146 Repository: mesos Description --- After upgraded to leveldb 1.19, the default CXXFLAGS of Mesos conflict with the require flags when building `db/c_test.c` with clang in macOS. This patch disables unnecessary rules in leveldb and bypass build failures in macOS. Diffs - 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9 Diff: https://reviews.apache.org/r/56847/diff/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 56847: Removed unnecessary leveldb build rules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/ --- (Updated Feb. 20, 2017, 4:33 p.m.) Review request for mesos and haosdent huang. Summary (updated) - Removed unnecessary leveldb build rules. Repository: mesos Description (updated) --- After upgraded to leveldb 1.19, the default CXXFLAGS of Mesos conflict with the require flags when building `db/c_test.c` with clang in macOS. This patch disables unnecessary rules in leveldb and bypass build failures in macOS. Diffs - 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9 Diff: https://reviews.apache.org/r/56847/diff/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 56847: Remove unecessary leveldb build rule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/ --- (Updated Feb. 20, 2017, 11:52 a.m.) Review request for mesos and haosdent huang. Repository: mesos Description --- Remove unecessary leveldb build rule. Diffs (updated) - 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9 Diff: https://reviews.apache.org/r/56847/diff/ Testing --- Thanks, Tomasz Janiszewski
Review Request 56847: Remove unecessary leveldb build rule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/ --- Review request for mesos and haosdent huang. Repository: mesos Description --- Remove unecessary leveldb build rule. Diffs - 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9 Diff: https://reviews.apache.org/r/56847/diff/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 51053: Update leveldb to 1.19.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51053/ --- (Updated Feb. 20, 2017, 4:41 a.m.) Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent huang, and Vinod Kone. Bugs: MESOS-970 https://issues.apache.org/jira/browse/MESOS-970 Repository: mesos Description --- Leveldb in modern version is required to support s390x and arm64. It's also required to replace default byte-wise comparator with varint comparator in \`src/log/leveldb.cpp\`. Diffs - 3rdparty/Makefile.am bbf9cfe7125b193003115f440a00c91e2e68f404 3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8 3rdparty/cmake/Versions.cmake ad23f3895b49d623709c0939d63a0529654788ef 3rdparty/leveldb-1.19.patch PRE-CREATION 3rdparty/leveldb-1.19.tar.gz PRE-CREATION 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 3rdparty/versions.am 26f839cd8d454de91f10c2e616e78decc30eff1b LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5 Diff: https://reviews.apache.org/r/51053/diff/ Testing (updated) --- make -j 8 distcheck Test document: https://docs.google.com/document/d/1fv2OMvH6hVm6waacOejSrTJwUuDQeXlqqPDZjBmbcKU/edit?usp=sharing Thanks, Tomasz Janiszewski
Re: Review Request 51053: Update leveldb to 1.19.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51053/ --- (Updated Feb. 15, 2017, 8:44 p.m.) Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent huang, and Vinod Kone. Bugs: MESOS-970 https://issues.apache.org/jira/browse/MESOS-970 Repository: mesos Description --- Leveldb in modern version is required to support s390x and arm64. It's also required to replace default byte-wise comparator with varint comparator in \`src/log/leveldb.cpp\`. Diffs (updated) - 3rdparty/Makefile.am bbf9cfe7125b193003115f440a00c91e2e68f404 3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8 3rdparty/cmake/Versions.cmake ad23f3895b49d623709c0939d63a0529654788ef 3rdparty/leveldb-1.19.patch PRE-CREATION 3rdparty/leveldb-1.19.tar.gz PRE-CREATION 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 3rdparty/versions.am 26f839cd8d454de91f10c2e616e78decc30eff1b LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5 Diff: https://reviews.apache.org/r/51053/diff/ Testing --- make -j 8 distcheck benchamrks: https://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872 Thanks, Tomasz Janiszewski
Re: Review Request 53741: Show maintainance schedule info in the WebUI.
> On Feb. 6, 2017, 9:30 a.m., haosdent huang wrote: > > I would fix these issues for you. Please take a look. Thanks a lot for your > > contribution! @haosdent Thanks for taking care of it. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review164323 --- On Feb. 6, 2017, 9:29 a.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53741/ > --- > > (Updated Feb. 6, 2017, 9:29 a.m.) > > > Review request for mesos, haosdent huang and Joseph Wu. > > > Bugs: MESOS-6443 > https://issues.apache.org/jira/browse/MESOS-6443 > > > Repository: mesos > > > Description > --- > > Create new page with Maintenance schedule. Schedule is downloaded on > page refresh. Schedule is not live like stats and tasks so there is > no need to poll it periodically. > Diable sorting when data-key is not defined in table header. > > > Diffs > - > > src/webui/master/static/index.html 7c6a8ad56437c2315fc563d469ed0426286b48ce > src/webui/master/static/js/app.js 558a67ddf59a39db43023b4f7aa26b7e319924b0 > src/webui/master/static/js/controllers.js > 07bc612a4d7a6b4b418de964303e8fb7083b5d31 > src/webui/master/static/maintenance.html PRE-CREATION > > Diff: https://reviews.apache.org/r/53741/diff/ > > > Testing > --- > > [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png) > > Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 > entires schedule generated with > [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 53741: Show maintainance schedule info in the WebUI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/ --- (Updated Feb. 6, 2017, 9:29 a.m.) Review request for mesos, haosdent huang and Joseph Wu. Summary (updated) - Show maintainance schedule info in the WebUI. Bugs: MESOS-6443 https://issues.apache.org/jira/browse/MESOS-6443 Repository: mesos Description --- Create new page with Maintenance schedule. Schedule is downloaded on page refresh. Schedule is not live like stats and tasks so there is no need to poll it periodically. Diable sorting when data-key is not defined in table header. Diffs - src/webui/master/static/index.html 7c6a8ad56437c2315fc563d469ed0426286b48ce src/webui/master/static/js/app.js 558a67ddf59a39db43023b4f7aa26b7e319924b0 src/webui/master/static/js/controllers.js 07bc612a4d7a6b4b418de964303e8fb7083b5d31 src/webui/master/static/maintenance.html PRE-CREATION Diff: https://reviews.apache.org/r/53741/diff/ Testing --- [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png) Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 entires schedule generated with [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) Thanks, Tomasz Janiszewski
Review Request 56193: Use Docker cpus instead of cpu_share if possible.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56193/ --- Review request for mesos, Jie Yu and Kevin Klues. Bugs: MESOS-7006 https://issues.apache.org/jira/browse/MESOS-7006 Repository: mesos Description --- Docker 1.13 introduces new flag `--cpus` for limiting cpu usage of a container. We can use this flag to avoid cpu share calculation and just pass cpus resources to Docker. Diffs - src/docker/docker.cpp b63b060ba1c1d39dc1702368cf667831edbd39bd Diff: https://reviews.apache.org/r/56193/diff/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 48291: Use varint comparator in replica log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48291/ --- (Updated Jan. 29, 2017, 2:56 p.m.) Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang. Changes --- rebase Bugs: MESOS-970 https://issues.apache.org/jira/browse/MESOS-970 Repository: mesos Description --- Since bug discussed at https://groups.google.com/forum/#!topic/leveldb/F-rDkWiQm6c was fixed. After upgrading leveldb to 1.18 we could replace default byte-wise comparator with varint comparator. Diffs (updated) - src/log/leveldb.cpp 5310a123b0fb25f240429722b676fe46174cb2ce Diff: https://reviews.apache.org/r/48291/diff/ Testing --- `make check dist` on Ubuntu x64 Thanks, Tomasz Janiszewski
Re: Review Request 48291: Use varint comparator in replica log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48291/ --- (Updated Jan. 29, 2017, 2:54 p.m.) Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang. Bugs: MESOS-970 https://issues.apache.org/jira/browse/MESOS-970 Repository: mesos Description --- Since bug discussed at https://groups.google.com/forum/#!topic/leveldb/F-rDkWiQm6c was fixed. After upgrading leveldb to 1.18 we could replace default byte-wise comparator with varint comparator. Diffs - src/log/leveldb.cpp f389d74b123574665c611b46cb52e3dc7042b331 Diff: https://reviews.apache.org/r/48291/diff/ Testing --- `make check dist` on Ubuntu x64 Thanks, Tomasz Janiszewski
Re: Review Request 51053: Update leveldb to 1.19.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51053/ --- (Updated Jan. 29, 2017, 2:52 p.m.) Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent huang, and Vinod Kone. Changes --- Rebase Bugs: MESOS-970 https://issues.apache.org/jira/browse/MESOS-970 Repository: mesos Description (updated) --- Leveldb in modern version is required to support s390x and arm64. It's also required to replace default byte-wise comparator with varint comparator in \`src/log/leveldb.cpp\`. Diffs (updated) - 3rdparty/Makefile.am bbf9cfe7125b193003115f440a00c91e2e68f404 3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8 3rdparty/cmake/Versions.cmake ad23f3895b49d623709c0939d63a0529654788ef 3rdparty/leveldb-1.19.patch PRE-CREATION 3rdparty/leveldb-1.19.tar.gz PRE-CREATION 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 3rdparty/versions.am 26f839cd8d454de91f10c2e616e78decc30eff1b LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5 Diff: https://reviews.apache.org/r/51053/diff/ Testing --- make -j 8 distcheck benchamrks: https://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872 Thanks, Tomasz Janiszewski
Re: Review Request 53741: Display maintainance info in the webui.
> On Jan. 25, 2017, 6:16 p.m., haosdent huang wrote: > > Hi, may you mind rebase this. Done. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review162986 --- On Jan. 29, 2017, 2:48 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53741/ > --- > > (Updated Jan. 29, 2017, 2:48 p.m.) > > > Review request for mesos, haosdent huang and Joseph Wu. > > > Bugs: MESOS-6443 > https://issues.apache.org/jira/browse/MESOS-6443 > > > Repository: mesos > > > Description > --- > > Create new page with Maintenance schedule. Schedule is downloaded on > page refresh. Schedule is not live like stats and tasks so there is > no need to poll it periodically. > Diable sorting when data-key is not defined in table header. > > > Diffs > - > > src/webui/master/static/index.html 7c6a8ad56437c2315fc563d469ed0426286b48ce > src/webui/master/static/js/app.js 558a67ddf59a39db43023b4f7aa26b7e319924b0 > src/webui/master/static/js/controllers.js > 07bc612a4d7a6b4b418de964303e8fb7083b5d31 > src/webui/master/static/maintenance.html PRE-CREATION > > Diff: https://reviews.apache.org/r/53741/diff/ > > > Testing > --- > > [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png) > > Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 > entires schedule generated with > [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 53741: Display maintainance info in the webui.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/ --- (Updated Jan. 29, 2017, 2:48 p.m.) Review request for mesos, haosdent huang and Joseph Wu. Changes --- Rebase and retest Bugs: MESOS-6443 https://issues.apache.org/jira/browse/MESOS-6443 Repository: mesos Description --- Create new page with Maintenance schedule. Schedule is downloaded on page refresh. Schedule is not live like stats and tasks so there is no need to poll it periodically. Diable sorting when data-key is not defined in table header. Diffs (updated) - src/webui/master/static/index.html 7c6a8ad56437c2315fc563d469ed0426286b48ce src/webui/master/static/js/app.js 558a67ddf59a39db43023b4f7aa26b7e319924b0 src/webui/master/static/js/controllers.js 07bc612a4d7a6b4b418de964303e8fb7083b5d31 src/webui/master/static/maintenance.html PRE-CREATION Diff: https://reviews.apache.org/r/53741/diff/ Testing --- [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png) Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 entires schedule generated with [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) Thanks, Tomasz Janiszewski
Re: Review Request 53288: Updated the brand in navbar to Mesos logo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53288/#review156314 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 29, 2016, 4:04 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53288/ > --- > > (Updated Oct. 29, 2016, 4:04 p.m.) > > > Review request for mesos, Benjamin Mahler and Vinod Kone. > > > Bugs: MESOS-6379 > https://issues.apache.org/jira/browse/MESOS-6379 > > > Repository: mesos > > > Description > --- > > Updated the brand in navbar to Mesos logo. > > > Diffs > - > > src/webui/master/static/css/mesos.css > 5b1227e9d64757f9fc106e497f7fa3ed72112c10 > src/webui/master/static/img/mesos_logo.png PRE-CREATION > src/webui/master/static/index.html 6211892e7d689df9bf3b2a9071a76ad4c60d0485 > > Diff: https://reviews.apache.org/r/53288/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 53289: Updated favicon.ico.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53289/#review156315 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 30, 2016, 1:40 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53289/ > --- > > (Updated Oct. 30, 2016, 1:40 p.m.) > > > Review request for mesos, Benjamin Mahler and Vinod Kone. > > > Bugs: MESOS-6379 > https://issues.apache.org/jira/browse/MESOS-6379 > > > Repository: mesos > > > Description > --- > > Updated favicon.ico. > > > Diffs > - > > src/webui/master/static/ico/favicon.ico > 737c102678f040b8281eeb83302734c03bc3a485 > > Diff: https://reviews.apache.org/r/53289/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 53287: Overrided the default navbar color to match project website.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53287/#review156313 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 29, 2016, 4:04 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53287/ > --- > > (Updated Oct. 29, 2016, 4:04 p.m.) > > > Review request for mesos, Benjamin Mahler and Vinod Kone. > > > Bugs: MESOS-6379 > https://issues.apache.org/jira/browse/MESOS-6379 > > > Repository: mesos > > > Description > --- > > Overrided the default navbar color to match project website. > > > Diffs > - > > src/webui/master/static/css/mesos.css > 5b1227e9d64757f9fc106e497f7fa3ed72112c10 > > Diff: https://reviews.apache.org/r/53287/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 53286: Applied material style in WebUI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53286/#review156312 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 29, 2016, 4:04 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53286/ > --- > > (Updated Oct. 29, 2016, 4:04 p.m.) > > > Review request for mesos, Benjamin Mahler and Vinod Kone. > > > Bugs: MESOS-6379 > https://issues.apache.org/jira/browse/MESOS-6379 > > > Repository: mesos > > > Description > --- > > Applied material style in WebUI. > > > Diffs > - > > src/webui/master/static/css/bootstrap-material-design.css PRE-CREATION > src/webui/master/static/css/bootstrap-material-design.min.css PRE-CREATION > src/webui/master/static/css/ripples.css PRE-CREATION > src/webui/master/static/css/ripples.min.css PRE-CREATION > src/webui/master/static/index.html 6211892e7d689df9bf3b2a9071a76ad4c60d0485 > src/webui/master/static/js/app.js c32177aa23c962f2bdf03d98272fb6d21a565382 > src/webui/master/static/js/material.js PRE-CREATION > src/webui/master/static/js/material.min.js PRE-CREATION > src/webui/master/static/js/ripples.js PRE-CREATION > src/webui/master/static/js/ripples.min.js PRE-CREATION > > Diff: https://reviews.apache.org/r/53286/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 53741: Display maintainance info in the webui.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/ --- (Updated Nov. 16, 2016, 7:54 p.m.) Review request for mesos, haosdent huang and Joseph Wu. Bugs: MESOS-6443 https://issues.apache.org/jira/browse/MESOS-6443 Repository: mesos Description --- Create new page with Maintenance schedule. Schedule is downloaded on page refresh. Schedule is not live like stats and tasks so there is no need to poll it periodically. Diable sorting when data-key is not defined in table header. Diffs (updated) - src/webui/master/static/index.html 6211892e7d689df9bf3b2a9071a76ad4c60d0485 src/webui/master/static/js/app.js c32177aa23c962f2bdf03d98272fb6d21a565382 src/webui/master/static/js/controllers.js dd0cc810748a9bd378d9c6b15e9fe89b7c0f11d9 src/webui/master/static/maintenance.html PRE-CREATION Diff: https://reviews.apache.org/r/53741/diff/ Testing --- [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png) Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 entires schedule generated with [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) Thanks, Tomasz Janiszewski
Re: Review Request 53741: Display maintainance info in the webui.
> On Nov. 16, 2016, 8:18 a.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js, line 469 > > <https://reviews.apache.org/r/53741/diff/2/?file=1564539#file1564539line469> > > > > Any reason that remove `pollState();` here? This function was redundant since this page is not live updated. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review156037 --- On Nov. 15, 2016, 9:03 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53741/ > --- > > (Updated Nov. 15, 2016, 9:03 p.m.) > > > Review request for mesos, haosdent huang and Joseph Wu. > > > Bugs: MESOS-6443 > https://issues.apache.org/jira/browse/MESOS-6443 > > > Repository: mesos > > > Description > --- > > Create new page with Maintenance schedule. Schedule is downloaded on > page refresh. Schedule is not live like stats and tasks so there is > no need to poll it periodically. > Diable sorting when data-key is not defined in table header. > > > Diffs > - > > src/webui/master/static/index.html 6211892e7d689df9bf3b2a9071a76ad4c60d0485 > src/webui/master/static/js/app.js c32177aa23c962f2bdf03d98272fb6d21a565382 > src/webui/master/static/js/controllers.js > dd0cc810748a9bd378d9c6b15e9fe89b7c0f11d9 > src/webui/master/static/maintenance.html PRE-CREATION > > Diff: https://reviews.apache.org/r/53741/diff/ > > > Testing > --- > > [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png) > > Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 > entires schedule generated with > [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 53741: Display maintainance info in the webui.
> On Nov. 15, 2016, 3:06 a.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [53741] > > > > Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' > > COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 > > MESOS_VERBOSE=1'; ./support/docker_build.sh @haosdent thanks for review. I applied your comments. Could you review it again? - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review155882 ------- On Nov. 15, 2016, 9:03 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53741/ > --- > > (Updated Nov. 15, 2016, 9:03 p.m.) > > > Review request for mesos, haosdent huang and Joseph Wu. > > > Bugs: MESOS-6443 > https://issues.apache.org/jira/browse/MESOS-6443 > > > Repository: mesos > > > Description > --- > > Create new page with Maintenance schedule. Schedule is downloaded on > page refresh. Schedule is not live like stats and tasks so there is > no need to poll it periodically. > Diable sorting when data-key is not defined in table header. > > > Diffs > - > > src/webui/master/static/index.html 6211892e7d689df9bf3b2a9071a76ad4c60d0485 > src/webui/master/static/js/app.js c32177aa23c962f2bdf03d98272fb6d21a565382 > src/webui/master/static/js/controllers.js > dd0cc810748a9bd378d9c6b15e9fe89b7c0f11d9 > src/webui/master/static/maintenance.html PRE-CREATION > > Diff: https://reviews.apache.org/r/53741/diff/ > > > Testing > --- > > [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png) > > Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 > entires schedule generated with > [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 53741: Display maintainance info in the webui.
> On Nov. 15, 2016, 5:38 p.m., haosdent huang wrote:
> > src/webui/master/static/js/app.js, line 291
> > <https://reviews.apache.org/r/53741/diff/1/?file=1563447#file1563447line291>
> >
> > Could not get the point why need this, I think `if (scope.columnKey ===
> > key) {` have cover this?
I added a comment. It's used to prevent adding sorting arrow in UI becouse it
could be misleading.
- Tomasz
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53741/#review155931
-------
On Nov. 15, 2016, 9:03 p.m., Tomasz Janiszewski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53741/
> ---
>
> (Updated Nov. 15, 2016, 9:03 p.m.)
>
>
> Review request for mesos, haosdent huang and Joseph Wu.
>
>
> Bugs: MESOS-6443
> https://issues.apache.org/jira/browse/MESOS-6443
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Create new page with Maintenance schedule. Schedule is downloaded on
> page refresh. Schedule is not live like stats and tasks so there is
> no need to poll it periodically.
> Diable sorting when data-key is not defined in table header.
>
>
> Diffs
> -
>
> src/webui/master/static/index.html 6211892e7d689df9bf3b2a9071a76ad4c60d0485
> src/webui/master/static/js/app.js c32177aa23c962f2bdf03d98272fb6d21a565382
> src/webui/master/static/js/controllers.js
> dd0cc810748a9bd378d9c6b15e9fe89b7c0f11d9
> src/webui/master/static/maintenance.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53741/diff/
>
>
> Testing
> ---
>
> [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png)
>
> Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500
> entires schedule generated with
> [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853)
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 53741: Display maintainance info in the webui.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/ --- (Updated Nov. 15, 2016, 9:03 p.m.) Review request for mesos, haosdent huang and Joseph Wu. Changes --- Apply Haosdent's comments Bugs: MESOS-6443 https://issues.apache.org/jira/browse/MESOS-6443 Repository: mesos Description --- Create new page with Maintenance schedule. Schedule is downloaded on page refresh. Schedule is not live like stats and tasks so there is no need to poll it periodically. Diable sorting when data-key is not defined in table header. Diffs (updated) - src/webui/master/static/index.html 6211892e7d689df9bf3b2a9071a76ad4c60d0485 src/webui/master/static/js/app.js c32177aa23c962f2bdf03d98272fb6d21a565382 src/webui/master/static/js/controllers.js dd0cc810748a9bd378d9c6b15e9fe89b7c0f11d9 src/webui/master/static/maintenance.html PRE-CREATION Diff: https://reviews.apache.org/r/53741/diff/ Testing --- [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png) Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 entires schedule generated with [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) Thanks, Tomasz Janiszewski
Review Request 53741: Display maintainance info in the webui.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/ --- Review request for mesos, haosdent huang and Joseph Wu. Bugs: MESOS-6443 https://issues.apache.org/jira/browse/MESOS-6443 Repository: mesos Description --- Create new page with Maintenance schedule. Schedule is downloaded on page refresh. Schedule is not live like stats and tasks so there is no need to poll it periodically. Diable sorting when data-key is not defined in table header. Diffs - src/webui/master/static/index.html 6211892e7d689df9bf3b2a9071a76ad4c60d0485 src/webui/master/static/js/app.js c32177aa23c962f2bdf03d98272fb6d21a565382 src/webui/master/static/js/controllers.js dd0cc810748a9bd378d9c6b15e9fe89b7c0f11d9 src/webui/master/static/maintenance.html PRE-CREATION Diff: https://reviews.apache.org/r/53741/diff/ Testing --- [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png) Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 entires schedule generated with [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) Thanks, Tomasz Janiszewski
Re: Review Request 49360: Supported TCP in health check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review146777 --- src/health-check/health_checker.cpp (line 452) <https://reviews.apache.org/r/49360/#comment213438> Will it work on all supported systems? src/health-check/health_checker.cpp (line 518) <https://reviews.apache.org/r/49360/#comment213439> `bash` appears in 3 places and may be extracted to constant. - Tomasz Janiszewski On Aug. 25, 2016, 12:34 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49360/ > --- > > (Updated Aug. 25, 2016, 12:34 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón > Kleiman, Gilbert Song, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-3567 > https://issues.apache.org/jira/browse/MESOS-3567 > > > Repository: mesos > > > Description > --- > > Supported TCP in health check. > > > Diffs > - > > src/health-check/health_checker.hpp > b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 > src/health-check/health_checker.cpp > 45a5fe00a95a6e88b1990c1396e03082feb202bc > > Diff: https://reviews.apache.org/r/49360/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 51053: Update leveldb to 1.19.
> On Aug. 22, 2016, 2:29 a.m., Vinod Kone wrote: > > Have you also done compatibility tests mentioned in the ticket? > > Tomasz Janiszewski wrote: > No. It's minior upgrade from 1.18 to 1.19 but I can got thur > https://docs.google.com/document/d/1fv2OMvH6hVm6waacOejSrTJwUuDQeXlqqPDZjBmbcKU/edit# > and check if everything is OK. > > haosdent huang wrote: > I could help to run from 1.14 to 1.19 if it is necessary. :) I took care of it. Folloed steps presented by Haosdent it works the same. Benchamrks were run as presented in ticket comments `MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK*.*/1" make check`. All tests performed on Ubuntu 16.04 4.4.0-34-generic x86_64. I've got a problem with running `support/test-upgrade.py` it failed with `mesos 1.0.0 framework failed` framework output ends with `Registered!` - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51053/#review146280 ----------- On Aug. 12, 2016, 11:17 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51053/ > --- > > (Updated Aug. 12, 2016, 11:17 p.m.) > > > Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-970 > https://issues.apache.org/jira/browse/MESOS-970 > > > Repository: mesos > > > Description > --- > > Leveldb in modern version is required to support s390x and arm64. > It's also required to replace default byte-wise comparator > with varint comparator in `src/log/leveldb.cpp`. > > > Diffs > - > > 3rdparty/Makefile.am 662146fade019e3085c00242dd74215ee91d6a70 > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake > eeb27860f6f95d297ccfe273ed76de5355b50ff8 > 3rdparty/cmake/Versions.cmake e5cf7d00921c73e37b4bdaaa43874ab3a1d2f1fe > 3rdparty/leveldb-1.19.patch PRE-CREATION > 3rdparty/leveldb-1.19.tar.gz PRE-CREATION > 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 > 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 > 3rdparty/versions.am 08e47b6c93be51b0ea86f099f76e9d2a4a6ffd78 > LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > src/python/native_common/ext_modules.py.in > 2d4a45efa224b32f80ace4542a00062c5ccb06d5 > > Diff: https://reviews.apache.org/r/51053/diff/ > > > Testing > --- > > make -j 8 distcheck > benchamrks: https://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872 > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 51053: Update leveldb to 1.19.
> On Aug. 22, 2016, 2:29 a.m., Vinod Kone wrote: > > Have you also done compatibility tests mentioned in the ticket? No. It's minior upgrade from 1.18 to 1.19 but I can got thur https://docs.google.com/document/d/1fv2OMvH6hVm6waacOejSrTJwUuDQeXlqqPDZjBmbcKU/edit# and check if everything is OK. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51053/#review146280 --- On Aug. 12, 2016, 11:17 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51053/ > --- > > (Updated Aug. 12, 2016, 11:17 p.m.) > > > Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-970 > https://issues.apache.org/jira/browse/MESOS-970 > > > Repository: mesos > > > Description > --- > > Leveldb in modern version is required to support s390x and arm64. > It's also required to replace default byte-wise comparator > with varint comparator in `src/log/leveldb.cpp`. > > > Diffs > - > > 3rdparty/Makefile.am 662146fade019e3085c00242dd74215ee91d6a70 > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake > eeb27860f6f95d297ccfe273ed76de5355b50ff8 > 3rdparty/cmake/Versions.cmake e5cf7d00921c73e37b4bdaaa43874ab3a1d2f1fe > 3rdparty/leveldb-1.19.patch PRE-CREATION > 3rdparty/leveldb-1.19.tar.gz PRE-CREATION > 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 > 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 > 3rdparty/versions.am 08e47b6c93be51b0ea86f099f76e9d2a4a6ffd78 > LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > src/python/native_common/ext_modules.py.in > 2d4a45efa224b32f80ace4542a00062c5ccb06d5 > > Diff: https://reviews.apache.org/r/51053/diff/ > > > Testing > --- > > make -j 8 distcheck > benchamrks: https://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872 > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 47324: Update leveldb to 1.18.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/#review145970 --- Closing in favor of [51053](https://reviews.apache.org/r/51053/) - Tomasz Janiszewski On Aug. 12, 2016, 4:58 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47324/ > --- > > (Updated Aug. 12, 2016, 4:58 p.m.) > > > Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent > huang. > > > Bugs: MESOS-970 > https://issues.apache.org/jira/browse/MESOS-970 > > > Repository: mesos > > > Description > --- > > Leveldb in modern version is required to support s390x. > It's also required to replace default byte-wise comparator > with varint comparator in `src/log/leveldb.cpp`. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake e5cf7d00921c73e37b4bdaaa43874ab3a1d2f1fe > 3rdparty/leveldb-1.18.patch PRE-CREATION > 3rdparty/leveldb-1.18.tar.gz PRE-CREATION > 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 > 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 > 3rdparty/versions.am 08e47b6c93be51b0ea86f099f76e9d2a4a6ffd78 > LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a > src/python/native_common/ext_modules.py.in > 2d4a45efa224b32f80ace4542a00062c5ccb06d5 > > Diff: https://reviews.apache.org/r/47324/diff/ > > > Testing > --- > > Tested on Ubuntu amd_64 need to test on PPC > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 51053: Update leveldb to 1.19.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51053/ --- (Updated Aug. 12, 2016, 11:17 p.m.) Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent huang, and Vinod Kone. Bugs: MESOS-970 https://issues.apache.org/jira/browse/MESOS-970 Repository: mesos Description (updated) --- Leveldb in modern version is required to support s390x and arm64. It's also required to replace default byte-wise comparator with varint comparator in `src/log/leveldb.cpp`. Diffs - 3rdparty/Makefile.am 662146fade019e3085c00242dd74215ee91d6a70 3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8 3rdparty/cmake/Versions.cmake e5cf7d00921c73e37b4bdaaa43874ab3a1d2f1fe 3rdparty/leveldb-1.19.patch PRE-CREATION 3rdparty/leveldb-1.19.tar.gz PRE-CREATION 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 3rdparty/versions.am 08e47b6c93be51b0ea86f099f76e9d2a4a6ffd78 LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5 Diff: https://reviews.apache.org/r/51053/diff/ Testing --- make -j 8 distcheck benchamrks: https://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872 Thanks, Tomasz Janiszewski
Re: Review Request 51053: Update leveldb to 1.19.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51053/ --- (Updated Aug. 12, 2016, 11:17 p.m.) Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent huang, and Vinod Kone. Changes --- Include binarry data Bugs: MESOS-970 https://issues.apache.org/jira/browse/MESOS-970 Repository: mesos Description (updated) --- Leveldb in modern version is required to support s390x and arm64. It's also required to replace default byte-wise comparator with varint comparator in \`src/log/leveldb.cpp\`. Diffs (updated) - 3rdparty/Makefile.am 662146fade019e3085c00242dd74215ee91d6a70 3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8 3rdparty/cmake/Versions.cmake e5cf7d00921c73e37b4bdaaa43874ab3a1d2f1fe 3rdparty/leveldb-1.19.patch PRE-CREATION 3rdparty/leveldb-1.19.tar.gz PRE-CREATION 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 3rdparty/versions.am 08e47b6c93be51b0ea86f099f76e9d2a4a6ffd78 LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5 Diff: https://reviews.apache.org/r/51053/diff/ Testing --- make -j 8 distcheck benchamrks: https://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872 Thanks, Tomasz Janiszewski
Review Request 51053: Update leveldb to 1.19.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51053/ --- Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent huang, and Vinod Kone. Bugs: MESOS-970 https://issues.apache.org/jira/browse/MESOS-970 Repository: mesos Description --- Leveldb in modern version is required to support s390x and arm64. It's also required to replace default byte-wise comparator with varint comparator in `src/log/leveldb.cpp`. Diffs - 3rdparty/Makefile.am 662146fade019e3085c00242dd74215ee91d6a70 3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8 3rdparty/cmake/Versions.cmake e5cf7d00921c73e37b4bdaaa43874ab3a1d2f1fe 3rdparty/leveldb-1.19.patch PRE-CREATION 3rdparty/leveldb-1.19.tar.gz PRE-CREATION 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 3rdparty/versions.am 08e47b6c93be51b0ea86f099f76e9d2a4a6ffd78 LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5 Diff: https://reviews.apache.org/r/51053/diff/ Testing --- make -j 8 distcheck benchamrks: https://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872 Thanks, Tomasz Janiszewski
Re: Review Request 47324: Update leveldb to 1.18.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/ --- (Updated Aug. 12, 2016, 4:58 p.m.) Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang. Bugs: MESOS-970 https://issues.apache.org/jira/browse/MESOS-970 Repository: mesos Description (updated) --- Leveldb in modern version is required to support s390x. It's also required to replace default byte-wise comparator with varint comparator in `src/log/leveldb.cpp`. Diffs - 3rdparty/cmake/Versions.cmake e5cf7d00921c73e37b4bdaaa43874ab3a1d2f1fe 3rdparty/leveldb-1.18.patch PRE-CREATION 3rdparty/leveldb-1.18.tar.gz PRE-CREATION 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 3rdparty/versions.am 08e47b6c93be51b0ea86f099f76e9d2a4a6ffd78 LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5 Diff: https://reviews.apache.org/r/47324/diff/ Testing --- Tested on Ubuntu amd_64 need to test on PPC Thanks, Tomasz Janiszewski
Re: Review Request 47324: Update leveldb to 1.18.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/ --- (Updated Aug. 12, 2016, 4:58 p.m.) Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang. Changes --- Rebase Bugs: MESOS-970 https://issues.apache.org/jira/browse/MESOS-970 Repository: mesos Description (updated) --- Leveldb in modern version is required to support s390x. It's also required to replace default byte-wise comparator with varint comparator in \`src/log/leveldb.cpp\`. Diffs (updated) - 3rdparty/cmake/Versions.cmake e5cf7d00921c73e37b4bdaaa43874ab3a1d2f1fe 3rdparty/leveldb-1.18.patch PRE-CREATION 3rdparty/leveldb-1.18.tar.gz PRE-CREATION 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 3rdparty/versions.am 08e47b6c93be51b0ea86f099f76e9d2a4a6ffd78 LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5 Diff: https://reviews.apache.org/r/47324/diff/ Testing --- Tested on Ubuntu amd_64 need to test on PPC Thanks, Tomasz Janiszewski
Re: Review Request 50981: Fix volumes help message example mistake.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50981/ --- (Updated Aug. 11, 2016, 2:07 p.m.) Review request for mesos and Guangya Liu. Bugs: MESOS-6028 https://issues.apache.org/jira/browse/MESOS-6028 Repository: mesos Description --- Changed docker_options to driver_options. Diffs - src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 Diff: https://reviews.apache.org/r/50981/diff/ Testing --- Thanks, Tomasz Janiszewski
Review Request 50981: Fix volumes help message example mistake.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50981/ --- Review request for mesos and Guangya Liu. Repository: mesos Description --- Changed docker_options to driver_options. Diffs - src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 Diff: https://reviews.apache.org/r/50981/diff/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 50851: Decode Protobuf long int form strings.
> On Aug. 10, 2016, 11:53 p.m., Joseph Wu wrote: > > Can you add the reason/motivation for this change in your patch description? @Josheph I added description and fixed/commented issues. Would you like to review it one mor time. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50851/#review145430 --- On Aug. 11, 2016, 8:47 a.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50851/ > --- > > (Updated Aug. 11, 2016, 8:47 a.m.) > > > Review request for mesos, Anand Mazumdar and Joseph Wu. > > > Bugs: MESOS-5995 > https://issues.apache.org/jira/browse/MESOS-5995 > > > Repository: mesos > > > Description > --- > > According to Protobuf JSON mapping long integers > should be stored as strings. > > > Diffs > - > > 3rdparty/stout/include/stout/protobuf.hpp > 91305e104c01d649bd435a27b15954036c27 > 3rdparty/stout/tests/protobuf_tests.cpp > 8877e8934e0f7875bfedcfa88b491ce4b13ca44f > > Diff: https://reviews.apache.org/r/50851/diff/ > > > Testing > --- > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 50851: Decode Protobuf long int form strings.
> On Aug. 10, 2016, 11:53 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/protobuf.hpp, lines 443-459 > > <https://reviews.apache.org/r/50851/diff/1/?file=1464266#file1464266line443> > > > > I wonder how far we want to follow the protobuf mapping > > recommendations. Technically, protobuf3 takes strings for all types of > > numbers :) > > > > I'm fine with just large numbers however. int32, fixed32, uint32 should be stored as a numbers. With float and double there is exception for "NaN" and "Infinity" > On Aug. 10, 2016, 11:53 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/protobuf.hpp, line 447 > > <https://reviews.apache.org/r/50851/diff/1/?file=1464266#file1464266line447> > > > > Unfortunately, `std::stoll` and similar functions will throw exceptions > > if they fail. And Mesos does not use exceptions. > > > > You'll need to parse the string some other way (i.e. `strtoimax`) and > > return an `Error` if the parsing fails. Good catch. I used `numify`. > On Aug. 10, 2016, 11:53 p.m., Joseph Wu wrote: > > 3rdparty/stout/tests/protobuf_tests.cpp, lines 334-336 > > <https://reviews.apache.org/r/50851/diff/1/?file=1464267#file1464267line334> > > > > This should be checking for equality, rather than parse success: > > > > EXPECT_SOME_EQ(, json); In this test I'm not interested in checking if String to JSON works. It's only used to generate JSON that will be parsed into message. > On Aug. 10, 2016, 11:53 p.m., Joseph Wu wrote: > > 3rdparty/stout/tests/protobuf_tests.cpp, lines 342-343 > > <https://reviews.apache.org/r/50851/diff/1/?file=1464267#file1464267line342> > > > > This is actually a Protobuf -> JSON -> String conversion. > > > > You'll want to split these two apart and have one comparision for each > > step. I changed it to compare against `Message` object. But since there is no equal method for protobuf object I serialise them to JSON. - Tomasz ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50851/#review145430 --- On Aug. 11, 2016, 8:47 a.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50851/ > --- > > (Updated Aug. 11, 2016, 8:47 a.m.) > > > Review request for mesos, Anand Mazumdar and Joseph Wu. > > > Bugs: MESOS-5995 > https://issues.apache.org/jira/browse/MESOS-5995 > > > Repository: mesos > > > Description > --- > > According to Protobuf JSON mapping long integers > should be stored as strings. > > > Diffs > - > > 3rdparty/stout/include/stout/protobuf.hpp > 91305e104c01d649bd435a27b15954036c27 > 3rdparty/stout/tests/protobuf_tests.cpp > 8877e8934e0f7875bfedcfa88b491ce4b13ca44f > > Diff: https://reviews.apache.org/r/50851/diff/ > > > Testing > --- > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 50851: Decode Protobuf long int form strings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50851/ --- (Updated Aug. 11, 2016, 8:47 a.m.) Review request for mesos, Anand Mazumdar and Joseph Wu. Changes --- Use numify to parse strings and handle errors. Bugs: MESOS-5995 https://issues.apache.org/jira/browse/MESOS-5995 Repository: mesos Description (updated) --- According to Protobuf JSON mapping long integers should be stored as strings. Diffs (updated) - 3rdparty/stout/include/stout/protobuf.hpp 91305e104c01d649bd435a27b15954036c27 3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f Diff: https://reviews.apache.org/r/50851/diff/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 50900: Removed unneeded extra space in libprocess code base.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50900/#review145191 --- Ship it! Ship It! - Tomasz Janiszewski On Aug. 8, 2016, 4:19 p.m., Gaojin CAO wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50900/ > --- > > (Updated Aug. 8, 2016, 4:19 p.m.) > > > Review request for mesos, Benjamin Bannier, Guangya Liu, and haosdent huang. > > > Bugs: MESOS-5830 > https://issues.apache.org/jira/browse/MESOS-5830 > > > Repository: mesos > > > Description > --- > > This patch is part of MESOS-5830, specially working on cleaning up > unneeded space in project libprocess. > > > Diffs > - > > 3rdparty/libprocess/include/process/async.hpp > e7d846288791221f4dfa03d7de89d9bde177f1ca > 3rdparty/libprocess/include/process/protobuf.hpp > 695c6e6572852d2c4afbaacc6b63771ed035fd65 > 3rdparty/libprocess/include/process/reap.hpp > 1a9709c618c5ddc9d2b7492cc1855a11f1fc4fb9 > 3rdparty/libprocess/include/process/sequence.hpp > c9a46f28b770023ca621696493521445762a3fd1 > 3rdparty/libprocess/include/process/statistics.hpp > 13aa464329c2cc77b017868a1dcbf5b77c53635d > 3rdparty/libprocess/src/reap.cpp f8d2fdc3449744cfd6a974170484b676e8f3ac7b > 3rdparty/libprocess/src/tests/benchmarks.cpp > 9fac45e21bd03ccea19d0ef7d8bb2efc408e60b5 > 3rdparty/libprocess/src/tests/http_tests.cpp > 8a0d61eb57f9ae972eedf3481f131844b283abc5 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 4ddd35b61f222ca674e41875a6d0ee43d12cbfbd > 3rdparty/libprocess/src/tests/reap_tests.cpp > 0cbe9f139d59ac154695d84638c551fbe098cb10 > 3rdparty/libprocess/src/tests/shared_tests.cpp > 8f94cca107ebe1fdefc19fb1f65e4c205f96 > 3rdparty/libprocess/src/tests/statistics_tests.cpp > db9817ff182f37b7a04358fb59b8b800b16a7e1e > > Diff: https://reviews.apache.org/r/50900/diff/ > > > Testing > --- > > Pass `make` and `make tests`. > > > Thanks, > > Gaojin CAO > >
Re: Review Request 50899: Removed unneeded extra space in stout code base.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50899/#review145190 --- Ship it! Ship It! - Tomasz Janiszewski On Aug. 8, 2016, 4:17 p.m., Gaojin CAO wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50899/ > --- > > (Updated Aug. 8, 2016, 4:17 p.m.) > > > Review request for mesos, Benjamin Bannier, Guangya Liu, and haosdent huang. > > > Bugs: MESOS-5830 > https://issues.apache.org/jira/browse/MESOS-5830 > > > Repository: mesos > > > Description > --- > > This patch is part of MESOS-5830, specially working on cleaning up > unneeded space in project stout. > > > Diffs > - > > 3rdparty/stout/include/stout/flags.hpp > 169f959ab2770744d615cc235062ba2becc8af64 > 3rdparty/stout/include/stout/interval.hpp > e6deeac39855488548678c59ed4c69646fc02602 > 3rdparty/stout/include/stout/json.hpp > 51b1ada87846d4d25cbc8a6bbb97ba91e02a9cab > 3rdparty/stout/include/stout/linkedhashmap.hpp > 6e06260bcce2dbe0f9134f3d0fd7a2b47b0d3286 > 3rdparty/stout/include/stout/os/osx.hpp > ca77bb0bbda0cee07d85435350dc4ccc176d4013 > 3rdparty/stout/include/stout/os/sunos.hpp > ec8e1f7562d5747113631351e6d8ff8989cf0fed > 3rdparty/stout/include/stout/os/sysctl.hpp > 6db7bf6f139770ce978d171f451e932072cdaf5f > 3rdparty/stout/include/stout/proc.hpp > b543432c1a8419093c508c1d0e72b9757df04463 > 3rdparty/stout/include/stout/protobuf.hpp > 91305e104c01d649bd435a27b15954036c27 > 3rdparty/stout/include/stout/strings.hpp > 7f7f1cffcebfe16cb986917b1d90c1ae4a480989 > 3rdparty/stout/tests/flags_tests.cpp > 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 > 3rdparty/stout/tests/ip_tests.cpp 4d1f1c9a4dd35da2a21bef1349a662af44bb4ba1 > 3rdparty/stout/tests/mac_tests.cpp 1ff60cf5506c1855547400aa20107ec5086d8431 > 3rdparty/stout/tests/multimap_tests.cpp > 2f606eb16fbaa3c755e597a05e97cd30d3bfd9f4 > 3rdparty/stout/tests/option_tests.cpp > 36abe137bdae1e6aaf65f39bf302d9e7a76fefdd > 3rdparty/stout/tests/os/process_tests.cpp > b536e664d22370e30c49a8f953189e92a1358709 > 3rdparty/stout/tests/os_tests.cpp e67444077eae55fd25945b451164b5bcc37552b0 > 3rdparty/stout/tests/proc_tests.cpp > 17b909368405d9ddb7e7127e89d0422a9a2baa11 > 3rdparty/stout/tests/strings_tests.cpp > b54a9dbf162403310b8bba687442e184a473f5a6 > > Diff: https://reviews.apache.org/r/50899/diff/ > > > Testing > --- > > Pass `make` and `make tests`. > > > Thanks, > > Gaojin CAO > >
Re: Review Request 50887: Trimmed unneeded extra space between right angle brackets.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50887/#review145189 --- Ship it! Ship It! - Tomasz Janiszewski On Aug. 8, 2016, 4:13 p.m., Gaojin CAO wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50887/ > --- > > (Updated Aug. 8, 2016, 4:13 p.m.) > > > Review request for mesos, Benjamin Bannier, Guangya Liu, and haosdent huang. > > > Bugs: MESOS-5830 > https://issues.apache.org/jira/browse/MESOS-5830 > > > Repository: mesos > > > Description > --- > > Mesos codebase has been evolved and no more need an extra space > between two right angle brackets, e.g. vector >, to > work around C++98 parsing deficiencies(see MESOS-5830). > > > Diffs > - > > include/mesos/log/log.hpp 0f69848bd72372e7a58f6e3789e86bf826eaeab7 > include/mesos/zookeeper/contender.hpp > 0ef9d56c15c4c5dd1d36f2866324ac95d55901d1 > include/mesos/zookeeper/detector.hpp > a953997b98e1242bea10efc791e2f31fa3252593 > src/authentication/cram_md5/auxprop.cpp > 85403417c8169c0796ffa16484aa85da2d5220ba > src/cli/mesos.cpp 81e2325c1978d56487479848966115ffd14b7cb0 > src/cli/resolve.cpp ac6be05e64c5e66703081068d992ebb0d6ca6c70 > src/files/files.cpp 793d68ec700c792fc9dd73b09ee2616108b88f4f > src/java/jni/org_apache_mesos_Log.cpp > 04f8afd99b4383e7941a93bfd565806a9988c870 > src/java/jni/org_apache_mesos_state_AbstractState.cpp > 3101352e42e8505a93d8760ad657d9fe35761080 > src/launcher/executor.cpp 9333dc0832cd04305e307ce750195c0fbc860ab2 > src/linux/ns.hpp e905aefe5ab178c8471cfe801e6432540d3dea67 > src/log/consensus.cpp 27f2c58c4c54cc3fe5b92873261096b6011ff15d > src/log/coordinator.hpp 9fa4f1988c531a9765c9522a017b39fafb0a9cea > src/log/coordinator.cpp ecf457ff266f447938ee6d2872a8ef3b6d50517e > src/log/log.cpp 0940f9288509409c1d593c27da48cfa2a50545c9 > src/log/main.cpp 171c312562442836a2cf8f61f0a83615c18d0971 > src/log/network.hpp 8750880e6cecb6edf4efab4f2b9afe3d8a4d5964 > src/log/recover.hpp 97793b6e1a26f92b4ae20b82e7da18d063776ce6 > src/log/recover.cpp eaf3fd334f7b66f9ba05f3856ee885bab9af62f6 > src/log/tool/benchmark.cpp da35b08b5448c965cedd3d9349d06b4a99fabfce > src/master/registrar.cpp 4d1eaa04fcc7f3330bf3abab8533428848691f2c > src/slave/gc.hpp 9a09e7b3585217754a26597b77ea51e706ecb933 > src/slave/gc.cpp a0af68b8d713a31bea533b24637861e81ca167e3 > src/slave/state.cpp 91dee118d1e6866fb2b968765cfe7c6f1b5a3325 > src/slave/status_update_manager.cpp > 9c67b8526915cb529b5c5afd5b5e4a451bf94d61 > src/tests/allocator.hpp c4d835afe180bcc2404cc3772af5f7c4885771bb > src/tests/containerizer.hpp ded331bc60078196abf9e1d338c23b9b962a3ad2 > src/tests/containerizer.cpp 105ca9c0416b16fd26d396a4fdef7fbc8a43b8a4 > src/tests/containerizer/composing_containerizer_tests.cpp > e7e3b622b6606a812aef046c761bf92368d34af2 > src/tests/containerizer/docker_containerizer_tests.cpp > 4e5b1fd1628504d346cced545f7911d6b6443773 > src/tests/containerizer/docker_tests.cpp > 7b73a4939da33d0b7dd08fdcf56525b6403eada3 > src/tests/containerizer/external_containerizer_test.cpp > 226eac56725e908040abda306a2e5e3c96bce9d7 > src/tests/containerizer/isolator_tests.cpp > 827c9f06b97191a5b74bb8fa2ef716c4282e7518 > src/tests/containerizer/launcher.hpp > 49f8ecb47abb098bf76017f79b7d00380401efe4 > src/tests/containerizer/port_mapping_tests.cpp > 94d6d7589a4d9accff6f43ad6abbf05bf3be7ee5 > src/tests/disk_quota_tests.cpp f379a6e351fbcf8b41d7db6ed62865ce55b0060e > src/tests/environment.cpp 6960c2a0165c4bb34851a0412c6b22b7da645540 > src/tests/exception_tests.cpp a9b1c23d3e8460c5c67c8f399346f85f2ac8addf > src/tests/health_check_tests.cpp 47c35d15a259d470f21f81303879077787c125e7 > src/tests/master_allocator_tests.cpp > 32e3a4638273fa1c792c3c9425e0b2ff8f6bed03 > src/tests/master_authorization_tests.cpp > 16f1ab46a92137de01313a29dac2b18f18f5e816 > src/tests/master_contender_detector_tests.cpp > 2970986830d0cfaedbf17f3b002c40ac5c28bd2a > src/tests/master_slave_reconciliation_tests.cpp > 03405e33d3f1cccbd5298810f5cd818c1dac8593 > src/tests/mesos.hpp 9174a3810d0da34b99dc257e9c77f83107fdd9f5 > src/tests/reconciliation_tests.cpp 492560c430eba45e3a9f7a767ee761dfa0cacb05 > src/tests/registrar_tests.cpp ba7c66ff83f09d68fb5324a3f85d2875068a35a6 > src/tests/registrar_zookeeper_tests.cpp > 98a5e312a8b2701dc8dc9b659
Review Request 50851: Decode Protobuf long int form strings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50851/ --- Review request for mesos, Anand Mazumdar and Joseph Wu. Bugs: MESOS-5995 https://issues.apache.org/jira/browse/MESOS-5995 Repository: mesos Description --- Decode Protobuf long int form strings. Diffs - 3rdparty/stout/include/stout/protobuf.hpp 91305e104c01d649bd435a27b15954036c27 3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f Diff: https://reviews.apache.org/r/50851/diff/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 50398: Added libz to Ubuntu build dependencies.
> On July 28, 2016, 12:01 a.m., Vinod Kone wrote: > > docs/getting-started.md, line 50 > > <https://reviews.apache.org/r/50398/diff/1/?file=1451919#file1451919line50> > > > > what's libz needed for? we don't seem to install it in our docker > > builds? https://github.com/apache/mesos/blob/master/support/docker_build.sh It looks like zlib is installed indirectly with other dependecies `libsvn-dev`,` libcurl4-nss-dev`. I double checkd it and `./configure` errors must be my fault. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50398/#review143863 ------- On July 25, 2016, 5:39 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50398/ > --- > > (Updated July 25, 2016, 5:39 p.m.) > > > Review request for mesos, Dave Lester, Kevin Klues, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Added libz to Ubuntu build dependencies. > > > Diffs > - > > docs/getting-started.md ebe52705b8c8757d4a507ce3ae75f56d535a39d1 > > Diff: https://reviews.apache.org/r/50398/diff/ > > > Testing > --- > > > Thanks, > > Tomasz Janiszewski > >
Review Request 50398: Added libz to Ubuntu build dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50398/ --- Review request for mesos, Dave Lester, Kevin Klues, and Vinod Kone. Repository: mesos Description --- Added libz to Ubuntu build dependencies. Diffs - docs/getting-started.md ebe52705b8c8757d4a507ce3ae75f56d535a39d1 Diff: https://reviews.apache.org/r/50398/diff/ Testing --- Thanks, Tomasz Janiszewski
Review Request 50114: Added missing tables attributes in docs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50114/ --- Review request for mesos, Alexander Rojas, Kapil Arya, and Vinod Kone. Repository: mesos Description --- Most of the tables presented in docs uses `class="table table-striped"`. To make tables looks consitent I added this attribute where it was missing on modules and authorization. Diffs - docs/authorization.md fc027ac643906451513e50d166b51c147b4a9d99 docs/modules.md 60191566cf3580792046ba21a6b9a66a21b18e21 Diff: https://reviews.apache.org/r/50114/diff/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 49360: Supported TCP check in health check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review142497 --- Ship it! Ship It! - Tomasz Janiszewski On July 2, 2016, 3:14 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49360/ > --- > > (Updated July 2, 2016, 3:14 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, > Jie Yu, and Timothy Chen. > > > Bugs: MESOS-3567 > https://issues.apache.org/jira/browse/MESOS-3567 > > > Repository: mesos > > > Description > --- > > Supported TCP check in health check. > > > Diffs > - > > include/mesos/mesos.proto 5b15a89bbac0b33c77e305c5b188823f2704a653 > include/mesos/v1/mesos.proto a1435278e81c8f3179d94cd9d2c3dd8c0ba82d35 > src/health-check/health_checker.hpp > f61e80d8e5eb09f8f71e80b6600f7c5b1548bd62 > src/health-check/health_checker.cpp > 585a0b565d948cfa292bad818a710501a4ce0daf > > Diff: https://reviews.apache.org/r/49360/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 36816: Supported HTTP/HTTPS in health check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review142496 --- Ship it! Ship It! - Tomasz Janiszewski On July 2, 2016, 3:14 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36816/ > --- > > (Updated July 2, 2016, 3:14 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, > Jie Yu, and Timothy Chen. > > > Bugs: MESOS-2533 > https://issues.apache.org/jira/browse/MESOS-2533 > > > Repository: mesos > > > Description > --- > > Supported HTTP/HTTPS in health check. > > > Diffs > - > > include/mesos/mesos.proto 5b15a89bbac0b33c77e305c5b188823f2704a653 > include/mesos/v1/mesos.proto a1435278e81c8f3179d94cd9d2c3dd8c0ba82d35 > src/health-check/health_checker.hpp > f61e80d8e5eb09f8f71e80b6600f7c5b1548bd62 > > Diff: https://reviews.apache.org/r/36816/diff/ > > > Testing > --- > > * Add unit test cases: HealthCheckTest.HealthyTaskViaHttp and > HealthCheckTest.HealthyTaskNotMatchHttpStatuses > make check > > > Thanks, > > haosdent huang > >
Re: Review Request 48910: Group frameworks by state in the webui.
> On Cze 27, 2016, 11:35 po południu, Vinod Kone wrote: > > src/webui/master/static/frameworks.html, line 8 > > <https://reviews.apache.org/r/48910/diff/3/?file=1431236#file1431236line8> > > > > why the change in capitalization of "frameworks"? it is consistent with > > how we capitalized "Active Tasks" and "Completed Tasks"? I'll fix it while > > committing. Copied form JIRA task description. Thanks for taking care of it. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/#review139696 ------- On Cze 27, 2016, 7:19 po południu, Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48910/ > --- > > (Updated Cze 27, 2016, 7:19 po południu) > > > Review request for mesos, Benjamin Mahler, Deshna Jain, haosdent huang, Ross > Allen, and Vinod Kone. > > > Bugs: MESOS-2145 > https://issues.apache.org/jira/browse/MESOS-2145 > > > Repository: mesos > > > Description > --- > > Create 3 groups in fameworks listing for active, > inactive and completed frameworks. > > > Diffs > - > > src/webui/master/static/frameworks.html > cfb6f4efc259419e4cb697332c8d6f2839e96970 > > Diff: https://reviews.apache.org/r/48910/diff/ > > > Testing > --- > >  > > Run framework (e.g. Marathon) wait until it appear on `#/frameworks`. Stop it > (no graceful shutdown with deregistration). It should be highlighted with > next page update. > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.
> On June 27, 2016, 6:27 p.m., Vinod Kone wrote: > > src/webui/master/static/js/controllers.js, line 149 > > <https://reviews.apache.org/r/49228/diff/4/?file=1431212#file1431212line149> > > > > task.statuses[0] could be a terminal state if a task went directly from > > TASK_STAGING to TASK_LOST, i.e., a task was removed before any update for > > it was received by the master (e.g., agent removed). > > Tomasz Janiszewski wrote: > What is desired behaviour for this situation? Now start and stop time > will be equal. Should start time be `null` when first status is terminal? > > Vinod Kone wrote: > looks like start time is capturing when the master receives a > TASK_RUNNING update and not when the task launch request from the scheduler > was received by the master. so i would prefer to not set `task.start_time` if > the master didn't receive that update. I added condition that will not set `task.start_time` when first status state is terminal. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139622 ----------- On June 27, 2016, 9:05 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49228/ > --- > > (Updated June 27, 2016, 9:05 p.m.) > > > Review request for mesos, Benjamin Mahler, haosdent huang, Ross Allen, and > Vinod Kone. > > > Repository: mesos > > > Description > --- > > Only set the terminal time if the last state is terminal. > > > Diffs > - > > src/webui/master/static/js/controllers.js > be3fa1f1fba9eda7ebcc9bf33142fe4307dd8d90 > > Diff: https://reviews.apache.org/r/49228/diff/ > > > Testing > --- > > Generate orpahne tasks that is alive. It should have not set stopped time. > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/ --- (Updated June 27, 2016, 9:05 p.m.) Review request for mesos, Benjamin Mahler, haosdent huang, Ross Allen, and Vinod Kone. Changes --- Do not set `task.start_time` if tasks first status is terminal Repository: mesos Description --- Only set the terminal time if the last state is terminal. Diffs (updated) - src/webui/master/static/js/controllers.js be3fa1f1fba9eda7ebcc9bf33142fe4307dd8d90 Diff: https://reviews.apache.org/r/49228/diff/ Testing --- Generate orpahne tasks that is alive. It should have not set stopped time. Thanks, Tomasz Janiszewski
Re: Review Request 48910: Group frameworks by state in the webui.
> On June 27, 2016, 3:49 a.m., Vinod Kone wrote:
> > src/webui/master/static/frameworks.html, line 29
> > <https://reviews.apache.org/r/48910/diff/2/?file=1430180#file1430180line29>
> >
> > should be filtered by `disconnected` boolean.
> >
> > a framework in master has two tags associated with it, `active` and
> > `connected`. so the following 4 states are theoretically possible:
> >
> > connected and active
> > connected but inactive (not currently possible but maybe in the future)
> > disconnected and active (doesn't make sense)
> > disconnected and inactive
>
> Tomasz Janiszewski wrote:
> I'm on latest master `git_sha:
> "05b553ec6b0260547055fbc807ab3acce4ece234"`. There is no `disconnected` field
> in frameworks returned by `/master/state`. On the other hand
> `/metrics/snapshot` has fields `master/frameworks_connected` and
> `master/frameworks_disconnected`. Should I add this fields to `/master/state`
> endpoint?
>
> Tomasz Janiszewski wrote:
> Adding connected field looks easy but I can't find tests for this part of
> code.
> ```
> diff --git a/src/master/http.cpp b/src/master/http.cpp
> index d55aa05..7c1008d 100644
> --- a/src/master/http.cpp
> +++ b/src/master/http.cpp
> @@ -367,6 +367,7 @@ static void json(JSON::ObjectWriter* writer, const
> Summary& summary)
>writer->field("hostname", framework.info.hostname());
>writer->field("webui_url", framework.info.webui_url());
>writer->field("active", framework.active);
> + writer->field("connected", framework.connected);
> }
> ```
>
> Vinod Kone wrote:
> Sorry I meant `connected` boolean. Didn't realize we didn't expose the
> `connected` field in /state (we will expose it in the v1 API).
>
> For now, I think it's simpler to have "Active Frameworks", "Inactive
> Frameworks" and "Completed Frameworks" in the WebUI.
Changed to "Active Frameworks", "Inactive Frameworks" and "Completed Frameworks"
> On June 27, 2016, 3:49 a.m., Vinod Kone wrote:
> > src/webui/master/static/frameworks.html, line 87
> > <https://reviews.apache.org/r/48910/diff/2/?file=1430180#file1430180line87>
> >
> > s/active/connected/
Chagned to "Active Frameworks", "Inactive Frameworks" and "Completed Frameworks"
- Tomasz
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48910/#review139516
---
On June 27, 2016, 7:19 p.m., Tomasz Janiszewski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48910/
> ---
>
> (Updated June 27, 2016, 7:19 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Deshna Jain, haosdent huang, Ross
> Allen, and Vinod Kone.
>
>
> Bugs: MESOS-2145
> https://issues.apache.org/jira/browse/MESOS-2145
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Create 3 groups in fameworks listing for active,
> inactive and completed frameworks.
>
>
> Diffs
> -
>
> src/webui/master/static/frameworks.html
> cfb6f4efc259419e4cb697332c8d6f2839e96970
>
> Diff: https://reviews.apache.org/r/48910/diff/
>
>
> Testing
> ---
>
> 
>
> Run framework (e.g. Marathon) wait until it appear on `#/frameworks`. Stop it
> (no graceful shutdown with deregistration). It should be highlighted with
> next page update.
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 48910: Group frameworks by state in the webui.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/ --- (Updated June 27, 2016, 7:19 p.m.) Review request for mesos, Benjamin Mahler, Deshna Jain, haosdent huang, Ross Allen, and Vinod Kone. Changes --- Change (dis)connected to (in)active Bugs: MESOS-2145 https://issues.apache.org/jira/browse/MESOS-2145 Repository: mesos Description (updated) --- Create 3 groups in fameworks listing for active, inactive and completed frameworks. Diffs (updated) - src/webui/master/static/frameworks.html cfb6f4efc259419e4cb697332c8d6f2839e96970 Diff: https://reviews.apache.org/r/48910/diff/ Testing ---  Run framework (e.g. Marathon) wait until it appear on `#/frameworks`. Stop it (no graceful shutdown with deregistration). It should be highlighted with next page update. Thanks, Tomasz Janiszewski
Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.
> On June 27, 2016, 6:27 p.m., Vinod Kone wrote: > > src/webui/master/static/js/controllers.js, line 149 > > <https://reviews.apache.org/r/49228/diff/4/?file=1431212#file1431212line149> > > > > task.statuses[0] could be a terminal state if a task went directly from > > TASK_STAGING to TASK_LOST, i.e., a task was removed before any update for > > it was received by the master (e.g., agent removed). What is desired behaviour for this situation? Now start and stop time will be equal. Should start time be `null` when first status is terminal? - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139622 ------- On June 27, 2016, 7:05 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49228/ > --- > > (Updated June 27, 2016, 7:05 p.m.) > > > Review request for mesos, Benjamin Mahler, haosdent huang, Ross Allen, and > Vinod Kone. > > > Repository: mesos > > > Description > --- > > Only set the terminal time if the last state is terminal. > > > Diffs > - > > src/webui/master/static/js/controllers.js > be3fa1f1fba9eda7ebcc9bf33142fe4307dd8d90 > > Diff: https://reviews.apache.org/r/49228/diff/ > > > Testing > --- > > Generate orpahne tasks that is alive. It should have not set stopped time. > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/ --- (Updated June 27, 2016, 7:05 p.m.) Review request for mesos, Benjamin Mahler, haosdent huang, Ross Allen, and Vinod Kone. Changes --- Apply @vinod's suggestions Repository: mesos Description --- Only set the terminal time if the last state is terminal. Diffs (updated) - src/webui/master/static/js/controllers.js be3fa1f1fba9eda7ebcc9bf33142fe4307dd8d90 Diff: https://reviews.apache.org/r/49228/diff/ Testing --- Generate orpahne tasks that is alive. It should have not set stopped time. Thanks, Tomasz Janiszewski
Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.
> On June 27, 2016, 5:28 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js, line 158 > > <https://reviews.apache.org/r/49228/diff/2/?file=1430958#file1430958line158> > > > > Not sure if `isTaskTerminated` is a better name. Definetely it is. Fixed. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139606 --- On June 27, 2016, 5:40 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49228/ > --- > > (Updated June 27, 2016, 5:40 p.m.) > > > Review request for mesos, Benjamin Mahler, haosdent huang, Ross Allen, and > Vinod Kone. > > > Repository: mesos > > > Description > --- > > Only set the terminal time if the last state is terminal. > > > Diffs > - > > src/webui/master/static/js/controllers.js > be3fa1f1fba9eda7ebcc9bf33142fe4307dd8d90 > > Diff: https://reviews.apache.org/r/49228/diff/ > > > Testing > --- > > Generate orpahne tasks that is alive. It should have not set stopped time. > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/ --- (Updated June 27, 2016, 5:40 p.m.) Review request for mesos, Benjamin Mahler, haosdent huang, Ross Allen, and Vinod Kone. Changes --- Fix @haosdent suggestions Repository: mesos Description --- Only set the terminal time if the last state is terminal. Diffs (updated) - src/webui/master/static/js/controllers.js be3fa1f1fba9eda7ebcc9bf33142fe4307dd8d90 Diff: https://reviews.apache.org/r/49228/diff/ Testing --- Generate orpahne tasks that is alive. It should have not set stopped time. Thanks, Tomasz Janiszewski
