Re: Review Request 71024: Supported insecure registry when provisioning docker images.
> On July 9, 2019, 5:44 a.m., Jie Yu wrote: > > Can you add some unit test for this? For instance, toggle the new agent > > flag, test with some docker registry (ideally, an unsecure registry, but I > > think it's ok to test with a secure one too just to excersize the code > > path). > > fei long wrote: > I started a local registry(127.0.0.1:5000) in a docker container and the > test case passed. But I am not sure how to redo it in the CI environment > since I need to > 1. start a "registry" docker container > 2. make sure that 127.0.0.1 is not in the "insecure registries" list. > > Could you give some advice? > > Jie Yu wrote: > you don't necessarily need to test with a insecure registry. we should > add a test to exercise the case where this agent flag is toggled. You can > still use dockerhub for that. Updated. - fei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71024/#review216441 ------- On July 14, 2019, 10:35 a.m., fei long wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71024/ > --- > > (Updated July 14, 2019, 10:35 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Bugs: MESOS-6183 > https://issues.apache.org/jira/browse/MESOS-6183 > > > Repository: mesos > > > Description > --- > > Supported insecure registry when provisioning docker images. > > > Diffs > - > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > d013c9d71c39c09e600f181aba31b8037aa9226a > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2 > src/slave/flags.hpp a10bf698dc447b1411c06083c2ba7585d7a78389 > src/slave/flags.cpp b4e3eb99221a09404dbbf813da33607867a78691 > src/slave/http.cpp 69e6d74e8b113cc6c937f47df8984ff9a63e5bb4 > src/tests/containerizer/provisioner_docker_tests.cpp > 5d5a355afd9c4fda1c653d6cecb75703b0fe > src/uri/fetchers/docker.hpp 2bb921474f3a8147d8cbf54579452f8df216d2f1 > src/uri/fetchers/docker.cpp 8f5fc964f056b349ce57ced139e07f538cb1cfd2 > > > Diff: https://reviews.apache.org/r/71024/diff/2/ > > > Testing > --- > > All testing cases passed. > > > Thanks, > > fei long > >
Re: Review Request 71024: Supported insecure registry when provisioning docker images.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71024/ --- (Updated July 14, 2019, 10:35 a.m.) Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Changes --- Changed insecure_docker_registry(string) to use_insecure_docker_registry(bool) and added a unit test. Bugs: MESOS-6183 https://issues.apache.org/jira/browse/MESOS-6183 Repository: mesos Description --- Supported insecure registry when provisioning docker images. Diffs (updated) - src/slave/containerizer/mesos/provisioner/docker/puller.cpp d013c9d71c39c09e600f181aba31b8037aa9226a src/slave/containerizer/mesos/provisioner/docker/store.cpp 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2 src/slave/flags.hpp a10bf698dc447b1411c06083c2ba7585d7a78389 src/slave/flags.cpp b4e3eb99221a09404dbbf813da33607867a78691 src/slave/http.cpp 69e6d74e8b113cc6c937f47df8984ff9a63e5bb4 src/tests/containerizer/provisioner_docker_tests.cpp 5d5a355afd9c4fda1c653d6cecb75703b0fe src/uri/fetchers/docker.hpp 2bb921474f3a8147d8cbf54579452f8df216d2f1 src/uri/fetchers/docker.cpp 8f5fc964f056b349ce57ced139e07f538cb1cfd2 Diff: https://reviews.apache.org/r/71024/diff/2/ Changes: https://reviews.apache.org/r/71024/diff/1-2/ Testing --- All testing cases passed. Thanks, fei long
Re: Review Request 71024: Supported insecure registry when provisioning docker images.
> On July 9, 2019, 5:44 a.m., Jie Yu wrote: > > Can you add some unit test for this? For instance, toggle the new agent > > flag, test with some docker registry (ideally, an unsecure registry, but I > > think it's ok to test with a secure one too just to excersize the code > > path). I started a local registry(127.0.0.1:5000) in a docker container and the test case passed. But I am not sure how to redo it in the CI environment since I need to 1. start a "registry" docker container 2. make sure that 127.0.0.1 is not in the "insecure registries" list. Could you give some advice? - fei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71024/#review216441 ------- On July 9, 2019, 5:44 a.m., fei long wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71024/ > --- > > (Updated July 9, 2019, 5:44 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Bugs: MESOS-6183 > https://issues.apache.org/jira/browse/MESOS-6183 > > > Repository: mesos > > > Description > --- > > Supported insecure registry when provisioning docker images. > > > Diffs > - > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > d013c9d71c39c09e600f181aba31b8037aa9226a > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 35b6afbb6b22575b90963927352443a8ddaf9885 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2 > src/slave/flags.hpp a10bf698dc447b1411c06083c2ba7585d7a78389 > src/slave/flags.cpp b4e3eb99221a09404dbbf813da33607867a78691 > src/slave/http.cpp 69e6d74e8b113cc6c937f47df8984ff9a63e5bb4 > src/uri/fetchers/docker.hpp 2bb921474f3a8147d8cbf54579452f8df216d2f1 > src/uri/fetchers/docker.cpp 8f5fc964f056b349ce57ced139e07f538cb1cfd2 > > > Diff: https://reviews.apache.org/r/71024/diff/1/ > > > Testing > --- > > All testing cases passed. > > > Thanks, > > fei long > >
Review Request 71024: Supported insecure registry when provisioning docker images.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71024/ --- Review request for mesos. Bugs: MESOS-6183 https://issues.apache.org/jira/browse/MESOS-6183 Repository: mesos Description --- Supported insecure registry when provisioning docker images. Diffs - src/slave/containerizer/mesos/provisioner/docker/puller.cpp d013c9d71c39c09e600f181aba31b8037aa9226a src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 35b6afbb6b22575b90963927352443a8ddaf9885 src/slave/containerizer/mesos/provisioner/docker/store.cpp 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2 src/slave/flags.hpp a10bf698dc447b1411c06083c2ba7585d7a78389 src/slave/flags.cpp b4e3eb99221a09404dbbf813da33607867a78691 src/slave/http.cpp 69e6d74e8b113cc6c937f47df8984ff9a63e5bb4 src/uri/fetchers/docker.hpp 2bb921474f3a8147d8cbf54579452f8df216d2f1 src/uri/fetchers/docker.cpp 8f5fc964f056b349ce57ced139e07f538cb1cfd2 Diff: https://reviews.apache.org/r/71024/diff/1/ Testing --- All testing cases passed. Thanks, fei long
Review Request 71005: Used euid to determine subprocess' user when launching tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71005/ --- Review request for mesos and Jie Yu. Bugs: mesos-9876 https://issues.apache.org/jira/browse/mesos-9876 Repository: mesos Description --- Used euid to determine subprocess' user when launching tasks. Diffs - src/slave/containerizer/mesos/launch.cpp b29ec556399a40aa662987a11a2b64e6a16de889 Diff: https://reviews.apache.org/r/71005/diff/1/ Testing --- All testing cases passed. Thanks, fei long
Re: Review Request 69735: Fixed maintenance causes machines not in schedule rescinding offers.
> On Jan. 14, 2019, 6:52 p.m., Joseph Wu wrote: > > Here's a test I wrote for this issue: https://reviews.apache.org/r/65366/ > > The patch is a bit old, but could be re-used if necessary. > > fei long wrote: > Since your patch has not been merged, I copied your code and passed the > test by running "./bin/mesos-tests.sh --verbose > --gtest_filter="*RescindOffers*" --gtest_break_on_failure --gtest_repeat=100". > > fei long wrote: > How could I re-trigger the CI? > > Benjamin Bannier wrote: > This requires special Jenkins karma. I triggered a rebuild for you. Thanks! And where can I see the rebuild results...? - fei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69735/#review211959 ------- On Jan. 14, 2019, 3:34 a.m., fei long wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69735/ > --- > > (Updated Jan. 14, 2019, 3:34 a.m.) > > > Review request for mesos and Benno Evers. > > > Bugs: MESOS-9394 > https://issues.apache.org/jira/browse/MESOS-9394 > > > Repository: mesos > > > Description > --- > > Fixed maintenance causes machines not in schedule rescinding offers. > > > Diffs > - > > src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4 > > > Diff: https://reviews.apache.org/r/69735/diff/1/ > > > Testing > --- > > > Thanks, > > fei long > >
Re: Review Request 69735: Fixed maintenance causes machines not in schedule rescinding offers.
> On Jan. 14, 2019, 6:52 p.m., Joseph Wu wrote: > > Here's a test I wrote for this issue: https://reviews.apache.org/r/65366/ > > The patch is a bit old, but could be re-used if necessary. > > fei long wrote: > Since your patch has not been merged, I copied your code and passed the > test by running "./bin/mesos-tests.sh --verbose > --gtest_filter="*RescindOffers*" --gtest_break_on_failure --gtest_repeat=100". How could I re-trigger the CI? - fei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69735/#review211959 ------- On Jan. 14, 2019, 3:34 a.m., fei long wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69735/ > --- > > (Updated Jan. 14, 2019, 3:34 a.m.) > > > Review request for mesos and Benno Evers. > > > Bugs: MESOS-9394 > https://issues.apache.org/jira/browse/MESOS-9394 > > > Repository: mesos > > > Description > --- > > Fixed maintenance causes machines not in schedule rescinding offers. > > > Diffs > - > > src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4 > > > Diff: https://reviews.apache.org/r/69735/diff/1/ > > > Testing > --- > > > Thanks, > > fei long > >
Re: Review Request 69735: Fixed maintenance causes machines not in schedule rescinding offers.
> On Jan. 14, 2019, 8:57 a.m., Gilbert Song wrote: > > Is `MasterAPITest.OperationUpdatesUponAgentGone/1` failure releted to the > > change? I run "./bin/mesos-tests.sh --verbose --gtest_filter="*OperationUpdatesUponAgentGone*" --gtest_break_on_failure --gtest_repeat=100" locally and it passed. I believe it's caused by something else. - fei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69735/#review211948 --- On Jan. 14, 2019, 3:34 a.m., fei long wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69735/ > --- > > (Updated Jan. 14, 2019, 3:34 a.m.) > > > Review request for mesos and Benno Evers. > > > Bugs: MESOS-9394 > https://issues.apache.org/jira/browse/MESOS-9394 > > > Repository: mesos > > > Description > --- > > Fixed maintenance causes machines not in schedule rescinding offers. > > > Diffs > - > > src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4 > > > Diff: https://reviews.apache.org/r/69735/diff/1/ > > > Testing > --- > > > Thanks, > > fei long > >
Re: Review Request 69735: Fixed maintenance causes machines not in schedule rescinding offers.
> On Jan. 14, 2019, 6:52 p.m., Joseph Wu wrote: > > Here's a test I wrote for this issue: https://reviews.apache.org/r/65366/ > > The patch is a bit old, but could be re-used if necessary. Since your patch has not been merged, I copied your code and passed the test by running "./bin/mesos-tests.sh --verbose --gtest_filter="*RescindOffers*" --gtest_break_on_failure --gtest_repeat=100". - fei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69735/#review211959 --- On Jan. 14, 2019, 3:34 a.m., fei long wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69735/ > --- > > (Updated Jan. 14, 2019, 3:34 a.m.) > > > Review request for mesos and Benno Evers. > > > Bugs: MESOS-9394 > https://issues.apache.org/jira/browse/MESOS-9394 > > > Repository: mesos > > > Description > --- > > Fixed maintenance causes machines not in schedule rescinding offers. > > > Diffs > - > > src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4 > > > Diff: https://reviews.apache.org/r/69735/diff/1/ > > > Testing > --- > > > Thanks, > > fei long > >
Review Request 69735: Fixed maintenance causes machines not in schedule rescinding offers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69735/ --- Review request for mesos and Benno Evers. Bugs: MESOS-9394 https://issues.apache.org/jira/browse/MESOS-9394 Repository: mesos Description --- Fixed maintenance causes machines not in schedule rescinding offers. Diffs - src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4 Diff: https://reviews.apache.org/r/69735/diff/1/ Testing --- Thanks, fei long
Re: Review Request 68986: Created cgroup recursively when calling prepare on containers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68986/ --- (Updated Oct. 12, 2018, 9:30 a.m.) Review request for mesos and Jie Yu. Bugs: MESOS-9305 https://issues.apache.org/jira/browse/MESOS-9305 Repository: mesos Description --- Created cgroup recursively when calling prepare on containers. Diffs (updated) - src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp fbb1b43a6147b4d1d1ef95e2ae1dc6b22261602a src/tests/containerizer/cgroups_isolator_tests.cpp fccab200c0804ee7cf0bd8da071a3701123ccd53 Diff: https://reviews.apache.org/r/68986/diff/2/ Changes: https://reviews.apache.org/r/68986/diff/1-2/ Testing --- Thanks, fei long
Re: Review Request 68986: Created cgroup recursively when calling prepare on containers.
> On Oct. 11, 2018, 5:25 a.m., Gilbert Song wrote: > > Seems like we aim to backport this improvement to previous release. Could > > we add a unit test to simulate the cgroup root being removed issue? Done! - fei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68986/#review209436 --- On Oct. 11, 2018, 5:12 a.m., fei long wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68986/ > --- > > (Updated Oct. 11, 2018, 5:12 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-9305 > https://issues.apache.org/jira/browse/MESOS-9305 > > > Repository: mesos > > > Description > --- > > Created cgroup recursively when calling prepare on containers. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > fbb1b43a6147b4d1d1ef95e2ae1dc6b22261602a > > > Diff: https://reviews.apache.org/r/68986/diff/1/ > > > Testing > --- > > > Thanks, > > fei long > >
Review Request 68986: Created cgroup recursively when calling prepare on containers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68986/ --- Review request for mesos and Jie Yu. Bugs: MESOS-9305 https://issues.apache.org/jira/browse/MESOS-9305 Repository: mesos Description --- Created cgroup recursively when calling prepare on containers. Diffs - src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp fbb1b43a6147b4d1d1ef95e2ae1dc6b22261602a Diff: https://reviews.apache.org/r/68986/diff/1/ Testing --- Thanks, fei long
Re: Review Request 66039: Check both disk and inode usage when slaves schedule gc.
> On April 4, 2018, 5:50 a.m., Gilbert Song wrote: > > src/slave/slave.cpp > > Lines 6743 (patched) > > <https://reviews.apache.org/r/66039/diff/2/?file=1974374#file1974374line6743> > > > > I would leave this to @andschwa since I suspect we could have a windows > > implementation together. andschwa left some comments in 66308, and they are all solved. - fei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66039/#review200429 ------- On April 14, 2018, 11:02 a.m., fei long wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66039/ > --- > > (Updated April 14, 2018, 11:02 a.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-8665 > https://issues.apache.org/jira/browse/MESOS-8665 > > > Repository: mesos > > > Description > --- > > Check both disk and inode usage when slaves schedule gc. > > > Diffs > - > > src/slave/slave.hpp d00c7b2e2466fd1de71e9e55343a27d3808bde3e > src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5 > src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031 > > > Diff: https://reviews.apache.org/r/66039/diff/3/ > > > Testing > --- > > No new tests are added and all "make check" tests are passed. > > > Thanks, > > fei long > >
Re: Review Request 66039: Check both disk and inode usage when slaves schedule gc.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66039/ --- (Updated April 14, 2018, 11:02 a.m.) Review request for mesos and Gilbert Song. Changes --- Put std::max in slave.cpp(caller) instead of fs.hpp(callee). Bugs: MESOS-8665 https://issues.apache.org/jira/browse/MESOS-8665 Repository: mesos Description --- Check both disk and inode usage when slaves schedule gc. Diffs (updated) - src/slave/slave.hpp d00c7b2e2466fd1de71e9e55343a27d3808bde3e src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5 src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031 Diff: https://reviews.apache.org/r/66039/diff/3/ Changes: https://reviews.apache.org/r/66039/diff/2-3/ Testing --- No new tests are added and all "make check" tests are passed. Thanks, fei long
Re: Review Request 66038: Add inodeUsage to provide inode usage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66038/ --- (Updated April 14, 2018, 8:43 a.m.) Review request for mesos and Gilbert Song. Changes --- Use inodeUsage instead of usageWithInode. Return 0 if f_files is 0. Summary (updated) - Add inodeUsage to provide inode usage. Bugs: MESOS-8665 https://issues.apache.org/jira/browse/MESOS-8665 Repository: mesos Description (updated) --- Add inodeUsage to provide inode usage. Diffs (updated) - 3rdparty/stout/include/stout/posix/fs.hpp 269a4f50f1df8d68be9e11030f885cf2c254c9d8 Diff: https://reviews.apache.org/r/66038/diff/3/ Changes: https://reviews.apache.org/r/66038/diff/2-3/ Testing --- No new tests are added and all "make check" tests are passed. Thanks, fei long
Re: Review Request 66038: Add usageWithInode to check both disk and inode usage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66038/ --- (Updated March 13, 2018, 2:08 p.m.) Review request for mesos and Gilbert Song. Bugs: MESOS-8665 https://issues.apache.org/jira/browse/MESOS-8665 Repository: mesos Description (updated) --- Add usageWithInode to check both disk and inode usage. Diffs (updated) - 3rdparty/stout/include/stout/posix/fs.hpp 269a4f50f1df8d68be9e11030f885cf2c254c9d8 Diff: https://reviews.apache.org/r/66038/diff/2/ Changes: https://reviews.apache.org/r/66038/diff/1-2/ Testing --- No new tests are added and all "make check" tests are passed. Thanks, fei long
Re: Review Request 66039: Check both disk and inode usage when slaves schedule gc.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66039/ --- (Updated March 13, 2018, 2:05 p.m.) Review request for mesos and Gilbert Song. Bugs: MESOS-8665 https://issues.apache.org/jira/browse/MESOS-8665 Repository: mesos Description (updated) --- Check both disk and inode usage when slaves schedule gc. Diffs (updated) - src/slave/slave.cpp 2f4ab157448eafc0f41372ee50255a76129e90db Diff: https://reviews.apache.org/r/66039/diff/2/ Changes: https://reviews.apache.org/r/66039/diff/1-2/ Testing --- No new tests are added and all "make check" tests are passed. Thanks, fei long
Review Request 66038: Add usageWithInode to check both disk and inode usage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66038/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8665 https://issues.apache.org/jira/browse/MESOS-8665 Repository: mesos Description --- Add fs::usageWithInode to check both disk and inode usage, which returns max(diskUsage, inodeUsage). Diffs - 3rdparty/stout/include/stout/posix/fs.hpp 269a4f50f1df8d68be9e11030f885cf2c254c9d8 Diff: https://reviews.apache.org/r/66038/diff/1/ Testing --- No new tests are added and all "make check" tests are passed. Thanks, fei long
Review Request 66039: Check both disk and inode usage when slaves schedule gc.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66039/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8665 https://issues.apache.org/jira/browse/MESOS-8665 Repository: mesos Description --- Check both disk and inode usage when slaves schedule gc. Call the newly added fs::usageWithInode to determine executorDirectoryMaxAllowedAge when slaves schedule gc. Diffs - src/slave/slave.cpp 2f4ab157448eafc0f41372ee50255a76129e90db Diff: https://reviews.apache.org/r/66039/diff/1/ Testing --- No new tests are added and all "make check" tests are passed. Thanks, fei long
