Re: Review Request 33718: Extended documentation on Mesos hooks.

2015-05-12 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33718/#review83364 --- Ship it! Looks great! Sorry I was so slow. Didn't realize it would

Re: Review Request 33718: Extended documentation on Mesos hooks.

2015-05-08 Thread Till Toenshoff
On May 7, 2015, 9:06 p.m., Niklas Nielsen wrote: docs/modules.md, line 149 https://reviews.apache.org/r/33718/diff/2/?file=952571#file952571line149 s/config/configuration file/? It does not have to be a file, hence I would suggest configuration. - Till

Re: Review Request 33718: Extended documentation on Mesos hooks.

2015-05-08 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33718/#review83074 --- docs/modules.md https://reviews.apache.org/r/33718/#comment133941

Re: Review Request 33718: Extended documentation on Mesos hooks.

2015-05-08 Thread Alexander Rukletsov
On May 7, 2015, 9:06 p.m., Niklas Nielsen wrote: Have you rendered this in a markdown viewer? As far as I know, the code block won't render if you don't have a preceeding newline I have and it was OK, but you're right and it's not consistent with the rest of the doc, I'll change that.

Re: Review Request 33718: Extended documentation on Mesos hooks.

2015-05-07 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33718/#review82908 --- Ship it! Have you rendered this in a markdown viewer? As far as I

Re: Review Request 33718: Extended documentation on Mesos hooks.

2015-05-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33718/ --- (Updated May 7, 2015, 8:40 p.m.) Review request for mesos, Adam B, Kapil Arya,