Re: Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-10 Thread Jiang Yan Xu
On June 9, 2015, 10:36 a.m., Niklas Nielsen wrote: src/master/master.cpp, lines 3513-3514 https://reviews.apache.org/r/35118/diff/1/?file=980131#file980131line3513 Does it make sense to point to some documentation (if it exists already, or inline) about how this resource math

Re: Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-09 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35118/#review87234 --- Ship it! src/master/master.cpp

Re: Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-09 Thread Ben Mahler
On June 9, 2015, 5:36 p.m., Niklas Nielsen wrote: src/master/master.cpp, lines 3513-3514 https://reviews.apache.org/r/35118/diff/1/?file=980131#file980131line3513 Does it make sense to point to some documentation (if it exists already, or inline) about how this resource math will

Re: Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35118/#review87083 --- Ship it! Ship It! - Vinod Kone On June 5, 2015, 9:09 p.m.,

Re: Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-08 Thread Ben Mahler
On June 5, 2015, 9:58 p.m., Vinod Kone wrote: src/master/master.cpp, line 3462 https://reviews.apache.org/r/35118/diff/1/?file=980131#file980131line3462 woah. didn't realize this was handled automagically by the install handler. Yeah, we didn't do this for framework provided

Re: Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-07 Thread Jiang Yan Xu
On June 5, 2015, 2:58 p.m., Vinod Kone wrote: src/master/master.cpp, line 3517 https://reviews.apache.org/r/35118/diff/1/?file=980131#file980131line3517 while you are at it, can you just send slave-totalResources here instead of oversubscribedResources? this will address my TODO

Re: Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35118/#review86850 --- src/master/master.cpp