Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 27, 2015, 6:22 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description (updated) --- [1/3] Changed hashmap, hashset to use std::unordered_{set,map} instead of boost::unordered_{set,map}. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 25684a405bfa9c4ab65641568341652a8efaf925 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 0b745866d0fe15335ac46cff53643e6770e18357 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 27, 2015, 5:12 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Changes --- Add result_type, argument_type for std::hash specializations. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Changed hashmap, hashset to use std::unordered_{set,map} instead of boost::unordered_{set,map}. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 25684a405bfa9c4ab65641568341652a8efaf925 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 0b745866d0fe15335ac46cff53643e6770e18357 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/#review96736 --- Ship it! Ship It! - Michael Park On Aug. 27, 2015, 4:22 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 27, 2015, 4:22 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- [1/3] Changed hashmap, hashset to use std::unordered_{set,map} instead of boost::unordered_{set,map}. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 25684a405bfa9c4ab65641568341652a8efaf925 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 0b745866d0fe15335ac46cff53643e6770e18357 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 27, 2015, 1:38 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Changes --- Fixed open issues. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Changed hashmap, hashset to use std::unordered_{set,map} instead of boost::unordered_{set,map}. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 25684a405bfa9c4ab65641568341652a8efaf925 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/#review96599 --- Please take a look at my comments in https://reviews.apache.org/r/37188/ Please note my comments for hashmap may also be applicable for the other containers modified. 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp (line 46) https://reviews.apache.org/r/37187/#comment152181 You can trim the extra whitespace ` ` to `` now. 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp (line 38) https://reviews.apache.org/r/37187/#comment152186 Did you want to allow the allocator to be specified? `class Allocator = std::allocatorstd::pairconst Key, T` Should we wait to add this until it is needed? 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp (lines 50 - 59) https://reviews.apache.org/r/37187/#comment152184 So now can we just use: ``` std::unordered_mapKey, Elem, Hash, Equal(map.begin(), map.end(), std::ceil(map.size() / max_load_factor())) {} ``` Here and below. Please see my note in https://reviews.apache.org/r/35874/ 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp (lines 107 - 109) https://reviews.apache.org/r/37187/#comment152187 ``` auto result = std::unordered_mapKey, Value, Hash, Equal::emplace(key, value); // If the element already existed, replace it. if (!result.second) { *result.first = value; } ``` 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp (lines 116 - 119) https://reviews.apache.org/r/37187/#comment152189 @Mpark Will turning this into a ternary aid RVO? - Joris Van Remoortere On Aug. 25, 2015, 4:02 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 25, 2015, 4:02 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Changed hashmap, hashset to use std::unordered_{set,map} instead of boost::unordered_{set,map}. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 25684a405bfa9c4ab65641568341652a8efaf925 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.
On Aug. 25, 2015, 12:27 p.m., Michael Park wrote: 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp, lines 142-172 https://reviews.apache.org/r/37187/diff/5/?file=1037650#file1037650line142 Given that there's no specified iteration order of a multihashmap, I don't think this is even something to test for. That is, this test doesn't test anything further than the test above it: ``` ASSERT_EQ(2u, map.get(foo).size()); ASSERT_TRUE(map.contains(foo, 1024)); ASSERT_TRUE(map.contains(foo, 1025)); ``` I would say we should just remove it, what do you think? Jan Schlicht wrote: IMHO the purpose of this test is to show that the iterator iteratates over all elements of a multihashmap, not that the iterater provides a specific order. But given that that this is not too complicated it's probably safe to remove this test. Michael Park wrote: Yeah, let's remove this test. Hm, how about we actually leave the test but follow the pattern for the `ForEach` test to ignore the ordering? - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/#review96331 --- On Aug. 25, 2015, 4:02 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 25, 2015, 4:02 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Changed hashmap, hashset to use std::unordered_{set,map} instead of boost::unordered_{set,map}. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 25684a405bfa9c4ab65641568341652a8efaf925 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.
On Aug. 25, 2015, 12:27 p.m., Michael Park wrote: 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp, lines 142-172 https://reviews.apache.org/r/37187/diff/5/?file=1037650#file1037650line142 Given that there's no specified iteration order of a multihashmap, I don't think this is even something to test for. That is, this test doesn't test anything further than the test above it: ``` ASSERT_EQ(2u, map.get(foo).size()); ASSERT_TRUE(map.contains(foo, 1024)); ASSERT_TRUE(map.contains(foo, 1025)); ``` I would say we should just remove it, what do you think? Jan Schlicht wrote: IMHO the purpose of this test is to show that the iterator iteratates over all elements of a multihashmap, not that the iterater provides a specific order. But given that that this is not too complicated it's probably safe to remove this test. Yeah, let's remove this test. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/#review96331 --- On Aug. 11, 2015, 11:57 a.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 11, 2015, 11:57 a.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Changed hashmap, hashset to use std::unordered_{set,map} instead of boost::unordered_{set,map}. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 25684a405bfa9c4ab65641568341652a8efaf925 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 25, 2015, 6:02 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Changes --- Removed multimap iterator test. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Changed hashmap, hashset to use std::unordered_{set,map} instead of boost::unordered_{set,map}. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 25684a405bfa9c4ab65641568341652a8efaf925 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/#review96348 --- Ship it! Ship It! - Michael Park On Aug. 25, 2015, 4:02 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 25, 2015, 4:02 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Changed hashmap, hashset to use std::unordered_{set,map} instead of boost::unordered_{set,map}. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 25684a405bfa9c4ab65641568341652a8efaf925 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.
On Aug. 25, 2015, 2:27 p.m., Michael Park wrote: 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp, lines 142-172 https://reviews.apache.org/r/37187/diff/5/?file=1037650#file1037650line142 Given that there's no specified iteration order of a multihashmap, I don't think this is even something to test for. That is, this test doesn't test anything further than the test above it: ``` ASSERT_EQ(2u, map.get(foo).size()); ASSERT_TRUE(map.contains(foo, 1024)); ASSERT_TRUE(map.contains(foo, 1025)); ``` I would say we should just remove it, what do you think? Jan Schlicht wrote: IMHO the purpose of this test is to show that the iterator iteratates over all elements of a multihashmap, not that the iterater provides a specific order. But given that that this is not too complicated it's probably safe to remove this test. Michael Park wrote: Yeah, let's remove this test. Michael Park wrote: Hm, how about we actually leave the test but follow the pattern for the `ForEach` test to ignore the ordering? As the `ForEach` test shows that one can iterate over all elements of multihashmap and would even fail if there where unexpected elements, it includes the test for expected iterator behavior. - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/#review96331 --- On Aug. 25, 2015, 6:02 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 25, 2015, 6:02 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Changed hashmap, hashset to use std::unordered_{set,map} instead of boost::unordered_{set,map}. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 25684a405bfa9c4ab65641568341652a8efaf925 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/#review96331 --- 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp (lines 142 - 172) https://reviews.apache.org/r/37187/#comment151644 Given that there's no specified iteration order of a multihashmap, I don't think this is even something to test for. That is, this test doesn't test anything further than the test above it: ``` ASSERT_EQ(2u, map.get(foo).size()); ASSERT_TRUE(map.contains(foo, 1024)); ASSERT_TRUE(map.contains(foo, 1025)); ``` I would say we should just remove it, what do you think? - Michael Park On Aug. 11, 2015, 11:57 a.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 11, 2015, 11:57 a.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Changed hashmap, hashset to use std::unordered_{set,map} instead of boost::unordered_{set,map}. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 25684a405bfa9c4ab65641568341652a8efaf925 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.
On Aug. 25, 2015, 2:27 p.m., Michael Park wrote: 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp, lines 142-172 https://reviews.apache.org/r/37187/diff/5/?file=1037650#file1037650line142 Given that there's no specified iteration order of a multihashmap, I don't think this is even something to test for. That is, this test doesn't test anything further than the test above it: ``` ASSERT_EQ(2u, map.get(foo).size()); ASSERT_TRUE(map.contains(foo, 1024)); ASSERT_TRUE(map.contains(foo, 1025)); ``` I would say we should just remove it, what do you think? IMHO the purpose of this test is to show that the iterator iteratates over all elements of a multihashmap, not that the iterater provides a specific order. But given that that this is not too complicated it's probably safe to remove this test. - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/#review96331 --- On Aug. 11, 2015, 1:57 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 11, 2015, 1:57 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Changed hashmap, hashset to use std::unordered_{set,map} instead of boost::unordered_{set,map}. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 25684a405bfa9c4ab65641568341652a8efaf925 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 11, 2015, 11:56 a.m.) Review request for mesos, Alexander Rojas and Michael Park. Changes --- Review fixes, change cache.hpp and multihashmap.hpp as well. Summary (updated) - Use std::unordered_{set,map} instead of boost::unordered_{set,map}. Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Changed hashmap, hashset to use std::unordered_{set,map} instead of boost::unordered_{set,map}. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 25684a405bfa9c4ab65641568341652a8efaf925 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 11, 2015, 1:57 p.m.) Review request for mesos, Alexander Rojas and Michael Park. Changes --- Fix failing multihashmap test (hash ordering may differ between STL implementations). Bugs: MESOS-3217 https://issues.apache.org/jira/browse/MESOS-3217 Repository: mesos Description --- Changed hashmap, hashset to use std::unordered_{set,map} instead of boost::unordered_{set,map}. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 25684a405bfa9c4ab65641568341652a8efaf925 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht