Re: Review Request 37996: Added property manager

> On Oct. 6, 2015, 12:39 p.m., Bernd Mathiske wrote: > > Ship It! I don't think we should introduce this into stout in its current form. I realize you're planning to use this for authentication stuff, but looking at this on its own, it seems like a confusing abstraction. Why would we couple

Re: Review Request 37996: Added property manager

> On Oct. 6, 2015, 1:14 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp, lines > > 30-52 > > > > > > Hm.. what will this abstraction be used for? I have a hard time

Re: Review Request 37996: Added property manager

> On Oct. 7, 2015, 1:42 a.m., Till Toenshoff wrote: > > Like most other reviewers, I must confess that my first reaction when > > seeing this tree application where mixed and triggered doubts if we really > > needed to introduce it. However, I found Alexander's given points very > >

Re: Review Request 37996: Added property manager

> On Oct. 6, 2015, 12:39 p.m., Bernd Mathiske wrote: > > Ship It! > > Ben Mahler wrote: > I don't think we should introduce this into stout in its current form. I > realize you're planning to use this for authentication stuff, but looking at > this on its own, it seems like a confusing

Re: Review Request 37996: Added property manager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/#review101707 --- Ship it! Like most other reviewers, I must confess that my first

Re: Review Request 37996: Added property manager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/#review101552 ---

Re: Review Request 37996: Added property manager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/ --- (Updated Oct. 5, 2015, 1:23 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37996: Added property manager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/ --- (Updated Oct. 5, 2015, 4:46 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37996: Added property manager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/#review101476 ---

Re: Review Request 37996: Added property manager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/ --- (Updated Oct. 5, 2015, 5:57 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37996: Added property manager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/ --- (Updated Oct. 5, 2015, 6:02 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37996: Added property manager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/#review101483 ---

Re: Review Request 37996: Added property manager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/ --- (Updated Sept. 30, 2015, 10:16 a.m.) Review request for mesos, Adam B,

Re: Review Request 37996: Added property manager

> On Sept. 25, 2015, 11:12 a.m., Adam B wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/properties.hpp, line 67 > > > > > > Why use a string instead of a stout::Path? I created the issue MESOS-3531 to

Re: Review Request 37996: Added property manager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/#review100561 --- Looks like a reasonable start to a useful class. I feel like there

Re: Review Request 37996: Added property manager

> On Sept. 23, 2015, 7:40 p.m., Alex Clemmer wrote: > > Can we please add these tests to the CMakeLists.txt file in > > 3rdparty/libprocess/3rdparty/stout/tests? It was done already since the first version of this patch. - Alexander

Re: Review Request 37996: Added property manager

> On Sept. 23, 2015, 5:40 p.m., Alex Clemmer wrote: > > Can we please add these tests to the CMakeLists.txt file in > > 3rdparty/libprocess/3rdparty/stout/tests? > > Alexander Rojas wrote: > It was done already since the first version of this patch. Ah. I'm so sorry. I just kind of troll

Re: Review Request 37996: Added property manager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/ --- (Updated Sept. 23, 2015, 1:17 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37996: Added property manager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/#review100236 --- Can we please add these tests to the CMakeLists.txt file in

Re: Review Request 37996: Added property manager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/ --- (Updated Sept. 23, 2015, 10:55 a.m.) Review request for mesos, Adam B,