Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote: > > src/Makefile.am, line 535 > > > > > > This will break agent headers. > > > > FOr instance, isolator.hpp has the following: > > ``` > > #include > >

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote: > > > > Kevin Klues wrote: > Look back at the thread above started by Vinod. This was dicussed in > there, though it's not clear what the outcome was. > > Kevin Klues wrote: > Also, if you look further down in the patch, the line: > >

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote: > > > > Kevin Klues wrote: > Look back at the thread above started by Vinod. This was dicussed in > there, though it's not clear what the outcome was. Also, if you look further down in the patch, the line: ``` ln -s

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote: > > Look back at the thread above started by Vinod. This was dicussed in there, though it's not clear what the outcome was. - Kevin --- This is an automatically generated e-mail. To reply,

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote: > > src/Makefile.am, line 535 > > > > > > This will break agent headers. > > > > FOr instance, isolator.hpp has the following: > > ``` > > #include > >

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46676/#review145265 --- src/Makefile.am (line 535)

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

> On April 26, 2016, 7:08 p.m., Vinod Kone wrote: > > src/Makefile.am, lines 2151-2152 > > > > > > IIUC, when someone does a `make install` there will be 2 directories > > in the installation directory. > >

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46676/#review130716 --- Patch looks great! Reviews applied: [46720, 46676] Passed

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46676/ --- (Updated 四月 27, 2016, 1:57 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

> On 四月 26, 2016, 7:08 p.m., Vinod Kone wrote: > > src/Makefile.am, lines 2151-2152 > > > > > > IIUC, when someone does a `make install` there will be 2 directories > > in the installation directory. > > > >

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

> On April 26, 2016, 7:08 p.m., Vinod Kone wrote: > > src/Makefile.am, line 535 > > > > > > what does setting this variable do? This is an autotools thing. If you define this and then list which headers to

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46676/#review130664 --- Can you make the description more descriptive please? Make it

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46676/#review130557 --- Patch looks great! Reviews applied: [46676] Passed command: