Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

2016-12-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/ --- (Updated Dec. 2, 2016, 5:54 a.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

2016-12-01 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/#review157697 --- Fix it, then Ship it! LGTM minus a small query regarding

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

2016-12-01 Thread Vinod Kone
> On Dec. 1, 2016, 7:49 p.m., Anand Mazumdar wrote: > > src/slave/http.cpp, line 1982 > > > > > > Why not be explicit here and set it to `ContainerClass::DEFAULT` like > > we do for the corresponding session one?

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

2016-12-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/ --- (Updated Dec. 2, 2016, 4:42 a.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

2016-12-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/ --- (Updated Dec. 2, 2016, 2:38 a.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

2016-12-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/ --- (Updated Dec. 2, 2016, 1:02 a.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

2016-12-01 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/#review157616 --- Mostly minor comments all around. The two major ones include

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

2016-12-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/#review157562 --- Bad patch! Reviews applied: [54196, 54194, 54193, 54245, 54115,

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/ --- (Updated Dec. 1, 2016, 6:46 a.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

2016-11-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/#review157391 --- Patch looks great! Reviews applied: [54193, 54194, 54196]