Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Dec. 11, 2015, 3:01 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/#review110006 --- Ship it! I'll make the changes below in order to avoid more round

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

> On Dec. 8, 2015, 8:52 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/process.hpp, lines 65-86 > > > > > > Why isn't this in the http header? It looks like firewall belongs there > > too since

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

> On Dec. 9, 2015, 12:19 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, lines 1339-1343 > > > > > > Hm.. it looks like you're using the principals here to check that the > > requests

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Dec. 10, 2015, 3:25 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Dec. 8, 2015, 11:23 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

> On Dec. 7, 2015, 11:51 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/process.cpp, lines 3218-3220 > > > > > > If this is an internal invariant, how about adding a `CHECK` here? How would the

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Dec. 8, 2015, 3:38 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/#review109243 --- This is starting to shape up, thanks Alexander. As we discussed

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/#review109405 --- Second part of my earlier review, this time I went throug the test

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Dec. 7, 2015, 3:14 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/#review109203 --- 3rdparty/libprocess/include/process/process.hpp (lines 261 - 263)

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Nov. 18, 2015, 3:51 p.m.) Review request for mesos, Adam B, Benjamin