Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102969 --- include/mesos/mesos.proto (lines 1104 - )

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

> On Oct. 12, 2015, 9:03 p.m., Ben Mahler wrote: > > include/mesos/mesos.proto, lines 1100-1101 > > > > > > Shall we say why it's "bad"? i.e. the default value when a caller > > doesn't check for presence is 0 and

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102317 --- Ship it! Really nice to see this stuff get fixed, thanks Jie! in

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102312 --- Patch looks great! Reviews applied: [38746] All tests passed. -

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/ --- (Updated Oct. 12, 2015, 7:33 p.m.) Review request for mesos, Ben Mahler, Timoth

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

> On Oct. 9, 2015, 10:54 p.m., Ben Mahler wrote: > > include/mesos/containerizer/containerizer.proto, lines 95-99 > > > > > > Why do you say "executor" here but termination is about "container" > > above? > > >

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

> On Oct. 9, 2015, 4:52 a.m., Timothy Chen wrote: > > include/mesos/mesos.proto, line 1121 > > > > > > What's the reasoning behind this order? Reordered according to alphabet. - Jie

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102111 --- Overall looks good, some of the comments I made can be addressed in

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

> On Oct. 9, 2015, 2:06 a.m., Kapil Arya wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1109-1115 > > > > > > I am slightly confused here. If one or more `Isolator::prepare` calls > > returned a

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102036 --- Patch looks great! Reviews applied: [38746] All tests passed. -

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102006 --- include/mesos/mesos.proto (line 1119)

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review101996 --- Thanks for doing this, Jie! I have one nit and one question about

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/ --- (Updated Oct. 9, 2015, 1:28 a.m.) Review request for mesos, Ben Mahler, Timothy

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/ --- (Updated Oct. 9, 2015, 1:27 a.m.) Review request for mesos, Ben Mahler, Timothy

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/ --- (Updated Oct. 9, 2015, 1:27 a.m.) Review request for mesos, Ben Mahler, Timothy

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review100526 --- Patch looks great! Reviews applied: [38746] All tests passed. -

Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/ --- Review request for mesos, Ben Mahler, Timothy Chen, and Vinod Kone. Bugs: MESOS