Re: Review Request 39211: Check for trailing characters in JSON::parse().

2015-10-21 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/#review103368 --- Ship it! Committing..

Re: Review Request 39211: Check for trailing characters in JSON::parse().

2015-10-20 Thread Greg Mann
> On Oct. 20, 2015, 7:28 a.m., Adam B wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, lines 744-748 > > > > > > I'm getting confused between `last_char` and `end`, since `end` isn't > > really

Re: Review Request 39211: Check for trailing characters in JSON::parse().

2015-10-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/ --- (Updated Oct. 20, 2015, 4:22 p.m.) Review request for mesos, Adam B and Joseph

Re: Review Request 39211: Check for trailing characters in JSON::parse().

2015-10-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/ --- (Updated Oct. 13, 2015, 5:51 p.m.) Review request for mesos, Adam B and Joseph

Re: Review Request 39211: Check for trailing characters in JSON::parse().

2015-10-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/#review102283 --- Ship it!

Re: Review Request 39211: Check for trailing characters in JSON::parse().

2015-10-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/ --- (Updated Oct. 12, 2015, 6:29 p.m.) Review request for mesos, Adam B and Joseph

Re: Review Request 39211: Check for trailing characters in JSON::parse().

2015-10-12 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/#review102372 --- Looks great! Just a couple of suggestions to expand unit testing &