Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-11-18 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39484/#review107028
---


I dont feel that we are really matching the intension of the ticket - even 
though it may be left unclear.

In any case, this user document is not a good place for documenting a single 
containerizer API function on a developer level.

Will try to find out what the original intension really was...

- Till Toenshoff


On Nov. 10, 2015, 7:17 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39484/
> ---
> 
> (Updated Nov. 10, 2015, 7:17 p.m.)
> 
> 
> Review request for mesos, Kapil Arya, Michael Park, Till Toenshoff, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-3113
> https://issues.apache.org/jira/browse/MESOS-3113
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add resource usage section to MesosContainerizer and DockerContainerizer 
> documentation
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/docker-containerizer.md 5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0 
> 
> Diff: https://reviews.apache.org/r/39484/diff/
> 
> 
> Testing
> ---
> 
> Github gist
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-11-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39484/#review105930
---


Bad patch!

Reviews applied: [39484]

Failed command: ./support/apply-review.sh -n -r 39484

Error:
 2015-11-10 19:26:22 URL:https://reviews.apache.org/r/39484/diff/raw/ 
[2788/2788] -> "39484.patch" [1]
error: docs/containerizer.md: does not exist in index
error: patch failed: docs/docker-containerizer.md:77
error: docs/docker-containerizer.md: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 10, 2015, 7:17 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39484/
> ---
> 
> (Updated Nov. 10, 2015, 7:17 p.m.)
> 
> 
> Review request for mesos, Kapil Arya, Michael Park, Till Toenshoff, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-3113
> https://issues.apache.org/jira/browse/MESOS-3113
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add resource usage section to MesosContainerizer and DockerContainerizer 
> documentation
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/docker-containerizer.md 5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0 
> 
> Diff: https://reviews.apache.org/r/39484/diff/
> 
> 
> Testing
> ---
> 
> Github gist
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-11-10 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39484/
---

(Updated Nov. 10, 2015, 11:17 a.m.)


Review request for mesos, Kapil Arya, Michael Park, Till Toenshoff, and Timothy 
Chen.


Bugs: MESOS-3113
https://issues.apache.org/jira/browse/MESOS-3113


Repository: mesos


Description
---

Add resource usage section to MesosContainerizer and DockerContainerizer 
documentation


Diffs (updated)
-

  docs/containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
  docs/docker-containerizer.md 5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0 

Diff: https://reviews.apache.org/r/39484/diff/


Testing
---

Github gist


Thanks,

Gilbert Song

Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-11-06 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39484/#review105562
---



docs/containerizer.md (line 94)


s/ and can be easily interpreted//



docs/containerizer.md (lines 94 - 116)


Instead of putting the protobuf. Can we simply change the language to 
something like:
```
  Some of the resources reported in this protobuf are user and system cpu 
time, cpu limits, resident set size, etc.
```

This way people can get an overall idea and still refer back to the proto 
definition for more details.



docs/containerizer.md (lines 119 - 136)


I am not sure why are we putting it out here. Why do we want to show how it 
is being called. Why not just make the description a bit more elaborate and 
kill the code?



docs/docker-containerizer.md (line 81)


Same comments as with containerizer.md.


- Kapil Arya


On Oct. 28, 2015, 3:48 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39484/
> ---
> 
> (Updated Oct. 28, 2015, 3:48 a.m.)
> 
> 
> Review request for mesos, Michael Park, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3113
> https://issues.apache.org/jira/browse/MESOS-3113
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add resource usage section to MesosContainerizer and DockerContainerizer 
> documentation
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/docker-containerizer.md 5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0 
> 
> Diff: https://reviews.apache.org/r/39484/diff/
> 
> 
> Testing
> ---
> 
> Github gist
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-10-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39484/#review103288
---


Patch looks great!

Reviews applied: [39484]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 4:45 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39484/
> ---
> 
> (Updated Oct. 20, 2015, 4:45 p.m.)
> 
> 
> Review request for mesos, Michael Park and Timothy Chen.
> 
> 
> Bugs: MESOS-3113
> https://issues.apache.org/jira/browse/MESOS-3113
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add resource usage section to MesosContainerizer and DockerContainerizer 
> documentation
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/docker-containerizer.md 5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0 
> 
> Diff: https://reviews.apache.org/r/39484/diff/
> 
> 
> Testing
> ---
> 
> Github gist
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-10-20 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39484/
---

Review request for mesos, Michael Park and Timothy Chen.


Bugs: MESOS-3113
https://issues.apache.org/jira/browse/MESOS-3113


Repository: mesos


Description
---

Add resource usage section to MesosContainerizer and DockerContainerizer 
documentation


Diffs
-

  docs/containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
  docs/docker-containerizer.md 5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0 

Diff: https://reviews.apache.org/r/39484/diff/


Testing
---

Github gist


Thanks,

Gilbert Song