----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39484/#review105562 -----------------------------------------------------------
docs/containerizer.md (line 94) <https://reviews.apache.org/r/39484/#comment164184> s/ and can be easily interpreted// docs/containerizer.md (lines 94 - 116) <https://reviews.apache.org/r/39484/#comment164185> Instead of putting the protobuf. Can we simply change the language to something like: ``` Some of the resources reported in this protobuf are user and system cpu time, cpu limits, resident set size, etc. ``` This way people can get an overall idea and still refer back to the proto definition for more details. docs/containerizer.md (lines 119 - 136) <https://reviews.apache.org/r/39484/#comment164186> I am not sure why are we putting it out here. Why do we want to show how it is being called. Why not just make the description a bit more elaborate and kill the code? docs/docker-containerizer.md (line 81) <https://reviews.apache.org/r/39484/#comment164187> Same comments as with containerizer.md. - Kapil Arya On Oct. 28, 2015, 3:48 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39484/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2015, 3:48 a.m.) > > > Review request for mesos, Michael Park, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-3113 > https://issues.apache.org/jira/browse/MESOS-3113 > > > Repository: mesos > > > Description > ------- > > Add resource usage section to MesosContainerizer and DockerContainerizer > documentation > > > Diffs > ----- > > docs/containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 > docs/docker-containerizer.md 5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0 > > Diff: https://reviews.apache.org/r/39484/diff/ > > > Testing > ------- > > Github gist > > > Thanks, > > Gilbert Song > >
