Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Dec. 14, 2015, 9:47 a.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Dec. 11, 2015, 12:45 p.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

> On Dec. 10, 2015, 7:58 p.m., Vinod Kone wrote: > > src/slave/qos_controllers/load.cpp, lines 236-241 > > > > > > if you do `return`s above, this could just be else block > > > > ``` > > } else { > >

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/#review110017 --- Ship it! src/slave/qos_controllers/load.cpp (line 206)

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

> On Dec. 9, 2015, 10:46 p.m., Vinod Kone wrote: > > src/Makefile.am, line 1600 > > > > > > Great to see a default QoS controller! Thx, can i `fix` that? =DDD - Bartek

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

> On Dec. 9, 2015, 6:32 p.m., Niklas Nielsen wrote: > > src/slave/qos_controllers/load.hpp, lines 39-45 > > > > > > Awesome comment! Let's make it a doxygen style one. Hmm, i followed all mesos style guidelines e.g

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/#review109842 --- src/slave/qos_controllers/load.cpp (line 76)

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

> On Dec. 9, 2015, 10:46 p.m., Vinod Kone wrote: > > Are you also planning to update > > https://github.com/apache/mesos/blob/master/docs/oversubscription.md ? Already in review: https://reviews.apache.org/r/41042/ (: Thx for detailed review i will fix the issues soon. > On Dec. 9, 2015,

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

> On Dec. 9, 2015, 10:46 p.m., Vinod Kone wrote: > > src/tests/oversubscription_tests.cpp, lines 1163-1176 > > > > > > push this inside the lamba below? Can i ask why? (: From the computation perspective now i

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/#review109798 --- Ship it! Looking great! Will let Vinod have one more look, but

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

> On Dec. 9, 2015, 10:32 a.m., Niklas Nielsen wrote: > > src/slave/qos_controllers/load.hpp, lines 39-45 > > > > > > Awesome comment! Let's make it a doxygen style one. > > Bartek Plotka wrote: > Hmm, i followed

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

> On Dec. 9, 2015, 2:46 p.m., Vinod Kone wrote: > > src/Makefile.am, line 1600 > > > > > > Great to see a default QoS controller! > > Bartek Plotka wrote: > Thx, can i `fix` that? =DDD @vinod - maybe wasn't

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Dec. 10, 2015, 5:03 p.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

> On Gru 9, 2015, 10:46 po południu, Vinod Kone wrote: > > src/Makefile.am, line 1600 > > > > > > Great to see a default QoS controller! > > Bartek Plotka wrote: > Thx, can i `fix` that? =DDD > > Niklas

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/#review109548 --- This is looking great, Bartek! One more round and I think we are

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/#review109597 --- Are you also planning to update

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Dec. 8, 2015, 11:16 a.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Dec. 7, 2015, 3:05 p.m.) Review request for mesos and Niklas Nielsen.

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Dec. 7, 2015, 3:02 p.m.) Review request for mesos and Niklas Nielsen.

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Dec. 7, 2015, 4:40 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/#review109057 --- looks great so far! We probably need a few tests to exercise the

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Nov. 26, 2015, 12:05 p.m.) Review request for mesos and Niklas

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Nov. 25, 2015, 3:45 p.m.) Review request for mesos and Niklas