Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-04-07 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
---

(Updated April 7, 2016, 10:37 a.m.)


Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.


Changes
---

Rebase.


Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655


Repository: mesos


Description
---

Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.


Diffs (updated)
-

  src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 

Diff: https://reviews.apache.org/r/43283/diff/


Testing
---

This also fix similar error in 
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.

# Note: This patch would discarded eventually.


Thanks,

haosdent huang

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-04-01 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
---

(Updated April 1, 2016, 10:45 a.m.)


Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.


Changes
---

Rebase.


Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655


Repository: mesos


Description (updated)
---

Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.


Diffs (updated)
-

  src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 

Diff: https://reviews.apache.org/r/43283/diff/


Testing
---

This also fix similar error in 
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.

# Note: This patch would discarded eventually.


Thanks,

haosdent huang

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-03-31 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
---

(Updated April 1, 2016, 3:06 a.m.)


Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.


Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655


Repository: mesos


Description
---

Please skip review this patch @jieyu. This is only used for pass local check in 
my machine.


Diffs
-

  src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 

Diff: https://reviews.apache.org/r/43283/diff/


Testing (updated)
---

This also fix similar error in 
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.

# Note: This patch would discarded eventually.


Thanks,

haosdent huang

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-03-31 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
---

(Updated April 1, 2016, 2:09 a.m.)


Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.


Changes
---

Rebase.


Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655


Repository: mesos


Description
---

Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.


Diffs (updated)
-

  src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 

Diff: https://reviews.apache.org/r/43283/diff/


Testing
---

This also fix similar error in 
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.


Thanks,

haosdent huang

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-27 Thread haosdent huang 


> On Feb. 8, 2016, 10:52 p.m., Ian Downes wrote:
> > src/linux/perf.cpp, lines 423-426
> > 
> >
> > Hmmm, I'm not satisfied with this. I thought the new output format was 
> > introduced at a specific kernel version (3.13.0 might not be correct). 
> > Could you please confirm that the 3.10 on CentOS7.1 has the new unit field 
> > but other 3.10 kernels don't.
> 
> haosdent huang wrote:
> The interesting thing here is I saw `unit` appear since 3.14 
> http://lxr.free-electrons.com/source/tools/perf/util/evsel.h?v=3.14#L72 I 
> think I missing something, let me find out more details about this.
> 
> haosdent huang wrote:
> According 
> https://github.com/torvalds/linux/blob/v3.13/tools/perf/builtin-stat.c#L1190-L1206
>  , I think the `perf stat` format for 3.13.0 also is `value,event,cgroup`.
> The `unit` added in this commit which contains since 3.14. 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=410136f5dd96b6013fe6d1011b523b1c247e1ccb
> Let me try create a virtual machine to verify this.
> 
> haosdent huang wrote:
> I try this in 
> 
> ```
> # cat /etc/issue
> Ubuntu 14.04.3 LTS \n \l
> ```
> 
> Kernel is 
> 
> ```
> uname -a
> Linux haosdent 3.13.0-32-generic #57-Ubuntu SMP Tue Jul 15 03:51:08 UTC 
> 2014 x86_64 x86_64 x86_64 GNU/Linux
> 
> 
> The `perf stat` output don't contains unit:
> 
> ```
> perf stat --all-cpus --field-separator , --log-fd 1 --event cycles 
> --cgroup mesos --event task-clock --cgroup mesos -- sleep 0.25
> ,cycles,mesos
> ,task-clock,mesos
> ```
> 
> Ian Downes wrote:
> Okay, if I'm understanding you correctly the value,unit,event,cgroup 
> format came in 3.14.0, not 3.13.0 as the current code states. Can we not 
> adjust the cases to correctly match the precise kernel versions?

Sorry, I could not get your idea here. Do you mean we need add a check >= 3.0.0 
?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/#review118314
---


On Feb. 14, 2016, 7:59 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43283/
> ---
> 
> (Updated Feb. 14, 2016, 7:59 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
> 
> 
> Bugs: MESOS-4655
> https://issues.apache.org/jira/browse/MESOS-4655
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
> 
> Diff: https://reviews.apache.org/r/43283/diff/
> 
> 
> Testing
> ---
> 
> This also fix similar error in 
> `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-26 Thread Ian Downes 


> On Feb. 8, 2016, 2:52 p.m., Ian Downes wrote:
> > src/linux/perf.cpp, lines 423-426
> > 
> >
> > Hmmm, I'm not satisfied with this. I thought the new output format was 
> > introduced at a specific kernel version (3.13.0 might not be correct). 
> > Could you please confirm that the 3.10 on CentOS7.1 has the new unit field 
> > but other 3.10 kernels don't.
> 
> haosdent huang wrote:
> The interesting thing here is I saw `unit` appear since 3.14 
> http://lxr.free-electrons.com/source/tools/perf/util/evsel.h?v=3.14#L72 I 
> think I missing something, let me find out more details about this.
> 
> haosdent huang wrote:
> According 
> https://github.com/torvalds/linux/blob/v3.13/tools/perf/builtin-stat.c#L1190-L1206
>  , I think the `perf stat` format for 3.13.0 also is `value,event,cgroup`.
> The `unit` added in this commit which contains since 3.14. 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=410136f5dd96b6013fe6d1011b523b1c247e1ccb
> Let me try create a virtual machine to verify this.
> 
> haosdent huang wrote:
> I try this in 
> 
> ```
> # cat /etc/issue
> Ubuntu 14.04.3 LTS \n \l
> ```
> 
> Kernel is 
> 
> ```
> uname -a
> Linux haosdent 3.13.0-32-generic #57-Ubuntu SMP Tue Jul 15 03:51:08 UTC 
> 2014 x86_64 x86_64 x86_64 GNU/Linux
> 
> 
> The `perf stat` output don't contains unit:
> 
> ```
> perf stat --all-cpus --field-separator , --log-fd 1 --event cycles 
> --cgroup mesos --event task-clock --cgroup mesos -- sleep 0.25
> ,cycles,mesos
> ,task-clock,mesos
> ```

Okay, if I'm understanding you correctly the value,unit,event,cgroup format 
came in 3.14.0, not 3.13.0 as the current code states. Can we not adjust the 
cases to correctly match the precise kernel versions?


- Ian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/#review118314
---


On Feb. 13, 2016, 11:59 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43283/
> ---
> 
> (Updated Feb. 13, 2016, 11:59 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
> 
> 
> Bugs: MESOS-4655
> https://issues.apache.org/jira/browse/MESOS-4655
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
> 
> Diff: https://reviews.apache.org/r/43283/diff/
> 
> 
> Testing
> ---
> 
> This also fix similar error in 
> `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-13 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
---

(Updated Feb. 14, 2016, 7:59 a.m.)


Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.


Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655


Repository: mesos


Description
---

Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.


Diffs
-

  src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 

Diff: https://reviews.apache.org/r/43283/diff/


Testing
---

This also fix similar error in 
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.


Thanks,

haosdent huang

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-09 Thread haosdent huang 


> On Feb. 8, 2016, 10:52 p.m., Ian Downes wrote:
> > src/linux/perf.cpp, lines 423-426
> > 
> >
> > Hmmm, I'm not satisfied with this. I thought the new output format was 
> > introduced at a specific kernel version (3.13.0 might not be correct). 
> > Could you please confirm that the 3.10 on CentOS7.1 has the new unit field 
> > but other 3.10 kernels don't.

The interesting thing here is I saw `unit` appear since 3.14 
http://lxr.free-electrons.com/source/tools/perf/util/evsel.h?v=3.14#L72 I think 
I missing something, let me find out more details about this.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/#review118314
---


On Feb. 7, 2016, 8:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43283/
> ---
> 
> (Updated Feb. 7, 2016, 8:18 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
> 
> 
> Bugs: MESOS-4039
> https://issues.apache.org/jira/browse/MESOS-4039
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
> 
> Diff: https://reviews.apache.org/r/43283/diff/
> 
> 
> Testing
> ---
> 
> This also fix similar error in 
> `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-09 Thread haosdent huang 


> On Feb. 8, 2016, 10:52 p.m., Ian Downes wrote:
> > src/linux/perf.cpp, lines 423-426
> > 
> >
> > Hmmm, I'm not satisfied with this. I thought the new output format was 
> > introduced at a specific kernel version (3.13.0 might not be correct). 
> > Could you please confirm that the 3.10 on CentOS7.1 has the new unit field 
> > but other 3.10 kernels don't.
> 
> haosdent huang wrote:
> The interesting thing here is I saw `unit` appear since 3.14 
> http://lxr.free-electrons.com/source/tools/perf/util/evsel.h?v=3.14#L72 I 
> think I missing something, let me find out more details about this.

According 
https://github.com/torvalds/linux/blob/v3.13/tools/perf/builtin-stat.c#L1190-L1206
 , I think the `perf stat` format for 3.13.0 also is `value,event,cgroup`.
The `unit` added in this commit which contains since 3.14. 
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=410136f5dd96b6013fe6d1011b523b1c247e1ccb
Let me try create a virtual machine to verify this.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/#review118314
---


On Feb. 7, 2016, 8:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43283/
> ---
> 
> (Updated Feb. 7, 2016, 8:18 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
> 
> 
> Bugs: MESOS-4039
> https://issues.apache.org/jira/browse/MESOS-4039
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
> 
> Diff: https://reviews.apache.org/r/43283/diff/
> 
> 
> Testing
> ---
> 
> This also fix similar error in 
> `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-09 Thread haosdent huang 


> On Feb. 8, 2016, 10:52 p.m., Ian Downes wrote:
> > src/linux/perf.cpp, lines 423-426
> > 
> >
> > Hmmm, I'm not satisfied with this. I thought the new output format was 
> > introduced at a specific kernel version (3.13.0 might not be correct). 
> > Could you please confirm that the 3.10 on CentOS7.1 has the new unit field 
> > but other 3.10 kernels don't.
> 
> haosdent huang wrote:
> The interesting thing here is I saw `unit` appear since 3.14 
> http://lxr.free-electrons.com/source/tools/perf/util/evsel.h?v=3.14#L72 I 
> think I missing something, let me find out more details about this.
> 
> haosdent huang wrote:
> According 
> https://github.com/torvalds/linux/blob/v3.13/tools/perf/builtin-stat.c#L1190-L1206
>  , I think the `perf stat` format for 3.13.0 also is `value,event,cgroup`.
> The `unit` added in this commit which contains since 3.14. 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=410136f5dd96b6013fe6d1011b523b1c247e1ccb
> Let me try create a virtual machine to verify this.

I try this in 

```
# cat /etc/issue
Ubuntu 14.04.3 LTS \n \l
```

Kernel is 

```
uname -a
Linux haosdent 3.13.0-32-generic #57-Ubuntu SMP Tue Jul 15 03:51:08 UTC 2014 
x86_64 x86_64 x86_64 GNU/Linux


The `perf stat` output don't contains unit:

```
perf stat --all-cpus --field-separator , --log-fd 1 --event cycles --cgroup 
mesos --event task-clock --cgroup mesos -- sleep 0.25
,cycles,mesos
,task-clock,mesos
```


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/#review118314
---


On Feb. 7, 2016, 8:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43283/
> ---
> 
> (Updated Feb. 7, 2016, 8:18 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
> 
> 
> Bugs: MESOS-4039
> https://issues.apache.org/jira/browse/MESOS-4039
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
> 
> Diff: https://reviews.apache.org/r/43283/diff/
> 
> 
> Testing
> ---
> 
> This also fix similar error in 
> `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-08 Thread Ian Downes 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/#review118314
---




src/linux/perf.cpp (lines 423 - 426)


Hmmm, I'm not satisfied with this. I thought the new output format was 
introduced at a specific kernel version (3.13.0 might not be correct). Could 
you please confirm that the 3.10 on CentOS7.1 has the new unit field but other 
3.10 kernels don't.


- Ian Downes


On Feb. 7, 2016, 12:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43283/
> ---
> 
> (Updated Feb. 7, 2016, 12:18 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
> 
> 
> Bugs: MESOS-4039
> https://issues.apache.org/jira/browse/MESOS-4039
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
> 
> Diff: https://reviews.apache.org/r/43283/diff/
> 
> 
> Testing
> ---
> 
> This also fix similar error in 
> `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-07 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
---

(Updated Feb. 7, 2016, 8:14 a.m.)


Review request for mesos, Jan Schlicht and Paul Brett.


Bugs: MESOS-4039
https://issues.apache.org/jira/browse/MESOS-4039


Repository: mesos


Description
---

Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.


Diffs
-

  src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 

Diff: https://reviews.apache.org/r/43283/diff/


Testing (updated)
---

This also fix similar error in 
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.


Thanks,

haosdent huang

Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-06 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
---

Review request for mesos and Jan Schlicht.


Bugs: MESOS-4039
https://issues.apache.org/jira/browse/MESOS-4039


Repository: mesos


Description
---

Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.


Diffs
-

  src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 

Diff: https://reviews.apache.org/r/43283/diff/


Testing
---


Thanks,

haosdent huang