Re: Review Request 43306: Migrated linux launcher systemd executor logic into subprocess hook.

2016-02-10 Thread Joris Van Remoortere
> On Feb. 9, 2016, 10:22 p.m., Benjamin Hindman wrote: > > src/slave/containerizer/mesos/linux_launcher.cpp, line 310 > > > > > > What about something like: > > > > ```c++ > > // Capture the freezer

Re: Review Request 43306: Migrated linux launcher systemd executor logic into subprocess hook.

2016-02-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43306/ --- (Updated Feb. 10, 2016, 4:51 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43306: Migrated linux launcher systemd executor logic into subprocess hook.

2016-02-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43306/ --- (Updated Feb. 9, 2016, 7:14 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43306: Migrated linux launcher systemd executor logic into subprocess hook.

2016-02-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43306/#review118487 --- src/linux/systemd.cpp (line 76)

Re: Review Request 43306: Migrated linux launcher systemd executor logic into subprocess hook.

2016-02-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43306/#review118469 --- Fix it, then Ship it! src/linux/systemd.cpp (line 66)

Review Request 43306: Migrated linux launcher systemd executor logic into subprocess hook.

2016-02-07 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43306/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos