Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 24, 2016, 4:14 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 23, 2016, 11:15 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 22, 2016, 5:05 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 17, 2016, 11:33 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

> On March 15, 2016, 8:11 p.m., Ben Mahler wrote: > > src/executor/executor.cpp, line 703 > > > > > > I'm thinking now that we should trust the value in the environment if > > it's set, rather than overwriting,

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/#review124289 --- Ship it! Ship It! - Ben Mahler On March 17, 2016, 11:33

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

> On March 15, 2016, 8:11 p.m., Ben Mahler wrote: > > include/mesos/v1/executor/executor.proto, lines 53-55 > > > > > > Now that the period within the Shutdown message was removed, we should > > probably have a TODO

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/#review124338 --- include/mesos/mesos.proto (line 445)

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/#review123731 --- Looking good! Just some minor logical tweaks and some updates to

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 15, 2016, 3:49 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 15, 2016, 2:25 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 14, 2016, 5:48 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Gilbert Song.

Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-1571