Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-25 Thread Greg Mann
> On April 25, 2016, 3:32 p.m., Kapil Arya wrote: > > src/tests/metrics_tests.cpp, line 85 > > > > > > Newline? Good catch! Fixed. - Greg --- This is an

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46261/ --- (Updated April 25, 2016, 5:37 p.m.) Review request for mesos, Adam B and

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46261/#review130425 --- Ship it! src/tests/metrics_tests.cpp (line 85)

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46261/ --- (Updated April 21, 2016, 5:58 p.m.) Review request for mesos, Adam B and

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-18 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46261/#review129303 --- Ship it! Ship It! - Alexander Rojas On April 15, 2016, 9:01

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-15 Thread Greg Mann
> On April 15, 2016, 11:39 a.m., Alexander Rojas wrote: > > src/tests/metrics_tests.cpp, line 288 > > > > > > To be consistent with your other patches, could you add tests for wrong > > credentials. > > > >

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46261/#review129100 --- src/tests/metrics_tests.cpp (line 288)

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46261/ --- (Updated April 15, 2016, 7:01 a.m.) Review request for mesos, Adam B and

Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46261/ --- Review request for mesos, Adam B and Alexander Rojas. Bugs: MESOS-4902