Re: Review Request 52002: Added helper methods to determine types of disk resources.

2017-05-24 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated May 24, 2017, 7:56 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2017-03-01 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/#review167527 --- Closing this review due to inactivity. Please see our

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-12-18 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Dec. 18, 2016, 8:38 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-12-09 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Dec. 10, 2016, 1:19 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-11-20 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Nov. 21, 2016, 7:18 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-11-18 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/#review156362 --- Fix it, then Ship it! src/common/resources.cpp (lines 792 -

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-10-25 Thread Anindya Sinha
> On Oct. 5, 2016, 8:56 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, lines 278-280 > > > > > > I still have reservations about this method. > > > > As we discussed, a predicate returning a

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-10-25 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Oct. 25, 2016, 6:19 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-10-25 Thread Anindya Sinha
> On Oct. 2, 2016, 3:14 a.m., Guangya Liu wrote: > > src/tests/resources_tests.cpp, line 2182 > > > > > > Here we should keep 4 space start from the `(` above or else you can: > > > > ``` > >

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-10-05 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Oct. 6, 2016, 2 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-10-05 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/#review150585 --- include/mesos/resources.hpp (lines 278 - 280)

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-10-03 Thread Guangya Liu
> On 十月 2, 2016, 3:14 a.m., Guangya Liu wrote: > > src/tests/resources_tests.cpp, line 2182 > > > > > > Here we should keep 4 space start from the `(` above or else you can: > > > > ``` > >

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-10-03 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Oct. 3, 2016, 11:46 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-10-03 Thread Anindya Sinha
> On Oct. 2, 2016, 3:14 a.m., Guangya Liu wrote: > > src/tests/resources_tests.cpp, line 2182 > > > > > > Here we should keep 4 space start from the `(` above or else you can: > > > > ``` > >

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-10-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/#review151126 --- src/common/resources.cpp (lines 857 - 860)

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-09-28 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Sept. 28, 2016, 7:24 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-09-26 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Sept. 26, 2016, 8:58 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-09-26 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Sept. 26, 2016, 6:48 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-09-21 Thread Anindya Sinha
> On Sept. 20, 2016, 10:29 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, lines 276-278 > > > > > > Would it be simpler to just have > > > > ``` > > static bool Resources::isMountDisk(const

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-09-21 Thread Jiang Yan Xu
> On Sept. 20, 2016, 3:29 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, lines 276-278 > > > > > > Would it be simpler to just have > > > > ``` > > static bool Resources::isMountDisk(const

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-09-21 Thread Anindya Sinha
> On Sept. 20, 2016, 10:29 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, lines 273-274 > > > > > > Does it need to be a Try? i.e., if it's not a disk, it's not a root > > disk, right? We have

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-09-20 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Sept. 21, 2016, 4:14 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-09-20 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/#review149739 --- include/mesos/resources.hpp (lines 273 - 274)

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-09-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Sept. 19, 2016, 10:43 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-09-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/#review149440 --- src/common/resources.cpp (lines 930 - 931)

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-09-18 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Sept. 19, 2016, 5 a.m.) Review request for mesos and Jiang Yan Xu.

Review Request 52002: Added helper methods to determine types of disk resources.

2016-09-18 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- Review request for mesos. Repository: mesos Description --- Added