----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/#review156362 -----------------------------------------------------------
Fix it, then Ship it! src/common/resources.cpp (lines 792 - 793) <https://reviews.apache.org/r/52002/#comment226582> This indentation looks odd. Let's do: ``` return resource.name() == "disk" && resource.has_disk() && resource.disk().has_persistence(); ``` src/common/resources.cpp (lines 835 - 836) <https://reviews.apache.org/r/52002/#comment226583> Style suggestion: ``` return resource.name() == "disk" && (!resource.has_disk() || !resource.disk().has_source()); ``` - Jiang Yan Xu On Oct. 25, 2016, 11:19 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52002/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2016, 11:19 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6062 > https://issues.apache.org/jira/browse/MESOS-6062 > > > Repository: mesos > > > Description > ------- > > Added helper methods to determine types of disk resources. > > > Diffs > ----- > > include/mesos/resources.hpp f569c931ff7db8d51dfd7c96f4f2addab05df85d > include/mesos/v1/resources.hpp f60ab794a0c7c24885c49cc47b798c363e3279e7 > src/common/resources.cpp 4bb9beffcb3509f4226b4985e05eccec01412d0f > src/tests/resources_tests.cpp d6eb7787bac58c1133a4bab0fc17df49117fed87 > src/v1/resources.cpp 46cc00f2f453f5eb4ddc4b0b9b89be2bd89f05d9 > > Diff: https://reviews.apache.org/r/52002/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
