Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204736 --- PASS: Mesos patch 67394 was successfully built and tested.

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/ --- (Updated June 13, 2018, 6:36 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

> On June 12, 2018, 5:23 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Failed to apply the current review. > > > > Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67394` > > > > All the build artifacts available at: > >

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204718 --- Ship it! Ship It! - Andrew Schwartzmeyer On June 12, 2018,

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204648 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/ --- (Updated June 12, 2018, 10:56 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204644 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/ --- (Updated June 12, 2018, 9:07 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

> On June 11, 2018, 9:52 a.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/launcher.hpp > > Lines 59-72 (original), 59-82 (patched) > > > > > > I'm not sure I follow; why do we need this entire change

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204549 --- src/slave/containerizer/mesos/launcher.hpp Lines 73 (patched)

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204523 --- src/tests/containerizer/launcher.hpp Line 60 (original), 60

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/ --- (Updated May 31, 2018, 10:50 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204082 --- Patch looks great! Reviews applied: [67286, 67287, 67394]

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204078 --- PASS: Mesos patch 67394 was successfully built and tested.

Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/ --- Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.