Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

2019-10-07 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71498/#review218108 --- Patch looks great! Reviews applied: [71486, 71487, 71488, 71489,

Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

2019-10-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71498/#review218092 --- Bad patch! Reviews applied: [71486, 71487, 71488, 71489, 71490,

Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

2019-10-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71498/#review218082 --- Bad review! Reviews applied: [71498, 71491, 71490, 71489, 71488,

Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

2019-09-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71498/#review217968 --- Patch looks great! Reviews applied: [71486, 71487, 71488, 71489,

Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

2019-09-18 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71498/#review217828 --- Patch looks great! Reviews applied: [71489, 71486, 71487, 71488,

Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

2019-09-18 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71498/ --- (Updated Sept. 18, 2019, 12:59 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

2019-09-17 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71498/#review217795 --- Fix it, then Ship it!

Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

2019-09-17 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71498/#review217794 --- Patch looks great! Reviews applied: [71489, 71486, 71487, 71488,

Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

2019-09-17 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71498/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-9949