Re: Review Request 32982: Added reservation user guide.

[Adam B]

> On June 29, 2015, 4:43 p.m., Adam B wrote:
> > Looks great! I know this is already committed, but I had a few 
> > questions/clarifications. Maybe you've answered these elsewhere, but I've 
> > been out of the loop for a while.

Thanks for answering my questions. I don't think there's anything that really 
warrants an edit/update.


> On June 29, 2015, 4:43 p.m., Adam B wrote:
> > docs/reservation.md, lines 109-110
> > 
> >
> > Shouldn't the master be able to determine the principal that this 
> > frameworkId is currently authenticated as? Why even allow the framework to 
> > specify a different principal if you're just going to Error?
> 
> Michael Park wrote:
> Hm, that's true. This was another situation where I wanted to keep  
> `ReservationInfo.principal` as `required`.

Fair enough, although it seems like you're leaking the internal data 
representation into the user-facing API. Shouldn't be necessary.


> On June 29, 2015, 4:43 p.m., Adam B wrote:
> > docs/reservation.md, line 196
> > 
> >
> > Could also only unreserve a subset, right?
> 
> Michael Park wrote:
> Yeah, that's true. I didn't really mention that part.

Not terribly important. Anybody familiar with using resource offers should be 
able to figure that one out.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89824
---


On June 27, 2015, 8:33 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 27, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Github rendered version is available [here]( 
> https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

> On June 28, 2015, 11:36 p.m., Benjamin Hindman wrote:
> > I made a few minor tweaks here before committing.
> > 
> > (1) Replaced the fenced code blocks with indented code blocks so that the 
> > doxygen generated markdown was readable.
> > (2) Made all the 'Coming Soon' be styled consistently (I went with one _, 
> > if you'd prefer the ___ underscore instead we can swap).
> > (3) Made the shell examples be copyable to an actual shell by adding line 
> > continuations, i.e., \.

Thanks for doing that Ben,

(1) Thanks,
(2) Yeah, I left it as _ in the header because the boldness part didn't seem to 
have any effect in its rendering. I would probably prefer the ___ since that's 
what we use in `Getting Started` as well for (___Recommended___) and, 
(___Advanced Users Only___)
(3) Sweet!


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89689
---


On June 28, 2015, 3:33 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 28, 2015, 3:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Github rendered version is available [here]( 
> https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

> On June 29, 2015, 11:43 p.m., Adam B wrote:
> > docs/reservation.md, line 108
> > 
> >
> > I know that we'll want to explicitly specify the role to support future 
> > multi-role frameworks, but why does this need to be included now?

There were 2 motivations for this. First is what you said, the second was that 
we can enforce the field to be `required` this way.


> On June 29, 2015, 11:43 p.m., Adam B wrote:
> > docs/reservation.md, lines 109-110
> > 
> >
> > Shouldn't the master be able to determine the principal that this 
> > frameworkId is currently authenticated as? Why even allow the framework to 
> > specify a different principal if you're just going to Error?

Hm, that's true. This was another situation where I wanted to keep  
`ReservationInfo.principal` as `required`.


> On June 29, 2015, 11:43 p.m., Adam B wrote:
> > docs/reservation.md, line 196
> > 
> >
> > Could also only unreserve a subset, right?

Yeah, that's true. I didn't really mention that part.


> On June 29, 2015, 11:43 p.m., Adam B wrote:
> > docs/reservation.md, line 309
> > 
> >
> > How can there be insufficient resources to unreserve?

The simplest case would be: if we have 4 dynamically reserved cpus and the 
request is to unreserve 6 dynamically reserved cpus. We don't simply unreserve 
the portion we can. A slightly more complicated case would be: if we have 4 
dynamically reserved cpus and the request is to unreserve 4 dynamically 
reserved cpus, but 2 of them are currently being used. As we don't currently 
pre-empt tasks, it results in a `Conflict` for us currently.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89824
---


On June 28, 2015, 3:33 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 28, 2015, 3:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Github rendered version is available [here]( 
> https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89824
---


Looks great! I know this is already committed, but I had a few 
questions/clarifications. Maybe you've answered these elsewhere, but I've been 
out of the loop for a while.


docs/reservation.md (line 108)


I know that we'll want to explicitly specify the role to support future 
multi-role frameworks, but why does this need to be included now?



docs/reservation.md (lines 109 - 110)


Shouldn't the master be able to determine the principal that this 
frameworkId is currently authenticated as? Why even allow the framework to 
specify a different principal if you're just going to Error?



docs/reservation.md (line 196)


Could also only unreserve a subset, right?



docs/reservation.md (line 248)


Again, if we're already authenticating as a certain principal in the 
request, why do we need to explicitly specify a (potentially different?) 
principal in the resources message?



docs/reservation.md (line 309)


How can there be insufficient resources to unreserve?


- Adam B


On June 27, 2015, 8:33 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 27, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Github rendered version is available [here]( 
> https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Benjamin Hindman]

> On May 13, 2015, 10:25 p.m., Marco Massenzio wrote:
> > docs/reservation.md, line 71
> > 
> >
> > this seems to imply that in the Request, the `slave_id` is some part of 
> > a "form" submission:
> > ```
> > -d, --data 
> >  (HTTP) Sends the specified data in a POST request to the HTTP
> >  server, in the same way that a browser does
> >  when a user has filled in an HTML form and presses the submit
> >  button. This will cause curl  to  pass  the data to the server
> >  using the content-type application/x-www-form-urlencoded.
> > ```
> > 
> > IMO the API should instead carry the `slave_id` either as part of the 
> > URL (`/reserve/slave_id/1234-xyz`) or part of the JSON body:
> > ```
> > {
> > "slave_id": "1234-xyz",
> > "resources": {
> >"name" : "cpus",
> >"type" : "SCALAR",
> >"scalar" : { "value" : 8 },
> >...
> > }
> > }
> > ```
> > Also, we need to be sure that the `Content-Type` is set accordingly 
> > (`application/json`)
> > 
> > The same for all the other endpoints.
> 
> Cody Maloney wrote:
> I think just having it all be in the request body is more like how Mesos 
> does all the rest of it's endpoints currently.
> 
> For the HTTP API version would be nice to do JSON, but the current 
> protobuf/http Mesos APIs currently they all work on the "form encoding" thing 
> which is a standard (Although mesos only implements a specific subset of it 
> with some quirks).
> 
> Michael Park wrote:
> Marco, thanks for mentioning the concerns here.
> 
> I think the API I described here is consistent with how existing APIs 
> work such as `/teardown`. I think your proposal is that we change the API for 
> all the endpoints, based on:
> > The same for all the other endpoints.
> 
> Let's create a JIRA ticket for this and tackle it as a separate task.

I've dropped this issue for now since the endpoint will be done in a separate 
review and we can discuss the API there. This section is marked _Coming Soon_ 
so we can change it once we it's finalized. For what it's worth, however, I'm 
also a +1 to have the slave ID (and other non-body POST data) in the URL path.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83674
---


On June 28, 2015, 3:33 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 28, 2015, 3:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Github rendered version is available [here]( 
> https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89689
---

Ship it!


I made a few minor tweaks here before committing.

(1) Replaced the fenced code blocks with indented code blocks so that the 
doxygen generated markdown was readable.
(2) Made all the 'Coming Soon' be styled consistently (I went with one _, if 
you'd prefer the ___ underscore instead we can swap).
(3) Made the shell examples be copyable to an actual shell by adding line 
continuations, i.e., \.

- Benjamin Hindman


On June 28, 2015, 3:33 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 28, 2015, 3:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Github rendered version is available [here]( 
> https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89654
---


Patch looks great!

Reviews applied: [32982]

All tests passed.

- Mesos ReviewBot


On June 28, 2015, 3:33 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 28, 2015, 3:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Github rendered version is available [here]( 
> https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated June 28, 2015, 3:33 a.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description (updated)
---

The Github rendered version is available [here]( 
https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)


Diffs
-

  docs/reservation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32982/diff/


Testing
---

Documentation.


Thanks,

Michael Park

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated June 28, 2015, 3:28 a.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description (updated)
---

The Github rendered version is available [here]( 
https://github.com/mesosphere/mesos/blob/reservation-user-doc/docs/reservation.md)


Diffs
-

  docs/reservation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32982/diff/


Testing
---

Documentation.


Thanks,

Michael Park

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated June 28, 2015, 3:27 a.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.


Changes
---

Rebased.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description
---

The Github rendered version is available at: 
https://github.com/mesosphere/mesos/blob/reservation-user-doc/docs/reservation.md


Diffs (updated)
-

  docs/reservation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32982/diff/


Testing
---

Documentation.


Thanks,

Michael Park

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated June 28, 2015, 3:23 a.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.


Changes
---

Conform to the Mesos Markdown Style.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description
---

The Github rendered version is available at: 
https://github.com/mesosphere/mesos/blob/reservation-user-doc/docs/reservation.md


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 
3aa9487bed2df038ca27a8bb94c24608ca7910a4 
  3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
967201888114e01f1a2d3c9cfaae847f1ce42d13 
  3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
bba8303347aac3f70566a9e69625a928cfb1bd24 
  3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp 
5d0970fe9f712d7162eec522c83905292892c94d 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
ae54566b9d0160def6146aa0ce634bdbf0967142 
  3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
4e8c3bd1e9abf0ff24f78c8385ed9625719dcf8c 
  3rdparty/libprocess/3rdparty/stout/include/stout/gtest.hpp 
f766359fdd5a75e3a80d19be3e5c233e87357bde 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
ecab60a21765c58b0732de747509aa6382d31c06 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
a0ea23797376288e8dc96886fd3c0702e5edf846 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
818560f8ce20126e0aa4af6ce368c973c9616c74 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp 
c6cfb60272d3754fdfdd4a8f9eefe56458d9cbf7 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
5570d62729453a639a94c5569eb510ff2f1395a1 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 
784104f26ceee2ef90709056a5f4428d48390c36 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp 
fed005e0bbbcfb7a8a9e4cccf1e47e1ab3d91394 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp 
dfb2d948f2c20d02f179b4137e59d15a8b3b9c3b 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
0e94e22817e21fc7944a995092e54bf302ab0e2c 
  3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
a4afdad0b5f053186ace4d6a37b41cd02e7d415b 
  3rdparty/libprocess/3rdparty/stout/include/stout/preprocessor.hpp 
11ec3d5349e2087f7352ebadf247ad509ab11c17 
  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
8c75f6b28c18596018eaefe427b238424aae2fd9 
  3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 
963029bea989a68a484f7b8b47d29ea5fffeb955 
  3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp 
8934ba79685685d5f5eae5991057c6ad3c8eea8e 
  3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp 
552d6e97c882a36d6a889af205c422e51f544b34 
  3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
5ad611497a47be64c539e832b9a1c23e6cf9586d 
  3rdparty/libprocess/3rdparty/stout/include/stout/utils.hpp 
faca859969a95b51d5fda5542d11906ff03dcf00 
  3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 
  3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 
8692323d28131cd5706dde0503d49f8f0b0a1aeb 
  3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp 
f8a0ba5fc004c1dae265aa17e2a014279cd97281 
  3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp 
35a62b199dc8e8ed538ad771504f0dbee4132fe7 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
2a6f67b9636b9a4e2be57465eea01af6cbc867be 
  3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 
2211f31b30ea3fb26d9ca3126daa26a325b61daf 
  3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 
4a8176b6f32403fc2e167364744bb13b2e4969e2 
  3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 
97a716788ed58db35e9fbe5621c07a40d89e7674 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
0011f080a08c203c8986ebbcb92540047ecfabca 
  3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 
0644d99df5fcf015b9dcc84f12798f8e2532e377 
  3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 
11f3bf746445704cbf4102989cc9fb911a2f6ab3 
  3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 
1c1f8be3640fe896f66565760d93344cf0c264b9 
  3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 
d87cf22dbb98e1ac99f129668ad984a1542e4ec9 
  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 
fee942cdebc2797b42ac4cf0ffd5b202c9733bf6 
  3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 
6d2d3d5db57581e0392b31d8187531a9b672d47b 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
4a01d9481c02ccbee323fd7e1319b811d344fb1d 
  3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 
3211a0d6b88d06b396678eaf20128698f576d198 
  3rdparty/libprocess/3rdparty/stout/tests/pro

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated June 27, 2015, 2:32 a.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.


Changes
---

Added link to rendered version.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description (updated)
---

The Github rendered version is available at: 
https://github.com/mesosphere/mesos/blob/reservation-user-doc/docs/reservation.md


Diffs
-

  docs/reservation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32982/diff/


Testing
---

Documentation.


Thanks,

Michael Park

Re: Review Request 32982: Added reservation user guide.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89562
---


Patch looks great!

Reviews applied: [32982]

All tests passed.

- Mesos ReviewBot


On June 26, 2015, 8:43 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 26, 2015, 8:43 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

> On May 13, 2015, 10:25 p.m., Marco Massenzio wrote:
> > docs/reservation.md, line 71
> > 
> >
> > this seems to imply that in the Request, the `slave_id` is some part of 
> > a "form" submission:
> > ```
> > -d, --data 
> >  (HTTP) Sends the specified data in a POST request to the HTTP
> >  server, in the same way that a browser does
> >  when a user has filled in an HTML form and presses the submit
> >  button. This will cause curl  to  pass  the data to the server
> >  using the content-type application/x-www-form-urlencoded.
> > ```
> > 
> > IMO the API should instead carry the `slave_id` either as part of the 
> > URL (`/reserve/slave_id/1234-xyz`) or part of the JSON body:
> > ```
> > {
> > "slave_id": "1234-xyz",
> > "resources": {
> >"name" : "cpus",
> >"type" : "SCALAR",
> >"scalar" : { "value" : 8 },
> >...
> > }
> > }
> > ```
> > Also, we need to be sure that the `Content-Type` is set accordingly 
> > (`application/json`)
> > 
> > The same for all the other endpoints.
> 
> Cody Maloney wrote:
> I think just having it all be in the request body is more like how Mesos 
> does all the rest of it's endpoints currently.
> 
> For the HTTP API version would be nice to do JSON, but the current 
> protobuf/http Mesos APIs currently they all work on the "form encoding" thing 
> which is a standard (Although mesos only implements a specific subset of it 
> with some quirks).

Marco, thanks for mentioning the concerns here.

I think the API I described here is consistent with how existing APIs work such 
as `/teardown`. I think your proposal is that we change the API for all the 
endpoints, based on:
> The same for all the other endpoints.

Let's create a JIRA ticket for this and tackle it as a separate task.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83674
---


On June 26, 2015, 8:35 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 26, 2015, 8:35 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated June 26, 2015, 8:43 p.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  docs/reservation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32982/diff/


Testing
---

Documentation.


Thanks,

Michael Park

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

> On May 13, 2015, 10:25 p.m., Marco Massenzio wrote:
> > docs/reservation.md, lines 97-100
> > 
> >
> > Let us please add at least a suggestion of the possible error codes 
> > (and a couple Response bodies) here too - at least people can comment.
> > 
> > Here's my suggestion:
> > ```
> > 400 - something went wrong, err_msg in JSON
> > 401 - the role/framework is not authorized to reserve stuff
> > 403 - the configuration and/or this slave do not allow reserved 
> > resources
> > 409 - you can't do this; for example: I offered you 4 CPUs and you want 
> > to reserve 8
> > ```
> > and our all-time favorite:
> > ```
> > 404 - the resources you want to reserve cannot be found ("name": 
> > "cash", "value": "$2MM")
> > ```
> > Only half-joking here: I can't think of any situation where a request 
> > like this could give a 404, but maybe there are some?
> > 
> > My recommendation would be to have the codes here (and for `unreserve` 
> > too) so that people can comment.

The possible HTTP responses currently are: `200 OK`, `400 BadRequest`, `401 
Unauthorized` and `409 Conflict`.

We could potentially introduce `403 Forbidden` and `404 Not Found` if they fit.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83674
---


On June 26, 2015, 8:35 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 26, 2015, 8:35 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

> On May 11, 2015, 9:51 a.m., Joerg Schad wrote:
> > docs/reservation.md, line 25
> > 
> >
> > s/existed prior/available since version x.x.x?
> 
> Michael Park wrote:
> I went with `introduced in 0.14.0` here.

Actually decided to go with `since 0.14.0`


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83212
---


On June 26, 2015, 8:35 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 26, 2015, 8:35 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

> On May 8, 2015, 7:02 p.m., Timothy Chen wrote:
> > docs/reservation.md, line 79
> > 
> >
> > A notable difference between static reservation is the principal here, 
> > are you going to cover that?

Thanks for bringing this up! I've added the following snippet.

```
We require a `principal` from the operator or framework in order to
authenticate/authorize the operations. [Authorization](authorization.md) is 
specified via the existing ACL mechanism. (___Coming Soon___)
```


> On May 8, 2015, 7:02 p.m., Timothy Chen wrote:
> > docs/reservation.md, line 25
> > 
> >
> > existed prior to 0.23.0 seems to imply it no longer exists after 0.23.0?
> 
> Michael Park wrote:
> I went with `introduced in 0.14.0` instead.

Actually decided to go with `since 0.14.0`


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83054
---


On June 26, 2015, 8:35 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 26, 2015, 8:35 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated June 26, 2015, 8:35 p.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  docs/reservation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32982/diff/


Testing
---

Documentation.


Thanks,

Michael Park

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated June 26, 2015, 8:33 p.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  docs/reservation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32982/diff/


Testing
---

Documentation.


Thanks,

Michael Park

Re: Review Request 32982: Added reservation user guide.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89551
---


Patch looks great!

Reviews applied: [32982]

All tests passed.

- Mesos ReviewBot


On June 26, 2015, 7:53 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 26, 2015, 7:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Cody Maloney]

> On May 13, 2015, 10:25 p.m., Marco Massenzio wrote:
> > docs/reservation.md, line 71
> > 
> >
> > this seems to imply that in the Request, the `slave_id` is some part of 
> > a "form" submission:
> > ```
> > -d, --data 
> >  (HTTP) Sends the specified data in a POST request to the HTTP
> >  server, in the same way that a browser does
> >  when a user has filled in an HTML form and presses the submit
> >  button. This will cause curl  to  pass  the data to the server
> >  using the content-type application/x-www-form-urlencoded.
> > ```
> > 
> > IMO the API should instead carry the `slave_id` either as part of the 
> > URL (`/reserve/slave_id/1234-xyz`) or part of the JSON body:
> > ```
> > {
> > "slave_id": "1234-xyz",
> > "resources": {
> >"name" : "cpus",
> >"type" : "SCALAR",
> >"scalar" : { "value" : 8 },
> >...
> > }
> > }
> > ```
> > Also, we need to be sure that the `Content-Type` is set accordingly 
> > (`application/json`)
> > 
> > The same for all the other endpoints.

I think just having it all be in the request body is more like how Mesos does 
all the rest of it's endpoints currently.

For the HTTP API version would be nice to do JSON, but the current 
protobuf/http Mesos APIs currently they all work on the "form encoding" thing 
which is a standard (Although mesos only implements a specific subset of it 
with some quirks).


- Cody


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83674
---


On June 26, 2015, 7:53 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 26, 2015, 7:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

> On May 13, 2015, 11:16 p.m., Bernd Mathiske wrote:
> > docs/reservation.md, line 95
> > 
> >
> > This sentence does not strictly add any information. It is more likely 
> > confusing. What does it mean to "convert" a resource? I suppose we are 
> > merely accounting for them here, not physically affecting the resources 
> > themselves, right?
> > 
> > Suggestion:
> > 
> > The Mesos master will take the requested reservation into account.

I agree that this section doesn't actually add much value. I've simplified this 
section and simply described the possible HTTP responses instead.


> On May 13, 2015, 11:16 p.m., Bernd Mathiske wrote:
> > docs/reservation.md, line 132
> > 
> >
> > Same as the above sentence.

Same here.


> On May 13, 2015, 11:16 p.m., Bernd Mathiske wrote:
> > docs/reservation.md, line 249
> > 
> >
> > Isn't this the exact same offer as above? Can we simply reference it 
> > instead of repeating it?

It is indeed the exact same offer. I decided to keep it here since one of the 
things I learned is that people don't read necessarily read from top to bottom. 
I have added a note saying that they're the same, for those who are reading top 
to bottom.

```
A framework is able to unreserve resources through the resource offer cycle. In 
Offer::Operation::Reserve, we reserved 8 CPUs and 4096 MB of RAM for our 
`role`. The master will continue to offer these resources to our `role`. 
Suppose we would like to unreserve these resources.
First, we receive a resource offer like below:

/* repeated for those who are jumping sections. */
```


> On May 13, 2015, 11:16 p.m., Bernd Mathiske wrote:
> > docs/reservation.md, line 320
> > 
> >
> > Even if we repeat the offer from way above here, we may want to mention 
> > that it is exactly the same again.

Agreed. Done.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83678
---


On June 26, 2015, 7:53 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 26, 2015, 7:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated June 26, 2015, 7:53 p.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  docs/reservation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32982/diff/


Testing
---

Documentation.


Thanks,

Michael Park

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

> On May 13, 2015, 11:16 p.m., Bernd Mathiske wrote:
> > docs/reservation.md, line 168
> > 
> >
> > "state of the recources" - what does this mean?
> > 
> > Suggestion: "resource specifications"

I've updated this to:

> `Offer::Operation::Reserve` has a `resources` field which we specify with the 
> resources to be reserved. We need to expicitly set the `role` and `principal` 
> fields with the framework's role and principal.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83678
---


On June 26, 2015, 6:13 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 26, 2015, 6:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated June 26, 2015, 6:13 p.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  docs/reservation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32982/diff/


Testing
---

Documentation.


Thanks,

Michael Park

Re: Review Request 32982: Added reservation user guide.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89532
---


Patch looks great!

Reviews applied: [32982]

All tests passed.

- Mesos ReviewBot


On June 26, 2015, 6:12 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 26, 2015, 6:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> NOTE: The framework API should be reviewed thoroughly at this point since 
> those have been implemented and landed.
>   The master API endpoints however are still in development and therefore 
> the state reflected in this patch is incomplete. (e.g. what HTTP code do we 
> return on failures?)
>   I'll update the guide to accurately reflect the master endpoints as it 
> gets more solified.
>   The purpose of including it was/is to get initial feedback on how it 
> generally works.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated June 26, 2015, 6:12 p.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.


Changes
---

Iterated on the API for frameworks.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description
---

See summary.

NOTE: The framework API should be reviewed thoroughly at this point since those 
have been implemented and landed.
  The master API endpoints however are still in development and therefore 
the state reflected in this patch is incomplete. (e.g. what HTTP code do we 
return on failures?)
  I'll update the guide to accurately reflect the master endpoints as it 
gets more solified.
  The purpose of including it was/is to get initial feedback on how it 
generally works.


Diffs (updated)
-

  docs/reservation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32982/diff/


Testing
---

Documentation.


Thanks,

Michael Park

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated June 26, 2015, 5:04 p.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description
---

See summary.

NOTE: The framework API should be reviewed thoroughly at this point since those 
have been implemented and landed.
  The master API endpoints however are still in development and therefore 
the state reflected in this patch is incomplete. (e.g. what HTTP code do we 
return on failures?)
  I'll update the guide to accurately reflect the master endpoints as it 
gets more solified.
  The purpose of including it was/is to get initial feedback on how it 
generally works.


Diffs (updated)
-

  docs/reservation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32982/diff/


Testing
---

Documentation.


Thanks,

Michael Park

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

> On May 8, 2015, 7:02 p.m., Timothy Chen wrote:
> > docs/reservation.md, line 243
> > 
> >
> > What happens if you try to unreserve a reservation that is being used 
> > right now?

The reason why we go through the offer cycle is to eliminate the case where a 
framework could attempt to unreserve resources that are being used. That is, we 
know that the resources are not used because the framework was offered them.

There are ways when the offer becomes invalid however. For example if it is 
rescinded, in the future it's possible that we're racing with another framework 
via optimistic offers. In these cases, the behavior will stay consistent with 
`LaunchTasks`. Currently the master just logs/drops invalid operations.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83054
---


On June 26, 2015, 4:54 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 26, 2015, 4:54 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> NOTE: The framework API should be reviewed thoroughly at this point since 
> those have been implemented and landed.
>   The master API endpoints however are still in development and therefore 
> the state reflected in this patch is incomplete. (e.g. what HTTP code do we 
> return on failures?)
>   I'll update the guide to accurately reflect the master endpoints as it 
> gets more solified.
>   The purpose of including it was/is to get initial feedback on how it 
> generally works.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated June 26, 2015, 4:54 p.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.


Changes
---

Addressed a few comments, marked master endpoints as `(Coming Soon)`, reordered 
to describe the interfaces for the framework first.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description
---

See summary.

NOTE: The framework API should be reviewed thoroughly at this point since those 
have been implemented and landed.
  The master API endpoints however are still in development and therefore 
the state reflected in this patch is incomplete. (e.g. what HTTP code do we 
return on failures?)
  I'll update the guide to accurately reflect the master endpoints as it 
gets more solified.
  The purpose of including it was/is to get initial feedback on how it 
generally works.


Diffs (updated)
-

  docs/reservation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32982/diff/


Testing
---

Documentation.


Thanks,

Michael Park

Re: Review Request 32982: Added reservation user guide.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89512
---


Patch looks great!

Reviews applied: [32982]

All tests passed.

- Mesos ReviewBot


On June 26, 2015, 4:04 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated June 26, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> NOTE: The framework API should be reviewed thoroughly at this point since 
> those have been implemented and landed.
>   The master API endpoints however are still in development and therefore 
> the state reflected in this patch is incomplete. (e.g. what HTTP code do we 
> return on failures?)
>   I'll update the guide to accurately reflect the master endpoints as it 
> gets more solified.
>   The purpose of including it was/is to get initial feedback on how it 
> generally works.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated June 26, 2015, 4:04 p.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.


Summary (updated)
-

Added reservation user guide.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description
---

See summary.

NOTE: The framework API should be reviewed thoroughly at this point since those 
have been implemented and landed.
  The master API endpoints however are still in development and therefore 
the state reflected in this patch is incomplete. (e.g. what HTTP code do we 
return on failures?)
  I'll update the guide to accurately reflect the master endpoints as it 
gets more solified.
  The purpose of including it was/is to get initial feedback on how it 
generally works.


Diffs (updated)
-

  docs/reservation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32982/diff/


Testing
---

Documentation.


Thanks,

Michael Park

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated May 13, 2015, 10:15 p.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.


Changes
---

Updated the description with the current state of this review request.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description (updated)
---

See summary.

NOTE: The framework API should be reviewed thoroughly at this point since those 
have been implemented and landed.
  The master API endpoints however are still in development and therefore 
the state reflected in this patch is incomplete. (e.g. what HTTP code do we 
return on failures?)
  I'll update the guide to accurately reflect the master endpoints as it 
gets more solified.
  The purpose of including it was/is to get initial feedback on how it 
generally works.


Diffs
-

  docs/reservation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32982/diff/


Testing
---

Documentation.


Thanks,

Michael Park

Re: Review Request 32982: Added reservation user guide.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83212
---

Ship it!


LGTM, I didn't test the examples though.


docs/reservation.md


s/existed prior/available since version x.x.x?


- Joerg Schad


On May 8, 2015, 6:57 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated May 8, 2015, 6:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> NOTE: Do not commit until master API endpoints are implemented for dynamic 
> reservations.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83054
---



docs/reservation.md


In the following sections



docs/reservation.md


existed prior to 0.23.0 seems to imply it no longer exists after 0.23.0?



docs/reservation.md


A notable difference between static reservation is the principal here, are 
you going to cover that?



docs/reservation.md


What happens if you try to unreserve a reservation that is being used right 
now?


- Timothy Chen


On May 8, 2015, 6:57 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated May 8, 2015, 6:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> NOTE: Do not commit until master API endpoints are implemented for dynamic 
> reservations.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

> On April 24, 2015, 8:17 a.m., Alexander Rukletsov wrote:
> > LGTM (not a native speaker). Shouldn't we commit this RR after introducing 
> > master endpoints : )?

> Shouldn't we commit this RR after introducing master endpoints : )?

Updated the description to make this clear.


> On April 24, 2015, 8:17 a.m., Alexander Rukletsov wrote:
> > docs/reservation.md, lines 97-100
> > 
> >
> > Do you want to mention HTTP response codes for response?

Yes. Thanks for pointing that out. My plan is to punt the decision to the 
implementation of master API endpoints.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review81459
---


On May 8, 2015, 6:57 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated May 8, 2015, 6:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> NOTE: Do not commit until master API endpoints are implemented for dynamic 
> reservations.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 32982: Added reservation user guide.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---

(Updated May 8, 2015, 6:57 p.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205


Repository: mesos


Description (updated)
---

See summary.

NOTE: Do not commit until master API endpoints are implemented for dynamic 
reservations.


Diffs
-

  docs/reservation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32982/diff/


Testing
---

Documentation.


Thanks,

Michael Park

Re: Review Request 32982: Added reservation user guide.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review81459
---


LGTM (not a native speaker). Shouldn't we commit this RR after introducing 
master endpoints : )?


docs/reservation.md


Do you want to mention HTTP response codes for response?


- Alexander Rukletsov


On April 8, 2015, 6:41 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> ---
> 
> (Updated April 8, 2015, 6:41 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> ---
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>