Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-06-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275/ --- (Updated June 2, 2015, 12:37 p.m.) Review request for mesos, Bernd Mathiske, Co

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-06-02 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275/#review86195 --- Ship it! Ship It! - Benjamin Hindman On May 20, 2015, 10:36 p.m.

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275/#review84623 --- Patch looks great! Reviews applied: [33271, 33272, 33275] All test

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-20 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275/#review84619 --- Ship it! Ship It! - Michael Park On May 20, 2015, 10:36 p.m., Jo

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-20 Thread Michael Park
> On May 12, 2015, 9:05 p.m., Michael Park wrote: > > I found 2 instances which look like they were missed: > > > > `check.hpp` > > ```cpp > > 34: for (const Option& _error = _check(expression); \ > > ``` > > > > `flags/stringifier.hpp` > > ```cpp > > 68:const Option& v = f->*flag

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275/ --- (Updated May 20, 2015, 10:36 p.m.) Review request for mesos, Bernd Mathiske, Co

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-20 Thread Joris Van Remoortere
> On May 12, 2015, 9:05 p.m., Michael Park wrote: > > I found 2 instances which look like they were missed: > > > > `check.hpp` > > ```cpp > > 34: for (const Option& _error = _check(expression); \ > > ``` > > > > `flags/stringifier.hpp` > > ```cpp > > 68:const Option& v = f->*flag

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275/#review84511 --- Ship it! Ship It! - Alexander Rojas On April 22, 2015, 8:11 p.m.

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275/#review83478 --- I found 2 instances which look like they were missed: `check.hpp` `

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275/#review82874 --- Ship it! Short bechmark (for the combined effort of removing tempor

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275/#review81206 --- Patch looks great! Reviews applied: [33271, 33272, 33275] All test

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-04-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275/ --- (Updated April 22, 2015, 6:11 p.m.) Review request for mesos, Bernd Mathiske, C