Re: Review Request 34436: Factor out launch helper for easier reuse

2015-05-22 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34436/ --- (Updated May 22, 2015, 8:48 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34436: Factor out launch helper for easier reuse

2015-05-22 Thread Paul Brett
> On May 22, 2015, 7:27 a.m., Ian Downes wrote: > > src/tests/port_mapping_tests.cpp, lines 186-187 > > > > > > How much noise is there? This seems onerous to users to modify source > > and recompile to enable some de

Re: Review Request 34436: Factor out launch helper for easier reuse

2015-05-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34436/#review84884 --- Where will this get re-used? src/tests/port_mapping_tests.cpp

Re: Review Request 34436: Factor out launch helper for easier reuse

2015-05-21 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34436/ --- (Updated May 21, 2015, 11:31 p.m.) Review request for mesos, Chi Zhang, Ian Dow

Re: Review Request 34436: Factor out launch helper for easier reuse

2015-05-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34436/#review84751 --- Bad patch! Reviews applied: [34321, 34426, 34321] Failed command:

Review Request 34436: Factor out launch helper for easier reuse

2015-05-21 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34436/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: M