Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- (Updated June 16, 2015, 5 p.m.) Review request for mesos, Bartek Plotka, Jie Yu

Re: Review Request 34721: Added QoS kill executor correction test.

> On June 16, 2015, 4:56 p.m., Jie Yu wrote: > > src/tests/oversubscription_tests.cpp, line 762 > > > > > > I cannot tell, does this exceed 80 chars? Good catch - it is too long. Will get that fixed right away. - Ni

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/#review88169 --- Ship it! LGTM! src/tests/oversubscription_tests.cpp (line 762)

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- (Updated June 16, 2015, 4:52 p.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- (Updated June 16, 2015, 4:50 p.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34721: Added QoS kill executor correction test.

> On June 16, 2015, 2:31 p.m., Jie Yu wrote: > > src/tests/mesos.hpp, line 205 > > > > > > Can you instead add a overload for qosController only (similar to what > > we did for resourceEstimator above)? Done > On J

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/#review88128 --- src/tests/mesos.hpp (line 205)

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- (Updated June 16, 2015, 1:43 p.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/#review87784 --- Patch looks great! Reviews applied: [35079, 34631, 34632, 34633, 34

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- (Updated June 12, 2015, 3:37 p.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/#review87663 --- Patch looks great! Reviews applied: [35079, 34631, 34632, 34633, 34

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- (Updated June 11, 2015, 3:58 p.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/#review86731 --- Patch looks great! Reviews applied: [35079, 34631, 34632, 34633, 34

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- (Updated June 4, 2015, 2:25 p.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- (Updated June 4, 2015, 10:43 a.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- (Updated June 2, 2015, 9:30 p.m.) Review request for mesos, Bartek Plotka, Jie

Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod