Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review87062 --- Ship it! Ship It! - Ian Downes On June 3, 2015, 2:54 p.m., Paul

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86860 --- Ship it! LGTM. I'll wait for Ian's shipit. - Jie Yu On June 3,

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86503 --- Patch looks great! Reviews applied: [34894] All tests passed. -

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-02 Thread Paul Brett
On June 1, 2015, 6:32 p.m., Chi Zhang wrote: include/mesos/mesos.proto, lines 543-545 https://reviews.apache.org/r/34894/diff/1/?file=975745#file975745line543 Maybe some comments for the three names? (kinda the reason you are not using 'repeated' of TrafficControlStatistics in

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86287 --- Bad patch! Reviews applied: [34899, 34830, 34832, 34426] Failed

Review Request 34894: Add new message for Traffic Control statistics

2015-06-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-01 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86033 --- include/mesos/mesos.proto

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86013 --- Patch looks great! Reviews applied: [34830, 34832, 34426, 34863,

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-01 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86048 --- include/mesos/mesos.proto

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-01 Thread Paul Brett
On June 1, 2015, 7:17 p.m., Ian Downes wrote: include/mesos/mesos.proto, lines 543-545 https://reviews.apache.org/r/34894/diff/1/?file=975745#file975745line543 What's possible here: can more than one be present or is it only any one? What's the difference between these?