Re: Review Request 34944: Used flags validation to handle --help.

2015-06-05 Thread Benjamin Hindman
On June 2, 2015, 3:54 p.m., Marco Massenzio wrote: Sweet! Only comment is that this does not give the client of FlagsBase an option as to the behavior of --help (ie, it prints and exit: like it or lump it :). Which is perfectly fine, IMO, but was wondering whether this was too

Review Request 34944: Used flags validation to handle --help.

2015-06-02 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34944/ --- Review request for mesos and Marco Massenzio. Repository: mesos Description

Re: Review Request 34944: Used flags validation to handle --help.

2015-06-02 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34944/ --- (Updated June 2, 2015, 2:46 p.m.) Review request for mesos and Marco

Re: Review Request 34944: Used flags validation to handle --help.

2015-06-02 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34944/#review86231 --- Ship it! Sweet! Only comment is that this does not give the

Re: Review Request 34944: Used flags validation to handle --help.

2015-06-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34944/#review86229 --- Patch looks great! Reviews applied: [34943, 34944] All tests