Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86545 --- Bad patch! Reviews applied: [34962, 34980] Failed command: ./suppo

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/ --- (Updated June 4, 2015, 12:08 a.m.) Review request for mesos, Jie Yu, Niklas Nie

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/ --- (Updated June 3, 2015, 11:10 p.m.) Review request for mesos, Jie Yu, Niklas Nie

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86497 --- src/slave/resource_estimators/noop.cpp

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86496 --- Ship it! Ship It! - Niklas Nielsen On June 3, 2015, 3:21 p.m., B

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/ --- (Updated June 3, 2015, 10:21 p.m.) Review request for mesos, Jie Yu, Niklas Nie

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86490 --- Ship it! src/slave/resource_estimators/noop.cpp

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

> On June 3, 2015, 9:06 p.m., Niklas Nielsen wrote: > > Do you want to add a test to verify that this works? :) Definitely will do that in next patch (: - Bartek --- This is an automatically generated e-mail. To reply, visit: https://re

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/ --- (Updated June 3, 2015, 9:16 p.m.) Review request for mesos, Jie Yu, Niklas Niel

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86464 --- Do you want to add a test to verify that this works? :) include/me

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

> On June 3, 2015, 5:58 a.m., Bartek Plotka wrote: > > Any idea why review requests failed to show diff of noop.hpp? > > > > I guess it something with > > https://reviews.apache.org/r/34962/diff/#file976910, since this patch > > depends on that. > > Bartek Plotka wrote: > reviewboard* N

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86441 --- src/slave/slave.cpp

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86366 --- Patch looks great! Reviews applied: [34962, 34980] All tests passe

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

> On June 3, 2015, 5:58 a.m., Bartek Plotka wrote: > > Any idea why review requests failed to show diff of noop.hpp? > > > > I guess it something with > > https://reviews.apache.org/r/34962/diff/#file976910, since this patch > > depends on that. reviewboard* - Bartek

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86362 --- Any idea why review requests failed to show diff of noop.hpp? I gue

Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/ --- Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone