Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

> On June 9, 2015, 6:11 p.m., Vinod Kone wrote: > > src/tests/fetcher_cache_tests.cpp, lines 201-207 > > > > > > While this looks good as a temporary fix, what is the long term > > strategy here? > > > > I re

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

Vinod, I am working on it. I reckon this will work: s/Return()/DeclineOffers() I’ll prepare a RR with this, that also fixes the CHECK the way Jie proposed. Bernd > On Jun 12, 2015, at 8:59 PM, Vinod Kone wrote: > > This is an automatically generated e-mail. To reply, > visit:https://reviews

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

> On June 9, 2015, 6:11 p.m., Vinod Kone wrote: > > src/tests/fetcher_cache_tests.cpp, lines 201-207 > > > > > > While this looks good as a temporary fix, what is the long term > > strategy here? > > > > I re

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

> On June 9, 2015, 6:11 p.m., Vinod Kone wrote: > > src/tests/fetcher_cache_tests.cpp, lines 360-361 > > > > > > Why not just do AWAIT_READY(offers)? > > Bernd Mathiske wrote: > That does not compile here, because

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35247/#review87616 --- I'll commit this for now with the reordering fix. Please follow up w

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

> On June 9, 2015, 6:11 p.m., Vinod Kone wrote: > > src/tests/fetcher_cache_tests.cpp, lines 201-207 > > > > > > While this looks good as a temporary fix, what is the long term > > strategy here? > > > > I re

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

> On June 9, 2015, 11:11 a.m., Vinod Kone wrote: > > src/tests/fetcher_cache_tests.cpp, lines 201-207 > > > > > > While this looks good as a temporary fix, what is the long term > > strategy here? > > > > I r

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

> On June 9, 2015, 11:11 a.m., Vinod Kone wrote: > > src/tests/fetcher_cache_tests.cpp, lines 360-361 > > > > > > Why not just do AWAIT_READY(offers)? That does not compile here, because it contains a "return" of type

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35247/#review87235 --- src/tests/fetcher_cache_tests.cpp

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35247/#review87157 --- Patch looks great! Reviews applied: [35247] All tests passed. - M

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35247/ --- (Updated June 9, 2015, 2:32 a.m.) Review request for mesos, Benjamin Hindman, T

Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35247/ --- Review request for mesos, Benjamin Hindman, Till Toenshoff, and Vinod Kone. Bug