Hey Mark,
First off, thanks for these patches! I appreciate you taking the time to
fix this.
Second, I think the review chain is reversed currently. The *stout* changes
should be the start of the chain, as it has the introduction of
*getOrElse* function.
So if you could flip it around to be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/#review90499
---
Bad patch!
Reviews applied: [35285, 35286]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/#review90504
---
Hi Mark,
Can you please make sure to rebase and post-review all of
On July 6, 2015, 5:23 p.m., Joris Van Remoortere wrote:
Hi Mark,
Can you please make sure to rebase and post-review all of the patches in
the dependency chain? The build bot will keep reporting this conflict until
it can apply the patches in the order it reports in its review.
Yea, I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/
---
(Updated July 6, 2015, 6:32 p.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/#review90536
---
Ship it!
Ship It!
- Joris Van Remoortere
On July 6, 2015, 6:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/
---
(Updated July 6, 2015, 6:46 p.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/
---
(Updated July 6, 2015, 6:45 p.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/#review90545
---
Ship it!
Ship It!
- Benjamin Hindman
On July 6, 2015, 6:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/
---
(Updated July 6, 2015, 3:04 p.m.)
Review request for mesos and Joris Van
On June 20, 2015, 9:45 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [35285, 35286, 35287]
Failed command: ./support/apply-review.sh -n -r 35287
Error:
2015-06-20 21:41:02 URL:https://reviews.apache.org/r/35287/diff/raw/
[2559/2559] - 35287.patch [1]
error:
On June 20, 2015, 9:45 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [35285, 35286, 35287]
Failed command: ./support/apply-review.sh -n -r 35287
Error:
2015-06-20 21:41:02 URL:https://reviews.apache.org/r/35287/diff/raw/
[2559/2559] - 35287.patch [1]
error:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/#review89279
---
Ship it!
Ship It!
- Till Toenshoff
On June 20, 2015, 4:48 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/
---
(Updated June 20, 2015, 4:19 p.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/
---
(Updated June 20, 2015, 4:48 p.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/#review88668
---
Bad patch!
Reviews applied: [35285, 35286, 35287]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/#review88428
---
Thanks for taking this on Mark!
Would you mind rebasing this chain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/
---
(Updated June 10, 2015, 8:11 a.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/
---
(Updated June 10, 2015, 8:10 a.m.)
Review request for mesos and Joris Van
19 matches
Mail list logo
