Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

2015-07-26 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36024/#review93089 --- After discussing this with the shepherd it was decided to drop this

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

2015-07-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36024/ --- (Updated July 9, 2015, 10:20 p.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

2015-07-08 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36024/ --- (Updated July 8, 2015, 10:44 p.m.) Review request for Joris Van Remoortere. C

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

2015-07-08 Thread Artem Harutyunyan
> On July 8, 2015, 7:54 p.m., Joris Van Remoortere wrote: > > src/tests/fetcher_tests.cpp, line 281 > > > > > > I think you mean `const vector& testEndpoints` ? Indeed! - Artem --

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

2015-07-08 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36024/ --- (Updated July 8, 2015, 9:48 p.m.) Review request for mesos and Joris Van Remoor

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

2015-07-06 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36024/ --- (Updated July 6, 2015, 1:59 p.m.) Review request for Joris Van Remoortere. Bu

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

2015-07-06 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36024/ --- (Updated July 6, 2015, 1:51 p.m.) Review request for mesos and Joris Van Remoor

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

2015-06-30 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36024/ --- (Updated June 30, 2015, 4:25 p.m.) Review request for mesos and Joris Van Remoo