Re: Review Request 36537: Made TaskState.data available via state.json endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36537/ --- (Updated July 16, 2015, 10:54 a.m.) Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-3061 https://issues.apache.org/jira/browse/MESOS-3061 Repository: mesos Description --- This would allows us to expose the docker container IP (that is queried via docker-inspect and is part of TaskState.data) to Mesos-DNS via Master state.json endpoint. Currently, Master doesn't store TaskState::data and so it's not made available via state.json. A follow up patch would fix it. Diffs - src/common/http.cpp 2bb1ba87a2755a4bd9b762280dea6fce81db1320 Diff: https://reviews.apache.org/r/36537/diff/ Testing --- Tested by modifying the test_executor to send data with TASK_RUNNING status update. The data showed up in Slave's state.json. Thanks, Kapil Arya
Re: Review Request 36537: Made TaskState.data available via state.json endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36537/#review91895 --- Patch looks great! Reviews applied: [36537] All tests passed. - Mesos ReviewBot On July 16, 2015, 2:54 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36537/ --- (Updated July 16, 2015, 2:54 p.m.) Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-3061 https://issues.apache.org/jira/browse/MESOS-3061 Repository: mesos Description --- This would allows us to expose the docker container IP (that is queried via docker-inspect and is part of TaskState.data) to Mesos-DNS via Master state.json endpoint. Currently, Master doesn't store TaskState::data and so it's not made available via state.json. A follow up patch would fix it. Diffs - src/common/http.cpp 2bb1ba87a2755a4bd9b762280dea6fce81db1320 Diff: https://reviews.apache.org/r/36537/diff/ Testing --- Tested by modifying the test_executor to send data with TASK_RUNNING status update. The data showed up in Slave's state.json. Thanks, Kapil Arya
Re: Review Request 36537: Made TaskState.data available via state.json endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36537/#review91937 --- We don't store 'data' because there are frameworks which send a lot of data, and this can OOM the master per MESOS-1746. Are you aware of this? - Ben Mahler On July 16, 2015, 2:54 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36537/ --- (Updated July 16, 2015, 2:54 p.m.) Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-3061 https://issues.apache.org/jira/browse/MESOS-3061 Repository: mesos Description --- This would allows us to expose the docker container IP (that is queried via docker-inspect and is part of TaskState.data) to Mesos-DNS via Master state.json endpoint. Currently, Master doesn't store TaskState::data and so it's not made available via state.json. A follow up patch would fix it. Diffs - src/common/http.cpp 2bb1ba87a2755a4bd9b762280dea6fce81db1320 Diff: https://reviews.apache.org/r/36537/diff/ Testing --- Tested by modifying the test_executor to send data with TASK_RUNNING status update. The data showed up in Slave's state.json. Thanks, Kapil Arya
Re: Review Request 36537: Made TaskState.data available via state.json endpoint.
On July 16, 2015, 6:38 p.m., Ben Mahler wrote: We don't store 'data' because there are frameworks which send a lot of data, and this can OOM the master per MESOS-1746. Are you aware of this? Kapil Arya wrote: Yes. That's why I haven't created the patch yet :-). I am still trying to explore avenues that can allow us to expose the `docker inspect` output _only_. One somewhat hackish way is to detect and save `docker inspect` run. An alternative is to create TaskStatus labels that are exposed via state.json. The latter would also allow us to create label decorator hooks for Slave modules. Isn't sending docker inspect already a hack? What if folks have a custom executor in their docker container? Then they won't be getting 'docker inspect' from the docker/executor.cpp, right? - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36537/#review91937 --- On July 16, 2015, 2:54 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36537/ --- (Updated July 16, 2015, 2:54 p.m.) Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-3061 https://issues.apache.org/jira/browse/MESOS-3061 Repository: mesos Description --- This would allows us to expose the docker container IP (that is queried via docker-inspect and is part of TaskState.data) to Mesos-DNS via Master state.json endpoint. Currently, Master doesn't store TaskState::data and so it's not made available via state.json. A follow up patch would fix it. Diffs - src/common/http.cpp 2bb1ba87a2755a4bd9b762280dea6fce81db1320 Diff: https://reviews.apache.org/r/36537/diff/ Testing --- Tested by modifying the test_executor to send data with TASK_RUNNING status update. The data showed up in Slave's state.json. Thanks, Kapil Arya
Re: Review Request 36537: Made TaskState.data available via state.json endpoint.
On July 16, 2015, 2:38 p.m., Ben Mahler wrote: We don't store 'data' because there are frameworks which send a lot of data, and this can OOM the master per MESOS-1746. Are you aware of this? Yes. That's why I haven't created the patch yet :-). I am still trying to explore avenues that can allow us to expose the `docker inspect` output _only_. One somewhat hackish way is to detect and save `docker inspect` run. An alternative is to create TaskStatus labels that are exposed via state.json. The latter would also allow us to create label decorator hooks for Slave modules. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36537/#review91937 --- On July 16, 2015, 10:54 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36537/ --- (Updated July 16, 2015, 10:54 a.m.) Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-3061 https://issues.apache.org/jira/browse/MESOS-3061 Repository: mesos Description --- This would allows us to expose the docker container IP (that is queried via docker-inspect and is part of TaskState.data) to Mesos-DNS via Master state.json endpoint. Currently, Master doesn't store TaskState::data and so it's not made available via state.json. A follow up patch would fix it. Diffs - src/common/http.cpp 2bb1ba87a2755a4bd9b762280dea6fce81db1320 Diff: https://reviews.apache.org/r/36537/diff/ Testing --- Tested by modifying the test_executor to send data with TASK_RUNNING status update. The data showed up in Slave's state.json. Thanks, Kapil Arya
