On July 29, 2015, 1:01 p.m., Alexander Rukletsov wrote:
include/mesos/mesos.proto, line 399
https://reviews.apache.org/r/36663/diff/5/?file=1021578#file1021578line399
`ip` and `port` are required, while `address` is optional. Is it
intentional / doesn't it introduce a pitfall?
On July 29, 2015, 1:01 p.m., Alexander Rukletsov wrote:
include/mesos/mesos.proto, line 399
https://reviews.apache.org/r/36663/diff/5/?file=1021578#file1021578line399
`ip` and `port` are required, while `address` is optional. Is it
intentional / doesn't it introduce a pitfall?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/#review93441
---
include/mesos/mesos.proto (line 399)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/#review92958
---
include/mesos/mesos.proto (line 397)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/#review93017
---
Ship it!
Ship It!
- Vinod Kone
On July 25, 2015, 12:36 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/
---
(Updated July 25, 2015, 12:36 a.m.)
Review request for mesos, Anand Mazumdar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/
---
(Updated July 23, 2015, 9:46 p.m.)
Review request for mesos, Anand Mazumdar
On July 23, 2015, 11:51 p.m., Vinod Kone wrote:
src/tests/master_tests.cpp, line 1022
https://reviews.apache.org/r/36663/diff/2/?file=1020111#file1020111line1022
This test is testing the createMasterInfo() method which is not used in
production. Can you also write a test with ZK
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/
---
(Updated July 24, 2015, 12:17 a.m.)
Review request for mesos, Anand Mazumdar
On July 23, 2015, 11:51 p.m., Vinod Kone wrote:
src/tests/master_tests.cpp, line 1022
https://reviews.apache.org/r/36663/diff/2/?file=1020111#file1020111line1022
This test is testing the createMasterInfo() method which is not used in
production. Can you also write a test with ZK
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/
---
(Updated July 23, 2015, 11:54 p.m.)
Review request for mesos, Anand Mazumdar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/
---
(Updated July 23, 2015, 8:29 p.m.)
Review request for mesos, Anand Mazumdar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/#review92834
---
src/master/master.cpp (lines 344 - 346)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/#review92853
---
Patch looks great!
Reviews applied: [36663]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/#review92630
---
Can you write a test for this?
include/mesos/mesos.proto (line
On July 21, 2015, 11:59 p.m., Anand Mazumdar wrote:
LGTM, thanks for adding much needed documentation too for the fields !
Upon reading the corresponding JIRA, I am assuming that we had an agreement
to not use the Address field that BenM introduced in r36450 for readability
of the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/
---
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-2736
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/#review92510
---
Patch looks great!
Reviews applied: [36663]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/#review92514
---
Ship it!
LGTM, thanks for adding much needed documentation too for
19 matches
Mail list logo
