Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37237/#review95194 --- Ship it! Ship It! - Timothy Chen On Aug. 8, 2015, 12:32 a.m.,

Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-12 Thread Jie Yu
On Aug. 12, 2015, 6:16 p.m., Jiang Yan Xu wrote: src/tests/containerizer/provisioner.hpp, line 34 https://reviews.apache.org/r/37237/diff/3/?file=1035029#file1035029line34 Should this be called MockProvisioner? I think we use TestXYZ to 'XYZ that faciliates tests' and MockXYZ for

Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37237/#review95025 --- Ship it! src/tests/containerizer/filesystem_isolator_tests.cpp

Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-12 Thread Jie Yu
On Aug. 12, 2015, 6:16 p.m., Jiang Yan Xu wrote: src/tests/containerizer/filesystem_isolator_tests.cpp, line 157 https://reviews.apache.org/r/37237/diff/3/?file=1035028#file1035028line157 So this relies on the launch not failing to indicate it has successfully pivoted?

Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37237/ --- Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan

Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37237/ --- (Updated Aug. 7, 2015, 11:30 p.m.) Review request for mesos, Lily Chen, Ian

Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37237/#review94611 --- Patch looks great! Reviews applied: [36929, 36930, 36954, 36956,