Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review141482 --- Closing this review due to inactivity. Please see our [guidelines

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review97456 --- src/slave/slave.cpp (line 2133)

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

> On Aug. 24, 2015, 11:56 p.m., Vinod Kone wrote: > > This review is a bit hard to follow because it's doing multiple things. I > > would recommend you to split this into multiple reviews > > > > #1) Expose framework user in state.json > > #2) Update framework user on re-registration (need a te

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96478 --- src/master/master.cpp (line 1920)

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96422 --- Patch looks great! Reviews applied: [37500] All tests passed. - M

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

> On Aug. 24, 2015, 4:56 p.m., Vinod Kone wrote: > > This review is a bit hard to follow because it's doing multiple things. I > > would recommend you to split this into multiple reviews > > > > #1) Expose framework user in state.json > > #2) Update framework user on re-registration (need a tes

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- (Updated Aug. 25, 2015, 8:25 p.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- (Updated Aug. 25, 2015, 8:19 p.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96412 --- Bad patch! Reviews applied: [37500] Failed command: ./support/appl

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96407 --- Bad patch! Reviews applied: [37500] Failed command: ./support/appl

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

> On Aug. 24, 2015, 11:56 p.m., Vinod Kone wrote: > > This review is a bit hard to follow because it's doing multiple things. I > > would recommend you to split this into multiple reviews > > > > #1) Expose framework user in state.json > > #2) Update framework user on re-registration (need a te

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

> On Aug. 24, 2015, 11:56 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 1879-1886 > > > > > > Per the design doc, we don't need a new message. You should be able to > > augment the existing UpdateFramewo

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- (Updated Aug. 25, 2015, 7:45 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96272 --- src/messages/messages.proto (line 350)

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96240 --- This review is a bit hard to follow because it's doing multiple thin

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review95510 --- Patch looks great! Reviews applied: [37500] All tests passed. - M

Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3240 https://issues.ap