Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99711
---

Ship it!


fixed inline.


docs/maintenance.md (lines 139 - 140)


It wasn't clear at first what you meant by "this is not allowed", as you 
are stating a rule above.


- Joris Van Remoortere


On Sept. 19, 2015, 1:27 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> ---
> 
> (Updated Sept. 19, 2015, 1:27 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Heavily based on the design doc 
> (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
> 
> Includes a diagram of the maintenance mode transitions.
> 
> 
> Diffs
> -
> 
>   docs/images/maintenance-primitives-modes.png PRE-CREATION 
>   docs/maintenance.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37585/diff/
> 
> 
> Testing
> ---
> 
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
> 
> 
> File Attachments
> 
> 
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99656
---


Bad patch!

Reviews applied: [37585]

Failed command: ./support/apply-review.sh -n -r 37585

Error:
 2015-09-19 06:46:30 URL:https://reviews.apache.org/r/37585/diff/raw/ 
[13712/13712] -> "37585.patch" [1]
error: missing binary patch data for 
'docs/images/maintenance-primitives-modes.png'
error: binary patch does not apply to 
'docs/images/maintenance-primitives-modes.png'
error: docs/images/maintenance-primitives-modes.png: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Sept. 19, 2015, 1:27 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> ---
> 
> (Updated Sept. 19, 2015, 1:27 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Heavily based on the design doc 
> (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
> 
> Includes a diagram of the maintenance mode transitions.
> 
> 
> Diffs
> -
> 
>   docs/images/maintenance-primitives-modes.png PRE-CREATION 
>   docs/maintenance.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37585/diff/
> 
> 
> Testing
> ---
> 
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
> 
> 
> File Attachments
> 
> 
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99635
---



docs/maintenance.md (line 25)


s/adds/add/.



docs/maintenance.md (line 27)


Did the notion of an operator not exist before Maintenance Primitives were 
introduced? I would rephrase the sentence above to say that we're definining 
terms for the puropse of this doc.



docs/maintenance.md (line 35)


s/in/during/
s/may not be/may become/



docs/maintenance.md (line 36)


s/about the/about the availability of the/



docs/maintenance.md (line 40)


s/will have unavailability info attached/will contain unavailability 
information/



docs/maintenance.md (lines 72 - 73)


Please add anchors to links so that the relevant parts of the .proto file 
in each case are highlighted.



docs/maintenance.md (line 75)


s/the schedule is/the schedule must be/



docs/maintenance.md (lines 91 - 92)


Can they also specify seconds? If not, we should definitely add a JIRA for 
that (as a syntactic sugar for the interface). Please mention somewhere that 
start is the nanoseconds since epoch.



docs/maintenance.md (line 107)


s/this schedule/the schedule/



docs/maintenance.md (line 118)


s/if, say, a faulty machine launches agents on boot./to, say, prevent a 
faulty machine from launching an agent on boot./



docs/maintenance.md (line 120)


What does this mean for the person reading this? Should they supply extra 
options through the agent command line? Should they make sure that their 
/etc/hosts is sane? This is currently not actionable, but it has to be.



docs/maintenance.md (line 127)


What if one or several of the checks fail?



docs/maintenance.md (line 133)


Isn't this one obvious?



docs/maintenance.md (line 134)


What does this mean? What if they aren't?



docs/maintenance.md (line 135)


Please explain a recommended workflow for updating maintenance schedule, 
and canceling it.



docs/maintenance.md (lines 144 - 145)


Does this potentially mean a mass task restart across the nodes that are 
undergoing maintenance?



docs/maintenance.md (line 190)


a link to .proto would be helpful here too.



docs/maintenance.md (line 203)


Again, not clear what happens if one of these conditions fails.



docs/maintenance.md (line 224)


s/maintenance starts/maintenance is triggered by the operator/.



docs/maintenance.md (line 235)


Link to .proto, please?



docs/maintenance.md (line 249)


s/guess/a best effort guess/


- Artem Harutyunyan


On Sept. 18, 2015, 12:51 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> ---
> 
> (Updated Sept. 18, 2015, 12:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Heavily based on the design doc 
> (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
> 
> Includes a diagram of the maintenance mode transitions.
> 
> 
> Diffs
> -
> 
>   docs/images/maintenance-primitives-modes.png PRE-CREATION 
>   docs/maintenance.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37585/diff/
> 
> 
> Testing
> ---
> 
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
> 
> 
> File Attachments
> 
> 
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
>   
> 

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
---

(Updated Sept. 18, 2015, 12:51 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Changes
---

Update json examples to match code changes.


Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083


Repository: mesos


Description
---

Heavily based on the design doc 
(https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).

Includes a diagram of the maintenance mode transitions.


Diffs (updated)
-

  docs/images/maintenance-primitives-modes.png PRE-CREATION 
  docs/maintenance.md PRE-CREATION 

Diff: https://reviews.apache.org/r/37585/diff/


Testing
---

Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.


File Attachments


Same as the image in the binary diff. (Uploaded for reviewer convenience.)
  
https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png


Thanks,

Joseph Wu

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
---

(Updated Sept. 18, 2015, 6:27 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Changes
---

Addressed most of Artem's comments.


Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083


Repository: mesos


Description
---

Heavily based on the design doc 
(https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).

Includes a diagram of the maintenance mode transitions.


Diffs (updated)
-

  docs/images/maintenance-primitives-modes.png PRE-CREATION 
  docs/maintenance.md PRE-CREATION 

Diff: https://reviews.apache.org/r/37585/diff/


Testing
---

Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.


File Attachments


Same as the image in the binary diff. (Uploaded for reviewer convenience.)
  
https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png


Thanks,

Joseph Wu

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Joseph Wu]

> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 27
> > 
> >
> > Did the notion of an operator not exist before Maintenance Primitives 
> > were introduced? I would rephrase the sentence above to say that we're 
> > definining terms for the puropse of this doc.

Moved to the top of the section.


> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, lines 91-92
> > 
> >
> > Can they also specify seconds? If not, we should definitely add a JIRA 
> > for that (as a syntactic sugar for the interface). Please mention somewhere 
> > that start is the nanoseconds since epoch.

Added a note.

However, any seconds-based usage might be kind of weird (we removed it before 
because it's simpler this way).


> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 134
> > 
> >
> > What does this mean? What if they aren't?

Added extra sentences.


> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 135
> > 
> >
> > Please explain a recommended workflow for updating maintenance 
> > schedule, and canceling it.

Added two sentences at the end of this section.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99635
---


On Sept. 18, 2015, 6:27 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> ---
> 
> (Updated Sept. 18, 2015, 6:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Heavily based on the design doc 
> (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
> 
> Includes a diagram of the maintenance mode transitions.
> 
> 
> Diffs
> -
> 
>   docs/images/maintenance-primitives-modes.png PRE-CREATION 
>   docs/maintenance.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37585/diff/
> 
> 
> Testing
> ---
> 
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
> 
> 
> File Attachments
> 
> 
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99596
---


Patch looks great!

Reviews applied: [37585]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2015, 7:51 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> ---
> 
> (Updated Sept. 18, 2015, 7:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Heavily based on the design doc 
> (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
> 
> Includes a diagram of the maintenance mode transitions.
> 
> 
> Diffs
> -
> 
>   docs/images/maintenance-primitives-modes.png PRE-CREATION 
>   docs/maintenance.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37585/diff/
> 
> 
> Testing
> ---
> 
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
> 
> 
> File Attachments
> 
> 
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
---

(Updated Sept. 14, 2015, 2:32 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Changes
---

One pass through the doc for Artem's comments.


Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083


Repository: mesos


Description
---

Heavily based on the design doc 
(https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).

Includes a diagram of the maintenance mode transitions.

This documents the current working prototype (MVP), which starts here:
https://reviews.apache.org/r/36321/

One TODO remaining: Update with the release version that maintenance primitives 
will be released in.


Diffs (updated)
-

  docs/images/maintenance-primitives-modes.png PRE-CREATION 
  docs/maintenance.md PRE-CREATION 

Diff: https://reviews.apache.org/r/37585/diff/


Testing
---

Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.


File Attachments


Same as the image in the binary diff. (Uploaded for reviewer convenience.)
  
https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png


Thanks,

Joseph Wu

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
---

(Updated Sept. 14, 2015, 2:32 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083


Repository: mesos


Description (updated)
---

Heavily based on the design doc 
(https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).

Includes a diagram of the maintenance mode transitions.


Diffs
-

  docs/images/maintenance-primitives-modes.png PRE-CREATION 
  docs/maintenance.md PRE-CREATION 

Diff: https://reviews.apache.org/r/37585/diff/


Testing
---

Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.


File Attachments


Same as the image in the binary diff. (Uploaded for reviewer convenience.)
  
https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png


Thanks,

Joseph Wu

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
---

(Updated Sept. 1, 2015, 10:42 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Changes
---

Updated example JSON and CURL based on current MVP.  Updated picture.


Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083


Repository: mesos


Description
---

Heavily based on the design doc 
(https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).

Includes a diagram of the maintenance mode transitions.

This documents the current working prototype (MVP), which starts here:
https://reviews.apache.org/r/36321/

One TODO remaining: Update with the release version that maintenance primitives 
will be released in.


Diffs (updated)
-

  docs/images/maintenance-primitives-modes.png PRE-CREATION 
  docs/maintenance.md PRE-CREATION 

Diff: https://reviews.apache.org/r/37585/diff/


Testing
---

Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.


File Attachments (updated)


Same as the image in the binary diff. (Uploaded for reviewer convenience.)
  
https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png


Thanks,

Joseph Wu

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review97317
---


Patch looks great!

Reviews applied: [37585]

All tests passed.

- Mesos ReviewBot


On Sept. 1, 2015, 5:42 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> ---
> 
> (Updated Sept. 1, 2015, 5:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Heavily based on the design doc 
> (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
> 
> Includes a diagram of the maintenance mode transitions.
> 
> This documents the current working prototype (MVP), which starts here:
> https://reviews.apache.org/r/36321/
> 
> One TODO remaining: Update with the release version that maintenance 
> primitives will be released in.
> 
> 
> Diffs
> -
> 
>   docs/images/maintenance-primitives-modes.png PRE-CREATION 
>   docs/maintenance.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37585/diff/
> 
> 
> Testing
> ---
> 
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
> 
> 
> File Attachments
> 
> 
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
---

(Updated Aug. 31, 2015, 11:11 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Changes
---

Addressed comments.  Added image file to review for reviewer convenience.


Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083


Repository: mesos


Description
---

Heavily based on the design doc 
(https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).

Includes a diagram of the maintenance mode transitions.

This documents the current working prototype (MVP), which starts here:
https://reviews.apache.org/r/36321/

One TODO remaining: Update with the release version that maintenance primitives 
will be released in.


Diffs (updated)
-

  docs/images/maintenance-primitives-modes.png PRE-CREATION 
  docs/maintenance.md PRE-CREATION 

Diff: https://reviews.apache.org/r/37585/diff/


Testing
---

Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.


File Attachments (updated)


Same as the image in the binary diff.  (Uploaded for reviewer convenience.)
  
https://reviews.apache.org/media/uploaded/files/2015/08/31/ce897571-0d3a-4ecb-8d36-a63eff855647__maintenance-primitives-modes.png


Thanks,

Joseph Wu

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review97128
---


Patch looks great!

Reviews applied: [37585]

All tests passed.

- Mesos ReviewBot


On Aug. 31, 2015, 6:11 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> ---
> 
> (Updated Aug. 31, 2015, 6:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Heavily based on the design doc 
> (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
> 
> Includes a diagram of the maintenance mode transitions.
> 
> This documents the current working prototype (MVP), which starts here:
> https://reviews.apache.org/r/36321/
> 
> One TODO remaining: Update with the release version that maintenance 
> primitives will be released in.
> 
> 
> Diffs
> -
> 
>   docs/images/maintenance-primitives-modes.png PRE-CREATION 
>   docs/maintenance.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37585/diff/
> 
> 
> Testing
> ---
> 
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
> 
> 
> File Attachments
> 
> 
> Same as the image in the binary diff.  (Uploaded for reviewer convenience.)
>   
> https://reviews.apache.org/media/uploaded/files/2015/08/31/ce897571-0d3a-4ecb-8d36-a63eff855647__maintenance-primitives-modes.png
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review96509
---



docs/maintenance.md (line 147)
https://reviews.apache.org/r/37585/#comment151937

Can we merge 147 - 149 and 152 - 153 together?



docs/maintenance.md (line 165)
https://reviews.apache.org/r/37585/#comment151944

s/emminently/eminently


- Guangya Liu


On Aug. 25, 2015, 12:59 a.m., Joseph Wu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37585/
 ---
 
 (Updated Aug. 25, 2015, 12:59 a.m.)
 
 
 Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
 Joris Van Remoortere, and Vinod Kone.
 
 
 Bugs: MESOS-2083
 https://issues.apache.org/jira/browse/MESOS-2083
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Heavily based on the design doc 
 (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
 
 Includes a diagram of the maintenance mode transitions.
 
 This documents the current working prototype (MVP), which starts here:
 https://reviews.apache.org/r/36321/
 
 One TODO remaining: Update with the release version that maintenance 
 primitives will be released in.
 
 
 Diffs
 -
 
   docs/images/maintenance-primitives-modes.png PRE-CREATION 
   docs/maintenance.md PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/37585/diff/
 
 
 Testing
 ---
 
 Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
 Checked for markdown correctness.
 
 
 Thanks,
 
 Joseph Wu
 

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review96520
---


Patch looks great!

Reviews applied: [37585]

All tests passed.

- Mesos ReviewBot


On Aug. 25, 2015, 12:59 a.m., Joseph Wu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37585/
 ---
 
 (Updated Aug. 25, 2015, 12:59 a.m.)
 
 
 Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
 Joris Van Remoortere, and Vinod Kone.
 
 
 Bugs: MESOS-2083
 https://issues.apache.org/jira/browse/MESOS-2083
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Heavily based on the design doc 
 (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
 
 Includes a diagram of the maintenance mode transitions.
 
 This documents the current working prototype (MVP), which starts here:
 https://reviews.apache.org/r/36321/
 
 One TODO remaining: Update with the release version that maintenance 
 primitives will be released in.
 
 
 Diffs
 -
 
   docs/images/maintenance-primitives-modes.png PRE-CREATION 
   docs/maintenance.md PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/37585/diff/
 
 
 Testing
 ---
 
 Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
 Checked for markdown correctness.
 
 
 Thanks,
 
 Joseph Wu
 

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
---

(Updated Aug. 24, 2015, 2:14 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Changes
---

Add a sentence under Scheduling Maintenance - Important Note; to describe what 
happens when a machine has multiple IPs/hostnames.


Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083


Repository: mesos


Description
---

Heavily based on the design doc 
(https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).

Includes a diagram of the maintenance mode transitions.

This documents the current working prototype (MVP), which starts here:
https://reviews.apache.org/r/36321/

One TODO remaining: Update with the release version that maintenance primitives 
will be released in.


Diffs (updated)
-

  docs/images/maintenance-primitives-modes.png PRE-CREATION 
  docs/maintenance.md PRE-CREATION 

Diff: https://reviews.apache.org/r/37585/diff/


Testing
---

Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.


Thanks,

Joseph Wu

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review96251
---


Bad patch!

Reviews applied: [37585]

Failed command: ./support/apply-review.sh -n -r 37585

Error:
 2015-08-25 00:20:09 URL:https://reviews.apache.org/r/37585/diff/raw/ 
[12769/12769] - 37585.patch [1]
error: missing binary patch data for 
'docs/images/maintenance-primitives-modes.png'
error: binary patch does not apply to 
'docs/images/maintenance-primitives-modes.png'
error: docs/images/maintenance-primitives-modes.png: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Aug. 24, 2015, 9:14 p.m., Joseph Wu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37585/
 ---
 
 (Updated Aug. 24, 2015, 9:14 p.m.)
 
 
 Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
 Joris Van Remoortere, and Vinod Kone.
 
 
 Bugs: MESOS-2083
 https://issues.apache.org/jira/browse/MESOS-2083
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Heavily based on the design doc 
 (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
 
 Includes a diagram of the maintenance mode transitions.
 
 This documents the current working prototype (MVP), which starts here:
 https://reviews.apache.org/r/36321/
 
 One TODO remaining: Update with the release version that maintenance 
 primitives will be released in.
 
 
 Diffs
 -
 
   docs/images/maintenance-primitives-modes.png PRE-CREATION 
   docs/maintenance.md PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/37585/diff/
 
 
 Testing
 ---
 
 Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
 Checked for markdown correctness.
 
 
 Thanks,
 
 Joseph Wu
 

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
---

(Updated Aug. 24, 2015, 5:59 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Changes
---

Updated with a binary patch.


Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083


Repository: mesos


Description
---

Heavily based on the design doc 
(https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).

Includes a diagram of the maintenance mode transitions.

This documents the current working prototype (MVP), which starts here:
https://reviews.apache.org/r/36321/

One TODO remaining: Update with the release version that maintenance primitives 
will be released in.


Diffs (updated)
-

  docs/images/maintenance-primitives-modes.png PRE-CREATION 
  docs/maintenance.md PRE-CREATION 

Diff: https://reviews.apache.org/r/37585/diff/


Testing
---

Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.


Thanks,

Joseph Wu