> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote: > > docs/maintenance.md, line 27 > > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line27> > > > > Did the notion of an operator not exist before Maintenance Primitives > > were introduced? I would rephrase the sentence above to say that we're > > definining terms for the puropse of this doc.
Moved to the top of the section. > On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote: > > docs/maintenance.md, lines 91-92 > > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line91> > > > > Can they also specify seconds? If not, we should definitely add a JIRA > > for that (as a syntactic sugar for the interface). Please mention somewhere > > that start is the nanoseconds since epoch. Added a note. However, any seconds-based usage might be kind of weird (we removed it before because it's simpler this way). > On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote: > > docs/maintenance.md, line 134 > > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line134> > > > > What does this mean? What if they aren't? Added extra sentences. > On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote: > > docs/maintenance.md, line 135 > > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line135> > > > > Please explain a recommended workflow for updating maintenance > > schedule, and canceling it. Added two sentences at the end of this section. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review99635 ----------------------------------------------------------- On Sept. 18, 2015, 6:27 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37585/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2015, 6:27 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, > Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-2083 > https://issues.apache.org/jira/browse/MESOS-2083 > > > Repository: mesos > > > Description > ------- > > Heavily based on the design doc > (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/). > > Includes a diagram of the maintenance mode transitions. > > > Diffs > ----- > > docs/images/maintenance-primitives-modes.png PRE-CREATION > docs/maintenance.md PRE-CREATION > > Diff: https://reviews.apache.org/r/37585/diff/ > > > Testing > ------- > > Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2 > Checked for markdown correctness. > > > File Attachments > ---------------- > > Same as the image in the binary diff. (Uploaded for reviewer convenience.) > > https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png > > > Thanks, > > Joseph Wu > >
